openc3 7.2.0 → 7.3.0

data/lib/openc3/microservices/interface_microservice.rb

@@ -195,7 +195,7 @@ module OpenC3
                 msg_hash = critical_model.cmd_hash
                 release_critical = true
               else
-                next "Critical command #{msg_hash['release_critical']} not found"
+                next "Critical command '#{msg_hash['release_critical']}' not found (interface command processing)"
               end
             end
             if msg_hash.key?('target_control')
@@ -272,6 +272,11 @@ module OpenC3
               else
                 next nil # Don't ack disabled targets
               end
+            rescue RangeError => e
+              # Command parameter out of range is a user error, not a bug,
+              # so only log the message and not the full stack trace
+              @logger.error "#{@interface.name}: #{e.message}"
+              next e.message
             rescue => e
               @logger.error "#{@interface.name}: #{msg_hash}"
               @logger.error "#{@interface.name}: #{e.formatted}"
@@ -281,6 +286,9 @@ module OpenC3
             command.extra ||= {}
             command.extra['cmd_string'] = msg_hash['cmd_string']
             command.extra['username'] = msg_hash['username']
+            command.extra['interface_name'] = @interface.name
+            # Original author of a queued command (set when released from a queue)
+            command.extra['queue_username'] = msg_hash['queue_username'] if msg_hash['queue_username']
             # Add approver info if this was a critical command that was approved
             if critical_model
               command.extra['approver'] = critical_model.approver
@@ -706,16 +714,19 @@ module OpenC3
         # Try to do clean disconnect because we're going down
         disconnect(false)
       end
-      if @interface_or_router == 'INTERFACE'
-        InterfaceStatusModel.set(@interface.as_json(), queued: true, scope: @scope)
-      else
-        RouterStatusModel.set(@interface.as_json(), queued: true, scope: @scope)
+      unless @cancel_thread
+        if @interface_or_router == 'INTERFACE'
+          InterfaceStatusModel.set(@interface.as_json(), queued: true, scope: @scope)
+        else
+          RouterStatusModel.set(@interface.as_json(), queued: true, scope: @scope)
+        end
       end
       @logger.info "#{@interface.name}: Stopped packet reading"
     end
 
     def handle_packet(packet)
-      InterfaceStatusModel.set(@interface.as_json(), queued: true, scope: @scope)
+      # Skip status update if stop() has been called to avoid re-creating the status model
+      InterfaceStatusModel.set(@interface.as_json(), queued: true, scope: @scope) unless @cancel_thread
       packet.received_time = Time.now.sys unless packet.received_time
 
       if packet.stored
@@ -853,7 +864,8 @@ module OpenC3
 
       # If the interface is set to auto_reconnect then delay so the thread
       # can come back around and allow the interface a chance to reconnect.
-      if allow_reconnect and @interface.auto_reconnect and @interface.state != 'DISCONNECTED'
+      # Skip reconnect if stop() has been called to avoid re-creating the status model
+      if allow_reconnect and @interface.auto_reconnect and @interface.state != 'DISCONNECTED' and !@cancel_thread
         attempting()
         if !@cancel_thread
           # @logger.debug "reconnect delay: #{@interface.reconnect_delay}"
@@ -861,10 +873,12 @@ module OpenC3
         end
       else
         @interface.state = 'DISCONNECTED'
-        if @interface_or_router == 'INTERFACE'
-          InterfaceStatusModel.set(@interface.as_json(), queued: true, scope: @scope)
-        else
-          RouterStatusModel.set(@interface.as_json(), queued: true, scope: @scope)
+        unless @cancel_thread
+          if @interface_or_router == 'INTERFACE'
+            InterfaceStatusModel.set(@interface.as_json(), queued: true, scope: @scope)
+          else
+            RouterStatusModel.set(@interface.as_json(), queued: true, scope: @scope)
+          end
         end
       end
     end
@@ -914,4 +928,4 @@ if __FILE__ == $0
   OpenC3::InterfaceMicroservice.run
   OpenC3::ThreadManager.instance.shutdown
   OpenC3::ThreadManager.instance.join
-end
+end

data/lib/openc3/microservices/queue_microservice.rb

@@ -76,12 +76,14 @@ module OpenC3
               end
               validate = command.key?('validate') ? command['validate'] : true
               timeout = command['timeout']
-              cmd(command['target_name'], command['cmd_name'], cmd_params, queue: false, validate: validate, timeout: timeout, scope: @scope)
+              # Pass queue_username so Command History is attributed to the original
+              # author rather than the queue microservice name
+              cmd(command['target_name'], command['cmd_name'], cmd_params, queue: false, validate: validate, timeout: timeout, queue_username: command['username'], scope: @scope)
             elsif command['value']
               # Legacy format: use single string parameter for backwards compatibility
               validate = command.key?('validate') ? command['validate'] : true
               timeout = command['timeout']
-              cmd(command['value'], queue: false, validate: validate, timeout: timeout, scope: @scope)
+              cmd(command['value'], queue: false, validate: validate, timeout: timeout, queue_username: command['username'], scope: @scope)
             else
               @logger.error "QueueProcessor: Invalid command format, missing required fields"
             end

data/lib/openc3/migrations/20260701000000_updated_at_to_int.rb

@@ -0,0 +1,55 @@
+# encoding: ascii-8bit
+
+# Copyright 2026 OpenC3, Inc.
+# All Rights Reserved.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+# See LICENSE.md for more details.
+#
+# This file may also be used under the terms of a commercial license
+# if purchased from OpenC3, Inc.
+
+require 'time'
+require 'openc3/utilities/migration'
+require 'openc3/core_ext/time'
+require 'openc3/models/scope_model'
+require 'openc3/models/script_status_model'
+
+module OpenC3
+  # Earlier versions of the Python script runner wrote the ScriptStatusModel
+  # updated_at field as an ISO8601 string (e.g. "2026-06-30T12:34:56.789012Z")
+  # instead of integer nanoseconds since the epoch. This migration rewrites any
+  # such string values as integers so updated_at is consistently an int.
+  #
+  # NOTE: The stored JSON is edited in place rather than reloaded through the
+  # model and re-created, because ScriptStatusModel#create always sets
+  # updated_at to the current time, which would discard the original timestamp.
+  class UpdatedAtToInt < Migration
+    def self.run
+      ScopeModel.names.each do |scope|
+        [ScriptStatusModel::RUNNING_PRIMARY_KEY, ScriptStatusModel::COMPLETED_PRIMARY_KEY].each do |key|
+          primary_key = "#{key}__#{scope}"
+          Store.hgetall(primary_key).each do |name, json|
+            data = JSON.parse(json, allow_nan: true)
+            updated_at = data['updated_at']
+            next unless updated_at.is_a?(String)
+
+            begin
+              data['updated_at'] = Time.parse(updated_at).to_nsec_from_epoch
+            rescue ArgumentError
+              # Leave unparsable values untouched
+              next
+            end
+            Store.hset(primary_key, name, JSON.generate(data, allow_nan: true))
+          end
+        end
+      end
+    end
+  end
+end
+
+unless ENV['OPENC3_NO_MIGRATE']
+  OpenC3::UpdatedAtToInt.run
+end

data/lib/openc3/migrations/20260731000000_system_health_json.rb

@@ -0,0 +1,41 @@
+require 'json'
+require 'openc3/utilities/local_mode'
+require 'openc3/utilities/migration'
+require 'openc3/models/scope_model'
+require 'openc3/models/setting_model'
+
+module OpenC3
+  # The system_health setting was originally stored as a Ruby Hash. Local mode
+  # writes settings to disk with File.write and reads them back as a String, so
+  # the Hash round tripped into a Ruby inspect String which nothing can parse.
+  # Store it as a JSON string like every other setting and repair existing data.
+  class SystemHealthJson < Migration
+    def self.run
+      setting = SettingModel.get(name: 'system_health')
+      data = repair(setting && setting['data'])
+      SettingModel.set({ name: 'system_health', data: JSON.generate(data) }, scope: 'DEFAULT')
+      # Repair the local mode file as well or sync_settings puts the bad data back
+      LocalMode.save_setting('DEFAULT', 'system_health', JSON.generate(data))
+    end
+
+    # @return [Hash] the existing settings if they can be recovered, otherwise defaults
+    def self.repair(data)
+      return ScopeModel::SYSTEM_HEALTH_DEFAULTS if data.nil?
+      return data if Hash === data
+      return ScopeModel::SYSTEM_HEALTH_DEFAULTS unless String === data
+      begin
+        parsed = JSON.parse(data)
+      rescue JSON::ParserError
+        # Ruby inspect format, e.g. {"cpu" => {"redThreshold" => 90, ... => nil}}
+        # Ruby 3.3 and earlier had no spaces around the rocket. All the values are
+        # numbers, booleans, or nil so there's nothing to accidentally rewrite.
+        parsed = JSON.parse(data.gsub(/\s*=>\s*/, ': ').gsub(/\bnil\b/, 'null')) rescue nil
+      end
+      Hash === parsed ? parsed : ScopeModel::SYSTEM_HEALTH_DEFAULTS
+    end
+  end
+end
+
+unless ENV['OPENC3_NO_MIGRATE']
+  OpenC3::SystemHealthJson.run
+end

data/lib/openc3/models/cvt_model.rb

@@ -26,8 +26,8 @@ module OpenC3
     @@override_cache = {}
 
     VALUE_TYPES = [:RAW, :CONVERTED, :FORMATTED]
-    def self.build_json_from_packet(packet)
-      packet.decom
+    def self.build_json_from_packet(packet, include_limits_states: true)
+      packet.decom(include_limits_states: include_limits_states)
     end
 
     # Get a Store instance routed to the correct db_shard for a target
@@ -86,7 +86,7 @@ module OpenC3
         return hash if hash and (now - cache_time) < cache_timeout
       end
       packet = store_for_target(target_name, scope: scope).hget(key, packet_name)
-      raise "Packet '#{target_name} #{packet_name}' does not exist" unless packet
+      raise "Packet '#{target_name} #{packet_name}' has no current values in CVT" unless packet
       hash = JSON.parse(packet, allow_nan: true, create_additions: true)
       @@packet_cache[tgt_pkt_key] = [now, hash]
       hash
@@ -107,7 +107,7 @@ module OpenC3
         hash["#{item_name}__C"] = value
         hash[item_name] = value
       else
-        raise "Unknown type '#{type}' for #{target_name} #{packet_name} #{item_name}"
+        raise "Unknown type '#{type}' for #{target_name} #{packet_name} #{item_name} (set_item)"
       end
       set(hash, target_name: target_name, packet_name: packet_name, queued: queued, scope: scope)
     end
@@ -252,7 +252,7 @@ module OpenC3
       when :FORMATTED, :WITH_UNITS
         hash["#{item_name}__F"] = value.to_s # Always a String
       else
-        raise "Unknown type '#{type}' for #{target_name} #{packet_name} #{item_name}"
+        raise "Unknown type '#{type}' for #{target_name} #{packet_name} #{item_name} (override)"
       end
 
       tgt_pkt_key = "#{scope}__tlm__#{target_name}__#{packet_name}"
@@ -277,7 +277,7 @@ module OpenC3
       when :FORMATTED, :WITH_UNITS
         hash.delete("#{item_name}__F")
       else
-        raise "Unknown type '#{type}' for #{target_name} #{packet_name} #{item_name}"
+        raise "Unknown type '#{type}' for #{target_name} #{packet_name} #{item_name} (normalize)"
       end
 
       tgt_pkt_key = "#{scope}__tlm__#{target_name}__#{packet_name}"
@@ -327,7 +327,7 @@ module OpenC3
       when :RAW
         types = [item_name]
       else
-        raise "Unknown type '#{type}' for #{target_name} #{packet_name} #{item_name}"
+        raise "Unknown type '#{type}' for #{target_name} #{packet_name} #{item_name} (get_item)"
       end
 
       tgt_pkt_key = "#{scope}__tlm__#{target_name}__#{packet_name}"

data/lib/openc3/models/db_sharded_model.rb

@@ -79,7 +79,7 @@ module OpenC3
     end
 
     # DB_Shard-aware create: writes to the store instance for the given db_shard.
-    def _db_sharded_create(db_shard, update: false, force: false, queued: false, isoformat: false, expire_seconds: nil)
+    def _db_sharded_create(db_shard, update: false, force: false, queued: false, expire_seconds: nil)
       db_shard_store = self.class.store.instance(db_shard: db_shard)
       unless force
         existing = db_shard_store.hget(@primary_key, @name)
@@ -89,7 +89,7 @@ module OpenC3
           raise RuntimeError.new("#{@primary_key}:#{@name} doesn't exist at update") if update
         end
       end
-      @updated_at = isoformat ? Time.now.utc.iso8601 : Time.now.utc.to_nsec_from_epoch
+      @updated_at = Time.now.utc.to_nsec_from_epoch
 
       if queued
         store = self.class.store_queued.instance(db_shard: db_shard)

data/lib/openc3/models/gem_model.rb

@@ -47,7 +47,7 @@ module OpenC3
       return path if File.exist?(path)
       path = "#{ENV['GEM_HOME']}/cache/#{name}"
       return path if File.exist?(path)
-      raise "Gem #{name} not found"
+      raise "Gem '#{name}' not found"
     end
 
     def self.put(gem_file_path, gem_install: true, scope:)

data/lib/openc3/models/interface_model.rb

@@ -256,7 +256,7 @@ module OpenC3
 
     def ensure_target_exists(target_name)
       target = TargetModel.get(name: target_name, scope: @scope)
-      raise "Target #{target_name} does not exist" unless target
+      raise "Target '#{target_name}' does not exist (InterfaceModel)" unless target
       target
     end
 
@@ -444,9 +444,11 @@ module OpenC3
       microservice
     end
 
-    # Looks up the deployed MicroserviceModel and destroy the microservice model
-    # should should trigger the operator to kill the microservice that in turn
-    # will destroy the InterfaceStatusModel when a stop is called.
+    # Destroys the deployed MicroserviceModel which triggers the operator to kill
+    # the microservice. Also directly destroys the Interface/RouterStatusModel in
+    # an ensure block. The microservice stop() no longer recreates the status
+    # model once cancel_thread is set, so undeploy must clean it up itself to
+    # avoid leaving an orphaned status model behind.
     def undeploy
       type = self.class._get_type
       name = "#{@scope}__#{type}__#{@name}"
@@ -455,15 +457,19 @@ module OpenC3
         model.destroy
         ConfigTopic.write({ kind: 'deleted', type: type.downcase, name: @name, plugin: @plugin }, scope: @scope)
       end
-
-      if type == 'INTERFACE'
-        status_model = InterfaceStatusModel.get_model(name: @name, scope: @scope)
-      else
-        status_model = RouterStatusModel.get_model(name: @name, scope: @scope)
-      end
-      status_model.destroy if status_model
     rescue Exception => error
       Logger.error("Error undeploying interface/router model #{@name} in scope #{@scope} due to #{error}")
+    ensure
+      begin
+        if type == 'INTERFACE'
+          status_model = InterfaceStatusModel.get_model(name: @name, scope: @scope)
+        else
+          status_model = RouterStatusModel.get_model(name: @name, scope: @scope)
+        end
+        status_model.destroy if status_model
+      rescue Exception => error
+        Logger.error("Error destroying #{type&.downcase || 'unknown'} status model #{@name} in scope #{@scope} due to #{error}")
+      end
     end
 
     def unmap_target(target_name, cmd_only: false, tlm_only: false)

data/lib/openc3/models/interface_status_model.rb

@@ -118,8 +118,8 @@ module OpenC3
       @rxcnt = rxcnt
     end
 
-    def create(update: false, force: false, queued: false, isoformat: false)
-      _db_sharded_create(self.class._db_shard_for_name(@name, scope: @scope, use_cache: true), update: update, force: force, queued: queued, isoformat: isoformat)
+    def create(update: false, force: false, queued: false)
+      _db_sharded_create(self.class._db_shard_for_name(@name, scope: @scope, use_cache: true), update: update, force: force, queued: queued)
     end
 
     def destroy

data/lib/openc3/models/metric_model.rb

@@ -77,8 +77,8 @@ module OpenC3
       @db_shard = db_shard.to_i
     end
 
-    def create(update: false, force: false, queued: false, isoformat: false, expire_seconds: nil)
-      _db_sharded_create(@db_shard, update: update, force: force, queued: queued, isoformat: isoformat, expire_seconds: expire_seconds)
+    def create(update: false, force: false, queued: false, expire_seconds: nil)
+      _db_sharded_create(@db_shard, update: update, force: force, queued: queued, expire_seconds: expire_seconds)
     end
 
     def destroy

data/lib/openc3/models/microservice_model.rb

@@ -140,6 +140,27 @@ module OpenC3
       @bucket = Bucket.getClient()
     end
 
+    # Resolve the Python environment variables that will be used at runtime.
+    # This mirrors the logic in MicroserviceOperator#convert_microservice_to_process_definition.
+    def runtime_python_env
+      python_bin = ENV['OPENC3_PYTHON_BIN'] || '/openc3/python/.venv/bin/python'
+      result = { 'OPENC3_PYTHON_BIN' => python_bin }
+      if @needs_dependencies && @plugin
+        sanitized_name = "#{@scope}__#{@plugin}".tr('^a-zA-Z0-9_-', '_')
+        candidate = "/gems/plugin_venvs/#{sanitized_name}/.venv"
+        if File.directory?(candidate)
+          result['VIRTUAL_ENV'] = candidate
+          result['PYTHONUSERBASE'] = candidate
+          site_packages = Dir.glob("#{candidate}/lib/python*/site-packages").first
+          result['PYTHONPATH'] = site_packages
+        else
+          result['VIRTUAL_ENV'] = nil
+          result['PYTHONUSERBASE'] = '/gems/python_packages'
+        end
+      end
+      result
+    end
+
     def as_json(*a)
       {
         'name' => @name,

data/lib/openc3/models/microservice_status_model.rb

@@ -76,8 +76,8 @@ module OpenC3
       @custom = custom
     end
 
-    def create(update: false, force: false, queued: false, isoformat: false)
-      _db_sharded_create(self.class._db_shard_for_name(@name, scope: @scope, use_cache: true), update: update, force: force, queued: queued, isoformat: isoformat)
+    def create(update: false, force: false, queued: false)
+      _db_sharded_create(self.class._db_shard_for_name(@name, scope: @scope, use_cache: true), update: update, force: force, queued: queued)
     end
 
     def destroy

data/lib/openc3/models/model.rb

@@ -134,7 +134,7 @@ module OpenC3
 
     # Update the Redis hash at primary_key and set the field "name"
     # to the JSON generated via calling as_json
-    def create(update: false, force: false, queued: false, isoformat: false)
+    def create(update: false, force: false, queued: false)
       unless force
         existing = self.class.store.hget(@primary_key, @name)
         if existing
@@ -143,11 +143,7 @@ module OpenC3
           raise "#{@primary_key}:#{@name} doesn't exist at update" if update
         end
       end
-      if isoformat
-        @updated_at = Time.now.utc.iso8601
-      else
-        @updated_at = Time.now.utc.to_nsec_from_epoch
-      end
+      @updated_at = Time.now.utc.to_nsec_from_epoch
 
       if queued
         write_store = self.class.store_queued