openc3 7.0.0.pre.rc3 → 7.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 920a681652723ab469d3311e6f28332ea202068300c3a506d3314c552f5c0f30
-  data.tar.gz: 2f35277fa1e25eb30646a27e8f45365cb2fd39d7d3b24758baabf004e9fe54b5
+  metadata.gz: 36f12f777f56b7d64a19cfd89b8886352b6f0fb06bbda59d95d5643b8d4c71f6
+  data.tar.gz: 1ebffbb1399279e391a47dde42e6f8b9492be10b389c8e63d148aab402ee614c
 SHA512:
-  metadata.gz: 1cd5cb567a743e90742e76db3b4ab8498f34d8b6ba6dc0032e351bb6e3fdfbc4f8db826cc907d500f4670ef461bd49193be74e8264648b6a0f5908d090b7e6cf
-  data.tar.gz: 9af5921a88413af21113b00c0f99dcc023e70c21b4dfc9e7f0f8840fbe226765f86d80e82a7b874458468c45cea590a3e6b0ab2d702d29613818e19e48b473be
+  metadata.gz: ee971acf5bfd378f5a238263b467385286997900bea7fe549b8458c707568fb3a2265b261ee8794601bd42db7d0c2e8a983cf3d81a52c0c5069b9be0b41c4966
+  data.tar.gz: 5ba0ea7fb684a6e3e029864289612975db9555d1754f30f65baf4cf3193208516ea74029bb889b4575014b7953c45990c7e515dcf8f43d292bf8fc844de15a6b

data/bin/openc3cli

@@ -75,6 +75,7 @@ def print_usage
   puts "  cli pkguninstall PKGFILENAME SCOPE  # Uninstall loaded package (Ruby gem or python package)"
   puts "  cli xtce_converter                # Convert to and from the XTCE format. Run with --help for more info."
   puts "  cli cstol_converter               # Converts CSTOL files (.prc) to COSMOS. Run with --help for more info."
+  puts "  cli setpassword                   # Set the initial password from OPENC3_API_PASSWORD env var"
   puts ""
 end
 
@@ -588,35 +589,44 @@ def run_bridge(filename, params)
   end
 end
 
-def cli_script_monitor(script_id)
+def cli_script_monitor(script_id, format: 'text')
   ret_code = ERROR_CODE
   require 'openc3/script'
+  require 'openc3/utilities/ctrf'
   begin
     OpenC3::RunningScriptWebSocketApi.new(id: script_id) do |api|
       while (resp = api.read) do
         # see ScriptRunner.vue for types and states
         case resp['type']
         when 'file'
-          puts "Filename #{resp['filename']} scope #{resp['scope']}"
+          puts "Filename #{resp['filename']} scope #{resp['scope']}" unless format == 'ctrf'
         when 'line'
           fn = resp['filename'].nil? ? '<no file>' : resp['filename']
-          puts "At [#{fn}:#{resp['line_no']}] state [#{resp['state']}]"
+          puts "At [#{fn}:#{resp['line_no']}] state [#{resp['state']}]" unless format == 'ctrf'
           if resp['state'] == 'error' or resp['state'] == 'crashed'
             $script_interrupt_text = ''
-            puts 'script failed'
+            puts 'script failed' unless format == 'ctrf'
             break
           end
         when 'output'
-          puts resp['line']
+          puts resp['line'] unless format == 'ctrf'
         when 'complete'
           $script_interrupt_text = ''
-          puts 'script complete'
+          if resp['report']
+            if format == 'ctrf'
+              ctrf_data = OpenC3::Ctrf.convert_report(resp['report'])
+              puts JSON.pretty_generate(ctrf_data)
+            else
+              puts resp['report']
+            end
+          end
+          puts 'script complete' unless format == 'ctrf'
           ret_code = 0
           break
         # These conditions are all handled by the else
         # when 'running', 'breakpoint', 'waiting', 'time'
         else
-          puts resp.pretty_inspect
+          puts resp.pretty_inspect unless format == 'ctrf'
         end
       end
     end
@@ -692,10 +702,10 @@ def cli_script_run(args, options)
     puts id
     $script_interrupt_text = "  Script #{args[1]} still running remotely.\n" # for Ctrl-C
     if (options[:wait] < 1) then
-      ret_code = cli_script_monitor(id)
+      ret_code = cli_script_monitor(id, format: options[:format])
     else
       Timeout::timeout(options[:wait], nil, "--wait #{options[:wait]} exceeded") do
-        ret_code = cli_script_monitor(id)
+        ret_code = cli_script_monitor(id, format: options[:format])
       rescue Timeout::ExitException, Timeout::Error => e
         # Timeout exceptions are also raised by the Websocket API, so we check
         if e.message =~ /^--wait /
@@ -795,7 +805,7 @@ rescue => e
 end
 
 def cli_script(args=[])
-  options = {scope: 'DEFAULT', disconnect: false, wait: 0, verbose: false}
+  options = {scope: 'DEFAULT', disconnect: false, wait: 0, verbose: false, format: 'text'}
   option_parser = OptionParser.new do |opts|
     opts.banner = "Usage: script --scope SCOPE [init | list | spawn | run]\n" +
       "  init                               Initialize running scripts (Enterprise Only)\n" +
@@ -812,6 +822,9 @@ def cli_script(args=[])
     opts.on("--scope SCOPE", "Run with specified scope (default = DEFAULT)") do |arg|
       options[:scope] = arg
     end
+    opts.on("--format FORMAT", "Output format: text or ctrf (default = text)") do |arg|
+      options[:format] = arg
+    end
     opts.on("--suite SUITE", "Run with specified suite") do |arg|
       options[:suite] = arg
     end
@@ -892,6 +905,25 @@ def cli_script(args=[])
   exit(ret_code)
 end
 
+def set_password
+  password = ENV['OPENC3_API_PASSWORD']
+  argon2_profile = ENV["OPENC3_ARGON2_PROFILE"]&.to_sym || :rfc_9106_low_memory
+  if password.nil? or password.empty?
+    abort "OPENC3_API_PASSWORD environment variable is required"
+  end
+  if password.length < 8
+    abort "Password must be at least 8 characters"
+  end
+  redis = Redis.new(url: $redis_url, username: ENV['OPENC3_REDIS_USERNAME'], password: ENV['OPENC3_REDIS_PASSWORD'])
+  if redis.exists('OPENC3__TOKEN') == 1
+    abort "Password has already been set. Use the web interface to change the password."
+  end
+  pw_hash = Argon2::Password.create(password, profile: argon2_profile)
+  redis.set('OPENC3__TOKEN', pw_hash)
+  puts "Password set successfully."
+  exit 0
+end
+
 def migrate_password_hash
   password = ENV['OPENC3_API_PASSWORD']
   argon2_profile = ENV["OPENC3_ARGON2_PROFILE"]&.to_sym || :rfc_9106_low_memory
@@ -1377,6 +1409,22 @@ if not ARGV[0].nil? # argument(s) given
     end
     run_migrations(ARGV[1])
 
+  when 'setpassword'
+    if ARGV[1] == '--help' || ARGV[1] == '-h'
+      puts "Usage: cli setpassword"
+      puts ""
+      puts "Set the initial COSMOS password from the OPENC3_API_PASSWORD environment variable."
+      puts "This allows you to skip the password creation screen in the web interface."
+      puts ""
+      puts "The password must be at least 8 characters. This command will fail if a"
+      puts "password has already been set."
+      puts ""
+      puts "Options:"
+      puts "  -h, --help        Show this help message"
+      exit 0
+    end
+    set_password()
+
   when 'migratepassword'
     migrate_password_hash()
 

data/bin/pipinstall

@@ -1,13 +1,45 @@
 #!/bin/sh
-uv venv "$PYTHONUSERBASE"
+uv venv "$PYTHONUSERBASE" --allow-existing
 echo "uv pip install $@"
 uv pip install --python "$PYTHONUSERBASE" "$@"
 if [ $? -eq 0 ]; then
     echo "Command succeeded"
-else
-    echo "Command failed - retrying with --no-index"
-    uv pip install --python "$PYTHONUSERBASE" --no-index "$@"
-    if [ $? -ne 0 ]; then
-        echo "ERROR: uv pip install failed"
+    exit 0
+fi
+
+# Collect the last arg and all preceding args
+LAST_ARG=""
+OPTS=""
+PREV=""
+for ARG in "$@"; do
+    if [ -n "$PREV" ]; then
+        OPTS="${OPTS} ${PREV}"
+    fi
+    PREV="$ARG"
+done
+LAST_ARG="$PREV"
+
+# If last arg is a directory with pyproject.toml, the build may have failed
+# (e.g. Poetry package-mode = false). Try compiling and installing declared
+# dependencies only, without attempting to build the package itself.
+if [ -d "$LAST_ARG" ] && [ -f "$LAST_ARG/pyproject.toml" ]; then
+    echo "Warning: Failed to build Python package, attempting to install declared dependencies from pyproject.toml"
+    TMPFILE=$(mktemp)
+    uv pip compile ${OPTS} "${LAST_ARG}/pyproject.toml" > "$TMPFILE"
+    if [ $? -eq 0 ] && [ -s "$TMPFILE" ]; then
+        uv pip install --python "$PYTHONUSERBASE" ${OPTS} -r "$TMPFILE"
+        if [ $? -eq 0 ]; then
+            echo "Dependencies installed successfully"
+            rm -f "$TMPFILE"
+            exit 0
+        fi
     fi
+    rm -f "$TMPFILE"
+fi
+
+echo "Warning: Install failed - retrying with --no-index"
+uv pip install --python "$PYTHONUSERBASE" --no-index "$@"
+if [ $? -ne 0 ]; then
+    echo "ERROR: uv pip install failed"
+    exit 1
 fi

data/data/config/command_modifiers.yaml

@@ -199,6 +199,7 @@ HIDDEN:
   summary: Hides this command from all OpenC3 tools such as Command Sender and Handbook Creator
   description: Hidden commands do not appear in the Script Runner popup helper when writing scripts.
     The command still exists in the system and can be sent by scripts.
+  since: 6.10.1
 DISABLED:
   summary: Disables this command from being sent
   description: Hides the command and also disables it from being sent by scripts.

data/data/config/interface_modifiers.yaml

@@ -53,7 +53,7 @@ RECONNECT_DELAY:
   parameters:
     - name: Delay
       required: true
-      description: Delay in seconds between reconnect attempts. The default is 15 seconds.
+      description: Delay in seconds between reconnect attempts. The default is 5 seconds.
       values: ([0-9]*[.])?[0-9]+
 DISABLE_DISCONNECT:
   summary: Disable the Disconnect button on the Interfaces tab in the Server

data/data/config/item_modifiers.yaml

@@ -72,7 +72,8 @@ GENERIC_READ_CONVERSION_START:
     class (Note, referencing the packet as 'myself' is still supported for backwards
     compatibility). The last line of code should return the converted
     value. The GENERIC_READ_CONVERSION_END keyword specifies that all lines of
-    code for the conversion have been given.
+    code for the conversion have been given. To specify the bit size, type, and array size of the converted data,
+    use the CONVERTED_DATA keyword.
   warning: Generic conversions are not a good long term solution. Consider creating
     a conversion class and using READ_CONVERSION instead. READ_CONVERSION is easier
     to debug and has higher performance.
@@ -81,22 +82,33 @@ GENERIC_READ_CONVERSION_START:
       GENERIC_READ_CONVERSION_START
         (value * 1.5).to_i # Convert the value by a scale factor
       GENERIC_READ_CONVERSION_END
+      CONVERTED_DATA 32 UINT
   python_example: |
     APPEND_ITEM ITEM1 32 UINT
       GENERIC_READ_CONVERSION_START
         int(value * 1.5) # Convert the value by a scale factor
       GENERIC_READ_CONVERSION_END
+      CONVERTED_DATA 32 UINT
+GENERIC_READ_CONVERSION_END:
+  summary: Complete a generic read conversion
+CONVERTED_DATA:
+  summary: Defines the bit size, type, and array size of the converted data for a read conversion
+  description: This keyword is used in conjunction with DERIVED items to specify the bit size, type, and array size of the converted data.
+    If this keyword is not used, DERIVED items are stored as strings in the decommutated data.
+  since: 7.0.0
   parameters:
+    - name: Converted Bit Size
+      required: true
+      description: Bit size of converted value
+      values: \d+
     - name: Converted Type
-      required: false
+      required: true
       description: Type of the converted value
       values: <%= %w(INT UINT FLOAT STRING BLOCK) %>
-    - name: Converted Bit Size
+    - name: Converted Array Size
       required: false
-      description: Bit size of converted value
+      description: Bit size of the total array if the converted value is an array. Only specified if the converted type is an array.
       values: \d+
-GENERIC_READ_CONVERSION_END:
-  summary: Complete a generic read conversion
 LIMITS:
   summary: Defines a set of limits for a telemetry item
   description: If limits are violated a message is printed in the Command and Telemetry Server
@@ -180,4 +192,5 @@ HIDDEN:
   summary: Hides this item from all the OpenC3 tools
   description: This item will not appear in PacketViewer or Item Choosers.
     It also hides this item from appearing in the Script Runner popup helper
-    when writing scripts. The item will also not be included in decom data.
+    when writing scripts. The item will also not be included in decom data.
+  since: 6.10.1

data/data/config/table_parameter_modifiers.yaml

@@ -3,7 +3,9 @@ HIDDEN:
   summary: Indicates that the parameter should not be shown to the user in the Table Manager GUI
   description: Hidden parameters still exist and will be saved to the resulting
     binary. This is useful for padding and other essential but non-user editable fields.
+  since: 6.10.1
 UNEDITABLE:
   summary: Indicates that the parameter should be shown to the user but not editable.
-  description: Uneditable parameters are useful for control fields which the user
+  description:
+    Uneditable parameters are useful for control fields which the user
     may be interested in but should not be able to edit.

data/data/config/telemetry.yaml

@@ -10,7 +10,7 @@ TELEMETRY:
       required: true
       description: Name of the target this telemetry packet is associated with
       values: .+
-    - name: Command
+    - name: Packet
       required: true
       description:
         Name of this telemetry packet. Also referred to as its mnemonic.

data/lib/openc3/accessors/json_accessor.rb

@@ -20,7 +20,7 @@ require 'openc3/accessors/accessor'
 OpenC3.disable_warnings do
   class JsonPath
     def self.process_object(obj_or_str, opts = {})
-      obj_or_str.is_a?(String) ? MultiJson.load(obj_or_str, max_nesting: opts[:max_nesting], create_additions: true, allow_nan: true) : obj_or_str
+      obj_or_str.is_a?(String) ? JSON.parse(obj_or_str, max_nesting: opts[:max_nesting], create_additions: true, allow_nan: true) : obj_or_str
     end
   end
 end

data/lib/openc3/accessors/template_accessor.rb

@@ -53,6 +53,9 @@ module OpenC3
       return nil if item.data_type == :DERIVED
       configure()
 
+      # No template items to read (e.g. command with fixed template string)
+      return nil if @item_keys.empty?
+
       # Scan the response for all the variables in brackets <VARIABLE>
       values = buffer.scan(@read_regexp)[0]
       if !values || (values.length != @item_keys.length)
@@ -73,6 +76,12 @@ module OpenC3
       result = {}
       configure()
 
+      # No template items to read (e.g. command with fixed template string)
+      if @item_keys.empty?
+        items.each { |item| result[item.name] = nil }
+        return result
+      end
+
       # Scan the response for all the variables in brackets <VARIABLE>
       values = buffer.scan(@read_regexp)[0]
       if !values || (values.length != @item_keys.length)

data/lib/openc3/api/tlm_api.rb

@@ -23,7 +23,7 @@
 
 require 'openc3/models/target_model'
 require 'openc3/models/cvt_model'
-require 'openc3/packets/packet'
+# require 'openc3/packets/packet' # Circular require
 require 'openc3/topics/telemetry_topic'
 require 'openc3/topics/interface_topic'
 require 'openc3/topics/decom_interface_topic'
@@ -281,7 +281,7 @@ module OpenC3
 
           case value_type
           when 'FORMATTED', 'WITH_UNITS'
-            if item['format_string']
+            if item['format_string'] or item['units']
               results << [target_name, orig_packet_name, item_name, 'FORMATTED'].join('__')
             # This logic must match the logic in Packet#decom
             elsif item['states'] or (item['read_conversion'] and item['data_type'] != 'DERIVED')
@@ -304,7 +304,7 @@ module OpenC3
           if item['limits']['DEFAULT']
             results[-1] += '__LIMITS'
           end
-        rescue RuntimeError => e
+        rescue RuntimeError
           results << nil
         end
       end

data/lib/openc3/config/config_parser.rb

@@ -15,10 +15,11 @@
 # This file may also be used under the terms of a commercial license
 # if purchased from OpenC3, Inc.
 
-require 'openc3/top_level'
+# require 'openc3/top_level' # Circular require
 require 'openc3/ext/config_parser' if RUBY_ENGINE == 'ruby' and !ENV['OPENC3_NO_EXT']
 require 'erb'
 require 'fileutils'
+require 'tempfile'
 
 module OpenC3
   # Reads OpenC3 style configuration data which consists of keywords followed
@@ -218,6 +219,7 @@ module OpenC3
                    &)
       ensure
         file.close unless file.closed?
+        file.unlink
       end
     end
 
@@ -417,9 +419,7 @@ module OpenC3
       elsif copy.include?(':') # Check for Windows drive letter
         copy = copy.split(':')[1]
       end
-      parsed_filename = File.join(Dir.tmpdir, 'openc3', 'tmp', copy)
-      FileUtils.mkdir_p(File.dirname(parsed_filename)) # Create the path
-      file = File.open(parsed_filename, 'w+')
+      file = Tempfile.new(copy)
       file.puts output
       file.rewind # Rewind so the file is ready to read
       file

data/lib/openc3/conversions/conversion.rb

@@ -20,11 +20,11 @@ module OpenC3
   class Conversion
     # @return [Symbol] The converted data type. Must be one of
     #   {OpenC3::StructureItem#data_type}
-    attr_reader :converted_type
+    attr_accessor :converted_type
     # @return [Integer] The size in bits of the converted value
-    attr_reader :converted_bit_size
+    attr_accessor :converted_bit_size
     # @return [Integer] The size in bits of the converted array value
-    attr_reader :converted_array_size
+    attr_accessor :converted_array_size
     # @return [Array] The arguments passed to the conversion
     attr_reader :params
 

data/lib/openc3/core_ext/faraday.rb

@@ -1,4 +1,8 @@
+# Remove warnings in CGI
+saved_verbose = $VERBOSE
+$VERBOSE = false
 require 'faraday'
+$VERBOSE = saved_verbose
 
 module Faraday
   class Response

data/lib/openc3/interfaces/interface.rb

@@ -295,17 +295,12 @@ module OpenC3
           else
             data, extra = protocol.read_data(data)
           end
-          protocol.read_protocol_output_base(data, extra) unless blank_test
+          protocol.read_protocol_output_base(data, extra) unless blank_test or data == :STOP or data == :DISCONNECT
           if data == :DISCONNECT
             Logger.info("#{@name}: Protocol #{protocol.class} read_data requested disconnect")
             return nil
           end
           break if data == :STOP
-          if blank_test
-            # This means the blank test returned something so we can log
-            protocol.read_protocol_input_base('', nil)
-            protocol.read_protocol_output_base(data, extra)
-          end
         end
         next if data == :STOP
 

data/lib/openc3/logs/log_writer.rb

@@ -126,6 +126,7 @@ module OpenC3
       @cleanup_times = []
       @previous_time_nsec_since_epoch = nil
       @tmp_dir = Dir.mktmpdir
+      @wait_threads = []
 
       # This is an optimization to avoid creating a new entry object
       # each time we create an entry which we do a LOT!
@@ -154,9 +155,8 @@ module OpenC3
 
     # Stops all logging and closes the current log file.
     def stop
-      threads = nil
-      @mutex.synchronize { threads = close_file(false); @logging_enabled = false; }
-      return threads
+      @mutex.synchronize { close_file(false); @logging_enabled = false; }
+      return @wait_threads
     end
 
     # Stop all logging, close the current log file, and kill the logging threads.
@@ -173,6 +173,13 @@ module OpenC3
       return threads
     end
 
+    def cleanup
+      if @tmp_dir
+        FileUtils.remove_entry_secure(@tmp_dir, true)
+        @tmp_dir = nil
+      end
+    end
+
     def graceful_kill
       @cancel_threads = true
     end
@@ -307,8 +314,19 @@ module OpenC3
     # to keep a full file's worth of data in the stream. This is what prevents continuous stream growth.
     # Returns thread that moves log to bucket
     def close_file(take_mutex = true)
-      threads = []
       @mutex.lock if take_mutex
+
+      # Remove old wait_threads
+      to_remove = []
+      @wait_threads.each do |thread|
+        unless thread.alive?
+          to_remove << thread
+        end
+      end
+      to_remove.each do |thread|
+        @wait_threads.delete(thread)
+      end
+
       begin
         if @file
           begin
@@ -322,7 +340,7 @@ module OpenC3
               # Cleanup timestamps here so they are unset for the next file
               @first_time = nil
               @last_time = nil
-              threads << BucketUtilities.move_log_file_to_bucket(@filename, bucket_key)
+              @wait_threads << BucketUtilities.move_log_file_to_bucket(@filename, bucket_key)
               # Now that the file is in storage, trim the Redis stream after a delay
               @cleanup_offsets << {}
               @last_offsets.each do |redis_topic, last_offset|
@@ -342,7 +360,7 @@ module OpenC3
       ensure
         @mutex.unlock if take_mutex
       end
-      return threads
+      return @wait_threads
     end
 
     def bucket_filename

data/lib/openc3/logs/packet_log_writer.rb

@@ -137,7 +137,6 @@ module OpenC3
     # Closing a log file isn't critical so we just log an error
     # Returns threads that moves log to bucket
     def close_file(take_mutex = true)
-      threads = []
       @mutex.lock if take_mutex
       begin
         # Need to write the OFFSET_MARKER for each packet
@@ -145,12 +144,10 @@ module OpenC3
           write_entry(:OFFSET_MARKER, nil, nil, nil, nil, nil, last_offset + ',' + redis_topic, nil) if @file
         end
 
-        threads.concat(super(false))
-
+        return super(false)
       ensure
         @mutex.unlock if take_mutex
       end
-      return threads
     end
 
     def get_packet_index(cmd_or_tlm, target_name, packet_name, entry_type, data)

data/lib/openc3/logs/stream_log_pair.rb

@@ -43,13 +43,20 @@ module OpenC3
 
     # Close any open stream log files
     def stop
-      @read_log.stop
-      @write_log.stop
+      threads = @read_log.stop
+      threads.concat(@write_log.stop)
+      return threads
     end
 
     def shutdown
-      @read_log.shutdown
-      @write_log.shutdown
+      threads = @read_log.shutdown
+      threads.concat(@write_log.shutdown)
+      return threads
+    end
+
+    def cleanup
+      @read_log.cleanup
+      @write_log.cleanup
     end
 
     # Clone the stream log pair

data/lib/openc3/logs/text_log_writer.rb

@@ -68,7 +68,6 @@ module OpenC3
     # Closing a log file isn't critical so we just log an error
     # Returns threads that moves log to bucket
     def close_file(take_mutex = true)
-      threads = []
       @mutex.lock if take_mutex
       begin
         # Need to write the OFFSET_MARKER for each packet
@@ -79,12 +78,10 @@ module OpenC3
           write_entry(time.to_nsec_from_epoch, data.as_json(allow_nan: true).to_json(allow_nan: true)) if @file
         end
 
-        threads.concat(super(false))
-
+        return super(false)
       ensure
         @mutex.unlock if take_mutex
       end
-      return threads
     end
 
     def extension

data/lib/openc3/microservices/decom_microservice.rb

@@ -116,7 +116,7 @@ module OpenC3
                 microservice_cmd(topic, msg_id, msg_hash, redis)
               elsif topic =~ /__DECOMINTERFACE/
                 if msg_hash.key?('inject_tlm')
-                  handle_inject_tlm(msg_hash['inject_tlm'])
+                  handle_inject_tlm_with_ack(msg_hash['inject_tlm'], msg_id)
                   next
                 end
                 if msg_hash.key?('build_cmd')

data/lib/openc3/microservices/interface_decom_common.rb

@@ -34,10 +34,26 @@ module OpenC3
       packet.received_time = Time.now.sys
       packet.received_count = TargetModel.increment_telemetry_count(packet.target_name, packet.packet_name, 1, scope: @scope)
       TelemetryTopic.write_packet(packet, scope: @scope)
-    # If the inject_tlm parameters are bad we rescue so
-    # interface_microservice and decom_microservice can continue
-    rescue => e
-      @logger.error "inject_tlm error due to #{e.message}"
+    end
+
+    def handle_inject_tlm_with_ack(inject_tlm_json, msg_id)
+      inject_tlm_hash = JSON.parse(inject_tlm_json, allow_nan: true, create_additions: true)
+      target_name = inject_tlm_hash['target_name']
+      ack_topic = "{#{@scope}__ACKCMD}TARGET__#{target_name}"
+      begin
+        handle_inject_tlm(inject_tlm_json)
+        msg_hash = {
+          id: msg_id,
+          result: 'SUCCESS'
+        }
+      rescue => error
+        @logger.error "inject_tlm error due to #{error.message}"
+        msg_hash = {
+          id: msg_id,
+          result: error.message
+        }
+      end
+      Topic.write_topic(ack_topic, msg_hash)
     end
 
     def handle_build_cmd(build_cmd_json, msg_id)
@@ -65,8 +81,7 @@ module OpenC3
       rescue => error
         msg_hash = {
           id: msg_id,
-          result: 'ERROR',
-          message: error.message
+          result: error.message
         }
       end
       Topic.write_topic(ack_topic, msg_hash)
@@ -97,8 +112,7 @@ module OpenC3
       rescue => error
         msg_hash = {
           id: msg_id,
-          result: 'ERROR',
-          message: error.message
+          result: error.message
         }
       end
       Topic.write_topic(ack_topic, msg_hash)