openc3 6.8.1 → 6.9.0

data/lib/openc3/models/script_status_model.rb

@@ -88,7 +88,7 @@ module OpenC3
           if r.nil?
             nil
           else
-            JSON.parse(r, :allow_nan => true, :create_additions => true)
+            JSON.parse(r, allow_nan: true, create_additions: true)
           end
         end
         return result
@@ -113,7 +113,7 @@ module OpenC3
           if r.nil?
             nil
           else
-            JSON.parse(r, :allow_nan => true, :create_additions => true)
+            JSON.parse(r, allow_nan: true, create_additions: true)
           end
         end
         return result
@@ -204,7 +204,7 @@ module OpenC3
       else
         write_store = self.class.store
       end
-      write_store.hset(@primary_key, @name, JSON.generate(self.as_json(:allow_nan => true), :allow_nan => true))
+      write_store.hset(@primary_key, @name, JSON.generate(self.as_json(), allow_nan: true))
 
       # Also add to ordered set on create
       write_store.zadd(@primary_key + "__LIST", @name.to_i, @name) if not update

data/lib/openc3/models/sorted_model.rb

@@ -50,14 +50,14 @@ module OpenC3
     # @return [String|nil] String of the saved json or nil if start not found
     def self.get(start:, scope:)
       result = Store.zrangebyscore(self.pk(scope), start, start)
-      return JSON.parse(result[0], :allow_nan => true, :create_additions => true) unless result.empty?
+      return JSON.parse(result[0], allow_nan: true, create_additions: true) unless result.empty?
       nil
     end
 
     # @return [Array<Hash>] Array up to the limit of the models (as Hash objects) stored under the primary key
     def self.all(scope:, limit: 100)
       result = Store.zrevrangebyscore(self.pk(scope), '+inf', '-inf', limit: [0, limit])
-      return result.map { |item| JSON.parse(item, :allow_nan => true, :create_additions => true) }
+      return result.map { |item| JSON.parse(item, allow_nan: true, create_additions: true) }
     end
 
     # @return [String|nil] json or nil if metadata empty
@@ -76,7 +76,7 @@ module OpenC3
         raise SortedInputError.new "start: #{start} must be before stop: #{stop}"
       end
       result = Store.zrangebyscore(self.pk(scope), start, stop, limit: [0, limit])
-      return result.map { |item| JSON.parse(item, :allow_nan => true, :create_additions => true) }
+      return result.map { |item| JSON.parse(item, allow_nan: true, create_additions: true) }
     end
 
     # @return [Integer] count of the members stored under the primary key
@@ -132,7 +132,7 @@ module OpenC3
       validate_start(update: update)
       @updated_at = Time.now.to_nsec_from_epoch
       SortedModel.destroy(scope: @scope, start: update) if update
-      Store.zadd(@primary_key, @start, JSON.generate(as_json(:allow_nan => true)))
+      Store.zadd(@primary_key, @start, JSON.generate(as_json, allow_nan: true))
       if update
         notify(kind: 'updated')
       else
@@ -156,7 +156,7 @@ module OpenC3
     # @return [] update the redis stream / timeline topic that something has changed
     def notify(kind:, extra: nil)
       notification = {
-        'data' => JSON.generate(as_json(:allow_nan => true)),
+        'data' => JSON.generate(as_json, allow_nan: true),
         'kind' => kind,
         'type' => 'calendar',
       }

data/lib/openc3/models/target_model.rb

@@ -207,7 +207,7 @@ module OpenC3
       json = Store.hget("#{scope}__openc3#{type.to_s.downcase}__#{target_name}", packet_name)
       raise "Packet '#{target_name} #{packet_name}' does not exist" if json.nil?
 
-      JSON.parse(json, :allow_nan => true, :create_additions => true)
+      JSON.parse(json, allow_nan: true, create_additions: true)
     end
 
     # @return [Array<Hash>] All packet hashes under the target_name
@@ -218,7 +218,7 @@ module OpenC3
       result = []
       packets = Store.hgetall("#{scope}__openc3#{type.to_s.downcase}__#{target_name}")
       packets.sort.each do |_packet_name, packet_json|
-        result << JSON.parse(packet_json, :allow_nan => true, :create_additions => true)
+        result << JSON.parse(packet_json, allow_nan: true, create_additions: true)
       end
       result
     end
@@ -232,7 +232,7 @@ module OpenC3
       raise "Unknown type #{type} for #{target_name} #{packet_name}" unless VALID_TYPES.include?(type)
 
       begin
-        Store.hset("#{scope}__openc3#{type.to_s.downcase}__#{target_name}", packet_name, JSON.generate(packet.as_json(:allow_nan => true)))
+        Store.hset("#{scope}__openc3#{type.to_s.downcase}__#{target_name}", packet_name, JSON.generate(packet.as_json, allow_nan: true))
       rescue JSON::GeneratorError => e
         Logger.error("Invalid text present in #{target_name} #{packet_name} #{type.to_s.downcase} packet")
         raise e
@@ -289,7 +289,7 @@ module OpenC3
     def self.limits_groups(scope:)
       groups = Store.hgetall("#{scope}__limits_groups")
       if groups
-        groups.map { |group, items| [group, JSON.parse(items, :allow_nan => true, :create_additions => true)] }.to_h
+        groups.map { |group, items| [group, JSON.parse(items, allow_nan: true, create_additions: true)] }.to_h
       else
         {}
       end
@@ -302,10 +302,10 @@ module OpenC3
       target_name = target_name.upcase
       json_data = Store.get(item_map_key)
       if json_data
-        item_map = JSON.parse(json_data, :allow_nan => true, :create_additions => true)
+        item_map = JSON.parse(json_data, allow_nan: true, create_additions: true)
       else
         item_map = build_item_to_packet_map(target_name, scope: scope)
-        Store.set(item_map_key, JSON.generate(item_map, :allow_nan => true))
+        Store.set(item_map_key, JSON.generate(item_map, allow_nan: true))
       end
       @@item_map_cache[target_name] = [Time.now, item_map]
       return item_map
@@ -462,7 +462,7 @@ module OpenC3
         'reduced_day_log_retain_time' => @reduced_day_log_retain_time,
         'cleanup_poll_time' => @cleanup_poll_time,
         'needs_dependencies' => @needs_dependencies,
-        'target_microservices' => @target_microservices.as_json(:allow_nan => true),
+        'target_microservices' => @target_microservices.as_json(),
         'reducer_disable' => @reducer_disable,
         'reducer_max_cpu_utilization' => @reducer_max_cpu_utilization,
         'disable_erb' => @disable_erb,
@@ -802,7 +802,7 @@ module OpenC3
         packets.each do |packet_name, packet|
           Logger.debug "Configuring tlm packet: #{target_name} #{packet_name}"
           begin
-            Store.hset("#{@scope}__openc3tlm__#{target_name}", packet_name, JSON.generate(packet.as_json(:allow_nan => true)))
+            Store.hset("#{@scope}__openc3tlm__#{target_name}", packet_name, JSON.generate(packet.as_json, allow_nan: true))
           rescue JSON::GeneratorError => e
             Logger.error("Invalid text present in #{target_name} #{packet_name} tlm packet")
             raise e
@@ -826,7 +826,7 @@ module OpenC3
         packets.each do |packet_name, packet|
           Logger.debug "Configuring cmd packet: #{target_name} #{packet_name}"
           begin
-            Store.hset("#{@scope}__openc3cmd__#{target_name}", packet_name, JSON.generate(packet.as_json(:allow_nan => true)))
+            Store.hset("#{@scope}__openc3cmd__#{target_name}", packet_name, JSON.generate(packet.as_json, allow_nan: true))
           rescue JSON::GeneratorError => e
             Logger.error("Invalid text present in #{target_name} #{packet_name} cmd packet")
             raise e
@@ -838,7 +838,7 @@ module OpenC3
     def update_store_limits_groups(system)
       system.limits.groups.each do |group, items|
         begin
-          Store.hset("#{@scope}__limits_groups", group, JSON.generate(items))
+          Store.hset("#{@scope}__limits_groups", group, JSON.generate(items, allow_nan: true))
         rescue JSON::GeneratorError => e
           Logger.error("Invalid text present in #{group} limits group")
           raise e
@@ -859,7 +859,7 @@ module OpenC3
       # Create item_map
       item_map_key = "#{@scope}__#{@name}__item_to_packet_map"
       item_map = self.class.build_item_to_packet_map(@name, scope: @scope)
-      Store.set(item_map_key, JSON.generate(item_map, :allow_nan => true))
+      Store.set(item_map_key, JSON.generate(item_map, allow_nan: true))
       @@item_map_cache[@name] = [Time.now, item_map]
     end
 

data/lib/openc3/models/timeline_model.rb

@@ -72,7 +72,7 @@ module OpenC3
 
     # @return [TimelineModel] Model generated from the passed JSON
     def self.from_json(json, name:, scope:)
-      json = JSON.parse(json, :allow_nan => true, :create_additions => true) if String === json
+      json = JSON.parse(json, allow_nan: true, create_additions: true) if String === json
       raise "json data is nil" if json.nil?
       self.new(**json.transform_keys(&:to_sym), name: name, scope: scope)
     end
@@ -120,7 +120,7 @@ module OpenC3
     # @return [] update the redis stream / timeline topic that something has changed
     def notify(kind:)
       notification = {
-        'data' => JSON.generate(as_json(:allow_nan => true)),
+        'data' => JSON.generate(as_json, allow_nan: true),
         'kind' => kind,
         'type' => 'timeline',
         'timeline' => @timeline_name

data/lib/openc3/models/tool_model.rb

@@ -298,7 +298,7 @@ module OpenC3
     def self.unordered_all(scope: nil)
       tools = Store.hgetall("#{scope}__#{PRIMARY_KEY}")
       tools.each do |key, value|
-        tools[key] = JSON.parse(value, :allow_nan => true, :create_additions => true)
+        tools[key] = JSON.parse(value, allow_nan: true, create_additions: true)
       end
       return tools
     end

data/lib/openc3/models/trigger_group_model.rb

@@ -101,19 +101,19 @@ module OpenC3
 
     # @return [TriggerGroupModel] Model generated from the passed JSON
     def self.from_json(json, name:, scope:)
-      json = JSON.parse(json, :allow_nan => true, :create_additions => true) if String === json
+      json = JSON.parse(json, allow_nan: true, create_additions: true) if String === json
       raise "json data is nil" if json.nil?
       self.new(**json.transform_keys(&:to_sym), name: name, scope: scope)
     end
 
     # @return [] update the redis stream / trigger topic that something has changed
     def notify(kind:, error: nil)
-      data = as_json(:allow_nan => true)
+      data = as_json()
       data['error'] = error unless error.nil?
       notification = {
         'kind' => kind,
         'type' => 'group',
-        'data' => JSON.generate(data),
+        'data' => JSON.generate(data, allow_nan: true),
       }
       AutonomicTopic.write_notification(notification, scope: @scope)
     end

data/lib/openc3/models/trigger_model.rb

@@ -200,21 +200,21 @@ module OpenC3
       end
       verify_triggers()
       @updated_at = Time.now.to_nsec_from_epoch
-      Store.hset(@primary_key, @name, JSON.generate(as_json(:allow_nan => true)))
+      Store.hset(@primary_key, @name, JSON.generate(as_json, allow_nan: true))
       notify(kind: 'created')
     end
 
     def update
       verify_triggers()
       @updated_at = Time.now.to_nsec_from_epoch
-      Store.hset(@primary_key, @name, JSON.generate(as_json(:allow_nan => true)))
+      Store.hset(@primary_key, @name, JSON.generate(as_json, allow_nan: true))
       # No notification as this is only called via trigger_controller which already notifies
     end
 
     def state=(value)
       @state = value
       @updated_at = Time.now.to_nsec_from_epoch
-      Store.hset(@primary_key, @name, JSON.generate(as_json(:allow_nan => true)))
+      Store.hset(@primary_key, @name, JSON.generate(as_json, allow_nan: true))
       notify(kind: @state.to_s)
     end
 
@@ -232,7 +232,7 @@ module OpenC3
     def disable
       notify_disable()
       @updated_at = Time.now.to_nsec_from_epoch
-      Store.hset(@primary_key, @name, JSON.generate(as_json(:allow_nan => true)))
+      Store.hset(@primary_key, @name, JSON.generate(as_json, allow_nan: true))
     end
 
     # ["#{@scope}__DECOM__{#{@target}}__#{@packet}"]
@@ -278,7 +278,7 @@ module OpenC3
 
     # @return [TriggerModel] Model generated from the passed JSON
     def self.from_json(json, name:, scope:)
-      json = JSON.parse(json, :allow_nan => true, :create_additions => true) if String === json
+      json = JSON.parse(json, allow_nan: true, create_additions: true) if String === json
       raise "json data is nil" if json.nil?
       self.new(**json.transform_keys(&:to_sym), name: name, scope: scope)
     end
@@ -288,7 +288,7 @@ module OpenC3
       notification = {
         'kind' => kind,
         'type' => 'trigger',
-        'data' => JSON.generate(as_json(:allow_nan => true)),
+        'data' => JSON.generate(as_json, allow_nan: true),
       }
       AutonomicTopic.write_notification(notification, scope: @scope)
     end

data/lib/openc3/models/widget_model.rb

@@ -54,7 +54,7 @@ module OpenC3
     def self.all(scope: nil)
       tools = Store.hgetall("#{scope}__#{PRIMARY_KEY}")
       tools.each do |key, value|
-        tools[key] = JSON.parse(value, :allow_nan => true, :create_additions => true)
+        tools[key] = JSON.parse(value, allow_nan: true, create_additions: true)
       end
       return tools
     end

data/lib/openc3/operators/operator.rb

@@ -196,13 +196,13 @@ module OpenC3
         stdout = @process.io.stdout.extract
         if stdout.length > 0
           message = "STDOUT #{stdout.length} bytes from #{cmd_line()}:"
-          STDOUT.puts Logger.build_log_data(Logger::INFO_LEVEL, message, user: nil, type: OpenC3::Logger::LOG, url: nil).as_json(:allow_nan => true).to_json(:allow_nan => true)
+          STDOUT.puts Logger.build_log_data(Logger::INFO_LEVEL, message, user: nil, type: OpenC3::Logger::LOG, url: nil).as_json().to_json(allow_nan: true)
           STDOUT.puts stdout
         end
         stderr = @process.io.stderr.extract
         if stderr.length > 0
           message = "STDERR #{stderr.length} bytes from #{cmd_line()}:"
-          STDERR.puts Logger.build_log_data(Logger::ERROR_LEVEL, message, user: nil, type: OpenC3::Logger::LOG, url: nil).as_json(:allow_nan => true).to_json(:allow_nan => true)
+          STDERR.puts Logger.build_log_data(Logger::ERROR_LEVEL, message, user: nil, type: OpenC3::Logger::LOG, url: nil).as_json().to_json(allow_nan: true)
           STDERR.puts stderr
         end
       end

data/lib/openc3/packets/json_packet.rb

@@ -48,7 +48,7 @@ module OpenC3
       end
       @extra = extra
       @json_hash = json_data
-      @json_hash = JSON.parse(json_data, :allow_nan => true, :create_additions => true) if String === json_data
+      @json_hash = JSON.parse(json_data, allow_nan: true, create_additions: true) if String === json_data
       if key_map
         uncompressed = {}
         @json_hash.each do |key, value|

data/lib/openc3/packets/packet.rb

@@ -1054,7 +1054,7 @@ module OpenC3
         end
       end
       packet.instance_variable_set("@read_conversion_cache".freeze, nil)
-      packet.extra = JSON.parse(packet.extra.as_json(:allow_nan => true).to_json(:allow_nan => true), :allow_nan => true, :create_additions => true) if packet.extra # Deep copy using JSON
+      packet.extra = JSON.parse(packet.extra.as_json().to_json(allow_nan: true), allow_nan: true, create_additions: true) if packet.extra # Deep copy using JSON
       packet
     end
     alias dup clone

data/lib/openc3/script/calendar.rb

@@ -98,10 +98,10 @@ module OpenC3
     def _cal_handle_response(response, error_message)
       return nil if response.nil?
       if response.status >= 400
-        result = JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+        result = JSON.parse(response.body, allow_nan: true, create_additions: true)
         raise "#{error_message} due to #{result['message']}"
       end
-      return JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+      return JSON.parse(response.body, allow_nan: true, create_additions: true)
     end
   end
 end

data/lib/openc3/script/metadata.rb

@@ -36,7 +36,7 @@ module OpenC3
       response = $api_server.request('get', "/openc3-api/metadata", query: { limit: limit }, scope: scope)
       # Non-existent just returns nil
       return nil if response.nil? || response.status != 200
-      return JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+      return JSON.parse(response.body, allow_nan: true, create_additions: true)
     end
     alias all_metadata metadata_all
 
@@ -51,7 +51,7 @@ module OpenC3
       end
       # Non-existent just returns nil
       return nil if response.nil? || response.status != 200
-      return JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+      return JSON.parse(response.body, allow_nan: true, create_additions: true)
     end
     alias get_metadata metadata_get
 
@@ -76,7 +76,7 @@ module OpenC3
       elsif response.status != 201
         raise "Failed to set metadata due to #{response.status}"
       end
-      return JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+      return JSON.parse(response.body, allow_nan: true, create_additions: true)
     end
     alias set_metadata metadata_set
 
@@ -104,7 +104,7 @@ module OpenC3
       if response.nil? || response.status != 200
         raise "Failed to update metadata"
       end
-      return JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+      return JSON.parse(response.body, allow_nan: true, create_additions: true)
     end
     alias update_metadata metadata_update
 

data/lib/openc3/script/queue.rb

@@ -30,10 +30,10 @@ module OpenC3
       if response.nil?
         raise "Failed to #{action}. No response from server."
       elsif response.status != 200 and response.status != 201
-        result = JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+        result = JSON.parse(response.body, allow_nan: true, create_additions: true)
         raise "Failed to #{action} due to #{result['message']}"
       end
-      return JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+      return JSON.parse(response.body, allow_nan: true, create_additions: true)
     end
 
     def queue_all(scope: $openc3_scope)

data/lib/openc3/script/script_runner.rb

@@ -34,7 +34,7 @@ module OpenC3
       if response.nil? || response.status != 200
         _script_response_error(response, "Script list request failed", scope: scope)
       else
-        scripts = JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+        scripts = JSON.parse(response.body, allow_nan: true, create_additions: true)
         # Remove the '*' from the script names
         return scripts.each { |script| script.gsub!(/\*$/, '') }
       end
@@ -50,7 +50,7 @@ module OpenC3
       if response.nil? || response.status != 200
         _script_response_error(response, "Script syntax check request failed", scope: scope)
       else
-        result = JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+        result = JSON.parse(response.body, allow_nan: true, create_additions: true)
         if result['title'] == "Syntax Check Successful"
           result['success'] = true
         else
@@ -66,7 +66,7 @@ module OpenC3
       if response.nil? || response.status != 200
         _script_response_error(response, "Failed to get #{filename}", scope: scope)
       else
-        result = JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+        result = JSON.parse(response.body, allow_nan: true, create_additions: true)
         return result['contents']
       end
     end
@@ -142,9 +142,9 @@ module OpenC3
       if response.nil? || response.status != 200
         _script_response_error(response, "Script instrumented request failed", scope: scope)
       else
-        result = JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+        result = JSON.parse(response.body, allow_nan: true, create_additions: true)
         if result['title'] == "Instrumented Script"
-          parsed = JSON.parse(result['description'], :allow_nan => true, :create_additions => true)
+          parsed = JSON.parse(result['description'], allow_nan: true, create_additions: true)
           return parsed.join("\n")
         else
           raise result.inspect
@@ -158,7 +158,7 @@ module OpenC3
       if response.nil? || response.status != 200
         _script_response_error(response, "Script create request failed", scope: scope)
       else
-        return JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+        return JSON.parse(response.body, allow_nan: true, create_additions: true)
       end
     end
 
@@ -178,7 +178,7 @@ module OpenC3
       if response.nil? || response.status != 200
         _script_response_error(response, "Running script list request failed", scope: scope)
       else
-        return JSON.parse(response.body, :allow_nan => true, :create_additions => true)['items']
+        return JSON.parse(response.body, allow_nan: true, create_additions: true)['items']
       end
     end
 
@@ -188,7 +188,7 @@ module OpenC3
       if response.nil? || response.status != 200
         _script_response_error(response, "Running script show request failed", scope: scope)
       else
-        return JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+        return JSON.parse(response.body, allow_nan: true, create_additions: true)
       end
     end
     alias running_script_get script_get # Deprecated alias for compatibility
@@ -275,7 +275,7 @@ module OpenC3
       if response.nil? || response.status != 200
         _script_response_error(response, "Completed script list request failed", scope: scope)
       else
-        return JSON.parse(response.body, :allow_nan => true, :create_additions => true)['items']
+        return JSON.parse(response.body, allow_nan: true, create_additions: true)['items']
       end
     end
   end

data/lib/openc3/script/storage.rb

@@ -199,7 +199,7 @@ module OpenC3
       if response.nil? || response.status != 201
         raise "Failed to get presigned URL for #{endpoint}"
       end
-      JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+      JSON.parse(response.body, allow_nan: true, create_additions: true)
     end
   end
 end

data/lib/openc3/script/tables.rb

@@ -40,10 +40,10 @@ module OpenC3
     def _tables_handle_response(response, error_message)
       return nil if response.nil?
       if response.status >= 400
-        result = JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+        result = JSON.parse(response.body, allow_nan: true, create_additions: true)
         raise "#{error_message} due to #{result['message']}"
       end
-      return JSON.parse(response.body, :allow_nan => true, :create_additions => true)
+      return JSON.parse(response.body, allow_nan: true, create_additions: true)
     end
   end
 end

data/lib/openc3/script/web_socket_api.rb

@@ -91,8 +91,8 @@ module OpenC3
       unless @subscribed
         json_hash = {}
         json_hash['command'] = 'subscribe'
-        json_hash['identifier'] = JSON.generate(@identifier)
-        @stream.write(JSON.generate(json_hash))
+        json_hash['identifier'] = JSON.generate(@identifier, allow_nan: true)
+        @stream.write(JSON.generate(json_hash, allow_nan: true))
         @subscribed = true
       end
     end
@@ -102,8 +102,8 @@ module OpenC3
       if @subscribed
         json_hash = {}
         json_hash['command'] = 'unsubscribe'
-        json_hash['identifier'] = JSON.generate(@identifier)
-        @stream.write(JSON.generate(json_hash))
+        json_hash['identifier'] = JSON.generate(@identifier, allow_nan: true)
+        @stream.write(JSON.generate(json_hash, allow_nan: true))
         @subscribed = false
       end
     end
@@ -112,9 +112,9 @@ module OpenC3
     def write_action(data_hash)
       json_hash = {}
       json_hash['command'] = 'message'
-      json_hash['identifier'] = JSON.generate(@identifier)
-      json_hash['data'] = JSON.generate(data_hash)
-      write(JSON.generate(json_hash))
+      json_hash['identifier'] = JSON.generate(@identifier, allow_nan: true)
+      json_hash['data'] = JSON.generate(data_hash, allow_nan: true)
+      write(JSON.generate(json_hash, allow_nan: true))
     end
 
     # General write to the websocket

data/lib/openc3/tools/cmd_tlm_server/interface_thread.rb

@@ -210,18 +210,6 @@ module OpenC3
       rescue => e
         Logger.error "Problem writing to router #{router.name} - #{e.class}:#{e.message}"
       end
-
-      # Write to packet log writers
-      if packet.stored and !@interface.stored_packet_log_writer_pairs.empty?
-        @interface.stored_packet_log_writer_pairs.each do |packet_log_writer_pair|
-          packet_log_writer_pair.tlm_log_writer.write(packet)
-        end
-      else
-        @interface.packet_log_writer_pairs.each do |packet_log_writer_pair|
-          # Write errors are handled by the log writer
-          packet_log_writer_pair.tlm_log_writer.write(packet)
-        end
-      end
     end
 
     def handle_connection_failed(connect_error)

data/lib/openc3/tools/table_manager/table_manager_core.rb

@@ -191,7 +191,7 @@ module OpenC3
           end
         end
       end
-      json.as_json(:allow_nan => true)
+      json.as_json()
     end
 
     def self.load_binary(config, data)

data/lib/openc3/topics/command_decom_topic.rb

@@ -39,8 +39,8 @@ module OpenC3
         json_hash[item.name + "__F"] = packet.read_item(item, :FORMATTED) if item.format_string
         json_hash[item.name + "__U"] = packet.read_item(item, :WITH_UNITS) if item.units
       end
-      json_hash['extra'] = JSON.generate(packet.extra.as_json(:allow_nan => true))
-      msg_hash['json_data'] = JSON.generate(json_hash.as_json(:allow_nan => true))
+      json_hash['extra'] = JSON.generate(packet.extra.as_json, allow_nan: true)
+      msg_hash['json_data'] = JSON.generate(json_hash.as_json, allow_nan: true)
       EphemeralStoreQueued.write_topic(topic, msg_hash)
     end
 
@@ -51,7 +51,7 @@ module OpenC3
           msg_hash['received_count'].to_i
         else
           json = msg_hash['json_data']
-          hash = JSON.parse(json, :allow_nan => true, :create_additions => true)
+          hash = JSON.parse(json, allow_nan: true, create_additions: true)
           # Start from the most complex down to the basic raw value
           value = hash["#{param_name}__U"]
           return value if value && type == :WITH_UNITS

data/lib/openc3/topics/command_topic.rb

@@ -47,7 +47,7 @@ module OpenC3
       Topic.update_topic_offsets([ack_topic])
       # Save the existing cmd_params Hash and JSON generate before writing to the topic
       cmd_params = command['cmd_params']
-      command['cmd_params'] = JSON.generate(command['cmd_params'].as_json(:allow_nan => true))
+      command['cmd_params'] = JSON.generate(command['cmd_params'].as_json, allow_nan: true)
       OpenC3.inject_context(command)
       cmd_id = Topic.write_topic("{#{scope}__CMD}TARGET__#{command['target_name']}", command, '*', 100)
       command["cmd_params"] = cmd_params # Restore the original cmd_params Hash

data/lib/openc3/topics/interface_topic.rb

@@ -42,10 +42,13 @@ module OpenC3
       while true
         Topic.read_topics(InterfaceTopic.topics(interface, scope: scope)) do |topic, msg_id, msg_hash, redis|
           result = yield topic, msg_id, msg_hash, redis
-          ack_topic = topic.split("__")
-          ack_topic[1] = 'ACK' + ack_topic[1]
-          ack_topic = ack_topic.join("__")
-          Topic.write_topic(ack_topic, { 'result' => result, 'id' => msg_id }, '*', 100)
+          if result
+            # Only ack if we intend to - Disabled targets will not ack
+            ack_topic = topic.split("__")
+            ack_topic[1] = 'ACK' + ack_topic[1]
+            ack_topic = ack_topic.join("__")
+            Topic.write_topic(ack_topic, { 'result' => result, 'id' => msg_id }, '*', 100)
+          end
         end
       end
     end
@@ -75,7 +78,7 @@ module OpenC3
 
     def self.connect_interface(interface_name, *interface_params, scope:)
       if interface_params && !interface_params.empty?
-        Topic.write_topic("{#{scope}__CMD}INTERFACE__#{interface_name}", { 'connect' => 'true', 'params' => JSON.generate(interface_params) }, '*', 100)
+        Topic.write_topic("{#{scope}__CMD}INTERFACE__#{interface_name}", { 'connect' => 'true', 'params' => JSON.generate(interface_params, allow_nan: true) }, '*', 100)
       else
         Topic.write_topic("{#{scope}__CMD}INTERFACE__#{interface_name}", { 'connect' => 'true' }, '*', 100)
       end
@@ -121,5 +124,42 @@ module OpenC3
       data['type'] = type
       Topic.write_topic("{#{scope}__CMD}INTERFACE__#{interface_name}", { 'inject_tlm' => JSON.generate(data, allow_nan: true) }, '*', 100)
     end
+
+    def self.interface_target_enable(interface_name, target_name, cmd_only: false, tlm_only: false, scope:)
+      data = {}
+      data['target_name'] = target_name.to_s.upcase
+      data['cmd_only'] = cmd_only
+      data['tlm_only'] = tlm_only
+      data['action'] = 'enable'
+      Topic.write_topic("{#{scope}__CMD}INTERFACE__#{interface_name}", { 'target_control' => JSON.generate(data, allow_nan: true) }, '*', 100)
+    end
+
+    def self.interface_target_disable(interface_name, target_name, cmd_only: false, tlm_only: false, scope:)
+      data = {}
+      data['target_name'] = target_name.to_s.upcase
+      data['cmd_only'] = cmd_only
+      data['tlm_only'] = tlm_only
+      data['action'] = 'disable'
+      Topic.write_topic("{#{scope}__CMD}INTERFACE__#{interface_name}", { 'target_control' => JSON.generate(data, allow_nan: true) }, '*', 100)
+    end
+
+    def self.interface_details(interface_name, timeout: nil, scope:)
+      interface_name = interface_name.upcase
+
+      timeout = COMMAND_ACK_TIMEOUT_S unless timeout
+      ack_topic = "{#{scope}__ACKCMD}INTERFACE__#{interface_name}"
+      Topic.update_topic_offsets([ack_topic])
+
+      cmd_id = Topic.write_topic("{#{scope}__CMD}INTERFACE__#{interface_name}", { 'interface_details' => 'true' }, '*', 100)
+      time = Time.now
+      while (Time.now - time) < timeout
+        Topic.read_topics([ack_topic]) do |_topic, _msg_id, msg_hash, _redis|
+          if msg_hash["id"] == cmd_id
+            return JSON.parse(msg_hash["result"], :allow_nan => true, :create_additions => true)
+          end
+        end
+      end
+      raise "Timeout of #{timeout}s waiting for cmd ack"
+    end
   end
 end