openc3 5.11.3 → 5.13.0

data/lib/openc3/models/target_model.rb

@@ -14,7 +14,7 @@
 # GNU Affero General Public License for more details.
 
 # Modified by OpenC3, Inc.
-# All changes Copyright 2022, OpenC3, Inc.
+# All changes Copyright 2023, OpenC3, Inc.
 # All Rights Reserved
 #
 # This file may also be used under the terms of a commercial license
@@ -78,6 +78,7 @@ module OpenC3
     attr_accessor :needs_dependencies
     attr_accessor :target_microservices
     attr_accessor :children
+    attr_accessor :disable_erb
 
     # NOTE: The following three class methods are used by the ModelController
     # and are reimplemented to enable various Model class methods to work
@@ -349,6 +350,7 @@ module OpenC3
       target_microservices: {'REDUCER' => [[]]},
       reducer_disable: false,
       reducer_max_cpu_utilization: 30.0,
+      disable_erb: nil,
       scope:
     )
       super("#{scope}__#{PRIMARY_KEY}", name: name, plugin: plugin, updated_at: updated_at,
@@ -396,6 +398,7 @@ module OpenC3
       @target_microservices = target_microservices
       @reducer_disable = reducer_disable
       @reducer_max_cpu_utilization = reducer_max_cpu_utilization
+      @disable_erb = disable_erb
       @bucket = Bucket.getClient()
       @children = []
     end
@@ -435,7 +438,8 @@ module OpenC3
         'needs_dependencies' => @needs_dependencies,
         'target_microservices' => @target_microservices.as_json(:allow_nan => true),
         'reducer_disable' => @reducer_disable,
-        'reducer_max_cpu_utilization' => @reducer_max_cpu_utilization
+        'reducer_max_cpu_utilization' => @reducer_max_cpu_utilization,
+        'disable_erb' => @disable_erb
       }
     end
 
@@ -544,6 +548,12 @@ module OpenC3
         else
           raise ConfigParser::Error.new(parser, "PACKET cannot be used without a TARGET_MICROSERVICE")
         end
+      when 'DISABLE_ERB'
+        # 0 to unlimited parameters
+        @disable_erb ||= []
+        if parameters
+          @disable_erb.concat(parameters)
+        end
       else
         raise ConfigParser::Error.new(parser, "Unknown keyword and parameters for Target: #{keyword} #{parameters.join(" ")}")
       end
@@ -567,10 +577,13 @@ module OpenC3
           # Load target files
           @filename = filename # For render
           data = File.read(filename, mode: "rb")
+          erb_disabled = check_disable_erb(filename)
           begin
-            OpenC3.set_working_dir(File.dirname(filename)) do
-              if ERB_EXTENSIONS.include?(File.extname(filename).downcase) and File.basename(filename)[0] != '_'
-                data = ERB.new(data.force_encoding("UTF-8").comment_erb(), trim_mode: "-").result(binding.set_variables(variables))
+            unless erb_disabled
+              OpenC3.set_working_dir(File.dirname(filename)) do
+                if ERB_EXTENSIONS.include?(File.extname(filename).downcase) and File.basename(filename)[0] != '_'
+                  data = ERB.new(data.force_encoding("UTF-8").comment_erb(), trim_mode: "-").result(binding.set_variables(variables))
+                end
               end
             end
           rescue => error
@@ -679,9 +692,15 @@ module OpenC3
         path = File.join(File.dirname(@filename), template_name)
       end
 
+      data = File.read(path, mode: "rb")
+      erb_disabled = check_disable_erb(path)
       begin
-        OpenC3.set_working_dir(File.dirname(path)) do
-          return ERB.new(File.read(path).force_encoding("UTF-8").comment_erb(), trim_mode: "-").result(b)
+        if erb_disabled
+          return data
+        else
+          OpenC3.set_working_dir(File.dirname(path)) do
+            return ERB.new(data.force_encoding("UTF-8").comment_erb(), trim_mode: "-").result(b)
+          end
         end
       rescue => error
         raise "ERB error parsing: #{path}: #{error.formatted}"
@@ -692,14 +711,14 @@ module OpenC3
       target_files = []
       Find.find(target_folder) { |file| target_files << file }
       target_files.sort!
-      hash = OpenC3.hash_files(target_files, nil, 'SHA256').hexdigest
-      File.open(File.join(target_folder, 'target_id.txt'), 'wb') { |file| file.write(hash) }
+      @id = OpenC3.hash_files(target_files, nil, 'SHA256').hexdigest
+      File.open(File.join(target_folder, 'target_id.txt'), 'wb') { |file| file.write(@id) }
       key = "#{@scope}/targets/#{@name}/target_id.txt"
-      @bucket.put_object(bucket: ENV['OPENC3_CONFIG_BUCKET'], key: key, body: hash)
+      @bucket.put_object(bucket: ENV['OPENC3_CONFIG_BUCKET'], key: key, body: @id)
 
       # Create target archive zip file
       prefix = File.dirname(target_folder) + '/'
-      output_file = File.join(temp_dir, @name + '_' + hash + '.zip')
+      output_file = File.join(temp_dir, @name + '_' + @id + '.zip')
       Zip.continue_on_exists_proc = true
       Zip::File.open(output_file, Zip::File::CREATE) do |zipfile|
         target_files.each do |target_file|
@@ -718,7 +737,7 @@ module OpenC3
         @bucket.put_object(bucket: ENV['OPENC3_CONFIG_BUCKET'], key: bucket_key, body: file)
       end
       File.open(output_file, 'rb') do |file|
-        bucket_key = key = "#{@scope}/target_archives/#{@name}/#{@name}_#{hash}.zip"
+        bucket_key = key = "#{@scope}/target_archives/#{@name}/#{@name}_#{@id}.zip"
         @bucket.put_object(bucket: ENV['OPENC3_CONFIG_BUCKET'], key: bucket_key, body: file)
       end
     end
@@ -733,7 +752,6 @@ module OpenC3
       @cmd_tlm_files = target.cmd_tlm_files
       @cmd_unique_id_mode = target.cmd_unique_id_mode
       @tlm_unique_id_mode = target.tlm_unique_id_mode
-      @id = target.id
       @limits_groups = system.limits.groups.keys
       update()
 
@@ -897,13 +915,21 @@ module OpenC3
       Logger.info "Configured microservice #{microservice_name}"
     end
 
-    def deploy_decom_microservice(gem_path, variables, topics, instance = nil, parent = nil)
+    def deploy_decom_microservice(target, gem_path, variables, topics, instance = nil, parent = nil)
       microservice_name = "#{@scope}__DECOM#{instance}__#{@name}"
+      # Assume Ruby initially
+      filename = 'decom_microservice.rb'
+      work_dir = '/openc3/lib/openc3/microservices'
+      if target.language == 'python'
+        filename = 'decom_microservice.py'
+        work_dir.sub!('openc3/lib', 'openc3/python')
+        parent = nil
+      end
       microservice = MicroserviceModel.new(
         name: microservice_name,
         folder_name: @folder_name,
-        cmd: ["ruby", "decom_microservice.rb", microservice_name],
-        work_dir: '/openc3/lib/openc3/microservices',
+        cmd: [target.language, filename, microservice_name],
+        work_dir: work_dir,
         topics: topics,
         target_names: [@name],
         plugin: @plugin,
@@ -963,7 +989,6 @@ module OpenC3
           name: microservice_name,
           cmd: ["ruby", "multi_microservice.rb", *@children],
           work_dir: '/openc3/lib/openc3/microservices',
-          target_names: [@name],
           plugin: @plugin,
           scope: @scope
         )
@@ -976,9 +1001,14 @@ module OpenC3
     def deploy_target_microservices(type, base_topic_list, topic_prefix)
       target_microservices = @target_microservices[type]
       if target_microservices
+        # These are stand alone microservice(s) ... not part of MULTI
         if base_topic_list
+          # Only create the microservice if there are topics
+          # This prevents creation of DECOM with no TLM Packets (for example)
           deploy_count = 0
           all_topics = base_topic_list.dup
+
+          # Figure out if there are individual packets assigned to this microservice
           target_microservices.sort! {|a, b| a.length <=> b.length}
           target_microservices.each_with_index do |packet_names, index|
             topics = []
@@ -996,15 +1026,19 @@ module OpenC3
               end
             end
           end
+          # If there are any topics (packets) left over that haven't been
+          # explictly handled above, spawn another microservice
           if all_topics.length > 0
             instance = nil
             instance = deploy_count unless deploy_count == 0
             yield all_topics, instance, nil
           end
         else
+          # Do not spawn the microservice
           yield nil, nil, nil
         end
       else
+        # Not a stand alone microservice ... part of MULTI
         yield base_topic_list, nil, @parent if not base_topic_list or base_topic_list.length > 0
       end
     end
@@ -1068,11 +1102,12 @@ module OpenC3
 
         # Decommutation Microservice
         deploy_target_microservices('DECOM', packet_topic_list, "#{@scope}__TELEMETRY__{#{@name}}") do |topics, instance, parent|
-          deploy_decom_microservice(gem_path, variables, topics, instance, parent)
+          deploy_decom_microservice(system.targets[@name], gem_path, variables, topics, instance, parent)
         end
 
         # Reducer Microservice
         unless @reducer_disable
+          # TODO: Does Reducer even need a topic list?
           deploy_target_microservices('REDUCER', decom_topic_list, "#{@scope}__DECOM__{#{@name}}") do |topics, instance, parent|
             deploy_reducer_microservice(gem_path, variables, topics, instance, parent)
           end

data/lib/openc3/models/tool_config_model.rb

@@ -24,6 +24,12 @@ require 'openc3/utilities/local_mode'
 
 module OpenC3
   class ToolConfigModel
+    def self.config_tool_names(scope: $openc3_scope)
+      cursor, keys = Store.scan(0, match: "#{scope}__config__*", type: 'hash', count: 100)
+      # Just return the tool name that is used in the other APIs
+      return keys.map! { |key| key.split('__')[2] }.sort
+    end
+
     def self.list_configs(tool, scope: $openc3_scope)
       Store.hkeys("#{scope}__config__#{tool}")
     end
@@ -32,14 +38,14 @@ module OpenC3
       Store.hget("#{scope}__config__#{tool}", name)
     end
 
-    def self.save_config(tool, name, data, scope: $openc3_scope, local_mode: true)
+    def self.save_config(tool, name, data, local_mode: true, scope: $openc3_scope)
       Store.hset("#{scope}__config__#{tool}", name, data)
       LocalMode.save_tool_config(scope, tool, name, data) if local_mode
     end
 
-    def self.delete_config(tool, name, scope: $openc3_scope)
+    def self.delete_config(tool, name, local_mode: true, scope: $openc3_scope)
       Store.hdel("#{scope}__config__#{tool}", name)
-      LocalMode.delete_tool_config(scope, tool, name)
+      LocalMode.delete_tool_config(scope, tool, name) if local_mode
     end
   end
 end

data/lib/openc3/models/tool_model.rb

@@ -39,6 +39,7 @@ module OpenC3
     attr_accessor :shown
     attr_accessor :position
     attr_accessor :needs_dependencies
+    attr_accessor :disable_erb
 
     # NOTE: The following three class methods are used by the ModelController
     # and are reimplemented to enable various Model class methods to work
@@ -135,6 +136,7 @@ module OpenC3
       updated_at: nil,
       plugin: nil,
       needs_dependencies: false,
+      disable_erb: nil,
       scope:
     )
       super("#{scope}__#{PRIMARY_KEY}", name: name, plugin: plugin, updated_at: updated_at, scope: scope)
@@ -152,6 +154,7 @@ module OpenC3
         @url = "/tools/#{folder_name}" unless @url
       end
       @needs_dependencies = needs_dependencies
+      @disable_erb = disable_erb
     end
 
     def create(update: false, force: false)
@@ -159,9 +162,11 @@ module OpenC3
 
       # Make sure a tool with this folder_name doesn't already exist
       unless update
-        tools.each do |_tool_name, tool|
-          if tool['folder_name'] == @folder_name
-            raise "Tool with folder_name #{@folder_name} already exists at create"
+        if @folder_name
+          tools.each do |_tool_name, tool|
+            if tool['folder_name'] == @folder_name
+              raise "Tool with folder_name #{@folder_name} already exists at create"
+            end
           end
         end
       end
@@ -193,6 +198,7 @@ module OpenC3
         'updated_at' => @updated_at,
         'plugin' => @plugin,
         'needs_dependencies' => @needs_dependencies,
+        'disable_erb' => @disable_erb
       }
     end
 
@@ -203,14 +209,14 @@ module OpenC3
         @url = parameters[0]
       when 'INLINE_URL'
         parser.verify_num_parameters(1, 1, "INLINE_URL <URL>")
-        @inline_url = parameters[0]
+        @inline_url = ConfigParser.handle_nil(parameters[0])
       when 'ICON'
         parser.verify_num_parameters(1, 1, "ICON <ICON Name>")
         @icon = parameters[0]
       when 'WINDOW'
-        parser.verify_num_parameters(1, 1, "WINDOW <INLINE | IFRAME | NEW>")
+        parser.verify_num_parameters(1, 1, "WINDOW <INLINE | IFRAME | SAME | NEW>")
         @window = parameters[0].to_s.upcase
-        raise ConfigParser::Error.new(parser, "Invalid WINDOW setting: #{@window}") unless ['INLINE', 'IFRAME', 'NEW'].include?(@window)
+        raise ConfigParser::Error.new(parser, "Invalid WINDOW setting: #{@window}") unless ['INLINE', 'IFRAME', 'SAME', 'NEW'].include?(@window)
       when 'CATEGORY'
         parser.verify_num_parameters(1, 1, "CATEGORY <Category Name>")
         @category = parameters[0].to_s
@@ -220,6 +226,12 @@ module OpenC3
       when 'POSITION'
         parser.verify_num_parameters(1, 1, "POSITION <value>")
         @position = parameters[0].to_i
+      when 'DISABLE_ERB'
+        # 0 to unlimited parameters
+        @disable_erb ||= []
+        if parameters
+          @disable_erb.concat(parameters)
+        end
       else
         raise ConfigParser::Error.new(parser, "Unknown keyword and parameters for Tool: #{keyword} #{parameters.join(" ")}")
       end
@@ -240,7 +252,10 @@ module OpenC3
 
         # Load tool files
         data = File.read(filename, mode: "rb")
-        data = ERB.new(data.comment_erb(), trim_mode: "-").result(binding.set_variables(variables)) if data.is_printable?
+        erb_disabled = check_disable_erb(filename)
+        unless erb_disabled
+          data = ERB.new(data.comment_erb(), trim_mode: "-").result(binding.set_variables(variables)) if data.is_printable?
+        end
         unless validate_only
           client = Bucket.getClient()
           cache_control = BucketUtilities.get_cache_control(filename)

data/lib/openc3/models/widget_model.rb

@@ -35,6 +35,7 @@ module OpenC3
     attr_accessor :filename
     attr_accessor :bucket_key
     attr_accessor :needs_dependencies
+    attr_accessor :disable_erb
 
     # NOTE: The following three class methods are used by the ModelController
     # and are reimplemented to enable various Model class methods to work
@@ -87,6 +88,7 @@ module OpenC3
       plugin: nil,
       label: nil,
       needs_dependencies: false,
+      disable_erb: nil,
       scope:
     )
       super("#{scope}__#{PRIMARY_KEY}", name: name, plugin: plugin, updated_at: updated_at, scope: scope)
@@ -95,6 +97,7 @@ module OpenC3
       @bucket_key = 'widgets/' + @full_name + '/' + @filename
       @label = label
       @needs_dependencies = needs_dependencies
+      @disable_erb = disable_erb
     end
 
     def as_json(*a)
@@ -104,11 +107,21 @@ module OpenC3
         'plugin' => @plugin,
         'label' => @label,
         'needs_dependencies' => @needs_dependencies,
+        'disable_erb' => @disable_erb
       }
     end
 
     def handle_config(parser, keyword, parameters)
-      raise ConfigParser::Error.new(parser, "Unknown keyword and parameters for Widget: #{keyword} #{parameters.join(" ")}")
+      case keyword
+      when 'DISABLE_ERB'
+        # 0 to unlimited parameters
+        @disable_erb ||= []
+        if parameters
+          @disable_erb.concat(parameters)
+        end
+      else
+        raise ConfigParser::Error.new(parser, "Unknown keyword and parameters for Widget: #{keyword} #{parameters.join(" ")}")
+      end
     end
 
     def deploy(gem_path, variables, validate_only: false)
@@ -123,8 +136,11 @@ module OpenC3
 
       # Load widget file
       data = File.read(filename, mode: "rb")
-      OpenC3.set_working_dir(File.dirname(filename)) do
-        data = ERB.new(data.comment_erb(), trim_mode: "-").result(binding.set_variables(variables)) if data.is_printable?
+      erb_disabled = check_disable_erb(filename)
+      unless erb_disabled
+        OpenC3.set_working_dir(File.dirname(filename)) do
+          data = ERB.new(data.comment_erb(), trim_mode: "-").result(binding.set_variables(variables)) if data.is_printable?
+        end
       end
       unless validate_only
         cache_control = BucketUtilities.get_cache_control(@filename)

data/lib/openc3/operators/microservice_operator.rb

@@ -50,8 +50,10 @@ module OpenC3
       env = microservice_config["env"].dup
       if microservice_config["needs_dependencies"]
         env['GEM_HOME'] = '/gems'
+        env['PYTHONUSERBASE'] = '/gems/python_packages'
       else
         env['GEM_HOME'] = nil
+        env['PYTHONUSERBASE'] = nil
       end
       env['OPENC3_MICROSERVICE_NAME'] = microservice_name
       container = microservice_config["container"]

data/lib/openc3/packets/json_packet.rb

@@ -65,66 +65,97 @@ module OpenC3
     # @param name [String] Name of the item to read - Should already by upcase
     # @param value_type (see #read_item)
     def read(name, value_type = :CONVERTED, reduced_type = nil)
+      value = nil
+      array_index = nil
+      if name[-1] == ']'
+        open_bracket_index = name.index('[')
+        if open_bracket_index
+          array_index = name[(open_bracket_index + 1)..-2].to_i
+          name = name[0..(open_bracket_index - 1)]
+        end
+      end
       if reduced_type
         raise "Reduced types only support RAW or CONVERTED value types: #{value_type} unsupported" if value_type == :WITH_UNITS or value_type == :FORMATTED
         if value_type == :CONVERTED
           case reduced_type
           when :AVG
             value = @json_hash["#{name}__CA"]
-            return value if value
           when :STDDEV
             value = @json_hash["#{name}__CS"]
-            return value if value
           when :MIN
             value = @json_hash["#{name}__CN"]
-            return value if value
           when :MAX
             value = @json_hash["#{name}__CX"]
-            return value if value
+          end
+          if value
+            value = value[array_index] if array_index
+            return value
           end
         end
         case reduced_type
         when :AVG
           value = @json_hash["#{name}__A"]
-          return value if value
         when :STDDEV
           value = @json_hash["#{name}__S"]
-          return value if value
         when :MIN
           value = @json_hash["#{name}__N"]
-          return value if value
         when :MAX
           value = @json_hash["#{name}__X"]
-          return value if value
+        end
+        if value
+          value = value[array_index] if array_index
+          return value
         end
       end
       if value_type == :WITH_UNITS
         value = @json_hash["#{name}__U"]
-        return value if value
+        if value
+          value = value[array_index] if array_index
+          return value
+        end
       end
       if value_type == :WITH_UNITS or value_type == :FORMATTED
         value = @json_hash["#{name}__F"]
-        return value if value
+        if value
+          value = value[array_index] if array_index
+          return value
+        end
 
         value = @json_hash["#{name}__C"]
-        return value.to_s if value
+        if value
+          value = value[array_index] if array_index
+          return value.to_s
+        end
 
         value = @json_hash[name]
-        return value.to_s if value
+        if value
+          value = value[array_index] if array_index
+          return value.to_s
+        end
 
         return nil
       end
       if value_type == :CONVERTED
         value = @json_hash["#{name}__C"]
-        return value if value
+        if value
+          value = value[array_index] if array_index
+          return value
+        end
       end
-      return @json_hash[name]
+      value = @json_hash[name]
+      if value
+        value = value[array_index] if array_index
+        return value
+      end
+      return nil
     end
 
     def read_with_limits_state(name, value_type = :CONVERTED, reduced_type = nil)
       value = read(name, value_type, reduced_type)
       limits_state = @json_hash["#{name}__L"]
-      limits_state.intern if limits_state
+      if limits_state
+        limits_state = limits_state.intern
+      end
       return [value, limits_state]
     end
 

data/lib/openc3/packets/limits.rb

@@ -73,21 +73,21 @@ module OpenC3
     # @param packet_name [String] The packet name. Must be a defined packet name and not 'LATEST'.
     # @param item_name [String] The item name
     def enabled?(target_name, packet_name, item_name)
-      get_packet(target_name, packet_name).get_item(item_name).limits.enabled
+      _get_packet(target_name, packet_name).get_item(item_name).limits.enabled
     end
 
     # Enables limit checking for the specified item
     #
     # @param (see #enabled?)
     def enable(target_name, packet_name, item_name)
-      get_packet(target_name, packet_name).enable_limits(item_name)
+      _get_packet(target_name, packet_name).enable_limits(item_name)
     end
 
     # Disables limit checking for the specified item
     #
     # @param (see #enabled?)
     def disable(target_name, packet_name, item_name)
-      get_packet(target_name, packet_name).disable_limits(item_name)
+      _get_packet(target_name, packet_name).disable_limits(item_name)
     end
 
     # Get the limits for a telemetry item
@@ -98,7 +98,7 @@ module OpenC3
     # @param limits_set [String or Symbol or nil] Desired Limits set.  nil = current limits set
     # @return [Array<limits_set, persistence, enabled, red_low, yellow_low, red_high, yellow_high, green_low (optional), green_high (optional)] Limits information
     def get(target_name, packet_name, item_name, limits_set = nil)
-      limits = get_packet(target_name, packet_name).get_item(item_name).limits
+      limits = _get_packet(target_name, packet_name).get_item(item_name).limits
       if limits.values
         if limits_set
           limits_set = limits_set.to_s.upcase.intern
@@ -132,7 +132,7 @@ module OpenC3
     # @param enabled [Boolean] If limits monitoring is enabled for this item
     # @return [Array<limits_set, persistence, enabled, red_low, yellow_low, red_high, yellow_high, green_low (optional), green_high (optional)] Limits information
     def set(target_name, packet_name, item_name, red_low, yellow_low, yellow_high, red_high, green_low = nil, green_high = nil, limits_set = :CUSTOM, persistence = nil, enabled = true)
-      packet = get_packet(target_name, packet_name)
+      packet = _get_packet(target_name, packet_name)
       item = packet.get_item(item_name)
       limits = item.limits
       if limits_set
@@ -172,7 +172,7 @@ module OpenC3
 
     protected
 
-    def get_packet(target_name, packet_name)
+    def _get_packet(target_name, packet_name)
       raise "LATEST packet not valid" if packet_name.upcase == LATEST_PACKET_NAME
 
       packets = @config.telemetry[target_name.to_s.upcase]
@@ -183,17 +183,5 @@ module OpenC3
 
       return packet
     end
-
-    def includes_item?(ignored_items, target_name, packet_name, item_name)
-      ignored_items.each do |array_target_name, array_packet_name, array_item_name|
-        if (array_target_name == target_name) &&
-           (array_packet_name == packet_name) &&
-           # If the item name is nil we're ignoring an entire packet
-           (array_item_name == item_name || array_item_name.nil?)
-          return true
-        end
-      end
-      return false
-    end
   end
 end

data/lib/openc3/packets/packet.rb

@@ -1061,6 +1061,7 @@ module OpenC3
       config['accessor'] = @accessor.class.to_s
       config['accessor_args'] = @accessor.args
       config['template'] = Base64.encode64(@template) if @template
+      config['config_name'] = self.config_name
 
       if @processors
         processors = []

data/lib/openc3/packets/packet_config.rb

@@ -119,7 +119,8 @@ module OpenC3
     #   an xtce file to automatically determine the target name.
     def process_file(filename, process_target_name)
       # Handle .xtce files
-      if File.extname(filename).to_s.downcase == ".xtce"
+      extension = File.extname(filename).to_s.downcase
+      if extension == ".xtce" or extension == ".xml"
         XtceParser.process(@commands, @telemetry, @warnings, filename, process_target_name)
         return
       end

data/lib/openc3/packets/parsers/format_string_parser.rb

@@ -17,7 +17,7 @@
 # All changes Copyright 2022, OpenC3, Inc.
 # All Rights Reserved
 #
-# This file may also be used under the terms of a commercial license 
+# This file may also be used under the terms of a commercial license
 # if purchased from OpenC3, Inc.
 
 module OpenC3
@@ -25,9 +25,9 @@ module OpenC3
     # @param parser [ConfigParser] Configuration parser
     # @param item [Packet] The current item
     def self.parse(parser, item)
-      @parser = FormatStringParser.new(parser)
-      @parser.verify_parameters()
-      @parser.create_format_string(item)
+      parser = FormatStringParser.new(parser)
+      parser.verify_parameters()
+      parser.create_format_string(item)
     end
 
     # @param parser [ConfigParser] Configuration parser

data/lib/openc3/packets/parsers/limits_parser.rb

@@ -17,7 +17,7 @@
 # All changes Copyright 2022, OpenC3, Inc.
 # All Rights Reserved
 #
-# This file may also be used under the terms of a commercial license 
+# This file may also be used under the terms of a commercial license
 # if purchased from OpenC3, Inc.
 
 module OpenC3
@@ -31,9 +31,9 @@ module OpenC3
     def self.parse(parser, packet, cmd_or_tlm, item, warnings)
       raise parser.error("Items with STATE can't define LIMITS") if item.states
 
-      @parser = LimitsParser.new(parser)
-      @parser.verify_parameters(cmd_or_tlm)
-      @parser.create_limits(packet, item, warnings)
+      parser = LimitsParser.new(parser)
+      parser.verify_parameters(cmd_or_tlm)
+      parser.create_limits(packet, item, warnings)
     end
 
     def initialize(parser)

data/lib/openc3/packets/parsers/limits_response_parser.rb

@@ -14,10 +14,10 @@
 # GNU Affero General Public License for more details.
 
 # Modified by OpenC3, Inc.
-# All changes Copyright 2022, OpenC3, Inc.
+# All changes Copyright 2023, OpenC3, Inc.
 # All Rights Reserved
 #
-# This file may also be used under the terms of a commercial license 
+# This file may also be used under the terms of a commercial license
 # if purchased from OpenC3, Inc.
 
 module OpenC3
@@ -26,9 +26,9 @@ module OpenC3
     # @param item [Packet] The current item
     # @param cmd_or_tlm [String] Whether this is a command or telemetry packet
     def self.parse(parser, item, cmd_or_tlm)
-      @parser = LimitsResponseParser.new(parser)
-      @parser.verify_parameters(cmd_or_tlm)
-      @parser.create_limits_response(item)
+      parser = LimitsResponseParser.new(parser)
+      parser.verify_parameters(cmd_or_tlm)
+      parser.create_limits_response(item)
     end
 
     # @param parser [ConfigParser] Configuration parser