openapi_parameters 0.2.2 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d08c51fd9da86ddf6ef26a0e0778031b33224475091f21bf212cbdda65dd0b80
-  data.tar.gz: b8c2d56ad760c556cb51996e694d7bb8dbfe3d6188f4407702f698e8ca49b720
+  metadata.gz: aa586602013f736682059c6e4615dbd4eb7e57daaa4633e6fb35982261a39e11
+  data.tar.gz: 772345d845efdf6d191c362176deac63036cf064fbd4145c8b375f9bf500faaf
 SHA512:
-  metadata.gz: fdb3cf5fd14b1decad231f881229d9344020a59722c07086e5a79c0ee6f58bbad335f982a8847d60e64fb9e62c066636a142f514239ca78a7ec5de0916663abd
-  data.tar.gz: affa943a27552eb4a9a1495272d80d5d8cb2f591145b79758056c2d2eb93949d61e63524733a0474a3596d1a7d0bc4c77c5187e0a7d4bd9cd02e41cbd88e6706
+  metadata.gz: 8d21a6c44fc2a1d6d72a3b4cd2bab4804ee4ddfd62d5cf73d3407bf913583b0733b61e9b567da45dca13f9bf2007d58ac6b45fb71299ffa509385aaa1f05b18a
+  data.tar.gz: d7cc40c0551910ba432955e7008762950d8c65df0b06e45d094dca0f8b601c6bacc68e6ef8d223471d9f59c112f7a872fd2a5903a7f78de2d70f0580ccfc9115

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [0.3.0] - 2023-10-27
+
+- Query parameters: Don't attempt to convert arras within deepObject objects. Behaviour is not defined in OpenApi 3.1.
+
 ## [0.2.2] - 2023-06-01
 
 - Remove superflous validation of "in" property

data/Gemfile

@@ -5,8 +5,8 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in OpenapiParameters.gemspec
 gemspec
 
+gem 'rack-test'
 gem 'rake', '~> 13.0'
-
 gem 'rspec', '~> 3.0'
 gem 'rspec-benchmark'
 gem 'rubocop'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    openapi_parameters (0.2.2)
+    openapi_parameters (0.3.0)
       rack (>= 2.2)
       zeitwerk (~> 2.6)
 
@@ -14,14 +14,19 @@ GEM
     benchmark-trend (0.4.0)
     diff-lcs (1.5.0)
     json (2.6.3)
+    language_server-protocol (3.17.0.3)
     parallel (1.23.0)
-    parser (3.2.2.1)
+    parser (3.2.2.4)
       ast (~> 2.4.1)
-    rack (3.0.7)
+      racc
+    racc (1.7.1)
+    rack (3.0.8)
+    rack-test (2.1.0)
+      rack (>= 1.3)
     rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.8.0)
-    rexml (3.2.5)
+    regexp_parser (2.8.2)
+    rexml (3.2.6)
     rspec (3.12.0)
       rspec-core (~> 3.12.0)
       rspec-expectations (~> 3.12.0)
@@ -36,33 +41,34 @@ GEM
     rspec-expectations (3.12.3)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
-    rspec-mocks (3.12.5)
+    rspec-mocks (3.12.6)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
-    rspec-support (3.12.0)
-    rubocop (1.51.0)
+    rspec-support (3.12.1)
+    rubocop (1.57.2)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.0.0)
+      parser (>= 3.2.2.4)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.28.0, < 2.0)
+      rubocop-ast (>= 1.28.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.28.1)
+    rubocop-ast (1.30.0)
       parser (>= 3.2.1.0)
-    rubocop-capybara (2.18.0)
+    rubocop-capybara (2.19.0)
       rubocop (~> 1.41)
-    rubocop-factory_bot (2.23.1)
-      rubocop (~> 1.33)
-    rubocop-rspec (2.22.0)
+    rubocop-factory_bot (2.24.0)
       rubocop (~> 1.33)
+    rubocop-rspec (2.25.0)
+      rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)
       rubocop-factory_bot (~> 2.22)
     ruby-progressbar (1.13.0)
-    unicode-display_width (2.4.2)
-    zeitwerk (2.6.8)
+    unicode-display_width (2.5.0)
+    zeitwerk (2.6.12)
 
 PLATFORMS
   arm64-darwin-21
@@ -72,6 +78,7 @@ PLATFORMS
 
 DEPENDENCIES
   openapi_parameters!
+  rack-test
   rake (~> 13.0)
   rspec (~> 3.0)
   rspec-benchmark

data/lib/openapi_parameters/converter.rb

@@ -3,87 +3,77 @@
 module OpenapiParameters
   ##
   # Tries to convert a request parameter value (string) to the type specified in the JSON Schema.
-  class Converter
-    ##
-    # @param input [String, Hash, Array] the value to convert
-    # @param schema [Hash] the schema to use for conversion.
-    def self.call(input, schema)
-      new(input, schema).call
-    end
-
-    def initialize(input, schema)
-      @input = input
-      @root_schema = schema
-    end
-
-    def call
-      convert(@input, @root_schema)
-    end
-
-    private
+  module Converter
+    class << self
+      ##
+      # @param input [String, Hash, Array] the value to convert
+      # @param schema [Hash] the schema to use for conversion.
+      def convert(value, schema) # rubocop:disable Metrics
+        return if value.nil?
+        return value if schema.nil?
 
-    def convert(value, schema) # rubocop:disable Metrics/*
-      # check_supported!(schema)
-      return if value.nil?
-      return value if schema.nil?
-
-      case type(schema)
-      when 'integer'
-        begin
-          Integer(value, 10)
-        rescue StandardError
-          value
-        end
-      when 'number'
-        begin
-          Float(value)
-        rescue StandardError
-          value
-        end
-      when 'boolean'
-        if value == 'true'
-          true
+        case type(schema)
+        when 'integer'
+          begin
+            Integer(value, 10)
+          rescue StandardError
+            value
+          end
+        when 'number'
+          begin
+            Float(value)
+          rescue StandardError
+            value
+          end
+        when 'boolean'
+          if value == 'true'
+            true
+          else
+            value == 'false' ? false : value
+          end
+        when 'object'
+          convert_object(value, schema)
+        when 'array'
+          convert_array(value, schema)
         else
-          value == 'false' ? false : value
+          value
         end
-      when 'object'
-        convert_object(value, schema)
-      when 'array'
-        convert_array(value, schema)
-      else
-        value
       end
-    end
 
-    def type(schema)
-      schema && schema['type']
-    end
+      private
 
-    def convert_object(object, schema)
-      object.each_with_object({}) do |(key, value), hsh|
-        hsh[key] = convert(value, schema['properties']&.fetch(key))
+      def type(schema)
+        schema && schema['type']
       end
-    end
 
-    def convert_array(array, schema)
-      item_schema = schema['items']
-      prefix_schemas = schema['prefixItems']
-      return convert_array_with_prefixes(array, prefix_schemas, item_schema) if prefix_schemas
+      def convert_object(object, schema)
+        object.each_with_object({}) do |(key, value), hsh|
+          hsh[key] = convert(value, schema['properties']&.fetch(key))
+        end
+      end
 
-      array.map { |item| convert(item, item_schema) }
-    end
+      def convert_array(array, schema)
+        return array unless array.is_a?(Array)
 
-    def convert_array_with_prefixes(array, prefix_schemas, item_schema)
-      prefixes =
-        array
-        .slice(0, prefix_schemas.size)
-        .each_with_index
-        .map { |item, index| convert(item, prefix_schemas[index]) }
-      array =
-        array[prefix_schemas.size..].map! do |item|
-          convert(item, item_schema)
-        end
-      prefixes + array
+        item_schema = schema['items']
+        prefix_schemas = schema['prefixItems']
+        return convert_array_with_prefixes(array, prefix_schemas, item_schema) if prefix_schemas
+
+        array.map { |item| convert(item, item_schema) }
+      end
+
+      def convert_array_with_prefixes(array, prefix_schemas, item_schema)
+        prefixes =
+          array
+          .slice(0, prefix_schemas.size)
+          .each_with_index
+          .map { |item, index| convert(item, prefix_schemas[index]) }
+        array =
+          array[prefix_schemas.size..].map! do |item|
+            convert(item, item_schema)
+          end
+        prefixes + array
+      end
     end
   end
 end

data/lib/openapi_parameters/cookie.rb

@@ -21,7 +21,7 @@ module OpenapiParameters
 
         result[parameter.name] = catch :skip do
           value = Unpacker.unpack_value(parameter, cookies[parameter.name])
-          @convert ? Converter.call(value, parameter.schema) : value
+          @convert ? Converter.convert(value, parameter.schema) : value
         end
       end
     end

data/lib/openapi_parameters/header.rb

@@ -18,7 +18,7 @@ module OpenapiParameters
 
         result[parameter.name] = catch :skip do
           value = Unpacker.unpack_value(parameter, headers[parameter.name])
-          @convert ? Converter.call(value, parameter.schema) : value
+          @convert ? Converter.convert(value, parameter.schema) : value
         end
       end
     end

data/lib/openapi_parameters/path.rb

@@ -22,7 +22,7 @@ module OpenapiParameters
 
         result[parameter.name] = catch :skip do
           value = Unpacker.unpack_value(parameter, path_params[parameter.name])
-          @convert ? Converter.call(value, parameter.schema) : value
+          @convert ? Converter.convert(value, parameter.schema) : value
         end
       end
     end

data/lib/openapi_parameters/query.rb

@@ -34,11 +34,18 @@ module OpenapiParameters
 
     private
 
+    def convert_primitive(value, parameter)
+      return value unless @convert
+      return value if value == ''
+
+      Converter.convert_primitive(value, parameter.schema)
+    end
+
     def convert(value, parameter)
       return value unless @convert
       return value if value == ''
 
-      Converter.call(value, parameter.schema)
+      Converter.convert(value, parameter.schema)
     end
   end
 end

data/lib/openapi_parameters/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OpenapiParameters
-  VERSION = '0.2.2'
+  VERSION = '0.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: openapi_parameters
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.0
 platform: ruby
 authors:
 - Andreas Haller
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-01 00:00:00.000000000 Z
+date: 2023-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack