openapi_first 0.10.2 → 0.11.0.alpha

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 49ebcf2af159defac87d97f5d9cc1b2c76a1f76ce09376f209bc38458c2eee07
-  data.tar.gz: dbe17ecf51792614df624c91a704f9a319bf1bf2b1b1cded454a748f193c2e21
+  metadata.gz: c16372f591f02e7332d7d010c0a91e239e38592f41bf2eb5d88d7777058f66fd
+  data.tar.gz: e02ab1188d3cd8bc64ece82381316f4d7e8012c784e21d1ae2bb0b16bc24b141
 SHA512:
-  metadata.gz: 9d478201cf1e856d745dff02e4977552b95c09500956be61c6d169cf179a1f15968bca460a63a9ce76fb97bba0c5d5713e94d5e802d8fe0446428fdfd6b3feb8
-  data.tar.gz: dac17e6ec186b821a6fbdf09c47c20478f43bb21d30175b5d3e8150e0e99cf98110b2a7c01e143207176733485b52df1972277bc6790a7730c6a365dde32e3b1
+  metadata.gz: 8d8f44debbe60e787de68246b822669991ba6d1aac3721cbe68f04ee51cffb99ea02b280be0ba3e6e28d0bf11a26b565d2e23792fb08f451462ab36990026970
+  data.tar.gz: 2545816e97f18afde6947c61893b81a2606fa5e27262d037f3fd1475430acf7c1ffa2bf5db70b6d06316cd6524380ac47290b656ae457200e29e8384da860dc9

data/.rubocop.yml

@@ -8,10 +8,16 @@ Metrics/BlockLength:
   Exclude:
   - 'spec/**/*.rb'
   - '*.gemspec'
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
 Layout/SpaceAroundMethodCallOperator:
   Enabled: true
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
 Lint/RaiseException:
   Enabled: true
+Style/SlicingWithRange:
+  Enabled: true
 Lint/StructNewOverride:
   Enabled: true
 Style/HashEachMethods:

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## Unreleased
+- Add ResponseValidation middleware that validates the response body
+- Add `raise` option to Router middleware to raise an error if request could not be found in the API description similar to committee's raise option.
+- Move namespace option from Router to OperationResolver
+
 ## 0.10.2
 - Return 400 if request body has invalid JSON ([issue](https://github.com/ahx/openapi_first/issues/73)) thanks Thomas Frütel
 

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    openapi_first (0.10.2)
+    openapi_first (0.11.0.alpha)
       deep_merge (>= 1.2.1)
-      hanami-router (~> 2.0.alpha2)
+      hanami-router (~> 2.0.alpha3)
       hanami-utils (~> 2.0.alpha1)
       json_schemer (~> 0.2)
       multi_json (~> 1.14)
@@ -13,7 +13,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.0.3)
+    activesupport (6.0.3.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
@@ -30,7 +30,7 @@ GEM
     ecma-re-validator (0.2.1)
       regexp_parser (~> 1.2)
     hana (1.3.6)
-    hanami-router (2.0.0.alpha2)
+    hanami-router (2.0.0.alpha3)
       mustermann (~> 1.0)
       mustermann-contrib (~> 1.0)
       rack (~> 2.0)
@@ -41,7 +41,6 @@ GEM
     hash-deep-merge (0.1.1)
     i18n (1.8.2)
       concurrent-ruby (~> 1.0)
-    jaro_winkler (1.5.4)
     json_schemer (0.2.11)
       ecma-re-validator (~> 0.2)
       hana (~> 1.3)
@@ -49,7 +48,7 @@ GEM
       uri_template (~> 0.7)
     method_source (1.0.0)
     mini_portile2 (2.4.0)
-    minitest (5.14.0)
+    minitest (5.14.1)
     multi_json (1.14.1)
     mustermann (1.1.1)
       ruby2_keywords (~> 0.0.1)
@@ -72,7 +71,7 @@ GEM
     pry (0.13.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    public_suffix (4.0.4)
+    public_suffix (4.0.5)
     rack (2.2.2)
     rack-test (1.1.0)
       rack (>= 1.0, < 3)
@@ -86,21 +85,23 @@ GEM
       rspec-mocks (~> 3.9.0)
     rspec-core (3.9.2)
       rspec-support (~> 3.9.3)
-    rspec-expectations (3.9.1)
+    rspec-expectations (3.9.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.3)
-    rubocop (0.82.0)
-      jaro_winkler (~> 1.5.1)
+    rubocop (0.84.0)
       parallel (~> 1.10)
       parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
       rexml
+      rubocop-ast (>= 0.0.3)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-ast (0.0.3)
+      parser (>= 2.7.0.1)
     ruby-progressbar (1.10.1)
     ruby2_keywords (0.0.2)
     thread_safe (0.3.6)

data/README.md

@@ -7,10 +7,19 @@ Start with writing an OpenAPI file that describes the API, which you are about t
 ## Rack middlewares
 OpenapiFirst consists of these Rack middlewares:
 
-- `OpenapiFirst::Router` finds the operation for the current request or returns 404 if no operation was found.
-- `OpenapiFirst::RequestValidation` validates the request against the found operation and returns 400 if the request is invalid.
+- `OpenapiFirst::Router` – Finds the operation for the current request or returns 404 if no operation was found. This can be customized.
+- `OpenapiFirst::RequestValidation` – Validates the request against the API description and returns 400 if the request is invalid.
 - `OpenapiFirst::OperationResolver` calls the [handler](#handlers) found for the operation.
 
+## OpenapiFirst::Router
+Options and their defaults:
+
+| Name | Possible values | Description | Default
+|:---|---|---|---|
+| `not_found:` |`nil`, `:continue`, `Proc`| Specifies what to do if path was not found in the API description. `nil` (default) returns a 404 response. `:continue` does nothing an calls the next app. `Proc` (or something that responds to `call`) to customize the response. | `nil` (return 404)
+| `raise:` |`false`, `true` | If set to true the middleware raises `OpenapiFirst::NotFoundError` when a path or method was not found in the API description. This is useful during testing to spot an incomplete API description. | `false` (don't raise an exception)
+
+
 ## Usage within your Rack webframework
 If you just want to use the request validation part without any handlers you can use the rack middlewares standalone:
 
@@ -25,6 +34,7 @@ These variables will available in your rack env:
 - `env[OpenapiFirst::OPERATION]` - Holds an Operation object that responsed about `operation_id` and `path`. This is useful for introspection.
 - `env[OpenapiFirst::INBOX]`. Holds the (filtered) path and query parameters and the parsed request body.
 
+
 ## Standalone usage
 You can implement your API in conveniently with just OpenapiFirst.
 
@@ -204,7 +214,7 @@ Out of scope. Use [Prism](https://github.com/stoplightio/prism) or [fakeit](http
 
 ## Alternatives
 
-This gem is inspired by [committee](https://github.com/interagent/committee), which has much more features like response stubs or support for Hyper-Schema or OpenAPI 2.
+This gem is inspired by [committee](https://github.com/interagent/committee) (Ruby) and [connexion](https://github.com/zalando/connexion) (Python).
 
 ## Development
 

data/benchmarks/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    openapi_first (0.10.2)
+    openapi_first (0.11.0.alpha)
       deep_merge (>= 1.2.1)
       hanami-router (~> 2.0.alpha2)
       hanami-utils (~> 2.0.alpha1)
@@ -13,7 +13,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.0.3)
+    activesupport (6.0.3.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
@@ -25,9 +25,9 @@ GEM
     benchmark-memory (0.1.2)
       memory_profiler (~> 0.9)
     builder (3.2.4)
-    committee (3.3.0)
+    committee (4.0.0)
       json_schema (~> 0.14, >= 0.14.3)
-      openapi_parser (>= 0.6.1)
+      openapi_parser (>= 0.11.1)
       rack (>= 1.5)
     concurrent-ruby (1.1.6)
     deep_merge (1.2.1)
@@ -55,7 +55,7 @@ GEM
       dry-logic (~> 1.0, >= 1.0.2)
     ecma-re-validator (0.2.1)
       regexp_parser (~> 1.2)
-    grape (1.3.2)
+    grape (1.3.3)
       activesupport
       builder
       dry-types (>= 1.1)
@@ -63,7 +63,7 @@ GEM
       rack (>= 1.3.0)
       rack-accept
     hana (1.3.6)
-    hanami-router (2.0.0.alpha2)
+    hanami-router (2.0.0.alpha3)
       mustermann (~> 1.0)
       mustermann-contrib (~> 1.0)
       rack (~> 2.0)
@@ -82,7 +82,7 @@ GEM
       uri_template (~> 0.7)
     memory_profiler (0.9.14)
     mini_portile2 (2.4.0)
-    minitest (5.14.0)
+    minitest (5.14.1)
     multi_json (1.14.1)
     mustermann (1.1.1)
       ruby2_keywords (~> 0.0.1)
@@ -101,8 +101,8 @@ GEM
       hash-deep-merge
       mustermann-contrib (~> 1.1.1)
       nokogiri
-    openapi_parser (0.10.0)
-    public_suffix (4.0.4)
+    openapi_parser (0.11.2)
+    public_suffix (4.0.5)
     rack (2.2.2)
     rack-accept (0.4.5)
       rack (>= 0.4)

data/lib/openapi_first.rb

@@ -8,6 +8,7 @@ require 'openapi_first/inbox'
 require 'openapi_first/router'
 require 'openapi_first/request_validation'
 require 'openapi_first/response_validator'
+require 'openapi_first/response_validation'
 require 'openapi_first/operation_resolver'
 require 'openapi_first/app'
 
@@ -48,5 +49,8 @@ module OpenapiFirst
   end
 
   class Error < StandardError; end
+  class NotFoundError < Error; end
   class ResponseCodeNotFoundError < Error; end
+  class ResponseMediaTypeNotFoundError < Error; end
+  class ResponseBodyInvalidError < Error; end
 end

data/lib/openapi_first/app.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'rack'
+require 'logger'
 
 module OpenapiFirst
   class App
@@ -11,12 +12,12 @@ module OpenapiFirst
     )
       @stack = Rack::Builder.app do
         freeze_app
-        use OpenapiFirst::Router,
-            spec: spec,
-            namespace: namespace,
-            parent_app: parent_app
+        use OpenapiFirst::Router, spec: spec, parent_app: parent_app
         use OpenapiFirst::RequestValidation
-        run OpenapiFirst::OperationResolver.new
+        run OpenapiFirst::OperationResolver.new(
+          spec: spec,
+          namespace: namespace
+        )
       end
     end
 

data/lib/openapi_first/definition.rb

@@ -4,7 +4,10 @@ require_relative 'operation'
 
 module OpenapiFirst
   class Definition
+    attr_reader :filepath
+
     def initialize(parsed)
+      @filepath = parsed.path
       @spec = parsed
     end
 

data/lib/openapi_first/find_handler.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require_relative 'utils'
+
+module OpenapiFirst
+  class FindHandler
+    def initialize(spec, namespace)
+      @spec = spec
+      @namespace = namespace
+    end
+
+    def all
+      @spec.operations.each_with_object({}) do |operation, hash|
+        operation_id = operation.operation_id
+        handler = find_by_operation_id(operation_id)
+        if handler.nil?
+          warn "#{self.class.name} cannot not find handler for '#{operation.operation_id}' (#{operation.method} #{operation.path}). This operation will be ignored." # rubocop:disable Layout/LineLength
+          next
+        end
+        hash[operation_id] = handler
+      end
+    end
+
+    def find_by_operation_id(operation_id) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      name = operation_id.match(/:*(.*)/)&.to_a&.at(1)
+      return if name.nil?
+
+      if name.include?('.')
+        module_name, method_name = name.split('.')
+        klass = find_const(@namespace, module_name)
+        return klass&.method(Utils.underscore(method_name))
+      end
+      if name.include?('#')
+        module_name, klass_name = name.split('#')
+        const = find_const(@namespace, module_name)
+        klass = find_const(const, klass_name)
+        return ->(params, res) { klass.new.call(params, res) } if klass.instance_method(:initialize).arity.zero?
+
+        return ->(params, res) { klass.new(params.env).call(params, res) }
+      end
+      method_name = Utils.underscore(name)
+      return unless @namespace.respond_to?(method_name)
+
+      @namespace.method(method_name)
+    end
+
+    private
+
+    def find_const(parent, name)
+      name = Utils.classify(name)
+      return unless parent.const_defined?(name, false)
+
+      parent.const_get(name, false)
+    end
+  end
+end

data/lib/openapi_first/operation.rb

@@ -2,6 +2,7 @@
 
 require 'forwardable'
 require_relative 'utils'
+require_relative 'response_object'
 
 module OpenapiFirst
   class Operation
@@ -25,18 +26,35 @@ module OpenapiFirst
     end
 
     def content_type_for(status)
-      content = @operation
-                .response_by_code(status.to_s, use_default: true)
-                .content
+      content = response_for(status)['content']
       content.keys[0] if content
+    end
+
+    def response_schema_for(status, content_type)
+      content = response_for(status)['content']
+      return if content.nil? || content.empty?
+
+      media_type = content[content_type]
+      unless media_type
+        message = "Response media type found: '#{content_type}' for '#{operation_name}'"
+        raise ResponseMediaTypeNotFoundError, message
+      end
+      media_type['schema']
+    end
+
+    def response_for(status)
+      @operation.response_by_code(status.to_s, use_default: true).raw
     rescue OasParser::ResponseCodeNotFound
-      operation_name = "#{method.upcase} #{path}"
-      message = "Response status code or default not found: #{status} for '#{operation_name}'" # rubocop:disable Layout/LineLength
+      message = "Response status code or default not found: #{status} for '#{operation_name}'"
       raise OpenapiFirst::ResponseCodeNotFoundError, message
     end
 
     private
 
+    def operation_name
+      "#{method.upcase} #{path}"
+    end
+
     def build_parameters_json_schema
       return unless @operation.parameters&.any?
 

data/lib/openapi_first/operation_resolver.rb

@@ -2,15 +2,20 @@
 
 require 'rack'
 require_relative 'inbox'
+require_relative 'find_handler'
 
 module OpenapiFirst
   class OperationResolver
+    def initialize(spec:, namespace:)
+      @handlers = FindHandler.new(spec, namespace).all
+      @namespace = namespace
+    end
+
     def call(env)
       operation = env[OpenapiFirst::OPERATION]
       res = Rack::Response.new
-      inbox = env[INBOX]
-      handler = env[HANDLER]
-      result = handler.call(inbox, res)
+      handler = @handlers[operation.operation_id]
+      result = handler.call(env[INBOX], res)
       res.write serialize(result) if result && res.body.empty?
       res[Rack::CONTENT_TYPE] ||= operation.content_type_for(res.status)
       res.finish

data/lib/openapi_first/request_validation.rb

@@ -46,9 +46,7 @@ module OpenapiFirst
 
       parsed_request_body = parse_request_body!(body)
       errors = validate_json_schema(schema, parsed_request_body)
-      if errors.any?
-        halt(error_response(400, serialize_request_body_errors(errors)))
-      end
+      halt(error_response(400, serialize_request_body_errors(errors))) if errors.any?
       env[INBOX].merge! env[REQUEST_BODY] = parsed_request_body
     end
 
@@ -113,9 +111,7 @@ module OpenapiFirst
 
       params = filtered_params(json_schema, params)
       errors = JSONSchemer.schema(json_schema).validate(params)
-      if errors.any?
-        halt error_response(400, serialize_query_parameter_errors(errors))
-      end
+      halt error_response(400, serialize_query_parameter_errors(errors)) if errors.any?
       env[PARAMETERS] = params
       env[INBOX].merge! params
     end

data/lib/openapi_first/response_object.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require 'forwardable'
+require_relative 'utils'
+
+module OpenapiFirst
+  # Represents an OpenAPI Response Object
+  class ResponseObject
+    extend Forwardable
+    def_delegators :@parsed,
+                   :content
+
+    def_delegators :@raw,
+                   :[]
+
+    def initialize(parsed)
+      @parsed = parsed
+      @raw = parsed.raw
+    end
+  end
+end

data/lib/openapi_first/response_validation.rb

@@ -0,0 +1,116 @@
+# frozen_string_literal: true
+
+require 'json_schemer'
+require 'multi_json'
+require_relative 'validation'
+
+module OpenapiFirst
+  class ResponseValidation
+    def initialize(app)
+      @app = app
+    end
+
+    def call(env)
+      operation = env[OPERATION]
+      return @app.call(env) unless operation
+
+      status, headers, body = @app.call(env)
+      content_type = headers[Rack::CONTENT_TYPE]
+      response_schema = operation.response_schema_for(status, content_type)
+      validate_response_body(response_schema, body) if response_schema
+
+      [status, headers, body]
+    end
+
+    private
+
+    def halt(status, body = '')
+      throw :halt, [status, {}, body]
+    end
+
+    def error(message)
+      { title: message }
+    end
+
+    def error_response(status, errors)
+      Rack::Response.new(
+        MultiJson.dump(errors: errors),
+        status,
+        Rack::CONTENT_TYPE => 'application/vnd.api+json'
+      ).finish
+    end
+
+    def validate_response_body(schema, response)
+      full_body = +''
+      response.each { |chunk| full_body << chunk }
+      data = full_body.empty? ? {} : MultiJson.load(full_body)
+      errors = JSONSchemer.schema(schema).validate(data).to_a.map do |error|
+        format_error(error)
+      end
+      raise ResponseBodyInvalidError, errors.join(', ') if errors.any?
+    end
+
+    def format_error(error)
+      err = ValidationFormat.error_details(error)
+      [err[:title], 'at', error['data_pointer'], err[:detail]].compact.join(' ')
+    end
+  end
+end
+
+# frozen_string_literal: true
+
+require 'json_schemer'
+require 'multi_json'
+require_relative 'validation'
+
+module OpenapiFirst
+  class ResponseValidator
+    def initialize(spec)
+      @spec = spec
+    end
+
+    def validate(request, response)
+      errors = validation_errors(request, response)
+      Validation.new(errors || [])
+    rescue OasParser::ResponseCodeNotFound, OasParser::MethodNotFound => e
+      Validation.new([e.message])
+    end
+
+    private
+
+    def validation_errors(request, response)
+      content = response_for(request, response)&.content
+      return unless content
+
+      content_type = content[response.content_type]
+      return ["Content type not found: '#{response.content_type}'"] unless content_type
+
+      response_schema = content_type['schema']
+      return unless response_schema
+
+      response_data = MultiJson.load(response.body)
+      validate_json_schema(response_schema, response_data)
+    end
+
+    def validate_json_schema(schema, data)
+      JSONSchemer.schema(schema).validate(data).to_a.map do |error|
+        format_error(error)
+      end
+    end
+
+    def format_error(error)
+      ValidationFormat.error_details(error)
+                      .merge!(
+                        data_pointer: error['data_pointer'],
+                        schema_pointer: error['schema_pointer']
+                      ).tap do |formatted|
+      end
+    end
+
+    def response_for(request, response)
+      @spec
+        .find_operation!(request)
+        &.response_by_code(response.status.to_s, use_default: true)
+    end
+  end
+end

data/lib/openapi_first/response_validator.rb

@@ -17,6 +17,13 @@ module OpenapiFirst
       Validation.new([e.message])
     end
 
+    def validate_operation(request, response)
+      errors = validation_errors(request, response)
+      Validation.new(errors || [])
+    rescue OasParser::ResponseCodeNotFound, OasParser::MethodNotFound => e
+      Validation.new([e.message])
+    end
+
     private
 
     def validation_errors(request, response)
@@ -24,9 +31,7 @@ module OpenapiFirst
       return unless content
 
       content_type = content[response.content_type]
-      unless content_type
-        return ["Content type not found: '#{response.content_type}'"]
-      end
+      return ["Content type not found: '#{response.content_type}'"] unless content_type
 
       response_schema = content_type['schema']
       return unless response_schema
@@ -46,8 +51,7 @@ module OpenapiFirst
                       .merge!(
                         data_pointer: error['data_pointer'],
                         schema_pointer: error['schema_pointer']
-                      ).tap do |formatted|
-      end
+                      )
     end
 
     def response_for(request, response)

data/lib/openapi_first/router.rb

@@ -7,76 +7,59 @@ require_relative 'utils'
 module OpenapiFirst
   class Router
     NOT_FOUND = Rack::Response.new('', 404).finish.freeze
+    DEFAULT_NOT_FOUND_APP = ->(_env) { NOT_FOUND }
 
-    def initialize(app, options)
+    def initialize(app, options) # rubocop:disable Metrics/MethodLength
       @app = app
-      @namespace = options.fetch(:namespace, nil)
       @parent_app = options.fetch(:parent_app, nil)
-      @router = build_router(options.fetch(:spec).operations)
+      @raise = options.fetch(:raise, false)
+      @failure_app = find_failure_app(options[:not_found])
+      if @failure_app.nil?
+        raise ArgumentError,
+              'not_found must be nil, :continue or must respond to call'
+      end
+      spec = options.fetch(:spec)
+      @filepath = spec.filepath
+      @router = build_router(spec.operations)
     end
 
     def call(env)
       endpoint = find_endpoint(env)
       return endpoint.call(env) if endpoint
+
+      if @raise
+        req = Rack::Request.new(env)
+        msg = "Could not find definition for #{req.request_method} '#{req.path}' in API description #{@filepath}"
+        raise NotFoundError, msg
+      end
       return @parent_app.call(env) if @parent_app
 
-      NOT_FOUND
+      @failure_app.call(env)
     end
 
-    def find_handler(operation_id) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
-      name = operation_id.match(/:*(.*)/)&.to_a&.at(1)
-      return if name.nil?
-
-      if name.include?('.')
-        module_name, method_name = name.split('.')
-        klass = find_const(@namespace, module_name)
-        return klass&.method(Utils.underscore(method_name))
-      end
-      if name.include?('#')
-        module_name, klass_name = name.split('#')
-        const = find_const(@namespace, module_name)
-        klass = find_const(const, klass_name)
-        if klass.instance_method(:initialize).arity.zero?
-          return ->(params, res) { klass.new.call(params, res) }
-        end
+    private
 
-        return ->(params, res) { klass.new(params.env).call(params, res) }
-      end
-      method_name = Utils.underscore(name)
-      return unless @namespace.respond_to?(method_name)
+    def find_failure_app(option)
+      return DEFAULT_NOT_FOUND_APP if option.nil?
+      return @app if option == :continue
 
-      @namespace.method(method_name)
+      option if option.respond_to?(:call)
     end
 
-    private
-
     def find_endpoint(env)
       original_path_info = env[Rack::PATH_INFO]
-      # Overwrite PATH_INFO temporarily, because hanami-router does not respect SCRIPT_NAME # rubocop:disable Layout/LineLength
       env[Rack::PATH_INFO] = Rack::Request.new(env).path
       @router.recognize(env).endpoint
     ensure
       env[Rack::PATH_INFO] = original_path_info
     end
 
-    def find_const(parent, name)
-      name = Utils.classify(name)
-      return unless parent.const_defined?(name, false)
-
-      parent.const_get(name, false)
-    end
-
     def build_router(operations) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
       router = Hanami::Router.new {}
       operations.each do |operation|
         normalized_path = operation.path.gsub('{', ':').gsub('}', '')
         if operation.operation_id.nil?
-          warn "operationId is missing in '#{operation.method} #{operation.path}'. I am ignoring this operation." # rubocop:disable Layout/LineLength
-          next
-        end
-        handler = @namespace && find_handler(operation.operation_id)
-        if @namespace && handler.nil?
-          warn "#{self.class.name} cannot not find handler for '#{operation.operation_id}' (#{operation.method} #{operation.path}). This operation will be ignored." # rubocop:disable Layout/LineLength
+          warn "operationId is missing in '#{operation.method} #{operation.path}'. I am ignoring this operation."
           next
         end
         router.public_send(
@@ -85,7 +68,6 @@ module OpenapiFirst
           to: lambda do |env|
             env[OPERATION] = operation
             env[PARAMETERS] = Utils.deep_stringify(env['router.params'])
-            env[HANDLER] = handler
             @app.call(env)
           end
         )

data/lib/openapi_first/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OpenapiFirst
-  VERSION = '0.10.2'
+  VERSION = '0.11.0.alpha'
 end

data/openapi_first.gemspec

@@ -33,7 +33,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'deep_merge', '>= 1.2.1'
-  spec.add_dependency 'hanami-router', '~> 2.0.alpha2'
+  spec.add_dependency 'hanami-router', '~> 2.0.alpha3'
   spec.add_dependency 'hanami-utils', '~> 2.0.alpha1'
   spec.add_dependency 'json_schemer', '~> 0.2'
   spec.add_dependency 'multi_json', '~> 1.14'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: openapi_first
 version: !ruby/object:Gem::Version
-  version: 0.10.2
+  version: 0.11.0.alpha
 platform: ruby
 authors:
 - Andreas Haller
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-05-08 00:00:00.000000000 Z
+date: 2020-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deep_merge
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.alpha2
+        version: 2.0.alpha3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.alpha2
+        version: 2.0.alpha3
 - !ruby/object:Gem::Dependency
   name: hanami-utils
   requirement: !ruby/object:Gem::Requirement
@@ -203,10 +203,13 @@ files:
 - lib/openapi_first/app.rb
 - lib/openapi_first/coverage.rb
 - lib/openapi_first/definition.rb
+- lib/openapi_first/find_handler.rb
 - lib/openapi_first/inbox.rb
 - lib/openapi_first/operation.rb
 - lib/openapi_first/operation_resolver.rb
 - lib/openapi_first/request_validation.rb
+- lib/openapi_first/response_object.rb
+- lib/openapi_first/response_validation.rb
 - lib/openapi_first/response_validator.rb
 - lib/openapi_first/router.rb
 - lib/openapi_first/utils.rb
@@ -232,9 +235,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.1.2
 signing_key: