openapi3_parser 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 81001258de6af8c21c8a7db87520d9433e3acb878483a56a616fdcd804e92848
-  data.tar.gz: 496f3a02ebcb386e949eab7ec6607f360a0b2e755be6bb4f1df3cd6b260a6e0d
+  metadata.gz: 5904884ad75e5d50acec8b37e27d4888ee903adab23998a78f884b4595e271dc
+  data.tar.gz: 8af9725d24ae912bac01b9be995be1d0105801cd245b7698508bb840b7e6da6a
 SHA512:
-  metadata.gz: d789d4ffe423f8854f961e902ffa6ef56b86d7dbcf506292106afa8548b72f2fbe968d98358ea7c80771a3c2e974c302096d43968c0663bdad40dc5f60a676e2
-  data.tar.gz: aea92fa77fbb4808872093b9149f8eb933f70a38336a0e415fa1fc9d4c15e691b8307abb0d70c0e51eee8eca89887cbc1a16b21e70f2d1812ae0fd77b75fe2a3
+  metadata.gz: 4edb5b8d4eec5c510ba62f58a2fb99b5156271548183d4dbc14039d17a0f14c504f466c359543cd871f8530d520e144ec03db1782fb8bcf6c006efb1434c6b45
+  data.tar.gz: 48f873eb9a0731fb8918b2015cb5263db8b9aeb0c6c24fe4e03e4d0d2be752f728efdecbff08064db915278e6862ad98f77259ed5a7d723e0f9c31cfd82debea

data/.github/workflows/ci.yml

@@ -3,7 +3,7 @@ jobs:
   test:
     strategy:
       matrix:
-        ruby: [2.5, 2.6, 2.7, 3.0]
+        ruby: [2.6, 2.7, 3.0, 3.1]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -13,11 +13,11 @@ jobs:
           ruby-version: ${{ matrix.ruby }}
       - name: Test Ruby ${{ matrix.ruby }}
         run: bundle exec rake
-        if: matrix.ruby != '2.5'
+        if: matrix.ruby != '2.6'
       - name: Test and publish coverage for Ruby ${{ matrix.ruby }}
         uses: paambaati/codeclimate-action@v2.7.5
         env:
           CC_TEST_REPORTER_ID: 8bc2d8e54331569aeb442094c21cb64a58d6efa0670f65ff00d9ae887f63c0b4
         with:
           coverageCommand: bundle exec rake
-        if: matrix.ruby == '2.5'
+        if: matrix.ruby == '2.6'

data/.ruby-version

@@ -1 +1 @@
-2.5.8
+2.6.9

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# 0.9.1
+
+- Fix Schema#requires? incorrectly returning true for referenced properties -
+  https://github.com/kevindew/openapi3_parser/issues/20
+- Drop support for Ruby 2.5
+
 # 0.9.0
 
 - Fix unexpected fields error when using Example nodes inside a Parameter -

data/README.md

@@ -121,7 +121,7 @@ You can install this gem into your bundler application by adding this line to
 your Gemfile:
 
 ```
-gem "openapi3_parser", "~> 0.8.0"
+gem "openapi3_parser", "~> 0.9.0"
 ```
 
 and then running `$ bundle install`

data/lib/openapi3_parser/node/schema.rb

@@ -120,9 +120,11 @@ module Openapi3Parser
       # @return [Boolean]
       def requires?(property)
         if property.is_a?(Schema)
+          # compare node_context of objects to ensure references aren't treated
+          # as equal - only direct properties of this object will pass.
           properties.to_h
                     .select { |k, _| required.to_a.include?(k) }
-                    .any? { |_, schema| schema == property }
+                    .any? { |_, schema| schema.node_context == property.node_context }
         else
           required.to_a.include?(property)
         end

data/lib/openapi3_parser/node_factory/path_item.rb

@@ -68,7 +68,7 @@ module Openapi3Parser
 
       def merge_data(base, priority)
         base.merge(priority) do |_, old, new|
-          if new.nil? || new.respond_to?(:nil_input?) && new.nil_input?
+          if new.nil? || (new.respond_to?(:nil_input?) && new.nil_input?)
             old
           else
             new

data/lib/openapi3_parser/node_factory/paths.rb

@@ -36,9 +36,7 @@ module Openapi3Parser
       end
 
       def validate(validatable)
-        paths = validatable.input.keys.reject do |key|
-          NodeFactory::EXTENSION_REGEX =~ key
-        end
+        paths = validatable.input.keys.grep_v(NodeFactory::EXTENSION_REGEX)
         validate_paths(validatable, paths)
       end
 

data/lib/openapi3_parser/source/pointer.rb

@@ -8,7 +8,7 @@ module Openapi3Parser
     # provide common means to convert it into different representations.
     class Pointer
       def self.from_fragment(fragment)
-        fragment = fragment[1..-1] if fragment.start_with?("#")
+        fragment = fragment[1..] if fragment.start_with?("#")
         absolute = fragment[0] == "/"
         segments = fragment.split("/").map do |part|
           next if part == ""
@@ -93,7 +93,7 @@ module Openapi3Parser
 
           joined = File.expand_path("/#{fragment_a}/#{fragment_b}", "/")
 
-          joined = joined[1..-1] unless pointer_a.absolute
+          joined = joined[1..] unless pointer_a.absolute
 
           Pointer.from_fragment("##{joined}")
         end

data/lib/openapi3_parser/source/resolved_reference.rb

@@ -29,13 +29,9 @@ module Openapi3Parser
       end
 
       def factory
-        @factory ||= begin
-          reference_registry
-            .factory(object_type, source_location)
-            .tap do |factory|
-              message = "Unregistered node factory at #{source_location}"
-              raise Openapi3Parser::Error, message unless factory
-            end
+        @factory ||= reference_registry.factory(object_type, source_location).tap do |factory|
+          message = "Unregistered node factory at #{source_location}"
+          raise Openapi3Parser::Error, message unless factory
         end
       end
 

data/lib/openapi3_parser/validators/unexpected_fields.rb

@@ -39,7 +39,7 @@ module Openapi3Parser
         extra_keys = input.keys - allowed_fields
         return extra_keys unless allow_extensions
 
-        extra_keys.reject { |key| key =~ NodeFactory::EXTENSION_REGEX }
+        extra_keys.grep_v(NodeFactory::EXTENSION_REGEX)
       end
     end
   end

data/lib/openapi3_parser/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Openapi3Parser
-  VERSION = "0.9.0"
+  VERSION = "0.9.1"
 end

data/openapi3_parser.gemspec

@@ -10,6 +10,7 @@ Gem::Specification.new do |spec|
   spec.version       = Openapi3Parser::VERSION
   spec.author        = "Kevin Dew"
   spec.email         = "kevindew@me.com"
+  spec.metadata      = { "rubygems_mfa_required" => "true" }
 
   spec.summary       = "An OpenAPI V3 parser for Ruby"
   spec.description   = <<-DESCRIPTION
@@ -24,7 +25,7 @@ Gem::Specification.new do |spec|
     f.match(%r{^spec/})
   end
 
-  spec.required_ruby_version = ">= 2.5.0"
+  spec.required_ruby_version = ">= 2.6.0"
 
   spec.add_dependency "commonmarker", "~> 0.17"
   spec.add_dependency "psych", "~> 3.1"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: openapi3_parser
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Kevin Dew
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-02-09 00:00:00.000000000 Z
+date: 2021-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: commonmarker
@@ -300,7 +300,8 @@ files:
 homepage: https://github.com/kevindew/openapi_parser
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -309,15 +310,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project:
-rubygems_version: 2.7.6.2
+rubygems_version: 3.0.3.1
 signing_key:
 specification_version: 4
 summary: An OpenAPI V3 parser for Ruby