RubyGems - openapi-ruby - Versions diffs - 2.1.0 → 2.2.0 - Mend

openapi-ruby 2.1.0 → 2.2.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (11) hide show

checksums.yaml +4 -4
data/README.md +8 -2
data/app/controllers/openapi_ruby/ui_controller.rb +5 -1
data/lib/openapi-ruby.rb +3 -0
data/lib/openapi_ruby/components/base.rb +38 -8
data/lib/openapi_ruby/components/key_transformer.rb +14 -5
data/lib/openapi_ruby/components/loader.rb +48 -43
data/lib/openapi_ruby/components/registry.rb +43 -7
data/lib/openapi_ruby/engine.rb +2 -15
data/lib/openapi_ruby/version.rb +1 -1
metadata +2 -1

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2fa2e6a3989eed9e11e17ff251bccf6044dd6ecb280bb32fb390f11179955afb
-  data.tar.gz: 15bcdc40a54580d95d5e71ec88665d9c1911b7d7630e38d4ebe56bcdf031aba2
+  metadata.gz: d7c1b8cfa3a8ecc15d1e378b9354d359333b5ac8d43f9cdd1de609d60830a839
+  data.tar.gz: c987648c9d766474bb5665d115647513c1ae7d6c3d4c5ea4478ec83d3b7fed22
 SHA512:
-  metadata.gz: 0d1ba7835ecebbfe335a86fddc39b772c730517729bc0f0a03902e31b5d35e6b53929cd6e693f4841c054a32ecf8eeaf821fe9913b7b6fd9d2faacead2834bd1
-  data.tar.gz: b18fdcc9aa4d8706b934bf775bfcd4c4a1505b4387277ef7f9c5efc4b80f678cad0a038b178e35a70b8343b5d55e4b8df137cfc93081b61170dd7a0573960f0c
+  metadata.gz: 01dc4b64bd6d67a48659d1d1ffb8f77dc93609d3ff790664d60ad312c8b38f2ff986ec013ae52cf14dda243f396637c39366c21985086098bb7c3effa0f4a813
+  data.tar.gz: d5df229413a0836644665b8ff29976764c547383ea6443eea20d156d6db8671405f8e84ddec26a25d11b1b3456d84157e44571ebb32ecc58265209e04b20e5b1

data/README.md CHANGED Viewed

@@ -1,6 +1,12 @@
-# openapi_ruby
+<p align="center">
+  <img src="logo.svg" alt="openapi_ruby" width="200">
+</p>
-A unified OpenAPI 3.1 toolkit for Rails that combines test-driven spec generation, reusable schema components as Ruby classes, and runtime request/response validation middleware. Works with both RSpec and Minitest.
+<h1 align="center">openapi_ruby</h1>
+<p align="center">
+  A unified OpenAPI 3.1 toolkit for Rails that combines test-driven spec generation, reusable schema components as Ruby classes, and runtime request/response validation middleware. Works with both RSpec and Minitest.
+</p>
 Replaces [rswag](https://github.com/rswag/rswag), [rswag-schema-components](https://github.com/101skills-gmbh/rswag-schema-components), and [committee](https://github.com/interagent/committee) with a single gem.

data/app/controllers/openapi_ruby/ui_controller.rb CHANGED Viewed

@@ -44,6 +44,7 @@ module OpenapiRuby
         <body>
           <div id="swagger-ui"></div>
           <script src="https://unpkg.com/swagger-ui-dist@5/swagger-ui-bundle.js"></script>
+          <script src="https://unpkg.com/swagger-ui-dist@5/swagger-ui-standalone-preset.js"></script>
           <script>
             SwaggerUIBundle({
               #{schema_urls_js},
@@ -51,7 +52,10 @@ module OpenapiRuby
               deepLinking: true,
               presets: [
                 SwaggerUIBundle.presets.apis,
-                SwaggerUIBundle.SwaggerUIStandalonePreset
+                SwaggerUIStandalonePreset
+              ],
+              plugins: [
+                SwaggerUIBundle.plugins.DownloadUrl
               ],
               layout: "#{(@schemas.size > 1) ? "StandaloneLayout" : "BaseLayout"}",
               #{ui_config_js}

data/lib/openapi-ruby.rb ADDED Viewed

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+require_relative "openapi_ruby"

data/lib/openapi_ruby/components/base.rb CHANGED Viewed

@@ -4,13 +4,20 @@ module OpenapiRuby
   module Components
     module Base
       def self.included(base)
-        base.extend ClassMethods
-        base.class_attribute :_schema_definition, default: {}
-        base.class_attribute :_schema_hidden, default: false
-        base.class_attribute :_skip_key_transformation, default: false
-        base.class_attribute :_component_type, default: :schemas
-        base.class_attribute :_component_scopes, default: []
-        base.class_attribute :_component_scopes_explicitly_set, default: false
+        # Guard against re-including in subclasses that already inherited Base.
+        # Re-running class_attribute with default: would overwrite inherited values.
+        already_included = base.respond_to?(:_schema_definition)
+        base.extend ClassMethods unless already_included
+        unless already_included
+          base.class_attribute :_schema_definition, default: {}
+          base.class_attribute :_schema_hidden, default: false
+          base.class_attribute :_skip_key_transformation, default: false
+          base.class_attribute :_component_type, default: :schemas
+          base.class_attribute :_component_scopes, default: []
+          base.class_attribute :_component_scopes_explicitly_set, default: false
+        end
         Registry.instance.register(base) if base.name
       end
@@ -28,7 +35,10 @@ module OpenapiRuby
         end
         def schema(definition = nil)
-          self._schema_definition = _schema_definition.deep_merge(deep_stringify(definition)) if definition
+          if definition
+            stringified = deep_stringify(definition)
+            self._schema_definition = deep_merge_with_array_concat(_schema_definition, stringified)
+          end
           _schema_definition
         end
@@ -58,6 +68,11 @@ module OpenapiRuby
           self._component_scopes_explicitly_set = true
         end
+        def transform_enum_key(key)
+          key = ActiveSupport::Inflector.underscore(key.to_s)
+          key.parameterize(separator: "_").upcase
+        end
         def component_name
           (name || "Anonymous").demodulize
         end
@@ -115,6 +130,21 @@ module OpenapiRuby
           !_skip_key_transformation && OpenapiRuby.configuration.camelize_keys
         end
+        # Deep merge that concatenates arrays instead of replacing them,
+        # matching the behavior of rswag-schema_components' deeper_merge.
+        # This ensures inherited schema properties (like `required`) are merged correctly.
+        def deep_merge_with_array_concat(base, override)
+          base.merge(override) do |_key, old_val, new_val|
+            if old_val.is_a?(Hash) && new_val.is_a?(Hash)
+              deep_merge_with_array_concat(old_val, new_val)
+            elsif old_val.is_a?(Array) && new_val.is_a?(Array)
+              (old_val + new_val).uniq
+            else
+              new_val
+            end
+          end
+        end
         def deep_stringify(value)
           case value
           when Hash

data/lib/openapi_ruby/components/key_transformer.rb CHANGED Viewed

@@ -9,15 +9,20 @@ module OpenapiRuby
         transform_keys(hash) { |key| camelize(key) }
       end
-      def transform_keys(value, &block)
+      def transform_keys(value, parent_key: nil, &block)
         case value
         when Hash
           value.each_with_object({}) do |(k, v), result|
             new_key = block.call(k.to_s)
-            result[new_key] = transform_keys(v, &block)
+            result[new_key] = transform_keys(v, parent_key: k.to_s, &block)
           end
         when Array
-          value.map { |v| transform_keys(v, &block) }
+          if parent_key == "required"
+            # Values in "required" arrays are property names that must also be transformed
+            value.map { |v| v.is_a?(String) ? block.call(v) : transform_keys(v, &block) }
+          else
+            value.map { |v| transform_keys(v, &block) }
+          end
         else
           value
         end
@@ -27,8 +32,12 @@ module OpenapiRuby
         key = key.to_s
         return key if key.start_with?("$")
-        parts = key.split("_")
-        parts[0] + parts[1..].map(&:capitalize).join
+        # Preserve leading underscore prefix (e.g., _destroy stays _destroy)
+        prefix = key.start_with?("_") ? "_" : ""
+        stripped = key.delete_prefix("_")
+        parts = stripped.split("_")
+        "#{prefix}#{parts[0]}#{parts[1..].map(&:capitalize).join}"
       end
     end
   end

data/lib/openapi_ruby/components/loader.rb CHANGED Viewed

@@ -63,77 +63,82 @@ module OpenapiRuby
           expanded = File.expand_path(path)
           next unless Dir.exist?(expanded)
-          define_nested_modules(expanded, expanded)
-        end
-      end
-      def define_nested_modules(base_path, current_path)
-        Dir.children(current_path).select { |f| File.directory?(File.join(current_path, f)) }.each do |dir|
-          mod_name = dir.camelize.to_sym
-          Object.const_set(mod_name, Module.new) unless Object.const_defined?(mod_name)
-          child_path = File.join(current_path, dir)
-          define_nested_modules(base_path, child_path)
+          Dir.glob(File.join(expanded, "**/")).each do |dir_path|
+            relative = dir_path.sub("#{expanded}/", "").chomp("/")
+            next if relative.empty?
+            const_name = relative.camelize
+            const_name.split("::").inject(Object) do |parent, name|
+              if parent.const_defined?(name, false)
+                parent.const_get(name, false)
+              else
+                parent.const_set(name, Module.new)
+              end
+            end
+          end
         end
       end
       def load_component_files!
         scope_paths = OpenapiRuby.configuration.component_scope_paths
+        # Collect all files with their base paths, then sort globally by relative
+        # path to ensure consistent load order across multiple base paths.
+        # This prevents cross-directory inheritance issues (e.g., a subclass in
+        # packs/ai_feedback loading before its superclass in packs/api).
+        all_files = collect_all_files
         if scope_paths.any?
-          load_with_scope_inference(scope_paths)
+          load_with_scope_inference(all_files, scope_paths)
         else
-          component_files.each { |f| require f }
+          all_files.each { |entry| require entry[:file] }
         end
       end
-      def load_with_scope_inference(scope_paths)
+      def collect_all_files
+        files = []
         @paths.each do |base_path|
           expanded = File.expand_path(base_path)
           next unless Dir.exist?(expanded)
-          files = Dir[File.join(expanded, "**", "*.rb")].sort
-          files.each do |file|
+          Dir[File.join(expanded, "**", "*.rb")].each do |file|
             relative = file.sub("#{expanded}/", "")
-            inferred_scope = infer_scope(relative, scope_paths)
-            registered_before = Registry.instance.all_registered_classes.dup
-            require file
-            registered_after = Registry.instance.all_registered_classes
-            new_classes = registered_after - registered_before
-            new_classes.each do |klass|
-              next if klass._component_scopes_explicitly_set
-              if inferred_scope == :shared
-                # Shared components have empty scopes (included in all specs)
-                klass._component_scopes = []
-              elsif inferred_scope
-                Registry.instance.unregister(klass)
-                klass._component_scopes = [inferred_scope]
-                Registry.instance.register(klass)
-              end
+            files << {file: file, base_path: expanded, relative: relative}
+          end
+        end
+        files.sort_by { |entry| entry[:relative] }
+      end
+      def load_with_scope_inference(all_files, scope_paths)
+        all_files.each do |entry|
+          inferred_scope = infer_scope(entry[:relative], scope_paths)
+          registered_before = Registry.instance.all_registered_classes.dup
+          require entry[:file]
+          registered_after = Registry.instance.all_registered_classes
+          new_classes = registered_after - registered_before
+          new_classes.each do |klass|
+            next if klass._component_scopes_explicitly_set
+            if inferred_scope == :shared
+              klass._component_scopes = []
+            elsif inferred_scope
+              Registry.instance.unregister(klass)
+              klass._component_scopes = [inferred_scope]
+              Registry.instance.register(klass)
             end
           end
         end
       end
       def infer_scope(relative_path, scope_paths)
-        # Match longest prefix first for specificity
         scope_paths.sort_by { |prefix, _| -prefix.length }.each do |prefix, scope|
           return scope&.to_sym if relative_path.start_with?("#{prefix}/")
         end
         nil
       end
-      def component_files
-        @paths.flat_map do |path|
-          expanded = File.expand_path(path)
-          Dir[File.join(expanded, "**", "*.rb")]
-        end
-      end
       def filter_type(type)
         to_openapi_hash[type.to_s] || {}
       end

data/lib/openapi_ruby/components/registry.rb CHANGED Viewed

@@ -13,21 +13,22 @@ module OpenapiRuby
       def register(component_class)
         type = component_class._component_type
-        key = component_class.registry_key
+        name = component_class.name || "Anonymous"
         @components[type] ||= {}
-        if @components[type].key?(key) && @components[type][key] != component_class
-          raise DuplicateComponentError, "Component '#{component_class.component_name}' already registered under #{type}"
-        end
+        check_for_duplicate!(component_class, type)
-        @components[type][key] = component_class
+        # Use the full class name as key to avoid collisions between
+        # same-named components in different scopes (e.g., Internal::V1::Schemas::PaginatedCollection
+        # vs Mobile::V1::Schemas::PaginatedCollection). Scope filtering happens in to_openapi_hash.
+        @components[type][name] = component_class
       end
       def unregister(component_class)
         type = component_class._component_type
-        key = component_class.registry_key
-        @components[type]&.delete(key)
+        name = component_class.name || "Anonymous"
+        @components[type]&.delete(name)
       end
       def components_for(type)
@@ -50,6 +51,41 @@ module OpenapiRuby
         @components = {}
       end
+      private
+      def check_for_duplicate!(component_class, type)
+        short_name = component_class.component_name
+        new_scopes = component_class._component_scopes
+        new_scopes_set = component_class._component_scopes_explicitly_set
+        @components[type]&.each_value do |existing|
+          next if existing.name == component_class.name
+          next unless existing.component_name == short_name
+          existing_scopes = existing._component_scopes
+          existing_scopes_set = existing._component_scopes_explicitly_set
+          # Skip when exactly one side has explicitly configured scopes — the other
+          # is still at its default (freshly included) and may get scopes set later via
+          # component_scopes, which unregisters/re-registers and retriggers this check.
+          next if new_scopes_set != existing_scopes_set
+          if scopes_overlap?(new_scopes, existing_scopes)
+            raise DuplicateComponentError,
+              "Component '#{short_name}' is already registered as #{type} " \
+              "(existing: #{existing.name}, new: #{component_class.name})"
+          end
+        end
+      end
+      def scopes_overlap?(a, b)
+        return true if a.empty? && b.empty?
+        return true if a.empty? || b.empty?
+        (a & b).any?
+      end
+      public
       def to_openapi_hash(scope: nil)
         result = {}
         @components.each do |type, components|

data/lib/openapi_ruby/engine.rb CHANGED Viewed

@@ -36,21 +36,8 @@ module OpenapiRuby
       end
     end
-    initializer "openapi_ruby.components" do
-      config = OpenapiRuby.configuration
-      config.component_paths.each do |path|
-        expanded = Rails.root.join(path)
-        next unless expanded.exist?
-        # Auto-define modules for subdirectories (Schemas, Parameters, etc.)
-        expanded.children.select(&:directory?).each do |dir|
-          mod_name = dir.basename.to_s.camelize.to_sym
-          Object.const_set(mod_name, Module.new) unless Object.const_defined?(mod_name)
-        end
-        Dir[expanded.join("**", "*.rb")].sort.each { |f| require f }
-      end
-    end
+    # Components are loaded on demand via Components::Loader (e.g. in test helpers),
+    # not at boot time — avoids cross-file dependency ordering issues.
     private

data/lib/openapi_ruby/version.rb CHANGED Viewed

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module OpenapiRuby
-  VERSION = "2.1.0"
+  VERSION = "2.2.0"
 end

metadata CHANGED Viewed

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: openapi-ruby
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Morten Hartvig
@@ -86,6 +86,7 @@ files:
 - lib/generators/openapi_ruby/install/install_generator.rb
 - lib/generators/openapi_ruby/install/templates/initializer.rb.tt
 - lib/generators/openapi_ruby/install/templates/openapi_helper.rb.tt
+- lib/openapi-ruby.rb
 - lib/openapi_ruby.rb
 - lib/openapi_ruby/adapters/minitest.rb
 - lib/openapi_ruby/adapters/rspec.rb