open_weather_client 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e71860d474b67b88ec968c56ca18bfcd98029b9078bbd73fef481bd1dcf8736
-  data.tar.gz: 8eb818af6393f4cbbac4dddea37800911ebe58a0dd10bc323f337251596cd088
+  metadata.gz: 12179413a7acc81adc794dbce0fb22720169a34c3e010fd22bfb32258c55a818
+  data.tar.gz: 4ca9bf5b64e2e5a4493084bdb7b91750279f40bd97b49c60c01a9e538b7e7390
 SHA512:
-  metadata.gz: 85a0e87c06cfa1753b6c3b2baaa251fd864fc03e50af861b86d015dc5a37739f043361c82fafea26794877b0652821a65b27f04efaab905ffb903bca22fedba5
-  data.tar.gz: 31ad8150d112bfcfd0b7b5e0b62830d3d5336968a76754dad1dc16e255ff0916901fd176fe8557688492101e2ed147392210cda1e4c6dd1920166d3c1bff477b
+  metadata.gz: ec49b4f16d5379f1a1f937184028ba6e332c966d6649f683d509132ce832660909b4ee89531675d1b9293dc170dba9228ba0127a69ac45ff54a642ee0d6c563f
+  data.tar.gz: 3c9aec3ddedd6c6e172a7d673bf8b6230ce1a6fa2dccf2c67b0cc9d0c0ad84eaef2798d1fa2d4387900e06cf2c01cd515cd2f5263b62dc05adfc99dbb9e12d30

data/CHANGES.md

@@ -1,5 +1,10 @@
 # Open Weather Client Changelog
 
+## 0.1.1
+- Raise `OpenWeatherClient::AuthenticationError` if the request is not authorized
+- - Raise `RangeError` if latitude or longitude is out of the allowed range
+- Raise `Faraday::Error` if the request fails otherwise 
+
 ## 0.1.0
 - Initial commit of the Open Weather Client gem
 - Configuration of OpenWeatherClient

data/README.md

@@ -35,6 +35,11 @@ end
 OpenWeatherClient::Weather.current(lat: 50.3569, lon: 7.5890)
 ```
 
+### Exceptions during requests
+When an error occurs during a request, an exception is raised.
+If the request is not authorized `OpenWeatherClient::AutheniticationError` is raied.
+When attributes like latitude or longitude are outside of the expected range a `RangeError` is raised.
+
 ### Secure Configuration
 In Rails provides the credentials functionality for [environmental security](https://edgeguides.rubyonrails.org/security.html#environmental-security). This mechanism can be used by OpenWeatherClient to load the API key from an encrypted file. This also allows easy separation of production and development channel configuration.
 All settings are defined under the top-level entry `open_weather_client`.

data/lib/open_weather_client/version.rb

@@ -1,3 +1,3 @@
 module OpenWeatherClient
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/open_weather_client/weather.rb

@@ -3,6 +3,9 @@ require 'faraday'
 module OpenWeatherClient
   class Weather
     def self.current(lat:, lon:)
+      raise RangeError unless (-90..90).member?(lat)
+      raise RangeError unless (-180..180).member?(lon)
+
       connection = Faraday.new(
         url: OpenWeatherClient.configuration.url,
         params: {
@@ -16,12 +19,16 @@ module OpenWeatherClient
           'User-Agent': OpenWeatherClient.configuration.user_agent
         }
       ) do |f|
+        f.response :raise_error
         f.response :json
       end
 
-      response = connection.get('2.5/weather')
-
-      response.body
+      begin
+        response = connection.get('2.5/weather')
+        response.body
+      rescue Faraday::UnauthorizedError
+        raise OpenWeatherClient::AuthenticationError
+      end
     end
   end
 end

data/lib/open_weather_client.rb

@@ -3,6 +3,8 @@ require 'open_weather_client/version'
 require 'open_weather_client/weather'
 
 module OpenWeatherClient
+  class AuthenticationError < StandardError; end
+
   class << self
     attr_accessor :configuration, :testing
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: open_weather_client
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Lucas Keune