open_uri_redirections 0.1.1 → 0.1.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: b8def15fe94729d1d4b1c78fa4852a0990860598
+  data.tar.gz: 822897ed3d8b22f28b3155a2ab09ef6f8986ef86
+SHA512:
+  metadata.gz: 1a04fd1cd49c2109376c758d0300f806dfb3e1d15292a29020aa0637ca542a507e3c634cff2d646f28d22771cb2a159fa1e27b1539a262f5988de2142970b134
+  data.tar.gz: afb121dc1b104a956f4daba3ccfd89ef5271f4405bd9d5f862dc3d77909d1a8bf0c16b347f71ad05d7c4ac19a934d59f2591d4c82ea3f75137d7848d0c6aac1c

data/.gitignore

@@ -4,6 +4,8 @@
 .config
 .yardoc
 .rvmrc
+.ruby-gemset
+.ruby-version
 Gemfile.lock
 InstalledFiles
 _yardoc

data/.travis.yml

@@ -1,4 +1,5 @@
 rvm:
   - 1.8.7
   - 1.9.2
-  - 1.9.3
+  - 1.9.3
+  - 2.0.0

data/lib/open-uri/redirections_patch.rb

@@ -29,27 +29,29 @@ module OpenURI
   #
   # The original open_uri takes *args but then doesn't do anything with them.
   # Assume we can only handle a hash.
-  def self.open_uri(name, options = {}, &block)
-    allow_redirections = options.delete :allow_redirections
+  def self.open_uri(name, *rest, &block)
+    mode, _, rest = OpenURI.scan_open_optional_arguments(*rest)
+    options = rest.first if !rest.empty? && Hash === rest.first
 
+    allow_redirections = options.delete :allow_redirections if options
     case allow_redirections
     when :safe
-      class <<self
+      class << self
         remove_method :redirectable?
         alias_method  :redirectable?, :redirectable_safe?
       end
     when :all
-      class <<self
+      class << self
         remove_method :redirectable?
         alias_method  :redirectable?, :redirectable_all?
       end
     else
-      class <<self
+      class << self
         remove_method :redirectable?
         alias_method  :redirectable?, :redirectable_cautious?
       end
     end
 
-    self.open_uri_original name, options, &block
+    self.open_uri_original name, *rest, &block
   end
-end
+end

data/lib/open_uri_redirections/version.rb

@@ -1,3 +1,3 @@
 module OpenUriRedirections
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/redirections_spec.rb

@@ -75,5 +75,19 @@ describe "OpenURI" do
         }.to yield_control
       end
     end
+
+    describe "with mode argument" do
+      it "should disallow HTTP => HTTPS redirections" do
+        expect {
+          open("http://safe.com", 'r')
+        }.to raise_error(RuntimeError, "redirection forbidden: http://safe.com -> https://safe.com/")
+      end
+
+      it "should allow HTTP => HTTPS redirections" do
+        expect {
+          open("http://safe.com", 'r', :allow_redirections => :safe)
+        }.to_not raise_error
+      end
+    end
   end
 end

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: open_uri_redirections
 version: !ruby/object:Gem::Version
-  version: 0.1.1
-  prerelease: 
+  version: 0.1.2
 platform: ruby
 authors:
 - Jaime Iniesta
@@ -10,12 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-11 00:00:00.000000000 Z
+date: 2013-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -23,7 +21,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -31,7 +28,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: fakeweb
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -39,7 +35,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -47,7 +42,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -55,7 +49,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -85,33 +78,26 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/jaimeiniesta/open_uri_redirections
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2413654041070005087
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2413654041070005087
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.0.6
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: OpenURI patch to allow redirections between HTTP and HTTPS
 test_files:
 - spec/redirections_spec.rb