open_uri_redirections 0.0.1

data/.gitignore

@@ -0,0 +1,18 @@
+*.gem
+*.rbc
+.bundle
+.config
+.yardoc
+.rvmrc
+Gemfile.lock
+InstalledFiles
+_yardoc
+coverage
+doc/
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp

data/Gemfile

@@ -0,0 +1,4 @@
+source 'https://rubygems.org'
+
+# Specify your gem's dependencies in open_uri_redirects.gemspec
+gemspec

data/LICENSE.txt

@@ -0,0 +1,22 @@
+Copyright (c) 2012 Jaime Iniesta
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -0,0 +1,63 @@
+# OpenUriRedirections
+
+This gem applies a patch to OpenURI to optionally allow redirections from HTTP to HTTPS, or from HTTPS to HTTP.
+
+Here is the problem it tries to solve:
+
+    $ irb
+    1.9.2p320 :001 > require 'open-uri'
+    => true 
+    1.9.2p320 :002 > open('http://github.com')
+    RuntimeError: redirection forbidden: http://github.com -> https://github.com/
+
+And here is how you can use this patch to follow the redirections:
+
+    $ irb
+    1.9.2p320 :001 > require 'open-uri'
+    => true 
+    > require 'open_uri_redirections'
+    => true 
+    1.9.2p320 :002 > open('http://github.com', :allow_safe_redirections => true)
+    => #<File:/var/folders/...>
+
+The patch contained in this gem adds two options to `OpenURI#open`:
+
+* `:allow_safe_redirections` When set to true, it will allow HTTP => HTTPS redirections.
+* `:allow_unsafe_redirections` When set to true, it will allow HTTPS => HTTP redirections.
+
+## Understand what you're doing
+
+Before using this gem, read this:
+
+### Original gist URL:
+[https://gist.github.com/1271420](https://gist.github.com/1271420)
+
+### Relevant issue:
+[http://redmine.ruby-lang.org/issues/3719](http://redmine.ruby-lang.org/issues/3719)
+
+### Source here:
+[https://github.com/ruby/ruby/blob/trunk/lib/open-uri.rb](https://github.com/ruby/ruby/blob/trunk/lib/open-uri.rb)
+
+Use it at your own risk!
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+    gem 'open_uri_redirections'
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install open_uri_redirections
+
+## Contributing
+
+1. Fork it
+2. Create your feature branch (`git checkout -b my-new-feature`)
+3. Commit your changes (`git commit -am 'Add some feature'`)
+4. Push to the branch (`git push origin my-new-feature`)
+5. Create new Pull Request

data/Rakefile

@@ -0,0 +1 @@
+require "bundler/gem_tasks"

data/lib/open-uri/redirections_patch.rb

@@ -0,0 +1,50 @@
+# Patch to allow open-uri to follow safe (http to https) and unsafe redirections (https to http).
+# Original gist URL:
+# https://gist.github.com/1271420
+#
+# Relevant issue:
+# http://redmine.ruby-lang.org/issues/3719
+#
+# Source here:
+# https://github.com/ruby/ruby/blob/trunk/lib/open-uri.rb
+
+module OpenURI
+  class <<self
+    alias_method :open_uri_original, :open_uri
+    alias_method :redirectable_cautious?, :redirectable?
+
+    def redirectable_safe?(uri1, uri2)
+      uri1.scheme.downcase == uri2.scheme.downcase || (uri1.scheme.downcase == "http" && uri2.scheme.downcase == "https")
+    end
+
+    def redirectable_unsafe?(uri1, uri2)
+      !redirectable_safe?(uri1, uri2)
+    end
+  end
+
+  # The original open_uri takes *args but then doesn't do anything with them.
+  # Assume we can only handle a hash.
+  def self.open_uri(name, options = {})
+    redirectable_unsafe = options.delete :allow_unsafe_redirections
+    redirectable_safe   = options.delete :allow_safe_redirections
+
+    if redirectable_unsafe
+      class <<self
+        remove_method :redirectable?
+        alias_method :redirectable?, :redirectable_unsafe?
+      end
+    elsif redirectable_safe
+      class <<self
+        remove_method :redirectable?
+        alias_method :redirectable?, :redirectable_safe?
+      end
+    else
+      class <<self
+        remove_method :redirectable?
+        alias_method :redirectable?, :redirectable_cautious?
+      end
+    end
+
+    self.open_uri_original name, options
+  end
+end

data/lib/open_uri_redirections.rb

@@ -0,0 +1,4 @@
+# -*- encoding: utf-8 -*-
+
+require 'open-uri'
+require File.expand_path(File.join(File.dirname(__FILE__), 'open-uri/redirections_patch'))

data/lib/open_uri_redirections/version.rb

@@ -0,0 +1,3 @@
+module OpenUriRedirections
+  VERSION = "0.0.1"
+end

data/open_uri_redirections.gemspec

@@ -0,0 +1,21 @@
+# -*- encoding: utf-8 -*-
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'open_uri_redirections/version'
+
+Gem::Specification.new do |gem|
+  gem.name          = "open_uri_redirections"
+  gem.version       = OpenUriRedirections::VERSION
+  gem.authors       = ["Jaime Iniesta", "Gabriel Cebrián"]
+  gem.email         = ["jaimeiniesta@gmail.com"]
+  gem.description   = %q{OpenURI patch to allow redirections between HTTP and HTTPS}
+  gem.summary       = %q{OpenURI patch to allow redirections between HTTP and HTTPS}
+  gem.homepage      = "https://github.com/jaimeiniesta/open_uri_redirections"
+
+  gem.files         = `git ls-files`.split($/)
+  gem.test_files    = gem.files.grep(%r{^(spec)/})
+  gem.require_paths = ["lib"]
+
+  gem.add_development_dependency 'rspec', '2.12.0'
+  gem.add_development_dependency 'fakeweb', '1.3.0'
+end

data/spec/redirections_spec.rb

@@ -0,0 +1,55 @@
+# -*- encoding: utf-8 -*-
+
+require File.join(File.dirname(__FILE__), "/spec_helper")
+
+describe "OpenURI" do
+  describe "#open" do
+    describe ":allow_safe_redirections" do
+      it "should allow HTTP => HTTPS redirections when true" do
+        expect {
+          open("http://safe.com", :allow_safe_redirections => true)
+        }.to_not raise_error
+      end
+
+      it "should disallow HTTP => HTTPS redirections when false" do
+        expect {
+          open("http://safe.com", :allow_safe_redirections => false)
+        }.to raise_error(RuntimeError, "redirection forbidden: http://safe.com -> https://safe.com/")
+      end
+
+      it "should disallow HTTP => HTTPS redirections by default" do
+        expect {
+          open("http://safe.com")
+        }.to raise_error(RuntimeError, "redirection forbidden: http://safe.com -> https://safe.com/")
+      end
+
+      it "should follow safe redirection when true" do
+        open("http://safe.com", :allow_safe_redirections => true).read.should == "Hello, this is Safe."
+      end
+    end
+
+    describe ":allow_unsafe_redirections" do
+      it "should allow HTTPS => HTTP redirections when true" do
+        expect {
+          open("https://unsafe.com", :allow_unsafe_redirections => true)
+        }.to_not raise_error
+      end
+
+      it "should disallow HTTPS => HTTP redirections when false" do
+        expect {
+          open("https://unsafe.com", :allow_unsafe_redirections => false)
+        }.to raise_error(RuntimeError, "redirection forbidden: https://unsafe.com -> http://unsafe.com/")
+      end
+
+      it "should disallow HTTPS => HTTP redirections by default" do
+        expect {
+          open("https://unsafe.com")
+        }.to raise_error(RuntimeError, "redirection forbidden: https://unsafe.com -> http://unsafe.com/")
+      end
+
+      it "should follow unsafe redirection when true" do
+        open("https://unsafe.com", :allow_unsafe_redirections => true).read.should == "Hello, this is Unsafe."
+      end
+    end
+  end
+end

data/spec/samples/http_safe.response

@@ -0,0 +1,9 @@
+HTTP/1.1 301 Moved Permanently
+Server: nginx
+Date: Mon, 03 Dec 2012 11:36:17 GMT
+Content-Type: text/html
+Content-Length: 178
+Connection: close
+Location: https://safe.com/
+
+Redirecting to https://safe.com/

data/spec/samples/http_unsafe.response

@@ -0,0 +1,15 @@
+HTTP/1.1 200 OK
+Server: nginx
+Date: Mon, 03 Dec 2012 11:37:51 GMT
+Content-Type: text/html; charset=utf-8
+Connection: keep-alive
+Status: 200 OK
+X-Runtime: 10
+ETag: "a9e1dd587bb233eb670ec06f7d553dbc"
+X-Frame-Options: deny
+Set-Cookie: _gh_sess=BAh7BzoPc2Vzc2lvbl9pZCIlZTc4ZDNlOGEwM2NlZDQ3Y2VhMDdlMTQyOTA4NWVmYzA6EF9jc3JmX3Rva2VuIjE0U2xsYUoybFFNSWxhWEtudHNvalJCVjZtVnJZcFVlRVk4WlpMbEZKWktRPQ%3D%3D--8ea4a235fd3c5e727d462e24b992fabd8f50050d; path=/; expires=Sat, 01-Jan-2022 00:00:00 GMT; secure; HttpOnly
+Content-Length: 21814
+Cache-Control: private, max-age=0, must-revalidate
+Strict-Transport-Security: max-age=2592000
+
+Hello, this is Unsafe.

data/spec/samples/https_safe.response

@@ -0,0 +1,15 @@
+HTTP/1.1 200 OK
+Server: nginx
+Date: Mon, 03 Dec 2012 11:37:51 GMT
+Content-Type: text/html; charset=utf-8
+Connection: keep-alive
+Status: 200 OK
+X-Runtime: 10
+ETag: "a9e1dd587bb233eb670ec06f7d553dbc"
+X-Frame-Options: deny
+Set-Cookie: _gh_sess=BAh7BzoPc2Vzc2lvbl9pZCIlZTc4ZDNlOGEwM2NlZDQ3Y2VhMDdlMTQyOTA4NWVmYzA6EF9jc3JmX3Rva2VuIjE0U2xsYUoybFFNSWxhWEtudHNvalJCVjZtVnJZcFVlRVk4WlpMbEZKWktRPQ%3D%3D--8ea4a235fd3c5e727d462e24b992fabd8f50050d; path=/; expires=Sat, 01-Jan-2022 00:00:00 GMT; secure; HttpOnly
+Content-Length: 21814
+Cache-Control: private, max-age=0, must-revalidate
+Strict-Transport-Security: max-age=2592000
+
+Hello, this is Safe.

data/spec/samples/https_unsafe.response

@@ -0,0 +1,9 @@
+HTTP/1.1 301 Moved Permanently
+Server: nginx
+Date: Mon, 03 Dec 2012 11:36:17 GMT
+Content-Type: text/html
+Content-Length: 178
+Connection: close
+Location: http://unsafe.com/
+
+Redirecting to http://unsafe.com.

data/spec/spec_helper.rb

@@ -0,0 +1,19 @@
+# -*- encoding: utf-8 -*-
+
+$: << File.join(File.dirname(__FILE__), "/../lib")
+require 'open_uri_redirections'
+require 'fakeweb'
+
+FakeWeb.allow_net_connect = false
+
+$samples_dir = File.dirname(__FILE__) + '/samples'
+
+#######################
+# Faked web responses #
+#######################
+
+FakeWeb.register_uri(:get, "http://safe.com/",    :response => open("#{$samples_dir}/http_safe.response").read)
+FakeWeb.register_uri(:get, "https://safe.com/",   :response => open("#{$samples_dir}/https_safe.response").read)
+
+FakeWeb.register_uri(:get, "https://unsafe.com/", :response => open("#{$samples_dir}/https_unsafe.response").read)
+FakeWeb.register_uri(:get, "http://unsafe.com/",  :response => open("#{$samples_dir}/http_unsafe.response").read)

metadata

@@ -0,0 +1,117 @@
+--- !ruby/object:Gem::Specification 
+name: open_uri_redirections
+version: !ruby/object:Gem::Version 
+  hash: 29
+  prerelease: 
+  segments: 
+  - 0
+  - 0
+  - 1
+  version: 0.0.1
+platform: ruby
+authors: 
+- Jaime Iniesta
+- "Gabriel Cebri\xC3\xA1n"
+autorequire: 
+bindir: bin
+cert_chain: []
+
+date: 2012-12-03 00:00:00 Z
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: rspec
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        hash: 63
+        segments: 
+        - 2
+        - 12
+        - 0
+        version: 2.12.0
+  type: :development
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
+  name: fakeweb
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        hash: 27
+        segments: 
+        - 1
+        - 3
+        - 0
+        version: 1.3.0
+  type: :development
+  version_requirements: *id002
+description: OpenURI patch to allow redirections between HTTP and HTTPS
+email: 
+- jaimeiniesta@gmail.com
+executables: []
+
+extensions: []
+
+extra_rdoc_files: []
+
+files: 
+- .gitignore
+- Gemfile
+- LICENSE.txt
+- README.md
+- Rakefile
+- lib/open-uri/redirections_patch.rb
+- lib/open_uri_redirections.rb
+- lib/open_uri_redirections/version.rb
+- open_uri_redirections.gemspec
+- spec/redirections_spec.rb
+- spec/samples/http_safe.response
+- spec/samples/http_unsafe.response
+- spec/samples/https_safe.response
+- spec/samples/https_unsafe.response
+- spec/spec_helper.rb
+homepage: https://github.com/jaimeiniesta/open_uri_redirections
+licenses: []
+
+post_install_message: 
+rdoc_options: []
+
+require_paths: 
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+requirements: []
+
+rubyforge_project: 
+rubygems_version: 1.8.24
+signing_key: 
+specification_version: 3
+summary: OpenURI patch to allow redirections between HTTP and HTTPS
+test_files: 
+- spec/redirections_spec.rb
+- spec/samples/http_safe.response
+- spec/samples/http_unsafe.response
+- spec/samples/https_safe.response
+- spec/samples/https_unsafe.response
+- spec/spec_helper.rb