open_graph_reader 0.7.2 → 0.8.0

data/spec/integration/real_world_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe "real world examples" do
     it "parses" do
       expect {
         OpenGraphReader.parse! fixture_html "real_world/mixed_case_properties"
-      }.to_not raise_error
+      }.not_to raise_error
     end
 
     it "assigns the right attributes" do
@@ -18,7 +18,7 @@ RSpec.describe "real world examples" do
       expect(object.og.site_name).to eq "Telepolis"
       expect(object.og.image.url).to eq "http://www.heise.de/tp/artikel/43/43516/43516_1.jpg"
       expect(object.og.description).to eq(
-        "Ungenehmigte Bürgerinitiative will das Paket EU-Kommissionschef Juncker zum Geburtstag "\
+        "Ungenehmigte Bürgerinitiative will das Paket EU-Kommissionschef Juncker zum Geburtstag " \
         "schenken"
       )
     end
@@ -36,7 +36,7 @@ RSpec.describe "real world examples" do
     it "parses" do
       expect {
         OpenGraphReader.parse! fixture_html "real_world/mixed_case_type"
-      }.to_not raise_error
+      }.not_to raise_error
     end
   end
 
@@ -54,7 +54,7 @@ RSpec.describe "real world examples" do
       expect(object.og.title).to eq "Emergency call system for all new cars by 2018"
       expect(object.og.type).to eq "article"
       expect(object.og.description).to eq(
-        "The European Parliament and EU member states have agreed that new cars must be fitted"\
+        "The European Parliament and EU member states have agreed that new cars must be fitted" \
         " with an automated system to alert emergency services in event of a crash."
       )
       expect(object.og.site_name).to eq "BBC News"
@@ -77,7 +77,7 @@ RSpec.describe "real world examples" do
         "http://cdn.instructables.com/FI2/D7XW/I2XTQWFE/FI2D7XWI2XTQWFE.RECTANGLE1.jpg"
       )
       expect(object.og.description).to eq(
-        "The OpenKnit machine is an open-source, low cost, digital fabrication tool developed by "\
+        "The OpenKnit machine is an open-source, low cost, digital fabrication tool developed by " \
         "Gerard Rubio.  The machine affords the user the opportunity to..."
       )
     end
@@ -99,10 +99,10 @@ RSpec.describe "real world examples" do
       expect(object.og.type).to eq "article"
       expect(object.og.title).to eq "Profesores y campesinos amarran a infiltrados en marcha"
       expect(object.og.description).to eq(
-        "Regeneración, 6 de diciembre de 2014.-Durante la marcha que realizan profesores y "\
-        "organizaciones campesinas sobre avenida Paseo de la Reforma, maestros de la Coordinadora "\
-        "Estatal de Trabajadores de la Educación en Guerrero (CETEG) ubicaron a 12 jóvenes como "\
-        "“infiltrados”, a quienes amarraron de las manos en una cadena humana para evitar que "\
+        "Regeneración, 6 de diciembre de 2014.-Durante la marcha que realizan profesores y " \
+        "organizaciones campesinas sobre avenida Paseo de la Reforma, maestros de la Coordinadora " \
+        "Estatal de Trabajadores de la Educación en Guerrero (CETEG) ubicaron a 12 jóvenes como " \
+        "“infiltrados”, a quienes amarraron de las manos en una cadena humana para evitar que " \
         "marchen con ellos, informó El …"
       )
       expect(object.og.url).to eq(
@@ -128,7 +128,7 @@ RSpec.describe "real world examples" do
       expect(object.og.title).to eq "Emergency call system for all new cars by 2018"
       expect(object.og.type).to eq "article"
       expect(object.og.description).to eq(
-        "The European Parliament and EU member states have agreed that new cars must be fitted with"\
+        "The European Parliament and EU member states have agreed that new cars must be fitted with" \
         " an automated system to alert emergency services in event of a crash."
       )
       expect(object.og.site_name).to eq "BBC News"
@@ -157,7 +157,7 @@ RSpec.describe "real world examples" do
         "http://cdn.instructables.com/FI2/D7XW/I2XTQWFE/FI2D7XWI2XTQWFE.RECTANGLE1.jpg"
       )
       expect(object.og.description).to eq(
-        "The OpenKnit machine is an open-source, low cost, digital fabrication tool developed by "\
+        "The OpenKnit machine is an open-source, low cost, digital fabrication tool developed by " \
         "Gerard Rubio.  The machine affords the user the opportunity to..."
       )
     end
@@ -185,11 +185,11 @@ RSpec.describe "real world examples" do
 
       expect(object.og.type).to eq "website"
       expect(object.og.title).to eq(
-        "Ultra Conservative Christian Lady Goes To Museum, Tries To Debunk Evolution, Fails Beyond"\
+        "Ultra Conservative Christian Lady Goes To Museum, Tries To Debunk Evolution, Fails Beyond" \
         " Miserably | Geekologie"
       )
       expect(object.og.image.url).to eq(
-        "http://geekologie.com/assets_c/2014/11/crazy-lady-goes-to-the"\
+        "http://geekologie.com/assets_c/2014/11/crazy-lady-goes-to-the" \
         "-museum-thumb-640x389-29314.jpg"
       )
     end
@@ -229,7 +229,7 @@ RSpec.describe "real world examples" do
 
       object = OpenGraphReader.parse!(
         fixture_html("real_world/image_path_2"),
-        "http://motherboard.vice.com/de/read/forscher-kreieren-ein-material-das-fast-so-dunkel-ist"\
+        "http://motherboard.vice.com/de/read/forscher-kreieren-ein-material-das-fast-so-dunkel-ist" \
         "-wie-ein-schwarzes-loch?trk_source=popular"
       )
 
@@ -239,11 +239,11 @@ RSpec.describe "real world examples" do
       )
       expect(object.og.site_name).to eq "Motherboard"
       expect(object.og.image.url).to eq(
-        "https://motherboard-images.vice.com/content-images/article/13701/1405417621515809.JPG?cro"\
+        "https://motherboard-images.vice.com/content-images/article/13701/1405417621515809.JPG?cro" \
         "p=0.75xw:1xh;*,*&resize=500:*&output-format=jpeg&output-quality=90"
       )
       expect(object.og.url).to eq(
-        "http://motherboard.vice.com/de/read/forscher-kreieren-ein-material-das-fast-so-dunkel-ist"\
+        "http://motherboard.vice.com/de/read/forscher-kreieren-ein-material-das-fast-so-dunkel-ist" \
         "-wie-ein-schwarzes-loch"
       )
     end
@@ -271,47 +271,47 @@ RSpec.describe "real world examples" do
       expect(object.og.url).to eq(
         "https://github.com/blog/1938-vulnerability-announced-update-your-git-clients"
       )
-      expect(object.og.description).to eq <<-DESCRIPTION.chomp
-A critical Git security vulnerability has been announced today, affecting all versions of the \
-official Git client and all related software that interacts with Git repositories, including \
-GitHub for Windows and GitHub for Mac. Because this is a client-side only vulnerability, \
-github.com and GitHub Enterprise are not directly affected.
-
-The vulnerability concerns Git and Git-compatible clients that access Git repositories in a \
-case-insensitive or case-normalizing filesystem. An attacker can craft a malicious Git tree that \
-will cause Git to overwrite its own .git/config file when cloning or checking out a repository, \
-leading to arbitrary command execution in the client machine. Git clients running on OS X (HFS+) \
-or any version of Microsoft Windows (NTFS, FAT) are exploitable through this vulnerability. Linux \
-clients are not affected if they run in a case-sensitive filesystem.
-
-We strongly encourage all users of GitHub and GitHub Enterprise to update their Git clients as \
-soon as possible, and to be particularly careful when cloning or accessing Git repositories hosted \
-on unsafe or untrusted hosts.
-
-Repositories hosted on github.com cannot contain any of the malicious trees that trigger the \
-vulnerability because we now verify and block these trees on push. We have also completed an \
-automated scan of all existing content on github.com to look for malicious content that might have \
-been pushed to our site before this vulnerability was discovered. This work is an extension of the \
-data-quality checks we have always performed on repositories pushed to our servers to protect our \
-users against malformed or malicious Git data.
-
-Updated versions of GitHub for Windows and GitHub for Mac are available for immediate download, and \
-both contain the security fix on the Desktop application itself and on the bundled version of the \
-Git command-line client.
-
-In addition, the following updated versions of Git address this vulnerability:
-
-
-The Git core team has announced maintenance releases for all current versions of Git (v1.8.5.6, \
-v1.9.5, v2.0.5, v2.1.4, and v2.2.1).
-Git for Windows (also known as MSysGit) has released maintenance version 1.9.5.
-The two major Git libraries, libgit2 and JGit, have released maintenance versions with the fix. \
-Third party software using these libraries is strongly encouraged to update.
-
-
-More details on the vulnerability can be found in the official Git mailing list announcement and on \
-the git-blame blog.
-DESCRIPTION
+      expect(object.og.description).to eq <<~DESCRIPTION.chomp
+        A critical Git security vulnerability has been announced today, affecting all versions of the \
+        official Git client and all related software that interacts with Git repositories, including \
+        GitHub for Windows and GitHub for Mac. Because this is a client-side only vulnerability, \
+        github.com and GitHub Enterprise are not directly affected.
+        
+        The vulnerability concerns Git and Git-compatible clients that access Git repositories in a \
+        case-insensitive or case-normalizing filesystem. An attacker can craft a malicious Git tree that \
+        will cause Git to overwrite its own .git/config file when cloning or checking out a repository, \
+        leading to arbitrary command execution in the client machine. Git clients running on OS X (HFS+) \
+        or any version of Microsoft Windows (NTFS, FAT) are exploitable through this vulnerability. Linux \
+        clients are not affected if they run in a case-sensitive filesystem.
+        
+        We strongly encourage all users of GitHub and GitHub Enterprise to update their Git clients as \
+        soon as possible, and to be particularly careful when cloning or accessing Git repositories hosted \
+        on unsafe or untrusted hosts.
+        
+        Repositories hosted on github.com cannot contain any of the malicious trees that trigger the \
+        vulnerability because we now verify and block these trees on push. We have also completed an \
+        automated scan of all existing content on github.com to look for malicious content that might have \
+        been pushed to our site before this vulnerability was discovered. This work is an extension of the \
+        data-quality checks we have always performed on repositories pushed to our servers to protect our \
+        users against malformed or malicious Git data.
+        
+        Updated versions of GitHub for Windows and GitHub for Mac are available for immediate download, and \
+        both contain the security fix on the Desktop application itself and on the bundled version of the \
+        Git command-line client.
+        
+        In addition, the following updated versions of Git address this vulnerability:
+        
+        
+        The Git core team has announced maintenance releases for all current versions of Git (v1.8.5.6, \
+        v1.9.5, v2.0.5, v2.1.4, and v2.2.1).
+        Git for Windows (also known as MSysGit) has released maintenance version 1.9.5.
+        The two major Git libraries, libgit2 and JGit, have released maintenance versions with the fix. \
+        Third party software using these libraries is strongly encouraged to update.
+        
+        
+        More details on the vulnerability can be found in the official Git mailing list announcement and on \
+        the git-blame blog.
+      DESCRIPTION
     end
   end
 
@@ -336,47 +336,47 @@ DESCRIPTION
       expect(object.og.url).to eq(
         "https://github.com/blog/1938-vulnerability-announced-update-your-git-clients"
       )
-      expect(object.og.description).to eq <<-DESCRIPTION.chomp
-A critical Git security vulnerability has been announced today, affecting all versions of the \
-official Git client and all related software that interacts with Git repositories, including \
-GitHub for Windows and GitHub for Mac. Because this is a client-side only vulnerability, \
-github.com and GitHub Enterprise are not directly affected.
-
-The vulnerability concerns Git and Git-compatible clients that access Git repositories in a \
-case-insensitive or case-normalizing filesystem. An attacker can craft a malicious Git tree that \
-will cause Git to overwrite its own .git/config file when cloning or checking out a repository, \
-leading to arbitrary command execution in the client machine. Git clients running on OS X (HFS+) \
-or any version of Microsoft Windows (NTFS, FAT) are exploitable through this vulnerability. Linux \
-clients are not affected if they run in a case-sensitive filesystem.
-
-We strongly encourage all users of GitHub and GitHub Enterprise to update their Git clients as \
-soon as possible, and to be particularly careful when cloning or accessing Git repositories hosted \
-on unsafe or untrusted hosts.
-
-Repositories hosted on github.com cannot contain any of the malicious trees that trigger the \
-vulnerability because we now verify and block these trees on push. We have also completed an \
-automated scan of all existing content on github.com to look for malicious content that might have \
-been pushed to our site before this vulnerability was discovered. This work is an extension of the \
-data-quality checks we have always performed on repositories pushed to our servers to protect our \
-users against malformed or malicious Git data.
-
-Updated versions of GitHub for Windows and GitHub for Mac are available for immediate download, and \
-both contain the security fix on the Desktop application itself and on the bundled version of the \
-Git command-line client.
-
-In addition, the following updated versions of Git address this vulnerability:
-
-
-The Git core team has announced maintenance releases for all current versions of Git (v1.8.5.6, \
-v1.9.5, v2.0.5, v2.1.4, and v2.2.1).
-Git for Windows (also known as MSysGit) has released maintenance version 1.9.5.
-The two major Git libraries, libgit2 and JGit, have released maintenance versions with the fix. \
-Third party software using these libraries is strongly encouraged to update.
-
-
-More details on the vulnerability can be found in the official Git mailing list announcement and on \
-the git-blame blog.
-DESCRIPTION
+      expect(object.og.description).to eq <<~DESCRIPTION.chomp
+        A critical Git security vulnerability has been announced today, affecting all versions of the \
+        official Git client and all related software that interacts with Git repositories, including \
+        GitHub for Windows and GitHub for Mac. Because this is a client-side only vulnerability, \
+        github.com and GitHub Enterprise are not directly affected.
+        
+        The vulnerability concerns Git and Git-compatible clients that access Git repositories in a \
+        case-insensitive or case-normalizing filesystem. An attacker can craft a malicious Git tree that \
+        will cause Git to overwrite its own .git/config file when cloning or checking out a repository, \
+        leading to arbitrary command execution in the client machine. Git clients running on OS X (HFS+) \
+        or any version of Microsoft Windows (NTFS, FAT) are exploitable through this vulnerability. Linux \
+        clients are not affected if they run in a case-sensitive filesystem.
+        
+        We strongly encourage all users of GitHub and GitHub Enterprise to update their Git clients as \
+        soon as possible, and to be particularly careful when cloning or accessing Git repositories hosted \
+        on unsafe or untrusted hosts.
+        
+        Repositories hosted on github.com cannot contain any of the malicious trees that trigger the \
+        vulnerability because we now verify and block these trees on push. We have also completed an \
+        automated scan of all existing content on github.com to look for malicious content that might have \
+        been pushed to our site before this vulnerability was discovered. This work is an extension of the \
+        data-quality checks we have always performed on repositories pushed to our servers to protect our \
+        users against malformed or malicious Git data.
+        
+        Updated versions of GitHub for Windows and GitHub for Mac are available for immediate download, and \
+        both contain the security fix on the Desktop application itself and on the bundled version of the \
+        Git command-line client.
+        
+        In addition, the following updated versions of Git address this vulnerability:
+        
+        
+        The Git core team has announced maintenance releases for all current versions of Git (v1.8.5.6, \
+        v1.9.5, v2.0.5, v2.1.4, and v2.2.1).
+        Git for Windows (also known as MSysGit) has released maintenance version 1.9.5.
+        The two major Git libraries, libgit2 and JGit, have released maintenance versions with the fix. \
+        Third party software using these libraries is strongly encouraged to update.
+        
+        
+        More details on the vulnerability can be found in the official Git mailing list announcement and on \
+        the git-blame blog.
+      DESCRIPTION
     end
 
     it "parses with datetime format parsing turned on" do
@@ -391,47 +391,47 @@ DESCRIPTION
       expect(object.og.image.url).to eq "https://github.com/apple-touch-icon-144.png"
       expect(object.og.title).to eq "Vulnerability announced: update your Git clients"
       expect(object.og.url).to eq "https://github.com/blog/1938-vulnerability-announced-update-your-git-clients"
-      expect(object.og.description).to eq <<-DESCRIPTION.chomp
-A critical Git security vulnerability has been announced today, affecting all versions of the \
-official Git client and all related software that interacts with Git repositories, including \
-GitHub for Windows and GitHub for Mac. Because this is a client-side only vulnerability, \
-github.com and GitHub Enterprise are not directly affected.
-
-The vulnerability concerns Git and Git-compatible clients that access Git repositories in a \
-case-insensitive or case-normalizing filesystem. An attacker can craft a malicious Git tree that \
-will cause Git to overwrite its own .git/config file when cloning or checking out a repository, \
-leading to arbitrary command execution in the client machine. Git clients running on OS X (HFS+) \
-or any version of Microsoft Windows (NTFS, FAT) are exploitable through this vulnerability. Linux \
-clients are not affected if they run in a case-sensitive filesystem.
-
-We strongly encourage all users of GitHub and GitHub Enterprise to update their Git clients as \
-soon as possible, and to be particularly careful when cloning or accessing Git repositories hosted \
-on unsafe or untrusted hosts.
-
-Repositories hosted on github.com cannot contain any of the malicious trees that trigger the \
-vulnerability because we now verify and block these trees on push. We have also completed an \
-automated scan of all existing content on github.com to look for malicious content that might have \
-been pushed to our site before this vulnerability was discovered. This work is an extension of the \
-data-quality checks we have always performed on repositories pushed to our servers to protect our \
-users against malformed or malicious Git data.
-
-Updated versions of GitHub for Windows and GitHub for Mac are available for immediate download, and \
-both contain the security fix on the Desktop application itself and on the bundled version of the \
-Git command-line client.
-
-In addition, the following updated versions of Git address this vulnerability:
-
-
-The Git core team has announced maintenance releases for all current versions of Git (v1.8.5.6, \
-v1.9.5, v2.0.5, v2.1.4, and v2.2.1).
-Git for Windows (also known as MSysGit) has released maintenance version 1.9.5.
-The two major Git libraries, libgit2 and JGit, have released maintenance versions with the fix. \
-Third party software using these libraries is strongly encouraged to update.
-
-
-More details on the vulnerability can be found in the official Git mailing list announcement and on \
-the git-blame blog.
-DESCRIPTION
+      expect(object.og.description).to eq <<~DESCRIPTION.chomp
+        A critical Git security vulnerability has been announced today, affecting all versions of the \
+        official Git client and all related software that interacts with Git repositories, including \
+        GitHub for Windows and GitHub for Mac. Because this is a client-side only vulnerability, \
+        github.com and GitHub Enterprise are not directly affected.
+        
+        The vulnerability concerns Git and Git-compatible clients that access Git repositories in a \
+        case-insensitive or case-normalizing filesystem. An attacker can craft a malicious Git tree that \
+        will cause Git to overwrite its own .git/config file when cloning or checking out a repository, \
+        leading to arbitrary command execution in the client machine. Git clients running on OS X (HFS+) \
+        or any version of Microsoft Windows (NTFS, FAT) are exploitable through this vulnerability. Linux \
+        clients are not affected if they run in a case-sensitive filesystem.
+        
+        We strongly encourage all users of GitHub and GitHub Enterprise to update their Git clients as \
+        soon as possible, and to be particularly careful when cloning or accessing Git repositories hosted \
+        on unsafe or untrusted hosts.
+        
+        Repositories hosted on github.com cannot contain any of the malicious trees that trigger the \
+        vulnerability because we now verify and block these trees on push. We have also completed an \
+        automated scan of all existing content on github.com to look for malicious content that might have \
+        been pushed to our site before this vulnerability was discovered. This work is an extension of the \
+        data-quality checks we have always performed on repositories pushed to our servers to protect our \
+        users against malformed or malicious Git data.
+        
+        Updated versions of GitHub for Windows and GitHub for Mac are available for immediate download, and \
+        both contain the security fix on the Desktop application itself and on the bundled version of the \
+        Git command-line client.
+        
+        In addition, the following updated versions of Git address this vulnerability:
+        
+        
+        The Git core team has announced maintenance releases for all current versions of Git (v1.8.5.6, \
+        v1.9.5, v2.0.5, v2.1.4, and v2.2.1).
+        Git for Windows (also known as MSysGit) has released maintenance version 1.9.5.
+        The two major Git libraries, libgit2 and JGit, have released maintenance versions with the fix. \
+        Third party software using these libraries is strongly encouraged to update.
+        
+        
+        More details on the vulnerability can be found in the official Git mailing list announcement and on \
+        the git-blame blog.
+      DESCRIPTION
     end
   end
 
@@ -500,7 +500,7 @@ DESCRIPTION
   describe "just_other_prefix" do
     it "parses" do
       expect {
-        object = OpenGraphReader.parse! fixture_html "real_world/just_other_prefix"
+        OpenGraphReader.parse! fixture_html "real_world/just_other_prefix"
       }.to raise_error OpenGraphReader::NoOpenGraphDataError
     end
   end

data/spec/integration/test_cases_spec.rb

@@ -0,0 +1,17 @@
+require "spec_helper"
+
+RSpec.describe "test cases" do
+  describe "image_alt_before_image" do
+    it "parses" do
+      expect {
+        OpenGraphReader.parse! fixture_html "test_cases/image_alt_before_image"
+      }.not_to raise_error
+    end
+
+    it "returns the data" do
+      object = OpenGraphReader.parse!(fixture_html("test_cases/image_alt_before_image"))
+      expect(object.og.image.content).to eq "https://example.com/example.png"
+      expect(object.og.image.alt).to eq "image:alt"
+    end
+  end
+end

data/spec/integration/valid_examples_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 
 RSpec.describe "valid examples" do
-  %w(
+  %w[
     article-offset
     article-utc
     audio-array
@@ -21,12 +21,12 @@ RSpec.describe "valid examples" do
     video-array
     video-movie
     video
-  ).each do |example|
+  ].each do |example|
     describe example do
       it "parses" do
         expect {
           OpenGraphReader.parse! example_html example
-        }.to_not raise_error
+        }.not_to raise_error
       end
     end
   end
@@ -37,7 +37,7 @@ RSpec.describe "valid examples" do
     it "parses" do
       expect {
         object
-      }.to_not raise_error
+      }.not_to raise_error
     end
 
     it "allows access to the first tag" do
@@ -70,7 +70,7 @@ RSpec.describe "valid examples" do
     it "parses" do
       expect {
         OpenGraphReader.parse! example_html "errors/book"
-      }.to_not raise_error
+      }.not_to raise_error
     end
   end
 end

data/spec/open_graph_reader/fetcher_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe OpenGraphReader::Fetcher do
   let(:fetcher) { described_class.new uri }
   let(:good_response) { {status: 200, body: "", headers: {"Content-Type" => "text/html"}} }
 
-  context "error during body fetch" do
+  context "with an error during body fetch" do
     before do
       stub_request(:head, host).to_return(good_response)
       stub_request(:get, host).to_raise(Faraday::ConnectionFailed.new("execution expired"))

data/spec/open_graph_reader_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe OpenGraphReader do
       allow(OpenGraphReader::Fetcher).to receive(:new).and_return(double(html?: false))
 
       expect {
-        OpenGraphReader.fetch! "http://example.org"
+        described_class.fetch! "http://example.org"
       }.to raise_error OpenGraphReader::NoOpenGraphDataError
     end
 
@@ -17,7 +17,7 @@ RSpec.describe OpenGraphReader do
       allow(OpenGraphReader::Fetcher).to receive(:new).and_return(fetcher)
       allow(OpenGraphReader::Parser).to receive(:new).and_return(double(any_tags?: false))
       expect {
-        OpenGraphReader.fetch! "http://example.org"
+        described_class.fetch! "http://example.org"
       }.to raise_error OpenGraphReader::NoOpenGraphDataError
     end
 
@@ -26,7 +26,7 @@ RSpec.describe OpenGraphReader do
       allow(OpenGraphReader::Fetcher).to receive(:new).and_return(fetcher)
 
       expect {
-        OpenGraphReader.fetch! "http://example.org"
+        described_class.fetch! "http://example.org"
       }.to raise_error OpenGraphReader::InvalidObjectError
     end
   end
@@ -36,8 +36,8 @@ RSpec.describe OpenGraphReader do
       allow(OpenGraphReader::Fetcher).to receive(:new).and_return(double(html?: false))
 
       expect {
-        OpenGraphReader.fetch "http://example.org"
-      }.to_not raise_error
+        described_class.fetch "http://example.org"
+      }.not_to raise_error
     end
 
     it "does not raise if there are no tags" do
@@ -46,8 +46,8 @@ RSpec.describe OpenGraphReader do
       allow(OpenGraphReader::Parser).to receive(:new).and_return(double(any_tags?: false))
 
       expect {
-        OpenGraphReader.fetch "http://example.org"
-      }.to_not raise_error
+        described_class.fetch "http://example.org"
+      }.not_to raise_error
     end
 
     it "does not raise if there's an invalid object" do
@@ -55,8 +55,8 @@ RSpec.describe OpenGraphReader do
       allow(OpenGraphReader::Fetcher).to receive(:new).and_return(fetcher)
 
       expect {
-        OpenGraphReader.fetch "http://example.org"
-      }.to_not raise_error
+        described_class.fetch "http://example.org"
+      }.not_to raise_error
     end
   end
 
@@ -65,13 +65,13 @@ RSpec.describe OpenGraphReader do
       allow(OpenGraphReader::Parser).to receive(:new).and_return(double(any_tags?: false))
 
       expect {
-        OpenGraphReader.parse! ""
+        described_class.parse! ""
       }.to raise_error OpenGraphReader::NoOpenGraphDataError
     end
 
     it "raises if there's an invalid object" do
       expect {
-        OpenGraphReader.parse! invalid_object
+        described_class.parse! invalid_object
       }.to raise_error OpenGraphReader::InvalidObjectError
     end
   end
@@ -81,14 +81,14 @@ RSpec.describe OpenGraphReader do
       allow(OpenGraphReader::Parser).to receive(:new).and_return(double(any_tags?: false))
 
       expect {
-        OpenGraphReader.parse ""
-      }.to_not raise_error
+        described_class.parse ""
+      }.not_to raise_error
     end
 
     it "does not raise if there's an invalid object" do
       expect {
-        OpenGraphReader.parse invalid_object
-      }.to_not raise_error
+        described_class.parse invalid_object
+      }.not_to raise_error
     end
   end
 end

data/spec/spec_helper.rb

@@ -25,7 +25,7 @@ RSpec.configure do |config|
   config.order = :random
   Kernel.srand config.seed
 
-  config.after(:each) do
+  config.after do
     OpenGraphReader.config.reset_to_defaults!
   end
 end