open_graph_reader 0.2.0 → 0.3.0

data/spec/integration/invalid_examples_spec.rb

@@ -1,18 +1,22 @@
 require 'spec_helper'
 
 RSpec.describe "invalid examples" do
-  %w(plain error).each do |example|
-    describe example do
-      it "says there are no tags" do
-        expect {
-          OpenGraphReader.parse! example_html 'plain'
-        }.to raise_error OpenGraphReader::NoOpenGraphDataError, /OpenGraph tags/
-      end
+  describe "plain" do
+    it "says there are no tags" do
+      expect {
+        OpenGraphReader.parse! example_html 'plain'
+      }.to raise_error OpenGraphReader::NoOpenGraphDataError, /OpenGraph tags/
+    end
+
+    it "says there are no tags with title synthesization turend on" do
+      OpenGraphReader.config.synthesize_title = true
+
+      expect {
+        OpenGraphReader.parse! example_html 'plain'
+      }.to raise_error OpenGraphReader::NoOpenGraphDataError, /OpenGraph tags/
     end
   end
 
-  # Most parsers synthesize missing required properties, however
-  # we do not (yet), making this example an invalid object
   describe "min" do
     it "has missing required properties" do
       expect {

data/spec/integration/real_world_spec.rb

@@ -79,7 +79,7 @@ RSpec.describe "real world examples" do
   end
 
   describe "undefined_property" do
-    it "parses" do
+    it "parses (1)" do
       object = OpenGraphReader.parse! fixture_html 'real_world/undefined_property'
 
       expect(object.og.locale.to_s).to eq "es_ES"
@@ -91,13 +91,33 @@ RSpec.describe "real world examples" do
       expect(object.og.image.url).to   eq "http://regeneracion.mx/wp-content/uploads/2014/12/Infiltrados.jpg"
     end
 
-    it "does not parse in strict mode" do
+    it "does not parse in strict mode (1)" do
       OpenGraphReader.config.strict = true
 
       expect {
         OpenGraphReader.parse! fixture_html 'real_world/undefined_property'
       }.to raise_error OpenGraphReader::InvalidObjectError, /Undefined property/
     end
+
+    it "parses (2)" do
+      object = OpenGraphReader.parse! fixture_html 'real_world/undefined_property_2'
+
+
+      expect(object.og.title).to            eq "Emergency call system for all new cars by 2018"
+      expect(object.og.type).to             eq "article"
+      expect(object.og.description).to      eq "The European Parliament and EU member states have agreed that new cars must be fitted with an automated system to alert emergency services in event of a crash."
+      expect(object.og.site_name).to        eq "BBC News"
+      expect(object.og.url).to              eq "http://www.bbc.co.uk/news/technology-30337272"
+      expect(object.og.image.url).to        eq "http://news.bbcimg.co.uk/media/images/79520000/jpg/_79520623_79519885.jpg"
+    end
+
+    it "does not parse in strict mode (2)" do
+      OpenGraphReader.config.strict = true
+
+      expect {
+        OpenGraphReader.parse! fixture_html 'real_world/undefined_property_2'
+      }.to raise_error OpenGraphReader::InvalidObjectError, /Undefined property/
+    end
   end
 
   describe "unknown_namespace" do
@@ -118,4 +138,42 @@ RSpec.describe "real world examples" do
       }.to raise_error OpenGraphReader::InvalidObjectError, /is not a registered namespace/
     end
   end
+
+
+  describe "missing_title" do
+    it "does not parse" do
+      expect {
+        OpenGraphReader.parse! fixture_html 'real_world/missing_title'
+      }.to raise_error OpenGraphReader::InvalidObjectError, /Missing required/
+    end
+
+    it "does parse when synthesizing titles" do
+      OpenGraphReader.config.synthesize_title = true
+
+      object = OpenGraphReader.parse! fixture_html 'real_world/missing_title'
+
+      expect(object.og.type).to      eq "website"
+      expect(object.og.title).to     eq "Ultra Conservative Christian Lady Goes To Museum, Tries To Debunk Evolution, Fails Beyond Miserably | Geekologie"
+      expect(object.og.image.url).to eq "http://geekologie.com/assets_c/2014/11/crazy-lady-goes-to-the-museum-thumb-640x389-29314.jpg"
+    end
+  end
+
+  describe "image_path" do
+    it "does not parse" do
+      expect {
+        OpenGraphReader.parse! fixture_html 'real_world/image_path'
+      }.to raise_error OpenGraphReader::InvalidObjectError, /does not start with/
+    end
+
+    it "parses with image paths turned on" do
+      OpenGraphReader.config.synthesize_image_url = true
+
+      object = OpenGraphReader.parse! fixture_html('real_world/image_path'), 'http://fritzing.org/download/'
+
+      expect(object.og.title).to     eq "Fritzing"
+      expect(object.og.type).to      eq "website"
+      expect(object.og.image.url).to eq "http://fritzing.org/static/img/fritzing.png"
+      expect(object.og.url).to       eq "http://fritzing.org/"
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: open_graph_reader
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Jonne Haß
@@ -165,11 +165,14 @@ files:
 - spec/fixtures/examples/video-array.html
 - spec/fixtures/examples/video-movie.html
 - spec/fixtures/examples/video.html
+- spec/fixtures/real_world/image_path.html
 - spec/fixtures/real_world/missing_image.html
+- spec/fixtures/real_world/missing_title.html
 - spec/fixtures/real_world/mixed_case_properties.html
 - spec/fixtures/real_world/mixed_case_type.html
 - spec/fixtures/real_world/not_a_reference.html
 - spec/fixtures/real_world/undefined_property.html
+- spec/fixtures/real_world/undefined_property_2.html
 - spec/fixtures/real_world/unknown_namespace.html
 - spec/fixtures/real_world/unknown_type.html
 - spec/integration/invalid_examples_spec.rb
@@ -249,11 +252,14 @@ test_files:
 - spec/fixtures/examples/video-array.html
 - spec/fixtures/examples/video-movie.html
 - spec/fixtures/examples/video.html
+- spec/fixtures/real_world/image_path.html
 - spec/fixtures/real_world/missing_image.html
+- spec/fixtures/real_world/missing_title.html
 - spec/fixtures/real_world/mixed_case_properties.html
 - spec/fixtures/real_world/mixed_case_type.html
 - spec/fixtures/real_world/not_a_reference.html
 - spec/fixtures/real_world/undefined_property.html
+- spec/fixtures/real_world/undefined_property_2.html
 - spec/fixtures/real_world/unknown_namespace.html
 - spec/fixtures/real_world/unknown_type.html
 - spec/integration/invalid_examples_spec.rb