open_graph_reader 0.1.0 → 0.2.0

data/spec/integration/invalid_examples_spec.rb

@@ -11,8 +11,25 @@ RSpec.describe "invalid examples" do
     end
   end
 
+  # Most parsers synthesize missing required properties, however
+  # we do not (yet), making this example an invalid object
+  describe "min" do
+    it "has missing required properties" do
+      expect {
+        OpenGraphReader.parse! example_html 'min'
+      }.to raise_error OpenGraphReader::InvalidObjectError, /Missing required/
+    end
+
+    it "returns what's there if required property validation is disabled" do
+      OpenGraphReader.config.validate_required = false
+      object = OpenGraphReader.parse! example_html 'min'
+      expect(object.og.site_name).to   eq "Open Graph protocol examples"
+      expect(object.og.description).to eq "Content not on page"
+    end
+  end
+
   describe "filters/xss-image" do
-    it "errors on the invaid URL" do
+    it "errors on the invaid URL in strict mode" do
       expect {
         OpenGraphReader.parse! example_html 'filters/xss-image'
       }.to raise_error OpenGraphReader::InvalidObjectError, /does not start with http/
@@ -44,19 +61,41 @@ RSpec.describe "invalid examples" do
   end
 
   describe "errors/geo" do
-    it "doesn't recognize the old elements" do
+    it "doesn't recognize the old elements in strict mode" do
+      OpenGraphReader.config.strict = true
+
       expect {
         OpenGraphReader.parse! example_html 'errors/geo'
       }.to raise_error OpenGraphReader::InvalidObjectError, /Undefined property/
     end
+
+    it "parses in default mode" do
+      object = OpenGraphReader.parse! example_html 'errors/geo'
+
+      expect(object.og.type).to      eq "website"
+      expect(object.og.title).to     eq "Open Graph protocol 1.0 location data"
+      expect(object.og.url).to       eq "http://examples.opengraphprotocol.us/errors/geo.html"
+      expect(object.og.image.url).to eq "http://examples.opengraphprotocol.us/media/images/50.png"
+    end
   end
 
   describe "errors/type" do
-    it "doesn't handle the unkown type" do
+    it "doesn't handle the unknown type in strict mode" do
+      OpenGraphReader.config.strict = true
+
       expect {
         OpenGraphReader.parse! example_html 'errors/type'
       }.to raise_error OpenGraphReader::InvalidObjectError, /Undefined type/
     end
+
+    it "parses the known properties" do
+      object = OpenGraphReader.parse! example_html 'errors/type'
+
+      expect(object.og.type).to      eq "fubar"
+      expect(object.og.title).to     eq "Undefined global type"
+      expect(object.og.url).to       eq "http://examples.opengraphprotocol.us/errors/type.html"
+      expect(object.og.image.url).to eq "http://examples.opengraphprotocol.us/media/images/50.png"
+    end
   end
 
   describe "errors/video-duration" do

data/spec/integration/real_world_spec.rb

@@ -0,0 +1,121 @@
+require 'spec_helper'
+
+RSpec.describe "real world examples" do
+  describe "mixed_case_properties" do
+    it "parses" do
+      expect {
+        OpenGraphReader.parse! fixture_html 'real_world/mixed_case_properties'
+      }.to_not raise_error
+    end
+
+    it "assigns the right attributes" do
+      object = OpenGraphReader.parse fixture_html 'real_world/mixed_case_properties'
+
+      expect(object.og.title).to       eq "Eine Million Unterschriften gegen TTIP"
+      expect(object.og.type).to        eq "website"
+      expect(object.og.locale.to_s).to eq "de_DE"
+      expect(object.og.url).to         eq "http://www.heise.de/tp/artikel/43/43516/"
+      expect(object.og.site_name).to   eq "Telepolis"
+      expect(object.og.image.url).to   eq "http://www.heise.de/tp/artikel/43/43516/43516_1.jpg"
+      expect(object.og.description).to eq "Ungenehmigte Bürgerinitiative will das Paket EU-Kommissionschef Juncker zum Geburtstag schenken"
+    end
+  end
+
+  describe "missing_image" do
+    it "does not parse" do
+      expect {
+        OpenGraphReader.parse! fixture_html 'real_world/missing_image'
+      }.to raise_error OpenGraphReader::InvalidObjectError, /Missing required/
+    end
+  end
+
+  describe "mixed_case_type" do
+    it "parses" do
+      expect {
+        OpenGraphReader.parse! fixture_html 'real_world/mixed_case_type'
+      }.to_not raise_error
+    end
+  end
+
+  describe "not_a_reference" do
+    it "does not parse" do
+      expect {
+        OpenGraphReader.parse! fixture_html 'real_world/not_a_reference'
+      }.to raise_error OpenGraphReader::InvalidObjectError, /does not start with/
+    end
+
+    it "parses with reference validation turned of" do
+      OpenGraphReader.config.validate_references = false
+      object = OpenGraphReader.parse! fixture_html 'real_world/not_a_reference'
+
+      expect(object.og.title).to            eq "Emergency call system for all new cars by 2018"
+      expect(object.og.type).to             eq "article"
+      expect(object.og.description).to      eq "The European Parliament and EU member states have agreed that new cars must be fitted with an automated system to alert emergency services in event of a crash."
+      expect(object.og.site_name).to        eq "BBC News"
+      expect(object.og.url).to              eq "http://www.bbc.co.uk/news/technology-30337272"
+      expect(object.og.image.url).to        eq "http://news.bbcimg.co.uk/media/images/79520000/jpg/_79520623_79519885.jpg"
+      expect(object.article.author.to_s).to eq "BBC News"
+      expect(object.article.section).to     eq "Technology"
+    end
+  end
+
+  describe "unknown_type" do
+    it "parses" do
+      object = OpenGraphReader.parse! fixture_html 'real_world/unknown_type'
+
+      expect(object.og.url).to         eq "http://www.instructables.com/id/Building-the-Open-Knit-machine/"
+      expect(object.og.title).to       eq "Building the OpenKnit machine"
+      expect(object.og.image.url).to   eq "http://cdn.instructables.com/FI2/D7XW/I2XTQWFE/FI2D7XWI2XTQWFE.RECTANGLE1.jpg"
+      expect(object.og.description).to eq "The OpenKnit machine is an open-source, low cost, digital fabrication tool developed by Gerard Rubio.  The machine affords the user the opportunity to..."
+    end
+
+    it "does not parse in strict mode" do
+      OpenGraphReader.config.strict = true
+
+      expect {
+        OpenGraphReader.parse! fixture_html 'real_world/unknown_type'
+      }.to raise_error OpenGraphReader::InvalidObjectError, /Undefined type/
+    end
+  end
+
+  describe "undefined_property" do
+    it "parses" do
+      object = OpenGraphReader.parse! fixture_html 'real_world/undefined_property'
+
+      expect(object.og.locale.to_s).to eq "es_ES"
+      expect(object.og.type).to        eq "article"
+      expect(object.og.title).to       eq "Profesores y campesinos amarran a infiltrados en marcha"
+      expect(object.og.description).to eq "Regeneración, 6 de diciembre de 2014.-Durante la marcha que realizan profesores y organizaciones campesinas sobre avenida Paseo de la Reforma, maestros de la Coordinadora Estatal de Trabajadores de la Educación en Guerrero (CETEG) ubicaron a 12 jóvenes como “infiltrados”, a quienes amarraron de las manos en una cadena humana para evitar que marchen con ellos, informó El …"
+      expect(object.og.url).to         eq "http://regeneracion.mx/sociedad/profesores-y-campesinos-amarran-a-infiltrados-en-marcha/"
+      expect(object.og.site_name).to   eq "Regeneración"
+      expect(object.og.image.url).to   eq "http://regeneracion.mx/wp-content/uploads/2014/12/Infiltrados.jpg"
+    end
+
+    it "does not parse in strict mode" do
+      OpenGraphReader.config.strict = true
+
+      expect {
+        OpenGraphReader.parse! fixture_html 'real_world/undefined_property'
+      }.to raise_error OpenGraphReader::InvalidObjectError, /Undefined property/
+    end
+  end
+
+  describe "unknown_namespace" do
+    it "parses" do
+      object = OpenGraphReader.parse! fixture_html 'real_world/unknown_namespace'
+
+      expect(object.og.url).to         eq "http://www.instructables.com/id/Building-the-Open-Knit-machine/"
+      expect(object.og.title).to       eq "Building the OpenKnit machine"
+      expect(object.og.image.url).to   eq "http://cdn.instructables.com/FI2/D7XW/I2XTQWFE/FI2D7XWI2XTQWFE.RECTANGLE1.jpg"
+      expect(object.og.description).to eq "The OpenKnit machine is an open-source, low cost, digital fabrication tool developed by Gerard Rubio.  The machine affords the user the opportunity to..."
+    end
+
+    it "does not parse in strict mode" do
+      OpenGraphReader.config.strict = true
+
+      expect {
+        OpenGraphReader.parse! fixture_html 'real_world/unknown_namespace'
+      }.to raise_error OpenGraphReader::InvalidObjectError, /is not a registered namespace/
+    end
+  end
+end

data/spec/integration/valid_examples_spec.rb

@@ -15,7 +15,6 @@ RSpec.describe 'valid examples' do
     image-url
     image
     index
-    min
     nomedia
     profile
     required

data/spec/spec_helper.rb

@@ -27,9 +27,17 @@ RSpec.configure do |config|
 
   config.order = :random
   Kernel.srand config.seed
+
+  config.after(:each) do
+    OpenGraphReader.config.reset_to_defaults!
+  end
 end
 
 
 def example_html example
-  File.read File.expand_path("./fixtures/examples/#{example}.html", __dir__)
+  fixture_html "examples/#{example}"
+end
+
+def fixture_html fixture
+  File.read File.expand_path("./fixtures/#{fixture}.html", __dir__)
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: open_graph_reader
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Jonne Haß
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-06 00:00:00.000000000 Z
+date: 2014-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -108,6 +108,7 @@ files:
 - lib/open_graph_reader.rb
 - lib/open_graph_reader/base.rb
 - lib/open_graph_reader/builder.rb
+- lib/open_graph_reader/configuration.rb
 - lib/open_graph_reader/definitions.rb
 - lib/open_graph_reader/fetcher.rb
 - lib/open_graph_reader/object.rb
@@ -164,11 +165,19 @@ files:
 - spec/fixtures/examples/video-array.html
 - spec/fixtures/examples/video-movie.html
 - spec/fixtures/examples/video.html
+- spec/fixtures/real_world/missing_image.html
+- spec/fixtures/real_world/mixed_case_properties.html
+- spec/fixtures/real_world/mixed_case_type.html
+- spec/fixtures/real_world/not_a_reference.html
+- spec/fixtures/real_world/undefined_property.html
+- spec/fixtures/real_world/unknown_namespace.html
+- spec/fixtures/real_world/unknown_type.html
 - spec/integration/invalid_examples_spec.rb
+- spec/integration/real_world_spec.rb
 - spec/integration/valid_examples_spec.rb
 - spec/open_graph_reader_spec.rb
 - spec/spec_helper.rb
-homepage: https://github.com/jhass/opengraph_reader
+homepage: https://github.com/jhass/open_graph_reader
 licenses:
 - MIT
 metadata: {}
@@ -240,7 +249,15 @@ test_files:
 - spec/fixtures/examples/video-array.html
 - spec/fixtures/examples/video-movie.html
 - spec/fixtures/examples/video.html
+- spec/fixtures/real_world/missing_image.html
+- spec/fixtures/real_world/mixed_case_properties.html
+- spec/fixtures/real_world/mixed_case_type.html
+- spec/fixtures/real_world/not_a_reference.html
+- spec/fixtures/real_world/undefined_property.html
+- spec/fixtures/real_world/unknown_namespace.html
+- spec/fixtures/real_world/unknown_type.html
 - spec/integration/invalid_examples_spec.rb
+- spec/integration/real_world_spec.rb
 - spec/integration/valid_examples_spec.rb
 - spec/open_graph_reader_spec.rb
 - spec/spec_helper.rb