open_exchange_rates 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b408da323d340240c7e8f2e3ef5492450c191374a2dcec160312f5a00e82d8b6
-  data.tar.gz: 3ca452d8c8d987e4381639af769684a85a7fcf2c484e3c757eda586bea5e08e5
+  metadata.gz: be2fae1e12c458efcb3c1059426aec3b923c4d13f933e95c48aeec6f59adeb78
+  data.tar.gz: 4c434c733a556a65d2cc0ae80e81be584c09d06f7d4b21ea4b102e4e631bfac6
 SHA512:
-  metadata.gz: 8a19772242da9aa04bf74716d682a72487bf3fa10ebfd4fa7d473c711a4b49c07efe713d15b9a99af48f962fe4bf17d221a02f5507c5ddcf10860e1fc07785f1
-  data.tar.gz: 67477660c6bcf803e3359af89bab4f85c125e9dc9b8621c93bca666b941f351531122ec8ed25949b2ada918ae50d0d221b0d248c787a7c62cdf938e73edcea20
+  metadata.gz: d33b6c67b4d67be6d77c99f0396c53fd84f85f00126260a72a5eb9f7ce9393ce32754fa2658fa760f75f2197b3f8b7404c2dd08177272b04f0e4e8267db2057d
+  data.tar.gz: 69c93f940c07296fa75c0b00c32dbb390c763c103fc411232d532a8d23318880aa0d40b712d7534e6019db2f3b31b51b3605e58923e8dd158569249b1e604766

data/lib/open_exchange_rates/rates.rb

@@ -1,5 +1,6 @@
 require "open-uri"
 require "date"
+require "json"
 
 module OpenExchangeRates
   class Rates
@@ -90,13 +91,13 @@ module OpenExchangeRates
     end
 
     def parse_latest
-      @latest_parser ||= OpenExchangeRates::Parser.new
-      @latest_parser.parse(URI.open("#{OpenExchangeRates::LATEST_URL}?app_id=#{@app_id}"))
+      json = URI.open("#{OpenExchangeRates::LATEST_URL}?app_id=#{@app_id}").read
+      JSON.parse(json)
     end
 
     def parse_on(date_string)
-      @on_parser = OpenExchangeRates::Parser.new
-      @on_parser.parse(URI.open("#{OpenExchangeRates::BASE_URL}/historical/#{date_string}.json?app_id=#{@app_id}"))
+      json = URI.open("#{OpenExchangeRates::BASE_URL}/historical/#{date_string}.json?app_id=#{@app_id}").read
+      JSON.parse(json)
     end
 
   end

data/lib/open_exchange_rates/version.rb

@@ -1,3 +1,3 @@
 module OpenExchangeRates
-  VERSION = "0.6.0"
+  VERSION = "0.6.1"
 end

data/lib/open_exchange_rates.rb

@@ -1,7 +1,6 @@
 require "rubygems"
 require "open_exchange_rates/version"
 require "open_exchange_rates/configuration"
-require "open_exchange_rates/parser"
 require "open_exchange_rates/response"
 require "open_exchange_rates/rates"
 

data/open_exchange_rates.gemspec

@@ -16,9 +16,7 @@ Gem::Specification.new do |gem|
   gem.version       = OpenExchangeRates::VERSION
   gem.license       = "MIT"
 
-  gem.add_dependency('yajl-ruby')
-
-  gem.add_development_dependency('rr')
+  gem.add_development_dependency('minitest')
   gem.add_development_dependency('rake')
   gem.add_development_dependency('dotenv')
 end

data/test/rates_test.rb

@@ -1,17 +1,12 @@
 require "test_helper"
 require 'complex'
+require 'json'
 
-class TestOpenExchangeRates < Test::Unit::TestCase
-
+class TestOpenExchangeRates < Minitest::Test
   def test_app_id_is_required
-    assert_nothing_raised { OpenExchangeRates::Rates.new }
-
-    stub(OpenExchangeRates.configuration).app_id { nil }
-    assert_raise(OpenExchangeRates::Rates::MissingAppIdError) { OpenExchangeRates::Rates.new }
-
-    assert_nothing_raised { OpenExchangeRates::Rates.new(:app_id => "myappid") }
-
-    OpenExchangeRates.configuration.app_id = ENV['OPEN_EXCHANGE_RATES_APP_ID']
+    OpenExchangeRates.configuration.stub(:app_id, nil) do
+      assert_raises(OpenExchangeRates::Rates::MissingAppIdError) { OpenExchangeRates::Rates.new }
+    end
   end
 
   def test_app_id_configuration
@@ -24,129 +19,129 @@ class TestOpenExchangeRates < Test::Unit::TestCase
     fx = OpenExchangeRates::Rates.new
     assert_equal "myappid", fx.app_id
 
-    fx = OpenExchangeRates::Rates.new(:app_id => 'myotherappid')
+    fx = OpenExchangeRates::Rates.new(app_id: 'myotherappid')
     assert_equal "myotherappid", fx.app_id
 
     OpenExchangeRates.configuration.app_id = ENV['OPEN_EXCHANGE_RATES_APP_ID']
   end
 
   def test_invalid_app_id_raise_error
-    stub(OpenExchangeRates.configuration).app_id { "somethingstupid" }
-    fx = OpenExchangeRates::Rates.new
+    OpenExchangeRates.configuration.stub(:app_id, "invalid-app-id") do
+      fx = OpenExchangeRates::Rates.new
 
-    assert_raise OpenURI::HTTPError do
-      fx.exchange_rate(:from => "USD", :to => "EUR")
+      assert_raises OpenURI::HTTPError do
+        fx.exchange_rate(:from => "USD", :to => "EUR")
+      end
     end
   end
 
   def test_exchange_rate
     fx = OpenExchangeRates::Rates.new
-    stub(fx).parse_latest { OpenExchangeRates::Parser.new.parse(open_asset("latest.json")) }
-
-    # 1 USD = 6.0995 HRK
-    # 1 USD = 1.026057 AUD
-    assert_equal 1, fx.exchange_rate(:from => "USD", :to => "USD")
-    assert_equal 1, fx.exchange_rate(:from => "AUD", :to => "AUD")
-    assert_equal 1, fx.exchange_rate(:from => "HRK", :to => "HRK")
+    fx.stub(:parse_latest, parse_asset("latest.json")) do
+      # 1 USD = 6.0995 HRK
+      # 1 USD = 1.026057 AUD
+      assert_equal 1, fx.exchange_rate(:from => "USD", :to => "USD")
+      assert_equal 1, fx.exchange_rate(:from => "AUD", :to => "AUD")
+      assert_equal 1, fx.exchange_rate(:from => "HRK", :to => "HRK")
 
-    assert_equal 6.0995, fx.exchange_rate(:from => "USD", :to => "HRK")
-    assert_equal 1.026057, fx.exchange_rate(:from => "USD", :to => "AUD")
+      assert_equal 6.0995, fx.exchange_rate(:from => "USD", :to => "HRK")
+      assert_equal 1.026057, fx.exchange_rate(:from => "USD", :to => "AUD")
 
-    assert_equal 0.163948, fx.exchange_rate(:from => "HRK", :to => "USD")
-    assert_equal 0.974605, fx.exchange_rate(:from => "AUD", :to => "USD")
+      assert_equal 0.163948, fx.exchange_rate(:from => "HRK", :to => "USD")
+      assert_equal 0.974605, fx.exchange_rate(:from => "AUD", :to => "USD")
 
-    assert_equal 5.944602, fx.exchange_rate(:from => "AUD", :to => "HRK")
-    assert_equal 0.168220, fx.exchange_rate(:from => "HRK", :to => "AUD")
+      assert_equal 5.944602, fx.exchange_rate(:from => "AUD", :to => "HRK")
+      assert_equal 0.168220, fx.exchange_rate(:from => "HRK", :to => "AUD")
 
-    assert_equal 0.00023, fx.exchange_rate(:from => 'SLL', to: 'USD')
-    assert_equal 4350, fx.exchange_rate(:from => 'USD', to: 'SLL')
+      assert_equal 0.00023, fx.exchange_rate(:from => 'SLL', to: 'USD')
+      assert_equal 4350, fx.exchange_rate(:from => 'USD', to: 'SLL')
+    end
   end
 
   def test_exchange_rate_on_specific_date
     fx = OpenExchangeRates::Rates.new
-    stub(fx).parse_on { OpenExchangeRates::Parser.new.parse(open_asset("2012-05-10.json")) }
-
-    # 1 USD = 5.80025 HRK
-    # 1 USD = 0.99458 AUD
-    assert_equal 1, fx.exchange_rate(:from => "USD", :to => "USD", :on => "2012-05-10")
-    assert_equal 1, fx.exchange_rate(:from => "AUD", :to => "AUD", :on => "2012-05-10")
-    assert_equal 1, fx.exchange_rate(:from => "HRK", :to => "HRK", :on => "2012-05-10")
+    fx.stub(:parse_on, parse_asset("2012-05-10.json")) do
+      # 1 USD = 5.80025 HRK
+      # 1 USD = 0.99458 AUD
+      assert_equal 1, fx.exchange_rate(:from => "USD", :to => "USD", :on => "2012-05-10")
+      assert_equal 1, fx.exchange_rate(:from => "AUD", :to => "AUD", :on => "2012-05-10")
+      assert_equal 1, fx.exchange_rate(:from => "HRK", :to => "HRK", :on => "2012-05-10")
 
-    assert_equal 5.80025, fx.exchange_rate(:from => "USD", :to => "HRK", :on => "2012-05-10")
-    assert_equal 0.99458, fx.exchange_rate(:from => "USD", :to => "AUD", :on => "2012-05-10")
+      assert_equal 5.80025, fx.exchange_rate(:from => "USD", :to => "HRK", :on => "2012-05-10")
+      assert_equal 0.99458, fx.exchange_rate(:from => "USD", :to => "AUD", :on => "2012-05-10")
 
-    assert_equal 0.172406, fx.exchange_rate(:from => "HRK", :to => "USD", :on => "2012-05-10")
-    assert_equal 1.005450, fx.exchange_rate(:from => "AUD", :to => "USD", :on => "2012-05-10")
+      assert_equal 0.172406, fx.exchange_rate(:from => "HRK", :to => "USD", :on => "2012-05-10")
+      assert_equal 1.005450, fx.exchange_rate(:from => "AUD", :to => "USD", :on => "2012-05-10")
 
-    assert_equal 5.831859, fx.exchange_rate(:from => "AUD", :to => "HRK", :on => "2012-05-10")
-    assert_equal 0.171472, fx.exchange_rate(:from => "HRK", :to => "AUD", :on => "2012-05-10")
+      assert_equal 5.831859, fx.exchange_rate(:from => "AUD", :to => "HRK", :on => "2012-05-10")
+      assert_equal 0.171472, fx.exchange_rate(:from => "HRK", :to => "AUD", :on => "2012-05-10")
+    end
   end
 
   def test_exchange_rate_on_specific_date_specified_by_date_class
     fx = OpenExchangeRates::Rates.new
-    stub(fx).parse_on { OpenExchangeRates::Parser.new.parse(open_asset("2012-05-10.json")) }
-
-    assert_equal 1, fx.exchange_rate(:from => "USD", :to => "USD", :on => Date.new(2012,05,10))
+    fx.stub(:parse_on, parse_asset("2012-05-10.json")) do
+      assert_equal 1, fx.exchange_rate(:from => "USD", :to => "USD", :on => Date.new(2012,05,10))
+    end
   end
 
   def test_exchange_requires_valid_date
     fx = OpenExchangeRates::Rates.new
 
-    assert_raise ArgumentError do
-      fx.exchange_rate(:from => "USD", :to => "USD", :on => "somethingstupid")
+    assert_raises ArgumentError do
+      fx.exchange_rate(:from => "USD", :to => "USD", :on => "invalid-date")
     end
-
-    assert_raise ArgumentError do
+    assert_raises ArgumentError do
       fx.exchange_rate(:from => "USD", :to => "USD", :on => Complex(0.3))
     end
   end
 
   def test_convert
     fx = OpenExchangeRates::Rates.new
-    stub(fx).parse_latest { OpenExchangeRates::Parser.new.parse(open_asset("latest.json")) }
-
-    # 1 USD = 6.0995 HRK
-    # 1 USD = 1.026057 AUD
-    assert_equal 609.95, fx.convert(100, :from => "USD", :to => "HRK")
-    assert_equal 16.39, fx.convert(100, :from => "HRK", :to => "USD")
-    assert_equal 120.32, fx.convert(123.4567, :from => "AUD", :to => "USD")
-    assert_equal 733.90, fx.convert(123.4567, :from => "AUD", :to => "HRK")
-    assert_equal 20.77, fx.convert(123.4567, :from => "HRK", :to => "AUD")
+    fx.stub(:parse_latest, parse_asset("latest.json")) do
+      # 1 USD = 6.0995 HRK
+      # 1 USD = 1.026057 AUD
+      assert_equal 609.95, fx.convert(100, :from => "USD", :to => "HRK")
+      assert_equal 16.39, fx.convert(100, :from => "HRK", :to => "USD")
+      assert_equal 120.32, fx.convert(123.4567, :from => "AUD", :to => "USD")
+      assert_equal 733.90, fx.convert(123.4567, :from => "AUD", :to => "HRK")
+      assert_equal 20.77, fx.convert(123.4567, :from => "HRK", :to => "AUD")
+    end
   end
 
   def test_convert_on_specific_date
     fx = OpenExchangeRates::Rates.new
-    stub(fx).parse_on { OpenExchangeRates::Parser.new.parse(open_asset("2012-05-10.json")) }
-
-    # 1 USD = 5.80025 HRK
-    # 1 USD = 0.99458 AUD
-    assert_equal 580.03, fx.convert(100, :from => "USD", :to => "HRK", :on => "2012-10-05")
-    assert_equal 17.24, fx.convert(100, :from => "HRK", :to => "USD", :on => "2012-10-05")
-    assert_equal 124.13, fx.convert(123.4567, :from => "AUD", :to => "USD", :on => "2012-10-05")
-    assert_equal 719.98, fx.convert(123.4567, :from => "AUD", :to => "HRK", :on => "2012-10-05")
-    assert_equal 21.17, fx.convert(123.4567, :from => "HRK", :to => "AUD", :on => "2012-10-05")
+    fx.stub(:parse_on, parse_asset("2012-05-10.json")) do
+      # 1 USD = 5.80025 HRK
+      # 1 USD = 0.99458 AUD
+      assert_equal 580.03, fx.convert(100, :from => "USD", :to => "HRK", :on => "2012-10-05")
+      assert_equal 17.24, fx.convert(100, :from => "HRK", :to => "USD", :on => "2012-10-05")
+      assert_equal 124.13, fx.convert(123.4567, :from => "AUD", :to => "USD", :on => "2012-10-05")
+      assert_equal 719.98, fx.convert(123.4567, :from => "AUD", :to => "HRK", :on => "2012-10-05")
+      assert_equal 21.17, fx.convert(123.4567, :from => "HRK", :to => "AUD", :on => "2012-10-05")
+    end
   end
 
   def test_convert_if_from_option_is_missing
     fx = OpenExchangeRates::Rates.new
-    stub(fx).parse_latest { OpenExchangeRates::Parser.new.parse(open_asset("latest.json")) }
-
-    # from defaults to base currency (USD)
-    # 1 USD = 6.0995 HRK
-    # 1 USD = 1.026057 AUD
-    assert_equal 609.95, fx.convert(100, :to => "HRK")
-    assert_equal 102.61, fx.convert(100, :to => "AUD")
+    fx.stub(:parse_latest, parse_asset("latest.json")) do
+      # from defaults to base currency (USD)
+      # 1 USD = 6.0995 HRK
+      # 1 USD = 1.026057 AUD
+      assert_equal 609.95, fx.convert(100, :to => "HRK")
+      assert_equal 102.61, fx.convert(100, :to => "AUD")
+    end
   end
 
   def test_convert_if_to_option_is_missing
     fx = OpenExchangeRates::Rates.new
-    stub(fx).parse_latest { OpenExchangeRates::Parser.new.parse(open_asset("latest.json")) }
-
-    # to defaults to base currency (USD)
-    # 1 USD = 6.0995 HRK
-    # 1 USD = 1.026057 AUD
-    assert_equal 16.39, fx.convert(100, :from => "HRK")
-    assert_equal 97.46, fx.convert(100, :from => "AUD")
+    fx.stub(:parse_latest, parse_asset("latest.json")) do
+      # to defaults to base currency (USD)
+      # 1 USD = 6.0995 HRK
+      # 1 USD = 1.026057 AUD
+      assert_equal 16.39, fx.convert(100, :from => "HRK")
+      assert_equal 97.46, fx.convert(100, :from => "AUD")
+    end
   end
 
   def test_latest
@@ -157,23 +152,23 @@ class TestOpenExchangeRates < Test::Unit::TestCase
     assert_equal "USD", latest_rates.base
     assert latest_rates.rates.is_a?(Hash)
 
-    stub(fx).parse_latest { OpenExchangeRates::Parser.new.parse(open_asset("latest.json")) }
-
-    # latest results are cached
-    cached_rates = fx.latest
-    assert_equal latest_rates.rates["USD"], cached_rates.rates["USD"]
-    assert_equal latest_rates.rates["AUD"], cached_rates.rates["AUD"]
-    assert_equal latest_rates.rates["HRK"], cached_rates.rates["HRK"]
-
-    # latest results are reloaded
-    stubbed_rates = fx.latest(:reload)
-    assert_equal latest_rates.rates["USD"], stubbed_rates.rates["USD"]
-    assert_not_equal latest_rates.rates["AUD"], stubbed_rates.rates["AUD"]
-    assert_not_equal latest_rates.rates["HRK"], stubbed_rates.rates["HRK"]
-
-    assert_equal 1, stubbed_rates.rates["USD"]
-    assert_equal 1.026057, stubbed_rates.rates["AUD"]
-    assert_equal 6.0995, stubbed_rates.rates["HRK"]
+    fx.stub(:parse_latest, parse_asset("latest.json")) do
+      # latest results are cached
+      cached_rates = fx.latest
+      assert_equal latest_rates.rates["USD"], cached_rates.rates["USD"]
+      assert_equal latest_rates.rates["AUD"], cached_rates.rates["AUD"]
+      assert_equal latest_rates.rates["HRK"], cached_rates.rates["HRK"]
+
+      # latest results are reloaded
+      stubbed_rates = fx.latest(:reload)
+      assert_equal latest_rates.rates["USD"], stubbed_rates.rates["USD"]
+      refute_equal latest_rates.rates["AUD"], stubbed_rates.rates["AUD"]
+      refute_equal latest_rates.rates["HRK"], stubbed_rates.rates["HRK"]
+
+      assert_equal 1, stubbed_rates.rates["USD"]
+      assert_equal 1.026057, stubbed_rates.rates["AUD"]
+      assert_equal 6.0995, stubbed_rates.rates["HRK"]
+    end
   end
 
   def test_on
@@ -197,29 +192,14 @@ class TestOpenExchangeRates < Test::Unit::TestCase
     assert_equal 12.3457, fx.round(12.345678, 4)
   end
 
-  def test_multiple_calls
-    fx = OpenExchangeRates::Rates.new
-
-    assert_nothing_raised do
-      fx.convert(123, :from => "EUR", :to => "AUD", :on => "2012-03-10")
-      fx.convert(100, :from => "USD", :to => "EUR")
-      fx.convert(123.45, :from => "EUR", :to => "USD", :on => "2012-04-10")
-      fx.convert(12, :from => "USD", :to => "EUR")
-      fx.convert(123.4567, :from => "EUR", :to => "USD", :on => "2012-05-10")
-      fx.exchange_rate(:from => "USD", :to => "EUR")
-      fx.exchange_rate(:from => "USD", :to => "EUR", :on => "2012-04-10")
-      fx.exchange_rate(:from => "USD", :to => "AUD", :on => "2012-05-10")
-    end
-  end
-
   def test_invalid_currency_code_fails_with_rate_not_found_error
     fx = OpenExchangeRates::Rates.new
 
-    assert_raise(OpenExchangeRates::Rates::RateNotFoundError) do
+    assert_raises(OpenExchangeRates::Rates::RateNotFoundError) do
       fx.exchange_rate(:from => "???", :to => "AUD", :on => "2012-05-10")
     end
 
-    assert_raise(OpenExchangeRates::Rates::RateNotFoundError) do
+    assert_raises(OpenExchangeRates::Rates::RateNotFoundError) do
       fx.exchange_rate(:from => "USD", :to => "???", :on => "2012-05-10")
     end
   end
@@ -230,8 +210,8 @@ private
     File.join(File.dirname(__FILE__), "assets")
   end
 
-  def open_asset(filename)
-    File.open("#{assets_root}/#{filename}")
+  def parse_asset(filename)
+    json = File.open("#{assets_root}/#{filename}").read
+    JSON.parse(json)
   end
-
 end

data/test/test_helper.rb

@@ -1,7 +1,6 @@
 require "rubygems"
-require "test/unit"
-require "rr"
 require 'dotenv'
+require "minitest/autorun"
 require "open_exchange_rates"
 
 # Pick up ENV variables from .env file if exists
@@ -9,5 +8,3 @@ Dotenv.load
 
 OpenExchangeRates.configuration.app_id = ENV['OPEN_EXCHANGE_RATES_APP_ID']
 
-class Test::Unit::TestCase
-end

metadata

@@ -1,31 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: open_exchange_rates
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Vlado Cingel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-11-19 00:00:00.000000000 Z
+date: 2022-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: yajl-ruby
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rr
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -84,7 +70,6 @@ files:
 - env.example
 - lib/open_exchange_rates.rb
 - lib/open_exchange_rates/configuration.rb
-- lib/open_exchange_rates/parser.rb
 - lib/open_exchange_rates/rates.rb
 - lib/open_exchange_rates/response.rb
 - lib/open_exchange_rates/version.rb

data/lib/open_exchange_rates/parser.rb

@@ -1,6 +0,0 @@
-require "yajl"
-
-module OpenExchangeRates
-  class Parser < Yajl::Parser
-  end
-end