open_exchange_rates 0.4.0 → 0.4.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: a144239c7adf3916dba057f3eb01743f02c3bea2
+  data.tar.gz: 97349586862a5cb230ada7866986a950ca415efe
+SHA512:
+  metadata.gz: d5968641119f615e0fe16a554fc659206c85037c5239bd42d469f7455007e29bc324596a2b7b265a19854cf0ca2d763b3cbaeb06be8ac1b07c8f28a603f9c00d
+  data.tar.gz: 3e7255bdb2b8ddda10c6c42c4428eba23c6d3230fd7b8a7dffe1ab57e56cdf8cefa86857565451c1cf6476253c9114408242dedb1fa6bc53143e4af41ae2a284

data/README.md

@@ -1,13 +1,13 @@
 # OpenExchangeRates
 
-[![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/vlado/open_exchange_rates)
+[![Code Climate](https://codeclimate.com/github/vlado/open_exchange_rates.png)](https://codeclimate.com/github/vlado/open_exchange_rates)
 [![Gem Version](https://badge.fury.io/rb/open_exchange_rates.png)](http://badge.fury.io/rb/open_exchange_rates)
 
 Ruby gem for currency conversion based on [Open Exchange Rates API](http://openexchangerates.org) - free / open source hourly-updated currency data for everybody
 
 ## Accuracy
 
-Please see [https://github.com/currencybot/open-exchange-rates/#accuracy](https://github.com/currencybot/open-exchange-rates/#accuracy) and/or [http://openexchangerates.org/documentation/#specification](http://openexchangerates.org/documentation/#specification)
+Please see [https://github.com/josscrowcroft/open-exchange-rates#accuracy](https://github.com/josscrowcroft/open-exchange-rates#accuracy)
 
 ## Installation
 
@@ -25,7 +25,7 @@ Or install it yourself as:
     
 ## Configuration
 
-You will need App ID to use OpenExchangeRates, you can get one for free [here](https://openexchangerates.org/signup/). Wanna know [why App ID is needed](http://www.josscrowcroft.com/2012/projects/open-exchange-rates-update-the-partys-not-over-it-just-got-a-little-too-noisy/).
+You will need App ID to use OpenExchangeRates, you can get one [here](https://openexchangerates.org/signup/) for [free](https://openexchangerates.org/signup/free). Wanna know [why App ID is needed](http://www.josscrowcroft.com/2012/projects/open-exchange-rates-update-the-partys-not-over-it-just-got-a-little-too-noisy/).
 
 **Option 1**
 
@@ -96,7 +96,15 @@ If you omit **:from** or **:to** option conversion will be related to base curre
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
 
+## Running tests
+
+1. Copy env.example to .env `cp env.example .env`
+2. Open `.env` and enter your API ID
+3. Run `rake`
+
+
 ## Licence and Terms
 
-Licence - [http://openexchangerates.org/license](http://openexchangerates.org/license)
-Terms - [http://openexchangerates.org/terms](http://openexchangerates.org/terms)
+This project rocks and uses MIT-LICENSE.
+
+Please check Open Exchange Rates API [license](http://openexchangerates.org/license) and [terms](http://openexchangerates.org/terms) also.

data/lib/open_exchange_rates/rates.rb

@@ -10,6 +10,13 @@ module OpenExchangeRates
       end
     end
 
+    class RateNotFoundError < StandardError
+      def initialize(from_curr, to_curr)
+        msg = "Rate not found for #{from_curr} => #{to_curr}"
+        super(msg)
+      end
+    end
+
     attr_reader :app_id
 
     def initialize(options = {})
@@ -32,6 +39,10 @@ module OpenExchangeRates
       from_curr = response.base_currency if from_curr.empty?
       to_curr = response.base_currency if to_curr.empty?
 
+      unless rates[from_curr] && rates[to_curr]
+        raise RateNotFoundError.new(from_curr, to_curr)
+      end
+
       if from_curr == to_curr
         rate = 1
       elsif from_curr == response.base_currency

data/lib/open_exchange_rates/version.rb

@@ -1,3 +1,3 @@
 module OpenExchangeRates
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

data/open_exchange_rates.gemspec

@@ -14,9 +14,11 @@ Gem::Specification.new do |gem|
   gem.name          = "open_exchange_rates"
   gem.require_paths = ["lib"]
   gem.version       = OpenExchangeRates::VERSION
+  gem.license       = "MIT"
 
   gem.add_dependency('yajl-ruby')
 
   gem.add_development_dependency('rr')
   gem.add_development_dependency('rake')
+  gem.add_development_dependency('dotenv')
 end

data/test/rates_test.rb

@@ -181,8 +181,8 @@ class TestOpenExchangeRates < Test::Unit::TestCase
     assert_equal "USD", on_rates.base
 
     assert_equal 1, on_rates.rates["USD"]
-    assert_equal 0.991118, on_rates.rates["AUD"]
-    assert_equal 5.795542, on_rates.rates["HRK"]
+    assert_equal 0.989596, on_rates.rates["AUD"]
+    assert_equal 5.793188, on_rates.rates["HRK"]
   end
 
   def test_round
@@ -209,6 +209,18 @@ class TestOpenExchangeRates < Test::Unit::TestCase
     end
   end
 
+  def test_invalid_currency_code_fails_with_rate_not_found_error
+    fx = OpenExchangeRates::Rates.new
+
+    assert_raise(OpenExchangeRates::Rates::RateNotFoundError) do
+      fx.exchange_rate(:from => "???", :to => "AUD", :on => "2012-05-10")
+    end
+
+    assert_raise(OpenExchangeRates::Rates::RateNotFoundError) do
+      fx.exchange_rate(:from => "USD", :to => "???", :on => "2012-05-10")
+    end
+  end
+
 private
 
   def assets_root

data/test/test_helper.rb

@@ -1,19 +1,13 @@
 require "rubygems"
 require "test/unit"
 require "rr"
+require 'dotenv'
 require "open_exchange_rates"
 
 # Pick up ENV variables from .env file if exists
-dot_env_file_path = File.expand_path("../../.env", __FILE__)
-if File.exist?(dot_env_file_path)
-  File.open(dot_env_file_path).each_line do |line|
-    key, value = line.strip.split("=")
-    ENV[key] = value unless key.nil? || value.nil?
-  end
-end
+Dotenv.load
 
 OpenExchangeRates.configuration.app_id = ENV['OPEN_EXCHANGE_RATES_APP_ID']
 
 class Test::Unit::TestCase
-  include RR::Adapters::TestUnit
-end
+end

metadata

@@ -1,75 +1,80 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: open_exchange_rates
-version: !ruby/object:Gem::Version 
-  hash: 15
-  prerelease: 
-  segments: 
-  - 0
-  - 4
-  - 0
-  version: 0.4.0
+version: !ruby/object:Gem::Version
+  version: 0.4.1
 platform: ruby
-authors: 
+authors:
 - Vlado Cingel
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2013-01-14 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2015-03-25 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: yajl-ruby
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: rr
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rr
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: dotenv
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id003
-description: Ruby library for Open Exchange Rates API - free / open source hourly-updated currency data for everybody
-email: 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Ruby library for Open Exchange Rates API - free / open source hourly-updated
+  currency data for everybody
+email:
 - vladocingel@gmail.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
-- .gitignore
+files:
+- ".gitignore"
 - Gemfile
 - LICENSE
 - README.md
@@ -87,39 +92,30 @@ files:
 - test/rates_test.rb
 - test/test_helper.rb
 homepage: https://github.com/vlado/open_exchange_rates
-licenses: []
-
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.8.12
+rubygems_version: 2.1.11
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Ruby library for Open Exchange Rates API
-test_files: 
+test_files:
 - test/assets/2012-05-10.json
 - test/assets/latest.json
 - test/rates_test.rb