open_dota_api 0.0.3 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 10283b2823ec6879ee2cbc78d3e7a17455a3a806
-  data.tar.gz: eff45f3ecc4dfef96d2d915fa2fee43a0ebfa606
+  metadata.gz: 46e4d4e73a745680d8a4c2e06fa6e300886ccb53
+  data.tar.gz: 60b2b5404aa7125b2a805c9a69bc59ae0ad949e1
 SHA512:
-  metadata.gz: 30840cf124f3c4ef6f24e862d222cab56dfe20e118b9bf262b7715e126172c3d97bdae6ea02dfbafe99d05d0068c6c894a6847904c5fe48b83e7f1e49e391566
-  data.tar.gz: f956ca55c5f2f13d14b3a613b2f8d28020d6680542ed4c71eddc0909aa93786d3970ce5ea92fc0f73c8e6dc7109403c8edc31c61832cf930428bff40d47e2ac9
+  metadata.gz: 6b2fac68e691847a93f71fdfa20e80dd3fab5aeeecc925600ce71076d396510f47fd7573e3e63ada57de605b9874cbd2cecd74f6e6d9e9e1e467f7da4c233777
+  data.tar.gz: c9d7a4c6122c944e09569c69e7f608b3f8ea6f4de9f770d4b3b3a812e1af89dd5acdebfb9a8678b36bd46da945a74434944794334ce3f10660cf44a1dd161d5a

data/Rakefile

@@ -0,0 +1,6 @@
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+
+task default: :spec

data/lib/open_dota_api.rb

@@ -1,4 +1,5 @@
 require 'open_dota_api/client'
+require 'open_dota_api/version'
 
 module OpenDotaApi
   extend SingleForwardable

data/lib/open_dota_api/entity.rb

@@ -3,8 +3,15 @@ require 'hashable'
 
 module OpenDotaApi
   class Entity
+    include Entities::Instantiatable
     include ::Hashable
 
+    def self.define_adder(attributes)
+      attributes.each do |attribute|
+        define_method(attribute) { data[attribute] }
+      end
+    end
+
     def initialize(data)
       @data = data
     end

data/lib/open_dota_api/hero.rb

@@ -2,36 +2,7 @@ require 'open_dota_api/entity'
 
 module OpenDotaApi
   class Hero < Entity
-    include Entities::Instantiatable
-
     ENDPOINT = 'heroes'.freeze
-
-    def id
-      data['id']
-    end
-
-    def name
-      data['name']
-    end
-
-    def localized_name
-      data['localized_name']
-    end
-
-    def primary_attr
-      data['primary_attr']
-    end
-
-    def attack_type
-      data['attack_type']
-    end
-
-    def roles
-      data['roles']
-    end
-
-    def legs
-      data['legs']
-    end
+    define_adder(%w[id name localized_name primary_attr attack_type roles legs])
   end
 end

data/lib/open_dota_api/league.rb

@@ -2,8 +2,6 @@ require 'open_dota_api/entity'
 
 module OpenDotaApi
   class League < Entity
-    include Entities::Instantiatable
-
     ENDPOINT = 'leagues'.freeze
 
     def league_id

data/lib/open_dota_api/match.rb

@@ -5,6 +5,10 @@ module OpenDotaApi
   class Match < Entity
     ENDPOINT = 'matches'.freeze
 
+    def self.instantiate(_ = nil)
+      raise NotImplementedError
+    end
+
     def match_id
       data['match_id']
     end
@@ -62,7 +66,7 @@ module OpenDotaApi
     end
 
     def players
-      data['players'].map { |player| Player.new(player) }
+      Player.instantiate(data['players'])
     end
 
     class Player < Matches::Player; end

data/lib/open_dota_api/team.rb

@@ -2,36 +2,7 @@ require 'open_dota_api/entity'
 
 module OpenDotaApi
   class Team < Entity
-    include Entities::Instantiatable
-
     ENDPOINT = 'teams'.freeze
-
-    def team_id
-      data['team_id']
-    end
-
-    def rating
-      data['rating']
-    end
-
-    def wins
-      data['wins']
-    end
-
-    def losses
-      data['losses']
-    end
-
-    def last_match_time
-      data['last_match_time']
-    end
-
-    def name
-      data['name']
-    end
-
-    def tag
-      data['tag']
-    end
+    define_adder(%w[team_id rating wins losses last_match_time name tag])
   end
 end

data/lib/open_dota_api/version.rb

@@ -1,3 +1,3 @@
 module OpenDotaApi
-  VERSION = '0.0.3'.freeze
+  VERSION = '0.1.0'.freeze
 end

data/spec/lib/open_dota_api/match_spec.rb

@@ -30,8 +30,8 @@ describe OpenDotaApi::Match do
     expect(match).to be_a OpenDotaApi::Entity
   end
 
-  it 'is instantiable' do
-    expect(match).to_not be_a OpenDotaApi::Entities::Instantiatable
+  it 'is not instantiable' do
+    expect{ described_class.instantiate }.to raise_error NotImplementedError
   end
 
   describe 'default attributes' do

data/spec/lib/open_dota_api/matches/player_spec.rb

@@ -34,7 +34,7 @@ describe OpenDotaApi::Matches::Player do
   end
 
   it 'is instantiable' do
-    expect(player).to_not be_a OpenDotaApi::Entities::Instantiatable
+    expect(player).to be_a OpenDotaApi::Entities::Instantiatable
   end
 
   describe 'default attributes' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: open_dota_api
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.1.0
 platform: ruby
 authors:
 - Yaroslav Oslavskiy
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Ruby wrapper for Open Dota API
 email:
 - osyaroslav@gmail.com.com
@@ -116,6 +130,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - MIT-LICENSE
+- Rakefile
 - lib/open_dota_api.rb
 - lib/open_dota_api/client.rb
 - lib/open_dota_api/connection.rb
@@ -160,7 +175,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Ruby wrapper for Open Dota API