open3 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f1dc26c8d711ed9394d746ea2fad6222de3cce813178dfb2d1aa52eb4fc0432
-  data.tar.gz: 121bb5a4ee245b344004afdf1bdabf0af421c5acaa306b08de5ff62865a896c3
+  metadata.gz: b3ab5dfcb825c74af61129ee82254609322af777421f454eb90053875bdbc851
+  data.tar.gz: fdf3f7c0783de3763390a6e62a7ec984f262d61ca5d8906e186ad7e7deeff5d2
 SHA512:
-  metadata.gz: ccb106824f5e6a47f6cf4324bc7638af0ea27fda57b87da181fb32c60cec309590a6d828635bb27afbfb13b3113e857a1d23cf88665a1630eeb5ea4e4e2dfe2c
-  data.tar.gz: '0918ee950ed53eeed0b64b569034496953b5e788d937bac2fb30c1ee1608c645adc5cd1c76c1982e263a3ae999af23e0783648c48a08e7f3a14d9fe1f3331924'
+  metadata.gz: 3e3508856456efd5c0700447c9e122163ea490b32a7bd4cc09d2d4fa79639b53baac5b8f45d983e5185dd439c93cfba2b546c302569e1dccf6d4086c0a3b0858
+  data.tar.gz: a79fd57d1a714b793ecc3849231cf3d58fd07bcc962ffad144b98ec7443d8da1642e97ab10e6f251c720cc9d0cfe72a809fb71c0c915226fcbed0b2a1c607839

data/.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: 'github-actions'
+    directory: '/'
+    schedule:
+      interval: 'weekly'

data/.github/workflows/test-jruby.yml

@@ -0,0 +1,21 @@
+name: test
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    name: build (${{ matrix.ruby }} / ${{ matrix.os }})
+    strategy:
+      matrix:
+        ruby: [ 2.7, 2.6, head, jruby-9.3 ]
+        os: [ ubuntu-latest, macos-latest ]
+    runs-on: ${{ matrix.os }}
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true # 'bundle install' and cache
+    - name: Run test
+      run: bundle exec rake test

data/.github/workflows/test.yml

@@ -0,0 +1,21 @@
+name: test
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    name: build (${{ matrix.ruby }} / ${{ matrix.os }})
+    strategy:
+      matrix:
+        ruby: [ '3.0', 2.7, 2.6, head ]
+        os: [ ubuntu-latest, macos-latest ]
+    runs-on: ${{ matrix.os }}
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true # 'bundle install' and cache
+    - name: Run test
+      run: bundle exec rake test

data/Rakefile

@@ -7,4 +7,11 @@ Rake::TestTask.new(:test) do |t|
   t.test_files = FileList["test/**/test_*.rb"]
 end
 
+task :sync_tool do
+  require 'fileutils'
+  FileUtils.cp "../ruby/tool/lib/core_assertions.rb", "./test/lib"
+  FileUtils.cp "../ruby/tool/lib/envutil.rb", "./test/lib"
+  FileUtils.cp "../ruby/tool/lib/find_executable.rb", "./test/lib"
+end
+
 task :default => :test

data/lib/open3/jruby_windows.rb

@@ -0,0 +1,127 @@
+#
+# Custom implementation of Open3.popen{3,2,2e} that uses java.lang.ProcessBuilder rather than pipes and spawns.
+#
+
+require 'jruby' # need access to runtime for RubyStatus construction
+
+module Open3
+
+  java_import java.lang.ProcessBuilder
+  java_import org.jruby.RubyProcess
+  java_import org.jruby.util.ShellLauncher
+
+  def popen3(*cmd, &block)
+    if cmd.size > 0 && Hash === cmd[-1]
+      opts = cmd.pop
+    else
+      opts = {}
+    end
+    processbuilder_run(cmd, opts, io: IO_3, &block)
+  end
+  module_function :popen3
+
+  IO_3 = proc do |process|
+    [process.getOutputStream.to_io, process.getInputStream.to_io, process.getErrorStream.to_io]
+  end
+
+  BUILD_2 = proc do |builder|
+    builder.redirectError(ProcessBuilder::Redirect::INHERIT)
+  end
+
+  IO_2 = proc do |process|
+    [process.getOutputStream.to_io, process.getInputStream.to_io]
+  end
+
+  def popen2(*cmd, &block)
+    if cmd.size > 0 && Hash === cmd[-1]
+      opts = cmd.pop
+    else
+      opts = {}
+    end
+    processbuilder_run(cmd, opts, build: BUILD_2, io: IO_2, &block)
+  end
+  module_function :popen2
+
+  BUILD_2E = proc do |builder|
+    builder.redirectErrorStream(true)
+  end
+
+  def popen2e(*cmd, &block)
+    if cmd.size > 0 && Hash === cmd[-1]
+      opts = cmd.pop
+    else
+      opts = {}
+    end
+    processbuilder_run(cmd, opts, build: BUILD_2E, io: IO_2, &block)
+  end
+  module_function :popen2e
+
+  def processbuilder_run(cmd, opts, build: nil, io:)
+    opts.each do |k, v|
+      if Integer === k
+        if IO == v || !(String === v || v.respond_to?(:to_path))
+          # target is an open IO or a non-pathable object, bail out
+          raise NotImplementedError.new("redirect to an open IO is not implemented on this platform")
+        end
+      end
+    end
+
+    if Hash === cmd[0]
+      env = cmd.shift;
+    else
+      env = {}
+    end
+
+    if cmd.size == 1 && (cmd[0] =~ / / || ShellLauncher.shouldUseShell(cmd[0]))
+      cmd = [RbConfig::CONFIG['SHELL'], JRuby::Util::ON_WINDOWS ? '/c' : '-c', cmd[0]]
+    end
+
+    builder = ProcessBuilder.new(cmd.to_java(:string))
+
+    builder.directory(java.io.File.new(opts[:chdir] || Dir.pwd))
+
+    environment = builder.environment
+    env.each { |k, v| v.nil? ? environment.remove(k) : environment.put(k, v) }
+
+    build.call(builder) if build
+
+    process = builder.start
+
+    pid = org.jruby.util.ShellLauncher.getPidFromProcess(process)
+
+    parent_io = io.call(process)
+
+    parent_io.each {|i| i.sync = true}
+
+    wait_thr = DetachThread.new(pid) { RubyProcess::RubyStatus.newProcessStatus(JRuby.runtime, process.waitFor << 8, pid) }
+
+    result = [*parent_io, wait_thr]
+
+    if defined? yield
+      begin
+        return yield(*result)
+      ensure
+        parent_io.each(&:close)
+        wait_thr.join
+      end
+    end
+
+    result
+  end
+  module_function :processbuilder_run
+  class << self
+    private :processbuilder_run
+  end
+
+  class DetachThread < Thread
+    attr_reader :pid
+
+    def initialize(pid)
+      super
+
+      @pid = pid
+      self[:pid] = pid
+    end
+  end
+
+end

data/lib/open3/version.rb

@@ -1,3 +1,3 @@
 module Open3
-  VERSION = "0.1.0"
+  VERSION = "0.1.2"
 end

data/lib/open3.rb

@@ -29,6 +29,8 @@
 # - Open3.pipeline : run a pipeline and wait for its completion
 #
 
+require 'open3/version'
+
 module Open3
 
   # Open stdin, stdout, and stderr streams and start external executable.
@@ -206,6 +208,13 @@ module Open3
     opts[[:out, :err]] = out_w
 
     popen_run(cmd, opts, [in_r, out_w], [in_w, out_r], &block)
+  ensure
+    if block
+      in_r.close
+      in_w.close
+      out_r.close
+      out_w.close
+    end
   end
   module_function :popen2e
 
@@ -750,3 +759,6 @@ module Open3
   end
 
 end
+
+# JRuby uses different popen logic on Windows, require it here to reuse wrapper methods above.
+require 'open3/jruby_windows' if RUBY_ENGINE == 'jruby' && JRuby::Util::ON_WINDOWS

data/open3.gemspec

@@ -1,17 +1,23 @@
-lib = File.expand_path("lib", __dir__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "open3/version"
+# frozen_string_literal: true
+
+name = File.basename(__FILE__, ".gemspec")
+version = ["lib", Array.new(name.count("-")+1, "..").join("/")].find do |dir|
+  break File.foreach(File.join(__dir__, dir, "#{name.tr('-', '/')}/version.rb")) do |line|
+    /^\s*VERSION\s*=\s*"(.*)"/ =~ line and break $1
+  end rescue nil
+end
 
 Gem::Specification.new do |spec|
-  spec.name          = "open3"
-  spec.version       = Open3::VERSION
-  spec.authors       = ["Hiroshi SHIBATA"]
-  spec.email         = ["hsbt@ruby-lang.org"]
+  spec.name          = name
+  spec.version       = version
+  spec.authors       = ["Yukihiro Matsumoto"]
+  spec.email         = ["matz@ruby-lang.org"]
 
   spec.summary       = %q{Popen, but with stderr, too}
   spec.description   = spec.summary
   spec.homepage      = "https://github.com/ruby/open3"
-  spec.license       = "BSD-2-Clause"
+  spec.licenses      = ["Ruby", "BSD-2-Clause"]
+  spec.required_ruby_version = ">= 2.6.0"
 
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = spec.homepage
@@ -19,7 +25,7 @@ Gem::Specification.new do |spec|
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+    `git ls-files -z 2>/dev/null`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }

metadata

@@ -1,24 +1,26 @@
 --- !ruby/object:Gem::Specification
 name: open3
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
-- Hiroshi SHIBATA
-autorequire: 
+- Yukihiro Matsumoto
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2019-11-06 00:00:00.000000000 Z
+date: 2022-12-14 00:00:00.000000000 Z
 dependencies: []
 description: Popen, but with stderr, too
 email:
-- hsbt@ruby-lang.org
+- matz@ruby-lang.org
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/dependabot.yml"
+- ".github/workflows/test-jruby.yml"
+- ".github/workflows/test.yml"
 - ".gitignore"
-- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -26,15 +28,17 @@ files:
 - bin/console
 - bin/setup
 - lib/open3.rb
+- lib/open3/jruby_windows.rb
 - lib/open3/version.rb
 - open3.gemspec
 homepage: https://github.com/ruby/open3
 licenses:
+- Ruby
 - BSD-2-Clause
 metadata:
   homepage_uri: https://github.com/ruby/open3
   source_code_uri: https://github.com/ruby/open3
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -42,15 +46,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.4.0.dev
+signing_key:
 specification_version: 4
 summary: Popen, but with stderr, too
 test_files: []

data/.travis.yml

@@ -1,6 +0,0 @@
-language: ruby
-cache: bundler
-rvm:
-  - 2.6.3
-  - ruby-head
-script: rake test