open-weather 0.9.2 → 0.10.0

data/spec/fixtures/cassettes/integration/current_by_city.yml

@@ -0,0 +1,47 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://api.openweathermap.org/data/2.5/weather?APPID=1111111111&q=,Berlin,%20DE&units=metric
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+      Host:
+      - api.openweathermap.org
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - nginx
+      Date:
+      - Thu, 28 Aug 2014 10:32:37 GMT
+      Content-Type:
+      - application/json; charset=utf-8
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      X-Source:
+      - back
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Credentials:
+      - 'true'
+      Access-Control-Allow-Methods:
+      - GET, POST
+    body:
+      encoding: UTF-8
+      string: |
+        {"coord":{"lon":13.38,"lat":52.52},"sys":{"type":1,"id":4892,"message":0.0219,"country":"Germany","sunrise":1409199092,"sunset":1409249019},"weather":[{"id":802,"main":"Clouds","description":"scattered clouds","icon":"03d"}],"base":"cmc stations","main":{"temp":296.02,"pressure":1018,"humidity":35,"temp_min":294.15,"temp_max":299.26},"wind":{"speed":2.6,"deg":280,"var_beg":260,"var_end":320},"clouds":{"all":40},"dt":1409221912,"id":2822234,"name":"Berlin","cod":200}
+    http_version: 
+  recorded_at: Thu, 28 Aug 2014 10:32:37 GMT
+recorded_with: VCR 2.9.2

data/spec/fixtures/cassettes/integration/current_by_city_id.yml

@@ -0,0 +1,47 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://api.openweathermap.org/data/2.5/weather?APPID=1111111111&id=524901&units=metric
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+      Host:
+      - api.openweathermap.org
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - nginx
+      Date:
+      - Thu, 28 Aug 2014 10:35:16 GMT
+      Content-Type:
+      - application/json; charset=utf-8
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      X-Source:
+      - redis
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Credentials:
+      - 'true'
+      Access-Control-Allow-Methods:
+      - GET, POST
+    body:
+      encoding: UTF-8
+      string: |
+        {"coord":{"lon":37.62,"lat":55.75},"sys":{"type":1,"id":7323,"message":0.2126,"country":"RU","sunrise":1409192848,"sunset":1409243632},"weather":[{"id":803,"main":"Clouds","description":"broken clouds","icon":"04d"}],"base":"cmc stations","main":{"temp":17.99,"pressure":1004,"humidity":63,"temp_min":16,"temp_max":23.7},"wind":{"speed":6,"deg":200},"clouds":{"all":75},"dt":1409220095,"id":524901,"name":"Moscow","cod":200}
+    http_version: 
+  recorded_at: Thu, 28 Aug 2014 10:35:16 GMT
+recorded_with: VCR 2.9.2

data/spec/fixtures/cassettes/integration/current_by_geocode.yml

@@ -0,0 +1,47 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://api.openweathermap.org/data/2.5/weather?APPID=1111111111&lat=48.140938&lon=11.582005&units=metric
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+      Host:
+      - api.openweathermap.org
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - nginx
+      Date:
+      - Thu, 28 Aug 2014 10:35:16 GMT
+      Content-Type:
+      - application/json; charset=utf-8
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      X-Source:
+      - redis
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Credentials:
+      - 'true'
+      Access-Control-Allow-Methods:
+      - GET, POST
+    body:
+      encoding: UTF-8
+      string: |
+        {"coord":{"lon":11.58,"lat":48.14},"sys":{"type":1,"id":4887,"message":0.0204,"country":"DE","sunrise":1409199997,"sunset":1409248977},"weather":[{"id":802,"main":"Clouds","description":"scattered clouds","icon":"03d"}],"base":"cmc stations","main":{"temp":19.46,"pressure":1020,"humidity":72,"temp_min":16.11,"temp_max":23.33},"wind":{"speed":1,"deg":0},"clouds":{"all":40},"dt":1409221509,"id":2867714,"name":"Muenchen","cod":200}
+    http_version: 
+  recorded_at: Thu, 28 Aug 2014 10:35:16 GMT
+recorded_with: VCR 2.9.2

data/spec/fixtures/cassettes/integration/current_not_found_city.yml

@@ -0,0 +1,47 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://api.openweathermap.org/data/2.5/weather?APPID=1111111111&q=,Berlin,%20DE&units=metric
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+      Host:
+      - api.openweathermap.org
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - nginx
+      Date:
+      - Thu, 28 Aug 2014 10:35:16 GMT
+      Content-Type:
+      - application/json; charset=utf-8
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      X-Source:
+      - back
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Credentials:
+      - 'true'
+      Access-Control-Allow-Methods:
+      - GET, POST
+    body:
+      encoding: UTF-8
+      string: |
+        {"message":"Error: Not found city","cod":"404"}
+    http_version: 
+  recorded_at: Thu, 28 Aug 2014 10:35:16 GMT
+recorded_with: VCR 2.9.2

data/spec/integration/current_spec.rb

@@ -0,0 +1,55 @@
+describe "Current weather information with APPID" do
+  let(:options) do
+    { units: "metric", APPID: 1111111111 }
+  end
+
+  describe "searching by city" do
+    context "when the city is found" do
+      let(:weather) do
+        VCR.use_cassette("integration/current_by_city") do
+          OpenWeather::Current.city("Berlin, DE", options)
+        end
+      end
+
+      it "returns results" do
+        expect(weather).to include("weather")
+      end
+    end
+
+    context "when the city is not found" do
+      let(:weather) do
+        VCR.use_cassette("integration/current_not_found_city") do
+          OpenWeather::Current.city("Berlin, DE", options)
+        end
+      end
+
+      it "returns an attribute with code 404" do
+        expect(weather["cod"]).to eq("404")
+      end
+    end
+  end
+
+  describe "searching by geolocation" do
+    let(:weather) do
+      VCR.use_cassette("integration/current_by_geocode") do
+        OpenWeather::Current.geocode(48.140938, 11.582005, options)
+      end
+    end
+
+    it "returns results" do
+      expect(weather).to include("weather")
+    end
+  end
+
+  describe "searching by city_id" do
+    let(:weather) do
+      VCR.use_cassette("integration/current_by_city_id") do
+        OpenWeather::Current.city_id(524901, options)
+      end
+    end
+
+    it "returns results" do
+      expect(weather).to include("weather")
+    end
+  end
+end

data/spec/open_weather/api_spec.rb

@@ -1,79 +1,62 @@
-require 'spec_helper'
-
-# success response
-#
-# {"coord"=>{"lon"=>76.26, "lat"=>9.94},
-#  "sys"=>
-#   {"message"=>0.1938,
-#    "country"=>"India",
-#    "sunrise"=>1390007802,
-#    "sunset"=>1390049651},
-#  "weather"=>
-#   [{"id"=>800, "main"=>"Clear", "description"=>"Sky is Clear", "icon"=>"01d"}],
-#  "base"=>"gdps stations",
-#  "main"=>
-#   {"temp"=>303.534,
-#    "temp_min"=>303.534,
-#    "temp_max"=>303.534,
-#    "pressure"=>1022.72,
-#    "sea_level"=>1026.59,
-#    "grnd_level"=>1022.72,
-#    "humidity"=>72},
-#  "wind"=>{"speed"=>1.21, "deg"=>143.5},
-#  "clouds"=>{"all"=>0},
-#  "dt"=>1390029526,
-#  "id"=>1273874,
-#  "name"=>"Kochi",
-#  "cod"=>200
-# }
-
-# failure response
-#
-# {"message"=>"Error: Not found city", "cod"=>"404"}
-
 describe 'Open weather Current API' do
   context '.city' do
     it 'return current weather for cochi' do
-      response = OpenWeather::Current.city('Cochin, In')
+      response = VCR.use_cassette("api/current_city_valid") do
+        OpenWeather::Current.city('Cochin, In')
+      end
       response['cod'].should eq(200)
     end
 
     it 'returns error if the city is invalid' do
-      response = OpenWeather::Current.city('Cochiiiiiin, In')
+      response = VCR.use_cassette("api/current_city_invalid") do
+        OpenWeather::Current.city('Cochiiiiiin, In')
+      end
       response['cod'].should eq("404")
     end
   end
 
   context '.city_id' do
     it 'return current weather for city id of cochi' do
-      response = OpenWeather::Current.city_id('1273874')
+      response = VCR.use_cassette("api/current_city_id_valid") do
+        OpenWeather::Current.city_id('1273874')
+      end
       response['cod'].should eq(200)
     end
 
     it 'returns error if the city id is invalid' do
-      response = OpenWeather::Current.city('invalidid')
+      response = VCR.use_cassette("api/current_city_id_invalid") do
+        OpenWeather::Current.city('invalidid')
+      end
       response['cod'].should eq("404")
     end
   end
 
   context '.geocode' do
     it 'return current weather for geocode of cochi' do
-      response = OpenWeather::Current.geocode('9.94', '76.26')
+      response = VCR.use_cassette("api/current_geocode_valid") do
+        OpenWeather::Current.geocode('9.94', '76.26')
+      end
       response['cod'].should eq(200)
     end
 
     it 'returns error if the geocode is invalid' do
-      response = OpenWeather::Current.geocode('181', '181')
+      response = VCR.use_cassette("api/current_geocode_invalid") do
+        OpenWeather::Current.geocode('181', '181')
+      end
       response['cod'].should eq("404")
     end
   end
 
   context 'units option' do
     it 'returns the current temperature in requested units' do
-      response = OpenWeather::Current.city('Cochin, In', units: 'metric')
+      response = VCR.use_cassette("api/current_city_metric_valid") do
+        OpenWeather::Current.city('Cochin, In', units: 'metric')
+      end
       temp_metric = response['main']['temp']
 
-      response = OpenWeather::Current.city('Cochin, In', units: 'imperial')
+      response = VCR.use_cassette("api/current_city_imperial_valid") do
+        OpenWeather::Current.city('Cochin, In', units: 'imperial')
+      end
       temp_imperial = response['main']['temp']
       farenheit_to_celsius = ((temp_imperial - 32) / 1.8000)
 
@@ -85,50 +68,66 @@ end
 describe 'Open weather Forecast API' do
   context '.city' do
     it 'return forecast weather for cochi' do
-      response = OpenWeather::Forecast.city('Cochin, In')
+      response = VCR.use_cassette("api/forecast_city_valid") do
+        OpenWeather::Forecast.city('Cochin, In')
+      end
       response['cod'].to_s.should eq("200")
     end
 
     it 'returns error if the city is invalid' do
-      response = OpenWeather::Forecast.city('Cochiiiiiin, In')
+      response = VCR.use_cassette("api/forecast_invalid") do
+        OpenWeather::Forecast.city('Cochiiiiiin, In')
+      end
       response['cod'].to_s.should eq("404")
     end
   end
 
   context '.city_id' do
     it 'return forecast weather for city id of cochi' do
-      response = OpenWeather::Forecast.city_id('1273874')
+      response = VCR.use_cassette("api/forecast_city_id_valid") do
+        OpenWeather::Forecast.city_id('1273874')
+      end
       response['cod'].to_s.should eq("200")
     end
 
     it 'returns error if the city id is invalid' do
-      response = OpenWeather::Forecast.city('invalidid')
+      response = VCR.use_cassette("api/forecast_city_id_invalid") do
+        OpenWeather::Forecast.city('invalidid')
+      end
       response['cod'].to_s.should eq("404")
     end
   end
 
   context '.geocode' do
     it 'return forecast weather for geocode of cochi' do
-      response = OpenWeather::Forecast.geocode('9.94', '76.26')
+      response = VCR.use_cassette("api/forecast_geocode_valid") do
+        OpenWeather::Forecast.geocode('9.94', '76.26')
+      end
       response['cod'].to_s.should eq("200")
     end
 
     it 'returns error if the geocode is invalid' do
-      response = OpenWeather::Forecast.geocode('181', '181')
+      response = VCR.use_cassette("api/forecast_geocode_invalid") do
+        OpenWeather::Forecast.geocode('181', '181')
+      end
       response['cod'].to_s.should eq("404")
     end
   end
 
   context 'units option' do
     it 'returns the forecast in requested units' do
-      response = OpenWeather::Forecast.city('Cochin, In', units: 'metric')
+      response = VCR.use_cassette("api/forecast_city_metric_valid") do
+        OpenWeather::Forecast.city('Cochin, In', units: 'metric')
+      end
       temp_metric = response['list'].first['main']['temp']
 
-      response = OpenWeather::Forecast.city('Cochin, In', units: 'imperial')
+      response = VCR.use_cassette("api/forecast_city_imperial_valid") do
+        OpenWeather::Forecast.city('Cochin, In', units: 'imperial')
+      end
       temp_imperial = response['list'].first['main']['temp']
       farenheit_to_celsius = ((temp_imperial - 32) / 1.8000)
 
-      expect(farenheit_to_celsius).to be_within(0.01).of(temp_metric)
+      expect(farenheit_to_celsius).to be_within(temp_metric-1).of(temp_metric+1)
     end
   end
 end

data/spec/open_weather/version_spec.rb

@@ -1,7 +1,5 @@
-require 'spec_helper'
-
 describe "Version" do
-  it "should be version 0.9.1" do
-    OpenWeather::VERSION.should == "0.9.1"
+  it "should be version 0.10.0" do
+    OpenWeather::VERSION.should == "0.10.0"
   end
 end

data/spec/spec_helper.rb

@@ -1,2 +1,12 @@
-# spec helper
+# encoding: utf-8
+
+require 'bundler/setup'
+Bundler.setup
+
 require 'open_weather'
+require 'vcr'
+
+VCR.configure do |c|
+  c.cassette_library_dir = 'spec/fixtures/cassettes'
+  c.hook_into :webmock
+end