open-temporary 1.0.0 → 1.0.1

data/.document

@@ -1,5 +1,5 @@
 lib/**/*.rb
 bin/*
-- 
+-
 features/**/*.feature
 LICENSE.txt

data/README.rdoc

@@ -1,19 +1,36 @@
-= open-temporary
+= open-temporary the "real file" temporary one.
 
-Description goes here.
+OK, so you dropped into a tempfile pitfall.  Like Rails.
 
-== Contributing to open-temporary
- 
-* Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet.
-* Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it.
-* Fork the project.
-* Start a feature/bugfix branch.
-* Commit and push until you are happy with your contribution.
-* Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
-* Please try not to mess with the Rakefile, version, or history. If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so I can cherry-pick around it.
+https://github.com/rails/rails/pull/2068
 
-== Copyright
+Why not just fix the situation so that you can safely dup?
 
-Copyright (c) 2012 Urabe, Shyouhei. See LICENSE.txt for
-further details.
+= How to use it?
 
+You first add
+
+  gem "open-temporary"
+
+to your Gemfile, then from your .rb file,
+
+  require 'open-temporary'
+
+And that's it.  Now you have the "open" method extended, just like
+the open-uri standard library.
+
+  File.open # => gives you a temporary file
+
+This time the null (zero-arity) argument indicates this is a temporary
+file.  You get a REAL instance of File, no proxy, no tweak.  It can be
+dup'ed, it can be used with process forks, and still, you can just
+leave it, and the GC reclaims the whole resources.
+
+= Great!  So why this isn't a standard?
+
+Because it has absolutely zero portability.  The magic behind the
+scene is that we just let your operating system to reclaim what's
+necessary.  That way, the behaviour detail is much much OS specific.
+Especially, this kind of API is not doable on a Windows environment.
+Might not also on Java (not sure).  So this can never be a part of
+gospel ruby.

data/VERSION

@@ -1 +1 @@
-1.0.0
+1.0.1

data/ext/open_temporary/open_temporary.c

@@ -23,10 +23,27 @@
 #include <stdlib.h>
 #include <unistd.h>
 #include <fcntl.h>
+#include <errno.h>
+
+#define preserving_errno(stmts) \
+	do {int saved_errno = errno; stmts; errno = saved_errno;} while (0)
 
 static VALUE tmpdir = Qundef;
 static VALUE tmpsuf = Qundef;
 
+struct fdopen_args {
+    int fd;
+    int mod;
+    const char *str;
+};
+
+static VALUE
+call_fdopen(VALUE args)
+{
+    struct fdopen_args *argp = (struct fdopen_args *)args;
+    return rb_io_fdopen(argp->fd, argp->mod, argp->str);
+}
+
 static VALUE
 open_temporary(int argc, VALUE* argv, VALUE klass)
 {
@@ -41,7 +58,7 @@ open_temporary(int argc, VALUE* argv, VALUE klass)
 
     if (dir == Qnil) dir = tmpdir;
     if (suf == Qnil) suf = tmpsuf;
-    
+
     SafeStringValue(dir);
     SafeStringValue(suf);
 
@@ -51,14 +68,27 @@ open_temporary(int argc, VALUE* argv, VALUE klass)
         rb_sys_fail("mkstemp(3)");
     }
     else if (unlink(str) == -1) {
+        preserving_errno((void)close(fd));
         /* unlink failed, no way to reclaim */
         rb_sys_fail("unlink(2)");
     }
     else if ((mod = fcntl(fd, F_GETFL)) == -1) {
+        preserving_errno((void)close(fd));
         rb_sys_fail("fcntl(2)");
     }
     else {
-        return rb_io_fdopen(fd, mod, str);
+        int state;
+        VALUE io;
+        struct fdopen_args args;
+        args.fd = fd;
+        args.mod = mod;
+        args.str = str;
+        io = rb_protect(call_fdopen, (VALUE)&args, &state);
+        if (state) {
+            (void)close(fd);
+            rb_jump_tag(state);
+        }
+        return io;
     }
 }
 

data/lib/open-temporary.rb

@@ -59,7 +59,7 @@ module Kernel
     else
       File.open
     end
-  end    
+  end
 end
 
 # 

data/open-temporary.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "open-temporary"
-  s.version = "1.0.0"
+  s.version = "1.0.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Urabe, Shyouhei"]
-  s.date = "2012-09-05"
+  s.date = "2012-09-06"
   s.description = "A variation of tempfile standard lib, that actually creates a File instance."
   s.email = "shyouhei@ruby-lang.org"
   s.extensions = ["ext/open_temporary/extconf.rb"]
@@ -37,7 +37,7 @@ Gem::Specification.new do |s|
   s.homepage = "http://github.com/shyouhei/open-temporary"
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.22"
+  s.rubygems_version = "1.8.24"
   s.summary = "A variant of Tempfile that makes File instead"
 
   if s.respond_to? :specification_version then

data/spec/spec_helper.rb

@@ -29,7 +29,7 @@ require_relative '../lib/open-temporary'
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
 
 RSpec.configure do |config|
-  
+
 end
 
 # 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: open-temporary
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-05 00:00:00.000000000 Z
+date: 2012-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -162,7 +162,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 956200431
+      hash: 1506962448648116596
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -171,7 +171,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.22
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: A variant of Tempfile that makes File instead