open-companies-house 0.2.3 → 0.2.4

Sign up to get free protection for your applications and to get access to all the features.
@@ -44,6 +44,9 @@ module CompaniesHouse
44
44
  body = response.body.encode("UTF-8", "ISO-8859-1")
45
45
  data = JSON.parse(body)
46
46
  @attributes = data["primaryTopic"]
47
+ rescue JSON::ParserError=> e
48
+ error_msg = "Companies house is having problems: #{response.body}"
49
+ raise ServerError.new(error_msg)
47
50
  end
48
51
  end
49
- end
52
+ end
@@ -1,3 +1,3 @@
1
1
  module CompaniesHouse
2
- VERSION = '0.2.3'.freeze
2
+ VERSION = '0.2.4'.freeze
3
3
  end
@@ -58,4 +58,16 @@ describe CompaniesHouse::Response do
58
58
  }.to raise_exception CompaniesHouse::ServerError
59
59
  end
60
60
  end
61
- end
61
+
62
+ context "when the server returns html" do
63
+ it "raises a companies house server error" do
64
+ http_response = stub('Response')
65
+ http_response.stubs(:body).returns("<html><head></head></html>")
66
+ http_response.stubs(:status).returns(200)
67
+
68
+ expect {
69
+ subject.new(http_response)
70
+ }.to raise_error(CompaniesHouse::ServerError)
71
+ end
72
+ end
73
+ end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: open-companies-house
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.2.3
4
+ version: 0.2.4
5
5
  prerelease:
6
6
  platform: ruby
7
7
  authors:
@@ -9,7 +9,7 @@ authors:
9
9
  autorequire:
10
10
  bindir: bin
11
11
  cert_chain: []
12
- date: 2012-11-12 00:00:00.000000000 Z
12
+ date: 2012-11-21 00:00:00.000000000 Z
13
13
  dependencies:
14
14
  - !ruby/object:Gem::Dependency
15
15
  name: rspec