opal 1.8.3 → 1.8.4.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b2ea28174046f03dbf38c8a33c59c6e9dfc44704f36e80d0b271cdf6fbc8d591
-  data.tar.gz: a1f1dff5830cdc5ca5ad9cae396373da7e1b3bead1d9bfd64de1178f3680ddf7
+  metadata.gz: '08bd2086cde5e7cdc4878b2bd1e7cd4d11e9a1234698905ec21ec0355df14151'
+  data.tar.gz: 85694adb4f63d60793776a9ffcf50f276cfba2aa457796631503f21e889d0159
 SHA512:
-  metadata.gz: 50e163da86b18c05218439925f3bd78706a9761d1f290013841fbf9075131e720aec24ff9d2a60c4d284b4873983fdeb28c1e772773fcbc51fefb47160abe8f7
-  data.tar.gz: 2214f9e09e7c0de82a6ed9e2b3fa9a3c99ac6cb82fb09966bc7c1f74a8586d917c85672c8826d14429dc46f18e681fa2dea8e0560e7127a82ce5adfa2cbdcb09
+  metadata.gz: c956cf5fd21ec2b7bb2e0f06dcf7e0015f147d4c05da67eae607c62437ae9e687e7302cea1669e6a5ce121f3e1335517a07f80dfb43b00e55648a8eecdcaaeba
+  data.tar.gz: 8661bbef6e06101eac3f2fd4829ec5a3cf3dd5028b40020d2ba9157cc3d51808ba2a2f662222c38f2014db8c6a6237a5bb132cb96f58f47d7204084336d3aec1

data/.github/workflows/build.yml

@@ -15,7 +15,7 @@ jobs:
   rake:
     name: ${{ matrix.combo.name || matrix.combo.ruby }}
     env:
-      DEFAULT_RUBY: '3.3'
+      DEFAULT_RUBY: '3.4'
     strategy:
       fail-fast: false
       matrix:
@@ -25,7 +25,7 @@ jobs:
           - name: mspec-chrome
             command: bin/rake mspec_chrome
           - name: mspec-firefox
-            firefox: '106.0.4'
+            firefox: 'latest-esr'
             command: xvfb-run bin/rake mspec_firefox
           - name: minitest
             command: bin/rake minitest
@@ -35,14 +35,20 @@ jobs:
           # - name: head-ruby
           #   ruby: head
           #   permissive: true
-          - name: current-ruby
-            ruby: '3.3'
-          - name: previous-ruby
-            ruby: '3.2'
-          - name: older-ruby
-            ruby: '3.1'
-          - name: near-eol-ruby
+          - name: ruby-3.0
             ruby: '3.0'
+          - name: ruby-3.1
+            ruby: '3.1'
+          - name: ruby-3.2
+            ruby: '3.2'
+          - name: ruby-3.3
+            ruby: '3.3'
+          - name: ruby-3.4
+            ruby: '3.4'
+          - name: ruby-4.0
+            ruby: '4.0'
+          - name: jruby
+            ruby: 'jruby'
           - name: smoke-test
             command: bin/rake smoke_test
           - name: windows-mspec-nodejs
@@ -52,7 +58,7 @@ jobs:
             command: bundle exec rake mspec_chrome
             os: windows-latest
           # - name: windows-mspec-firefox
-          #   firefox: '106.0.4'
+          #   firefox: 'latest-esr'
           #   command: bundle exec rake mspec_firefox
           #   os: windows-latest
           - name: macos-mspec-safari
@@ -79,7 +85,6 @@ jobs:
 
           # Currently failing:
           # - ruby: truffleruby
-          # - ruby: jruby
 
     runs-on: ${{ matrix.combo.os || 'ubuntu-latest' }}
     continue-on-error: ${{ matrix.combo.permissive || false }}

data/.rubocop.yml

@@ -2,7 +2,8 @@ inherit_from:
   - .rubocop_todo.yml
   - .rubocop/todo.yml
 
-require: rubocop-performance
+plugins:
+  - rubocop-performance
 
 
 AllCops:
@@ -158,6 +159,10 @@ Lint/RedundantStringCoercion:
     # That's what MRI does
     - 'opal/corelib/error.rb'
 
+Lint/RedundantRequireStatement:
+  Exclude:
+    - 'lib/opal/nodes/if.rb'
+
 Lint/UnusedBlockArgument:
   Exclude:
     # Variable from Ruby can be accessed in JS, rubocop can't catch it (but JSHint can)
@@ -212,7 +217,7 @@ Naming/BinaryOperatorParameterName:
     - 'opal/**/*.rb'
     - 'stdlib/**/*.rb'
 
-Naming/PredicateName:
+Naming/PredicatePrefix:
   # Ruby has "has_key?" method
   ForbiddenPrefixes: 
     - is_
@@ -385,6 +390,8 @@ Security/Eval:
   Exclude:
     # That's what parser does
     - 'stdlib/opal-parser.rb'
+    # Binding#eval necessarily uses eval
+    - 'opal/corelib/binding.rb'
 
 Naming/AccessorMethodName:
   Exclude:

data/Gemfile

@@ -41,6 +41,8 @@ group :development do
   gem 'guard', require: false
   gem 'listen', require: false
   gem 'simplecov', require: false
+  gem 'ruby-lsp', require: false
+  gem 'uri', '> 1', require: false
 
   if RUBY_PLATFORM =~ /darwin/
     gem 'terminal-notifier-guard'
@@ -49,5 +51,5 @@ group :development do
 end unless ENV['CI']
 
 group :doc do
-  gem 'redcarpet' unless RUBY_ENGINE == 'truffleruby'
+  gem 'redcarpet' unless %w[truffleruby jruby].include?(RUBY_ENGINE)
 end unless ENV['CI']

data/UNRELEASED.md

@@ -1,10 +1,46 @@
 <!--
-### Internal
-### Changed
+### Deprecated
+-->
+
 ### Added
+
+- Support JRuby in the builder scheduler and system runner ([#2686](https://github.com/opal/opal/pull/2686))
+- Allow `BUN_OPTS` and `DENO_OPTS` to pass extra options to the Bun and Deno runners ([#2695](https://github.com/opal/opal/pull/2695))
+
+### Changed
+
+- Refresh bundled npm dependencies and migrate development linting to ESLint 9 ([#2685](https://github.com/opal/opal/pull/2685))
+- Update unsupported `String` method definitions ([#2717](https://github.com/opal/opal/pull/2717))
+
 ### Removed
-### Deprecated
-### Performance
+
+- Drop `bin/opal-mspec` in favor of the generic `bin/test` helper ([#2735](https://github.com/opal/opal/pull/2735))
+
 ### Fixed
--->
 
+- Detect Chromium on macOS when running Chrome-based specs ([#2681](https://github.com/opal/opal/pull/2681))
+- Fix the Firefox runner ([#2694](https://github.com/opal/opal/pull/2694))
+- Fix browser runner failures with `INVERT_RUNNING_MODE` and `PATTERN` ([#2696](https://github.com/opal/opal/pull/2696), [#2711](https://github.com/opal/opal/pull/2711))
+- Require `::Math` for mspec compatibility ([#2708](https://github.com/opal/opal/pull/2708))
+- Fix `Module#include` behavior after `#prepend` ([#2722](https://github.com/opal/opal/pull/2722))
+- Require the `Thread` shim from `if` node compilation support ([#2727](https://github.com/opal/opal/pull/2727))
+- Fix `Array#flatten` maximum call stack errors ([#2729](https://github.com/opal/opal/pull/2729))
+- Fix `Kernel#frozen?` for singleton classes ([#2731](https://github.com/opal/opal/pull/2731))
+- Fix `defined?` for constants set to `0` ([#2744](https://github.com/opal/opal/pull/2744))
+- Fix Terser invocation ([#2749](https://github.com/opal/opal/pull/2749))
+- Fix `Enumerable#first` return values ([#2753](https://github.com/opal/opal/pull/2753))
+- Support keyword arguments when initializing Logger ([#2772](https://github.com/opal/opal/pull/2772))
+- Avoid an additional boot error when `$stderr` is unavailable ([#2703](https://github.com/opal/opal/pull/2703))
+
+### Performance
+
+- Reduce RSpec runtime overhead ([#2781](https://github.com/opal/opal/pull/2781))
+
+### Internal
+
+- Rename and sort Ruby CI jobs ([#2752](https://github.com/opal/opal/pull/2752))
+- Add Ruby LSP to the development Gemfile ([#2724](https://github.com/opal/opal/pull/2724))
+- Backport JRuby and TruffleRuby lint follow-ups ([#2690](https://github.com/opal/opal/pull/2690))
+- Restore the stable ES3 generated-JS lint contract after the ESLint 9 backport.
+- Update CI coverage for Ruby 3.4 and Ruby 4.0 ([#2779](https://github.com/opal/opal/pull/2779))
+- Add the `ostruct` development dependency needed by the test harness on Ruby 4 ([#2786](https://github.com/opal/opal/pull/2786))

data/bin/test

@@ -0,0 +1,43 @@
+#!/usr/bin/env ruby
+
+require 'shellwords'
+require 'pathname'
+require 'fileutils'
+extend FileUtils
+
+def system(*args)
+  if Hash === args.first
+    env_string = "env #{args.first.map { |k, v| "#{k}=#{v.shellescape}" }.join(' ')} "
+  end
+
+  warn "$ #{env_string}#{args.select{String === _1}.shelljoin}"
+  super(*args, exception: true) rescue exit(1)
+end
+
+ENV["NODE_ENV"] = "test"
+
+files = []
+args = []
+ARGV.each do |arg|
+  if File.directory?(arg)
+    files += Dir.glob("#{arg}/**/{*_spec.rb,test_*.rb}")
+  elsif File.file?(arg)
+    files << arg
+  else
+    args << arg
+  end
+end
+
+files.map! do |file|
+  file = Pathname(file).expand_path
+  base = Pathname("#{__dir__}/..").expand_path
+  file.relative_path_from(base).to_s
+end
+
+mspec, minitest = files.partition { |file| file.end_with?('_spec.rb') }
+opalspec, rubyspec = mspec.partition { _1.start_with?('spec/opal') }
+to_glob = ->(files) { "{#{files.join(',')}}" }
+
+system({"PATTERN" => to_glob[opalspec]}, "bundle", "exec", "rake", "mspec_opal_nodejs") if opalspec.any?
+system({"PATTERN" => to_glob[mspec]}, "bundle", "exec", "rake", "mspec_ruby_nodejs") if mspec.any?
+system({"PATTERN" => to_glob[minitest]}, "bundle", "exec", "rake", "minitest_nodejs") if minitest.any?

data/eslint.await.config.mjs

@@ -0,0 +1,17 @@
+import config from "./eslint.config.mjs";
+
+export default config.map((entry) => {
+  if (!entry.languageOptions) return entry;
+
+  return {
+    ...entry,
+    languageOptions: {
+      ...entry.languageOptions,
+      ecmaVersion: 8,
+      parserOptions: {
+        ...entry.languageOptions.parserOptions,
+        allowReserved: false,
+      },
+    },
+  };
+});

data/eslint.config.mjs

@@ -0,0 +1,58 @@
+import globals from "globals";
+import js from "@eslint/js";
+
+export default [
+  js.configs.recommended,
+  {
+    languageOptions: {
+      ecmaVersion: 3,
+      sourceType: "commonjs",
+      parserOptions: {
+          allowReserved: true,
+      },
+      globals: {
+          ...globals.browser,
+          ...globals.node,
+          ArrayBuffer: "readonly",
+          DataView: "readonly",
+          globalThis: "readonly",
+          JSON: "readonly",
+          Opal: "readonly",
+          Promise: "readonly",
+          Proxy: "readonly",
+          Reflect: "readonly",
+          Uint8Array: "readonly",
+          Int32Array: "readonly",
+          WeakRef: "readonly",
+          Map: "readonly",
+      },
+    },
+
+    rules: {
+      "no-unused-vars": ["error", {
+          varsIgnorePattern: "($($|$$|yield|post_args|[a-z])|self)",
+          argsIgnorePattern: "($($|$$|yield|post_args|[a-z])|self)",
+          caughtErrorsIgnorePattern: "^e$",
+      }],
+
+      "no-extra-semi": "off",
+      "no-empty": "off",
+      "no-unreachable": "off",
+      "no-cond-assign": "off",
+      "no-prototype-builtins": "off",
+
+      "no-constant-condition": ["error", {
+          checkLoops: false,
+      }],
+
+      "no-useless-escape": "off",
+
+      "no-fallthrough": ["error", {
+          commentPattern: "raise|no-break",
+      }],
+
+      "no-regex-spaces": "off",
+      "no-control-regex": "off",
+    },
+  }
+];

data/lib/opal/builder.rb

@@ -265,7 +265,7 @@ module Opal
         unless autoload
           case missing_require_severity
           when :error   then raise MissingRequire, message
-          when :warning then warn message
+          when :warning then warn 'Warning: ' + message
           when :ignore  then # noop
           end
         end

data/lib/opal/builder_scheduler.rb

@@ -13,7 +13,10 @@ module Opal
 
   singleton_class.attr_accessor :builder_scheduler
 
-  if RUBY_ENGINE != 'opal'
+  if RUBY_ENGINE == 'opal'
+    require 'opal/builder_scheduler/sequential'
+    Opal.builder_scheduler = BuilderScheduler::Sequential
+  elsif RUBY_ENGINE == 'ruby'
     # Windows has a faulty `fork`.
     if OS.windows? || ENV['OPAL_PREFORK_DISABLE']
       require 'opal/builder_scheduler/sequential'

data/lib/opal/cli_runners/bun.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require 'shellwords'
+require 'opal/paths'
+require 'opal/cli_runners/system_runner'
+require 'opal/os'
+
+module Opal
+  module CliRunners
+    class Bun
+      def self.call(data)
+        argv = data[:argv].dup.to_a
+
+        SystemRunner.call(data) do |tempfile|
+          opts = Shellwords.shellwords(ENV['BUN_OPTS'] || '')
+          [
+            'bun',
+            'run',
+            *opts,
+            tempfile.path,
+            *argv
+          ]
+        end
+      rescue Errno::ENOENT
+        raise MissingBun, 'Please install Bun to be able to run Opal scripts.'
+      end
+
+      class MissingBun < RunnerError
+      end
+    end
+  end
+end

data/lib/opal/cli_runners/chrome.rb

@@ -201,7 +201,13 @@ module Opal
               return path
             end
           elsif OS.macos?
-            '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome'
+            [
+              '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome',
+              '/Applications/Chromium.app/Contents/MacOS/Chromium'
+            ].each do |path|
+              next unless File.exist? path
+              return path
+            end
           else
             %w[
               google-chrome-stable

data/lib/opal/cli_runners/deno.rb

@@ -12,11 +12,13 @@ module Opal
         argv = data[:argv].dup.to_a
 
         SystemRunner.call(data) do |tempfile|
+          opts = Shellwords.shellwords(ENV['DENO_OPTS'] || '')
           [
             'deno',
             'run',
             '--allow-read',
             '--allow-write',
+            *opts,
             tempfile.path,
             *argv
           ]

data/lib/opal/cli_runners/firefox.rb

@@ -167,7 +167,12 @@ module Opal
               return path
             end
           elsif OS.macos?
-            '/Applications/Firefox.app/Contents/MacOS/Firefox'
+            [
+              '/Applications/Firefox.app/Contents/MacOS/Firefox',
+              '/Applications/Firefox.app/Contents/MacOS/firefox',
+            ].each do |path|
+              return path if File.exist? path
+            end
           else
             %w[
               firefox
@@ -303,6 +308,8 @@ module Opal
           'network.cookie.cookieBehavior': 0,
           # Disable experimental feature that is only available in Nightly
           'network.cookie.sameSite.laxByDefault': false,
+          # Avoid cookie expiry date to be affected by server time, which can result in flaky tests.
+          'network.cookie.useServerTime': false,
           # Do not prompt for temporary redirects
           'network.http.prompt-temp-redirect': false,
           # Disable speculative connections so they are not reported as leaking
@@ -315,6 +322,11 @@ module Opal
           # Disable Flash.
           'plugin.state.flash': 0,
           'privacy.trackingprotection.enabled': false,
+          # To enable remote protocols use:
+          #   const WEBDRIVER_BIDI_ACTIVE = 0x1;
+          #   const CDP_ACTIVE = 0x2;
+          # Enable only CDP for now
+          'remote.active-protocols': 2,
           # Can be removed once Firefox 89 is no longer supported
           # https://bugzilla.mozilla.org/show_bug.cgi?id=1710839
           'remote.enabled': true,

data/lib/opal/cli_runners/node_modules/.package-lock.json

@@ -1,10 +1,12 @@
 {
   "name": "cli_runners",
-  "lockfileVersion": 2,
+  "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "node_modules/chrome-remote-interface": {
-      "version": "0.31.3",
+      "version": "0.33.2",
+      "resolved": "https://registry.npmjs.org/chrome-remote-interface/-/chrome-remote-interface-0.33.2.tgz",
+      "integrity": "sha512-wvm9cOeBTrb218EC+6DteGt92iXr2iY0+XJP30f15JVDhqvWvJEVACh9GvUm8b9Yd8bxQivaLSb8k7mgrbyomQ==",
       "license": "MIT",
       "dependencies": {
         "commander": "2.11.x",
@@ -16,10 +18,14 @@
     },
     "node_modules/commander": {
       "version": "2.11.0",
+      "resolved": "https://registry.npmjs.org/commander/-/commander-2.11.0.tgz",
+      "integrity": "sha512-b0553uYA5YAEGgyYIGYROzKQ7X5RAqedkfjiZxwi0kL1g3bOaBNNZfYkzt/CL0umgD5wc9Jec2FbB98CjkMRvQ==",
       "license": "MIT"
     },
     "node_modules/ws": {
-      "version": "7.5.9",
+      "version": "7.5.10",
+      "resolved": "https://registry.npmjs.org/ws/-/ws-7.5.10.tgz",
+      "integrity": "sha512-+dbF1tHwZpXcbOJdVOkzLDxZP1ailvSxM6ZweXTegylPny803bFhA+vqBYw4s31NSAk4S2Qz+AKXK9a4wkdjcQ==",
       "license": "MIT",
       "engines": {
         "node": ">=8.3.0"

data/lib/opal/cli_runners/node_modules/chrome-remote-interface/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2021 Andrea Cardaci <cyrus.and@gmail.com>
+Copyright (c) 2024 Andrea Cardaci <cyrus.and@gmail.com>
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of
 this software and associated documentation files (the "Software"), to deal in

data/lib/opal/cli_runners/node_modules/chrome-remote-interface/README.md

@@ -1,7 +1,6 @@
-# chrome-remote-interface [![Build Status][]][travis]
+# chrome-remote-interface
 
-[Build Status]: https://app.travis-ci.com/cyrus-and/chrome-remote-interface.svg?branch=master
-[travis]: https://app.travis-ci.com/cyrus-and/chrome-remote-interface
+[![CI status](https://github.com/cyrus-and/chrome-remote-interface/actions/workflows/ci.yml/badge.svg)](https://github.com/cyrus-and/chrome-remote-interface/actions?query=workflow:CI)
 
 [Chrome Debugging Protocol] interface that helps to instrument Chrome (or any
 other suitable [implementation](#implementations)) by providing a simple
@@ -131,14 +130,14 @@ Since version 59, additionally use the `--headless` option, for example:
 
 #### Android
 
-Plug the device and enable the [port forwarding][adb], for example:
+Plug the device and make sure to authorize the connection from the device itself. Then
+enable the port forwarding, for example:
 
-    adb forward tcp:9222 localabstract:chrome_devtools_remote
+    adb -d forward tcp:9222 localabstract:chrome_devtools_remote
 
-Note that in Android, Chrome does not have its own protocol available, a local
-version must be used. See [here](#chrome-debugging-protocol-versions) for more information.
-
-[adb]: https://developer.chrome.com/devtools/docs/remote-debugging-legacy
+After that you should be able to use `http://127.0.0.1:9222` as usual, but note that in
+Android, Chrome does not have its own protocol available, so a local version must be used.
+See [here](#chrome-debugging-protocol-versions) for more information.
 
 ##### WebView
 
@@ -400,6 +399,7 @@ To generate a JavaScript file that can be used with a `<script>` element:
     </script>
     <script src="chrome-remote-interface.js"></script>
     ```
+
 ## TypeScript Support
 
 [TypeScript][] definitions are kindly provided by [Khairul Azhar Kasmiran][] and [Seth Westphal][], and can be installed from [DefinitelyTyped][]:
@@ -408,6 +408,12 @@ To generate a JavaScript file that can be used with a `<script>` element:
 npm install --save-dev @types/chrome-remote-interface
 ```
 
+Note that the TypeScript definitions are automatically generated from the npm package `devtools-protocol@0.0.927104`. For other versions of devtools-protocol:
+
+1. Install patch-package using [the instructions given](https://github.com/ds300/patch-package#set-up).
+2. Copy the contents of the corresponding https://github.com/ChromeDevTools/devtools-protocol/tree/master/types folder (according to commit) into `node_modules/devtools-protocol/types`.
+3. Run `npx patch-package devtools-protocol` so that the changes persist across an `npm install`.
+
 [TypeScript]: https://www.typescriptlang.org/
 [Khairul Azhar Kasmiran]: https://github.com/kazarmy
 [Seth Westphal]: https://github.com/westy92