opal 1.8.0.beta1 → 1.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 506ba9114548fa5c492467950421043dbf46d0b72df49eab40c5a62e6f6c2ce6
-  data.tar.gz: e59c280933851d6de0a63f42b19139e5b16c90f68fe0c4652cf555a5ef7e1968
+  metadata.gz: 8af8b2b4d485065e48d45e66e00075cf3b2f3d58c358355f5cbf5c97c46cd607
+  data.tar.gz: 87b7e4d8443eeb45953d48ca6ebb321b27269d9e7bbe2c4770c5189bcd44bcf9
 SHA512:
-  metadata.gz: 8536d4701b9197c3cee876bb35bb3fd34cee5726241069d108fa12f8c83753c43d8bc6ac8f95fd867ee5da23ba98b2c8a1b3e284a56df7b6656ffa17850b36c4
-  data.tar.gz: b0f0283471809563e3ea29afcef0b911109aa7d9d9a1f04701c34f48facc8654f20cacc3bd7061273bf74d837c7ae1256d13249e1eb9371e6faa94e3f54fa22b
+  metadata.gz: 615891333955fa65566ccad7f18d7a2a65905076db6268775bb5e9f06604b56e4ebfcb8fc05d181353c1bcfbba64c195c2eb4f71b37f805e9f7984f990e56a41
+  data.tar.gz: 1566eb09bf04acbcb49c7386ab9259cd13f8d94810e9dfecadf109b57ad2eaf479d1df419359a4a776b11aba2c7cc97d7df761c9ade46a2b8512d2718503ab69

data/CHANGELOG.md

@@ -16,7 +16,7 @@ Changes are grouped as follows:
 
 
 
-## [1.7.3](https://github.com/opal/opal/compare/v1.7.2...v1.7.3) - 2023-03-23
+## [1.8.1](https://github.com/opal/opal/compare/v1.8.0...v1.8.1) - 2023-11-09
 
 
 <!--
@@ -26,8 +26,157 @@ Changes are grouped as follows:
 ### Removed
 ### Deprecated
 ### Performance
+### Fixed
+-->
+
+
+### Fixed
+
+- `Array` methods should handle elements inserted during the iteration ([#2602](https://github.com/opal/opal/pull/2602))
+- Assign correct values to duplicated underscore parameters ([#2606](https://github.com/opal/opal/pull/2606))
+
+
+### Added
+
+- Support an `IO` argument of `Kernel.printf` ([#2605](https://github.com/opal/opal/pull/2605))
+
+
+### Performance
+
+- Fix a performance regression introduced by freezing support ([#2609](https://github.com/opal/opal/pull/2609))
+
+
+
+
+## [1.8.0](https://github.com/opal/opal/compare/v1.7.4...v1.8.0) - 2023-10-26
+
+
+<!--
+### Internal
+### Added
+### Removed
+### Deprecated
+### Performance
+### Fixed
+### Documentation
 -->
 
+## Highlights
+
+### `Hash` is now bridged to JavaScript `Map`
+
+This change brings a lot of benefits, but also some incompatibilities. The main benefit is that `Hash` now is both more performant and relies on native JavaScript capabilities.
+This improves interoperability with JavaScript. As a downside, applications reaching for internal `Hash` data structures will need to be updated.
+
+Interacting with `Hash` from `JavaScript` is easier than ever:
+
+```ruby
+hash = `new Map([['a', 1], ['b', 2]])`
+hash # => {a: 1, b: 2}
+`console.log(hash)` # => Map(2) {"a" => 1, "b" => 2}
+`hash.get('a')` # => 1
+`hash.set('c', 3)`
+hash # => {a: 1, b: 2, c: 3}
+hash.keys # => ["a", "b", "c"]
+hash.values # => [1, 2, 3]
+```
+
+### Performance improvements
+
+This release brings a lot of performance improvements, our tests on Asciidoctor show a 25% improvement in performance, but we've seen up to 66% performance improvement on some applications.
+
+## Changelog
+
+### Deprecated
+
+- Deprecate using x-string to access JavaScript without an explicit magic-comment ([#2543](https://github.com/opal/opal/pull/2543))
+
+### Compatibility
+
+- Add a magic-comment that will disable x-string compilation to JavaScript ([#2543](https://github.com/opal/opal/pull/2543))
+- Pass value in `PromiseV2#always` just like `PromiseV1#always` does it ([#2579](https://github.com/opal/opal/pull/2579))
+- `#hash` now returns integers ([#2582](https://github.com/opal/opal/pull/2582))
+- Improve `Range#include?`/`member?`/`cover?`/`===` ([#2598](https://github.com/opal/opal/pull/2598))
+- Make `Module#define_method` more compatible with CRuby ([#2593](https://github.com/opal/opal/pull/2593))
+- `Hash#clone` must freeze clone if original is frozen, but `Hash#dup` must not ([#2603](https://github.com/opal/opal/pull/2603))
+
+### Fixed
+
+- Fix `Kernel#Float` with `exception:` option ([#2532](https://github.com/opal/opal/pull/2532))
+- Fix `Kernel#Integer` with `exception:` option ([#2531](https://github.com/opal/opal/pull/2531))
+- Fix `String#split` with limit and capturing regexp ([#2544](https://github.com/opal/opal/pull/2544))
+- Fix `switch` with Object-wrapped values ([#2542](https://github.com/opal/opal/pull/2542))
+- Fix non-direct subclasses of bridged classes not calling the original constructor ([#2546](https://github.com/opal/opal/pull/2546))
+- Regexp.escape: Cast to String or drop exception ([#2552](https://github.com/opal/opal/pull/2552))
+- Propagate removal of method from included/prepended modules ([#2553](https://github.com/opal/opal/pull/2553))
+- Restore `nodejs/yaml` functionality ([#2551](https://github.com/opal/opal/pull/2551))
+- Fix sine `Range#size` edge cases ([#2541](https://github.com/opal/opal/pull/2541))
+- Use a Map instead of a POJO for the jsid_cache ([#2584](https://github.com/opal/opal/pull/2584))
+- Fix `String#object_id`, `String#__id__`, `String#hash` to match CRuby's behavior ([#2576](https://github.com/opal/opal/pull/2576))
+- Lowercase response headers in `SimpleServer` for rack 3.0 compatibility ([#2578](https://github.com/opal/opal/pull/2578))
+- Fix `Module#clone` and `Module#dup` to properly copy methods ([#2572](https://github.com/opal/opal/pull/2572))
+- Chrome runner fix: support code that contains `</script>` ([#2581](https://github.com/opal/opal/pull/2581))
+- Do not skip `$truthy` when left hand side of a comparison is `self` ([#2596](https://github.com/opal/opal/pull/2596))
+- Unexpected `return`/`break` should raise `LocalJumpError` ([#2591](https://github.com/opal/opal/pull/2591))
+
+### Added
+
+- SourceMap support for `Kernel#eval` ([#2534](https://github.com/opal/opal/pull/2534))
+- Add `CGI::Util#escapeURIComponent` and `CGI::Util#unescapeURIComponent` ([#2566](https://github.com/opal/opal/pull/2566))
+- `CGI::Util` implement additional methods ([#2601](https://github.com/opal/opal/pull/2601))
+
+### Changed
+
+- Change compilation of Regexp nodes that may contain advanced features, so if invalid that they would raise at runtime, not parse-time ([#2548](https://github.com/opal/opal/pull/2548))
+- `Hash` is now bridged to JavaScript `Map` and support for non-symbol keys in keyword arguments ([#2568](https://github.com/opal/opal/pull/2568))
+
+### Documentation
+
+- Bridging documentation ([#2541](https://github.com/opal/opal/pull/2541))
+- Fix Typo in Running tests Section of README.md File ([#2580](https://github.com/opal/opal/pull/2580))
+
+### Performance
+
+- Improve performance of `Array#intersect?` and `#intersection` ([#2533](https://github.com/opal/opal/pull/2533))
+- `Proc#call`: Refactor for performance ([#2541](https://github.com/opal/opal/pull/2541))
+- Opal.stub_for: optimize ([#2541](https://github.com/opal/opal/pull/2541))
+- Hash: Optimize `#to_a` ([#2541](https://github.com/opal/opal/pull/2541))
+- Array: Optimize `#collect`/`#map` ([#2541](https://github.com/opal/opal/pull/2541))
+- Optimize argument slicing in runtime for performance ([#2555](https://github.com/opal/opal/pull/2555))
+- Closure: Generate a JavaScript object, not an Error, gain up to 15% on Asciidoctor ([#2556](https://github.com/opal/opal/pull/2556))
+- Optimize `String#split` and `String#start_with` ([#2560](https://github.com/opal/opal/pull/2560))
+- Compute `$@` dynamically ([#2592](https://github.com/opal/opal/pull/2592))
+- Optimize the `$prop` helper ([#2597](https://github.com/opal/opal/pull/2597))
+- Improve `Array.push()` performance when pushing many items ([#2565](https://github.com/opal/opal/pull/2565))
+- Optimize `Opal.instance_methods` ([#2600](https://github.com/opal/opal/pull/2600))
+
+### Internal
+
+- Update rubocop ([#2535](https://github.com/opal/opal/pull/2535))
+- Match3Node Cleanup ([#2541](https://github.com/opal/opal/pull/2541))
+- IFlipFlop/EFlipFlop: Refactor for readability ([#2541](https://github.com/opal/opal/pull/2541))
+- ForRewriter: Refactor for readability ([#2541](https://github.com/opal/opal/pull/2541))
+
+
+
+
+## [1.7.4](https://github.com/opal/opal/compare/v1.7.3...v1.7.4) - 2023-09-14
+
+
+### Fixed
+
+- Use a Map instead of a POJO for the jsid_cache ([#2584](https://github.com/opal/opal/pull/2584))
+- Lowercase response headers in `SimpleServer` for rack 3.0 compatibility ([#2578](https://github.com/opal/opal/pull/2578))
+- Fix `switch` with Object-wrapped values ([#2542](https://github.com/opal/opal/pull/2542))
+- Regexp.escape: Cast to String or drop exception ([#2552](https://github.com/opal/opal/pull/2552))
+- Chrome runner fix: support code that contains `</script>` ([#2581](https://github.com/opal/opal/pull/2581))
+
+
+
+
+## [1.7.3](https://github.com/opal/opal/compare/v1.7.2...v1.7.3) - 2023-03-23
+
+
 ### Fixed
 
 - Disallow to define a singleton class for Number ([#2521](https://github.com/opal/opal/pull/2521))

data/UNRELEASED.md

@@ -1,101 +1,10 @@
 <!--
 ### Internal
+### Changed
 ### Added
 ### Removed
 ### Deprecated
 ### Performance
 ### Fixed
-### Documentation
 -->
 
-## Highlights
-
-### `Hash` is now bridged to JavaScript `Map`
-
-This change brings a lot of benefits, but also some incompatibilities. The main benefit is that `Hash` now is both more performant and relies on native JavaScript capabilities.
-This improves interoperability with JavaScript. As a downside, applications reaching for internal `Hash` data structures will need to be updated.
-
-Interacting with `Hash` from `JavaScript` is easier than ever:
-
-```ruby
-hash = `new Map([['a', 1], ['b', 2]])`
-hash # => {a: 1, b: 2}
-`console.log(hash)` # => Map(2) {"a" => 1, "b" => 2}
-`hash.get('a')` # => 1
-`hash.set('c', 3)`
-hash # => {a: 1, b: 2, c: 3}
-hash.keys # => ["a", "b", "c"]
-hash.values # => [1, 2, 3]
-```
-
-### Performance improvements
-
-This release brings a lot of performance improvements, our tests on Asciidoctor show a 25% improvement in performance, but we've seen up to 66% performance improvement on some applications.
-
-## Changelog
-
-### Deprecated
-
-- Deprecate using x-string to access JavaScript without an explicit magic-comment (#2543)
-
-### Compatibility
-
-- Add a magic-comment that will disable x-string compilation to JavaScript (#2543)
-- Pass value in `PromiseV2#always` just like `PromiseV1#always` does it (#2579)
-- `#hash` now returns integers #2582)
-
-### Fixed
-
-- Fix `Kernel#Float` with `exception:` option (#2532)
-- Fix `Kernel#Integer` with `exception:` option (#2531)
-- Fix `String#split` with limit and capturing regexp (#2544)
-- Fix `switch` with Object-wrapped values (#2542)
-- Fix non-direct subclasses of bridged classes not calling the original constructor (#2546)
-- Regexp.escape: Cast to String or drop exception (#2552)
-- Propagate removal of method from included/prepended modules (#2553)
-- Restore `nodejs/yaml` functionality (#2551)
-- Fix sine `Range#size` edge cases (#2541)
-- Use a Map instead of a POJO for the jsid_cache (#2584)
-- Fix `String#object_id`, `String#__id__`, `String#hash` to match CRuby's behavior (#2576)
-- Lowercase response headers in `SimpleServer` for rack 3.0 compatibility (#2578)
-- Fix `Module#clone` and `Module#dup` to properly copy methods (#2572)
-- Chrome runner fix: support code that contains `</script>` (#2581)
-- Do not skip `$truthy` when left hand side of a comparison is `self` (#2596)
-- Unexpected `return`/`break` should raise `LocalJumpError` (#2591)
-
-### Added
-
-- SourceMap support for `Kernel#eval` (#2534)
-- Add `CGI::Util#escapeURIComponent` and `CGI::Util#unescapeURIComponent` (#2566)
-
-### Changed
-
-- Change compilation of Regexp nodes that may contain advanced features, so if invalid that they would raise at runtime, not parse-time (#2548)
-- `Hash` is now bridged to JavaScript `Map` and support for non-symbol keys in keyword arguments (#2568)
-
-### Documentation
-
-- Bridging documentation (#2541)
-- Fix Typo in Running tests Section of README.md File (#2580)
-
-### Performance
-
-- Improve performance of `Array#intersect?` and `#intersection` (#2533)
-- `Proc#call`: Refactor for performance (#2541)
-- Opal.stub_for: optimize (#2541)
-- Hash: Optimize `#to_a` (#2541)
-- Array: Optimize `#collect`/`#map` (#2541)
-- Optimize argument slicing in runtime for performance (#2555)
-- Closure: Generate a JavaScript object, not an Error, gain up to 15% on Asciidoctor (#2556)
-- Optimize `String#split` and `String#start_with` (#2560)
-- Compute `$@` dynamically (#2592)
-- Optimize the `$prop` helper (#2597)
-- Improve `Array.push()` performance when pushing many items (#2565)
-- 
-
-### Internal
-
-- Update rubocop (#2535)
-- Match3Node Cleanup (#2541)
-- IFlipFlop/EFlipFlop: Refactor for readability (#2541)
-- ForRewriter: Refactor for readability (#2541)

data/lib/opal/nodes/args/parameters.rb

@@ -10,25 +10,28 @@ module Opal
 
         def to_code
           stringified_parameters = @args.map do |arg|
-            public_send(:"on_#{arg.type}", *arg)
+            public_send(:"on_#{arg.type}", arg)
           end
 
           "[#{stringified_parameters.compact.join(', ')}]"
         end
 
-        def on_arg(arg_name)
+        def on_arg(arg)
+          arg_name = arg.meta[:arg_name]
           %{['req', '#{arg_name}']}
         end
 
-        def on_mlhs(*)
+        def on_mlhs(_arg)
           %{['req']}
         end
 
-        def on_optarg(arg_name, _default_value)
+        def on_optarg(arg)
+          arg_name = arg.meta[:arg_name]
           %{['opt', '#{arg_name}']}
         end
 
-        def on_restarg(arg_name = nil)
+        def on_restarg(arg)
+          arg_name = arg.meta[:arg_name]
           if arg_name
             arg_name = :* if arg_name == :fwd_rest_arg
             %{['rest', '#{arg_name}']}
@@ -37,15 +40,18 @@ module Opal
           end
         end
 
-        def on_kwarg(arg_name)
+        def on_kwarg(arg)
+          arg_name = arg.meta[:arg_name]
           %{['keyreq', '#{arg_name}']}
         end
 
-        def on_kwoptarg(arg_name, _default_value)
+        def on_kwoptarg(arg)
+          arg_name = arg.meta[:arg_name]
           %{['key', '#{arg_name}']}
         end
 
-        def on_kwrestarg(arg_name = nil)
+        def on_kwrestarg(arg)
+          arg_name = arg.meta[:arg_name]
           if arg_name
             %{['keyrest', '#{arg_name}']}
           else
@@ -53,16 +59,17 @@ module Opal
           end
         end
 
-        def on_blockarg(arg_name)
+        def on_blockarg(arg)
+          arg_name = arg.meta[:arg_name]
           arg_name = :& if arg_name == :fwd_block_arg
           %{['block', '#{arg_name}']}
         end
 
-        def on_kwnilarg
+        def on_kwnilarg(_arg)
           %{['nokey']}
         end
 
-        def on_shadowarg(_arg_name); end
+        def on_shadowarg(_arg); end
       end
     end
   end

data/lib/opal/nodes/args.rb

@@ -25,40 +25,12 @@ module Opal
     class ArgsNode < Base
       handle :args
 
-      # ruby allows for args with the same name, if the arg starts with a '_', like:
-      #   def funny_method_name(_, _)
-      #     puts _
-      #   end
-      # but javascript in strict mode does not allow for args with the same name
-      # ruby assigns the value of the first arg given
-      #   funny_method_name(1, 2) => 1
-      # 1. check for args starting with '_' and check if they appear multiple times
-      # 2. leave the first appearance as it is and rename the other ones
-      # compiler result:
-      #   function $$funny_method_name(_, __$2)
-
       def compile
-        same_arg_counter = {}
         children.each_with_index do |arg, idx|
-          if multiple_underscore?(arg)
-            same_arg_counter[arg] ||= 0
-            same_arg_counter[arg]  += 1
-            if same_arg_counter[arg] > 1
-              arg = s(arg.type, :"#{arg.children[0]}_$#{same_arg_counter[arg]}")
-            end
-          end
-
           push ', ' if idx != 0
           push process(arg)
         end
       end
-
-      def multiple_underscore?(arg)
-        arg.type == :arg &&
-          arg.children.count == 1 &&
-          arg.children.first.to_s.start_with?('_') &&
-          children.count(arg) > 1
-      end
     end
   end
 end

data/lib/opal/nodes/super.rb

@@ -176,7 +176,6 @@ module Opal
       def implicit_arglist
         args = []
         kwargs = []
-        same_arg_counter = Hash.new(0)
 
         def_scope.original_args.children.each do |sexp|
           lvar_name = sexp.children[0]
@@ -184,14 +183,6 @@ module Opal
           case sexp.type
           when :arg, :optarg
             arg_node = s(:lvar, lvar_name)
-            #   def m(_, _)
-            # is compiled to
-            #   function $$m(_, __$2)
-            # See Opal::Node::ArgsNode
-            if lvar_name[0] == '_'
-              same_arg_counter[lvar_name] += 1
-              arg_node = s(:js_tmp, "#{lvar_name}_$#{same_arg_counter[lvar_name]}") if same_arg_counter[lvar_name] > 1
-            end
             args << arg_node
           when :restarg
             arg_node = lvar_name ? s(:lvar, lvar_name) : s(:js_tmp, '$rest_arg')

data/lib/opal/rewriter.rb

@@ -11,6 +11,7 @@ require 'opal/rewriters/logical_operator_assignment'
 require 'opal/rewriters/binary_operator_assignment'
 require 'opal/rewriters/hashes/key_duplicates_rewriter'
 require 'opal/rewriters/dump_args'
+require 'opal/rewriters/deduplicate_arg_name'
 require 'opal/rewriters/mlhs_args'
 require 'opal/rewriters/inline_args'
 require 'opal/rewriters/numblocks'
@@ -66,6 +67,7 @@ module Opal
     use Rewriters::BinaryOperatorAssignment
     use Rewriters::Hashes::KeyDuplicatesRewriter
     use Rewriters::ReturnableLogic
+    use Rewriters::DeduplicateArgName
     use Rewriters::DumpArgs
     use Rewriters::MlhsArgs
     use Rewriters::InlineArgs

data/lib/opal/rewriters/deduplicate_arg_name.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+module Opal
+  module Rewriters
+    # Ruby allows for args with the same name, if the arg starts with a '_', like:
+    #   def funny_method_name(_, _)
+    #     puts _
+    #   end
+    # but JavaScript in strict mode does not allow for args with the same name
+    # Ruby assigns the value of the first arg given
+    #   funny_method_name(1, 2) => 1
+    # leave the first appearance as it is and rename the other ones
+    # compiler result:
+    #   function $$funny_method_name(_, __$2)
+    class DeduplicateArgName < Base
+      def on_args(node)
+        @arg_name_count = Hash.new(0)
+
+        children = node.children.map do |arg|
+          rename_arg(arg)
+        end
+
+        super(node.updated(nil, children))
+      end
+
+      def rename_arg(arg)
+        case arg.type
+        when :arg, :restarg, :kwarg, :kwrestarg, :blockarg
+          name = arg.children[0]
+          name ? arg.updated(nil, [unique_name(name)]) : arg
+        when :optarg, :kwoptarg
+          name, value = arg.children
+          arg.updated(nil, [unique_name(name), value])
+        when :mlhs
+          new_children = arg.children.map { |child| rename_arg(child) }
+          arg.updated(nil, new_children)
+        else
+          arg
+        end
+      end
+
+      def unique_name(name)
+        count = (@arg_name_count[name] += 1)
+        count > 1 ? :"#{name}_$#{count}" : name
+      end
+    end
+  end
+end

data/lib/opal/rewriters/inline_args.rb

@@ -91,7 +91,6 @@ module Opal
           @initialization = []
 
           @type = type
-          @underscore_found = false
 
           STEPS.each do |step|
             send(step)
@@ -120,20 +119,9 @@ module Opal
           @args.args.each do |arg|
             if @type == :iter
               # block args are not required,
-              # so we neeed to tell compiler that required args
+              # so we need to tell compiler that required args
               # must be initialized with nil-s
               @initialization << arg.updated(:initialize_iter_arg)
-
-              if arg.children[0] == :_
-                if @underscore_found
-                  # for proc { |_, _| _ }.call(1, 2) result must be 1
-                  # here we convert all underscore args starting from the 2nd
-                  # to a "fake" arg
-                  arg = s(:fake_arg)
-                end
-
-                @underscore_found = true
-              end
             else
               # required inline def argument like 'def m(req)'
               # no initialization is required

data/lib/opal/version.rb

@@ -3,5 +3,5 @@
 module Opal
   # WHEN RELEASING:
   # Remember to update RUBY_ENGINE_VERSION in opal/corelib/constants.rb too!
-  VERSION = '1.8.0.beta1'
+  VERSION = '1.8.1'
 end

data/opal/corelib/array.rb

@@ -47,7 +47,7 @@ class ::Array < `Array`
     function filterIf(self, filter, block) {
       var value, raised = null, updated = new Array(self.length);
 
-      for (var i = 0, i2 = 0, length = self.length; i < length; i++) {
+      for (var i = 0, i2 = 0; i < self.length; i++) {
         if (!raised) {
           try {
             value = $yield1(block, self[i])
@@ -708,10 +708,9 @@ class ::Array < `Array`
     return enum_for(:collect) { size } unless block_given?
 
     %x{
-      var length = self.length;
-      var result = new Array(length);
+      var result = [];
 
-      for (var i = 0; i < length; i++) {
+      for (var i = 0; i < self.length; i++) {
         var value = $yield1(block, self[i]);
         result[i] = value;
       }
@@ -726,7 +725,7 @@ class ::Array < `Array`
     %x{
       $deny_frozen_access(self);
 
-      for (var i = 0, length = self.length; i < length; i++) {
+      for (var i = 0; i < self.length; i++) {
         var value = $yield1(block, self[i]);
         self[i] = value;
       }
@@ -988,8 +987,8 @@ class ::Array < `Array`
     return enum_for(:each) { size } unless block_given?
 
     %x{
-      for (var i = 0, length = self.length; i < length; i++) {
-        var value = $yield1(block, self[i]);
+      for (var i = 0; i < self.length; i++) {
+        $yield1(block, self[i]);
       }
     }
 
@@ -1000,8 +999,8 @@ class ::Array < `Array`
     return enum_for(:each_index) { size } unless block_given?
 
     %x{
-      for (var i = 0, length = self.length; i < length; i++) {
-        var value = $yield1(block, i);
+      for (var i = 0; i < self.length; i++) {
+        $yield1(block, i);
       }
     }
 
@@ -1348,7 +1347,7 @@ class ::Array < `Array`
         }
       }
       else if (block !== nil) {
-        for (i = 0, length = self.length; i < length; i++) {
+        for (i = 0; i < self.length; i++) {
           value = block(self[i]);
 
           if (value !== false && value !== nil) {
@@ -1789,7 +1788,7 @@ class ::Array < `Array`
     %x{
       var result = [];
 
-      for (var i = 0, length = self.length, value; i < length; i++) {
+      for (var i = 0, value; i < self.length; i++) {
         value = block(self[i]);
 
         if (value === false || value === nil) {
@@ -1839,7 +1838,11 @@ class ::Array < `Array`
   def reverse_each(&block)
     return enum_for(:reverse_each) { size } unless block_given?
 
-    reverse.each(&block)
+    %x{
+      for (var i = self.length - 1; i >= 0; i--) {
+        $yield1(block, self[i]);
+      }
+    }
     self
   end
 
@@ -2048,7 +2051,7 @@ class ::Array < `Array`
     %x{
       var result = [];
 
-      for (var i = 0, length = self.length, item, value; i < length; i++) {
+      for (var i = 0, item, value; i < self.length; i++) {
         item = self[i];
 
         value = $yield1(block, item);
@@ -2293,7 +2296,7 @@ class ::Array < `Array`
     %x{
       var result = [];
 
-      for (var i = 0, length = self.length, item, value; i < length; i++) {
+      for (var i = 0, item, value; i < self.length; i++) {
         item = self[i];
 
         value = block(item);
@@ -2389,7 +2392,7 @@ class ::Array < `Array`
         }
       }
       else {
-        for (i = 0, length = self.length; i < length; i++) {
+        for (i = 0; i < self.length; i++) {
           item = self[i];
           key = $yield1(block, item);
           if ($hash_get(hash, key) === undefined) {
@@ -2406,23 +2409,24 @@ class ::Array < `Array`
     %x{
       $deny_frozen_access(self);
 
-      var original_length = self.length, hash = #{{}}, i, length, item, key;
+      var hash = #{{}}, i, item, key, delete_indexes = [];
 
-      for (i = 0, length = original_length; i < length; i++) {
+      for (i = 0; i < self.length; i++) {
         item = self[i];
         key = (block === nil ? item : $yield1(block, item));
 
         if ($hash_get(hash, key) === undefined) {
           $hash_put(hash, key, item);
-          continue;
+        } else {
+          delete_indexes.push(i);
         }
+      }
 
-        self.splice(i, 1);
-        length--;
-        i--;
+      for (i = delete_indexes.length - 1; i >= 0; i--) {
+        self.splice(delete_indexes[i], 1);
       }
 
-      return self.length === original_length ? nil : self;
+      return delete_indexes.length === 0 ? nil : self;
     }
   end
 

data/opal/corelib/constants.rb

@@ -1,8 +1,8 @@
 ::RUBY_PLATFORM       = 'opal'
 ::RUBY_ENGINE         = 'opal'
 ::RUBY_VERSION        = '3.2.0'
-::RUBY_ENGINE_VERSION = '1.8.0.beta1'
-::RUBY_RELEASE_DATE   = '2023-10-12'
+::RUBY_ENGINE_VERSION = '1.8.1'
+::RUBY_RELEASE_DATE   = '2023-11-09'
 ::RUBY_PATCHLEVEL     = 0
 ::RUBY_REVISION       = '0'
 ::RUBY_COPYRIGHT      = 'opal - Copyright (C) 2011-2023 Adam Beynon and the Opal contributors'