opal 1.7.3 → 1.8.0.alpha1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8af0b92263196be9125b7ba0d1133b9a157aed0da2d91e282320ef8a8ce9a1a3
-  data.tar.gz: 8d05dfd7e6dcc883c27f674ddebc84e57c29e80c33b981d70118f44d869d80d0
+  metadata.gz: c756d4ba883cb8f7c7bdfefa6b88cf4a2db0604d1ef8a906d7c58add76eee1bf
+  data.tar.gz: e88f7de8d6add79b64c7d6b896fbd1c94f51edd34754e6da3ceb59e3fa501134
 SHA512:
-  metadata.gz: 52adf7dafb792d434e9d423d0f4340df8d114071e94de6165856e8396476bfca9193ba1831464bf2f701e9978f9a7674de3590680f8a1264e542cd1f0715f2b2
-  data.tar.gz: 6f73fb32a7837daf9ad771a75cb0f549b0a69a968b8f18fa40d1a05f66ac61109dde51b6e9717def8942dd4068c532dc413e0fdb2541d80ab7596db3d6ed4db1
+  metadata.gz: 1d9e3b8b4cc8decc9fc5644eb842ee84290bb0c6f231de362d259a691570296ac9fab95e400dccda20d317e12b7f3d58334d816a8f5279b304d0435d15ac699f
+  data.tar.gz: '02883fef4e6869c54b718c370ddd03a934e50698eb37638da6788d212286fbc57ecab6c5e0c2c46bd02931ff75e39455f09a6de462157433b03cb8535d1ce76b'

data/.eslintrc.js

@@ -33,5 +33,6 @@ module.exports = {
     "Reflect": "readonly",
     "Uint8Array": "readonly",
     "WeakRef": "readonly",
+    "Map": "readonly",
   }
 };

data/.github/workflows/build.yml

@@ -4,8 +4,8 @@ on:
   push:
     branches:
       - master
-      - "*-stable"
-      - "*/ci-check"
+      - '*-stable'
+      - '*/ci-check'
   pull_request: {}
 
 permissions:
@@ -59,13 +59,13 @@ jobs:
             command: bundle exec rake mspec_chrome
             ruby: '3.0'
             os: windows-latest
-          - name: windows-mspec-firefox
-            env:
-              # when changing version, also change it below and above
-              MOZILLA_FIREFOX_BINARY: 'C:/Program Files/Firefox_106.0.4/firefox.exe'
-            ruby: '3.0'
-            command: bundle exec rake mspec_firefox
-            os: windows-latest
+          # - name: windows-mspec-firefox
+          #   env:
+          #     # when changing version, also change it below and above
+          #     MOZILLA_FIREFOX_BINARY: 'C:/Program Files/Firefox_106.0.4/firefox.exe'
+          #   ruby: '3.0'
+          #   command: bundle exec rake mspec_firefox
+          #   os: windows-latest
           - name: macos-mspec-safari
             command: bundle exec rake mspec_safari
             ruby: '3.0'

data/.rubocop/todo.yml

@@ -1,6 +1,6 @@
 # All items in this file require fixing
 
-Metrics/LineLength:
+Layout/LineLength:
   Enabled: false
 
 Lint/AssignmentInCondition:
@@ -33,7 +33,7 @@ Style/MutableConstant:
     - 'lib/opal/nodes/call.rb'
     - 'lib/opal/util.rb'
 
-Lint/HandleExceptions:
+Lint/SuppressedException:
   Exclude:
     - 'stdlib/ostruct.rb'
 

data/.rubocop.yml

@@ -1,8 +1,14 @@
+inherit_from:
+  - .rubocop_todo.yml
+  - .rubocop/todo.yml
+
 require: rubocop-performance
-inherit_from: .rubocop/todo.yml
+
 
 AllCops:
-  TargetRubyVersion: 2.6
+  TargetRubyVersion: 3.0
+  NewCops: disable
+  SuggestExtensions: false
   Exclude:
     - CHANGELOG.md
     - CONDUCT.md
@@ -78,7 +84,7 @@ Layout/CommentIndentation:
     - 'lib/opal/source_map/file.rb'
 
 # We need to support older rubies
-Layout/IndentHeredoc:
+Layout/HeredocIndentation:
   Enabled: false
 
 Style/FrozenStringLiteralComment:
@@ -104,7 +110,7 @@ Layout/ExtraSpacing:
     # This files uses extra spaces to show an inheritance tree of error classes
     - 'opal/corelib/error.rb'
 
-Layout/IndentArray:
+Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
 
 Layout/SpaceAroundOperators:
@@ -147,7 +153,7 @@ Lint/RescueException:
     - 'stdlib/promise.rb'
     - 'opal/corelib/binding.rb'
 
-Lint/StringConversionInInterpolation:
+Lint/RedundantStringCoercion:
   Exclude:
     # That's what MRI does
     - 'opal/corelib/error.rb'
@@ -208,7 +214,7 @@ Naming/BinaryOperatorParameterName:
 
 Naming/PredicateName:
   # Ruby has "has_key?" method
-  NamePrefixBlacklist: is_, have_
+  ForbiddenPrefixes: is_, have_
 
 Performance/FlatMap:
   Exclude:
@@ -267,7 +273,7 @@ Style/InverseMethods:
     - 'opal/corelib/basic_object.rb'
     - 'opal/corelib/kernel.rb'
 
-Style/MethodMissingSuper:
+Lint/MissingSuper:
   # Base Opal classes simply can't or shouldn't call super for #method_missing
   Exclude:
     - 'opal/corelib/basic_object.rb'
@@ -318,7 +324,7 @@ Style/TrailingCommaInArguments:
   # Any style is allowed
   Enabled: false
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   EnforcedStyle: with_fixed_indentation
 
 Layout/MultilineMethodCallBraceLayout:
@@ -371,6 +377,7 @@ Naming/ConstantName:
   Exclude:
     # MRI has a constant BigDecimal::SIGN_NaN
     - 'stdlib/bigdecimal.rb'
+    - 'stdlib/opal-platform.rb'
 
 Security/Eval:
   Exclude:
@@ -395,7 +402,7 @@ Style/TrailingCommaInHashLiteral:
   # Any style is allowed
   Enabled: false
 
-Naming/UncommunicativeMethodParamName:
+Naming/MethodParameterName:
   Exclude:
     # This file uses parser's code that doesn't match our styling requirements
     - 'lib/opal/parser/patch.rb'
@@ -436,7 +443,7 @@ Style/MultipleComparison:
 Layout/EmptyLineAfterGuardClause:
   Enabled: false
 
-Layout/AlignHash:
+Layout/HashAlignment:
   Enabled: false
 
 # No way to set multiple preferred names

data/.rubocop_todo.yml

@@ -0,0 +1,311 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2023-05-09 13:13:04 UTC using RuboCop version 1.50.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 30
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, IndentationWidth.
+# SupportedStyles: with_first_argument, with_fixed_indentation
+Layout/ArgumentAlignment:
+  Exclude:
+    - 'lib/opal/builder.rb'
+    - 'lib/opal/cli.rb'
+    - 'lib/opal/cli_options.rb'
+    - 'lib/opal/nodes/call_special.rb'
+    - 'lib/opal/repl.rb'
+    - 'lib/opal/rewriters/arguments.rb'
+    - 'lib/opal/rewriters/forward_args.rb'
+    - 'lib/opal/rewriters/opal_engine_check.rb'
+    - 'lib/opal/rewriters/returnable_logic.rb'
+    - 'opal/corelib/complex.rb'
+    - 'stdlib/date.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyleAlignWith, Severity.
+# SupportedStylesAlignWith: start_of_line, begin
+Layout/BeginEndAlignment:
+  Exclude:
+    - 'lib/opal/cache.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowForAlignment.
+Layout/CommentIndentation:
+  Exclude:
+    - 'stdlib/opal-platform.rb'
+
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EmptyLineBetweenMethodDefs, EmptyLineBetweenClassDefs, EmptyLineBetweenModuleDefs, AllowAdjacentOneLineDefs, NumberOfEmptyLines.
+Layout/EmptyLineBetweenDefs:
+  Exclude:
+    - 'stdlib/bigdecimal/util.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: around, only_before
+Layout/EmptyLinesAroundAccessModifier:
+  Exclude:
+    - 'stdlib/ruby2_keywords.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowAliasSyntax, AllowedMethods.
+# AllowedMethods: alias_method, public, protected, private
+Layout/EmptyLinesAroundAttributeAccessor:
+  Exclude:
+    - 'opal/corelib/string/encoding.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only
+Layout/EmptyLinesAroundClassBody:
+  Exclude:
+    - 'opal/corelib/string/__old__mutable.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
+# SupportedStylesForExponentOperator: space, no_space
+Layout/SpaceAroundOperators:
+  Exclude:
+    - 'lib/opal/regexp_anchors.rb'
+
+# Offense count: 25
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: space, no_space
+Layout/SpaceInsideStringInterpolation:
+  Exclude:
+    - 'lib/opal/nodes/literal.rb'
+    - 'opal/corelib/array.rb'
+    - 'opal/corelib/hash.rb'
+    - 'opal/corelib/kernel.rb'
+    - 'opal/corelib/number.rb'
+
+# Offense count: 2
+# Configuration parameters: AllowComments.
+Lint/EmptyFile:
+  Exclude:
+    - 'stdlib/fileutils.rb'
+    - 'stdlib/iconv.rb'
+
+# Offense count: 1
+Lint/FloatComparison:
+  Exclude:
+    - 'opal/corelib/rational.rb'
+
+# Offense count: 13
+# This cop supports safe autocorrection (--autocorrect).
+Lint/LiteralInInterpolation:
+  Exclude:
+    - 'opal/corelib/array.rb'
+    - 'opal/corelib/enumerable.rb'
+    - 'opal/corelib/module.rb'
+    - 'opal/corelib/proc.rb'
+    - 'opal/corelib/time.rb'
+
+# Offense count: 26
+Lint/MissingSuper:
+  Enabled: false
+
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
+Lint/RedundantCopDisableDirective:
+  Exclude:
+    - 'lib/opal/cli.rb'
+    - 'lib/opal/rewriters/thrower_finder.rb'
+    - 'stdlib/delegate.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Lint/RedundantRequireStatement:
+  Exclude:
+    - 'stdlib/delegate.rb'
+    - 'stdlib/opal-replutils.rb'
+
+# Offense count: 11
+# This cop supports safe autocorrection (--autocorrect).
+Lint/RedundantStringCoercion:
+  Exclude:
+    - 'lib/opal/cli_runners/safari.rb'
+    - 'opal/corelib/array.rb'
+    - 'opal/corelib/kernel/format.rb'
+    - 'opal/corelib/marshal/read_buffer.rb'
+    - 'opal/corelib/string.rb'
+    - 'stdlib/date.rb'
+    - 'stdlib/nodejs/env.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowedPatterns.
+# AllowedPatterns: (?-mix:(exactly|at_least|at_most)\(\d+\)\.times)
+Lint/UnreachableLoop:
+  Exclude:
+    - 'opal/corelib/enumerable.rb'
+
+# Offense count: 6
+# This cop supports safe autocorrection (--autocorrect).
+Performance/BindCall:
+  Exclude:
+    - 'opal/corelib/marshal/write_buffer.rb'
+    - 'opal/corelib/method.rb'
+    - 'stdlib/native.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Performance/RedundantBlockCall:
+  Exclude:
+    - 'stdlib/deno/file.rb'
+    - 'stdlib/nodejs/file.rb'
+
+# Offense count: 21
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: separated, grouped
+Style/AccessorGrouping:
+  Exclude:
+    - 'lib/opal/cli.rb'
+    - 'lib/opal/nodes/node_with_args.rb'
+    - 'lib/opal/nodes/scope.rb'
+    - 'lib/opal/source_map/file.rb'
+    - 'opal/corelib/string/encoding.rb'
+    - 'stdlib/logger.rb'
+    - 'stdlib/strscan.rb'
+
+# Offense count: 4
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: MinBranchesCount.
+Style/CaseLikeIf:
+  Exclude:
+    - 'lib/opal/nodes/call.rb'
+    - 'opal/corelib/complex.rb'
+    - 'opal/corelib/marshal/read_buffer.rb'
+    - 'opal/corelib/marshal/write_buffer.rb'
+
+# Offense count: 6
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+# AllowedMethods: ==, equal?, eql?
+Style/ClassEqualityComparison:
+  Exclude:
+    - 'lib/opal/fragment.rb'
+    - 'lib/opal/rewriters/pattern_matching.rb'
+    - 'opal/corelib/marshal/read_buffer.rb'
+    - 'opal/corelib/marshal/write_buffer.rb'
+    - 'opal/corelib/struct.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Keywords, RequireColon.
+# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE
+Style/CommentAnnotation:
+  Exclude:
+    - 'stdlib/delegate.rb'
+
+# Offense count: 8
+# This cop supports safe autocorrection (--autocorrect).
+Style/ExplicitBlockArgument:
+  Exclude:
+    - 'lib/opal/cli_runners/chrome.rb'
+    - 'lib/opal/cli_runners/firefox.rb'
+    - 'lib/opal/cli_runners/safari.rb'
+    - 'opal/corelib/enumerable.rb'
+    - 'opal/corelib/set.rb'
+    - 'stdlib/date.rb'
+    - 'stdlib/ostruct.rb'
+
+# Offense count: 16
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/GlobalStdStream:
+  Exclude:
+    - 'lib/opal/cli_runners/safari.rb'
+    - 'opal/corelib/io.rb'
+    - 'stdlib/deno/base.rb'
+    - 'stdlib/nodejs/base.rb'
+
+# Offense count: 2
+# Configuration parameters: MinBranchesCount.
+Style/HashLikeCase:
+  Exclude:
+    - 'lib/opal/fragment.rb'
+    - 'stdlib/buffer.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/MultilineWhenThen:
+  Exclude:
+    - 'lib/opal/builder.rb'
+
+# Offense count: 43
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
+  Enabled: false
+
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantAssignment:
+  Exclude:
+    - 'lib/opal/nodes/args/arity_check.rb'
+    - 'lib/opal/parser/default_config.rb'
+    - 'opal/corelib/file.rb'
+    - 'stdlib/shellwords.rb'
+
+# Offense count: 13
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantFreeze:
+  Exclude:
+    - 'lib/opal/erb.rb'
+    - 'lib/opal/magic_comments.rb'
+    - 'lib/opal/nodes/literal.rb'
+    - 'lib/opal/path_reader.rb'
+    - 'lib/opal/rewriters/js_reserved_words.rb'
+
+# Offense count: 15
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantRegexpEscape:
+  Exclude:
+    - 'lib/opal/compiler.rb'
+    - 'lib/opal/nodes/helpers.rb'
+    - 'opal/corelib/file.rb'
+    - 'stdlib/shellwords.rb'
+
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Exclude:
+    - 'lib/opal/compiler.rb'
+    - 'stdlib/bigdecimal.rb'
+    - 'stdlib/pathname.rb'
+
+# Offense count: 35
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/SlicingWithRange:
+  Enabled: false
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowModifier.
+Style/SoleNestedConditional:
+  Exclude:
+    - 'lib/opal/nodes/if.rb'
+
+# Offense count: 24
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Mode.
+Style/StringConcatenation:
+  Enabled: false
+
+# Offense count: 3
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/ZeroLengthPredicate:
+  Exclude:
+    - 'lib/opal/source_map/file.rb'

data/UNRELEASED.md

@@ -1,10 +1,87 @@
 <!--
 ### Internal
-### Changed
 ### Added
 ### Removed
 ### Deprecated
 ### Performance
 ### Fixed
+### Documentation
 -->
 
+## Highlights
+
+### `Hash` is now bridged to JavaScript `Map`
+
+This change brings a lot of benefits, but also some incompatibilities. The main benefit is that `Hash` now is both more performant and relies on native JavaScript capabilities.
+This improves interoperability with JavaScript. As a downside, applications reaching for internal `Hash` data structures will need to be updated.
+
+Interacting with `Hash` from `JavaScript` is easier than ever:
+
+```ruby
+hash = `new Map([['a', 1], ['b', 2]])`
+hash # => {a: 1, b: 2}
+`console.log(hash)` # => Map(2) {"a" => 1, "b" => 2}
+`hash.get('a')` # => 1
+`hash.set('c', 3)`
+hash # => {a: 1, b: 2, c: 3}
+hash.keys # => ["a", "b", "c"]
+hash.values # => [1, 2, 3]
+```
+
+### Performance improvements
+
+This release brings a lot of performance improvements, our tests on Asciidoctor show a 25% improvement in performance, but we've seen up to 66% performance improvement on some applications.
+
+## Changelog
+
+### Deprecated
+
+- Deprecate using x-string to access JavaScript without an explicit magic-comment (#2543)
+
+### Compatibility
+
+- Add a magic-comment that will disable x-string compilation to JavaScript (#2543)
+
+### Fixed
+
+- Fix `Kernel#Float` with `exception:` option (#2532)
+- Fix `Kernel#Integer` with `exception:` option (#2531)
+- Fix `String#split` with limit and capturing regexp (#2544)
+- Fix `switch` with Object-wrapped values (#2542)
+- Fix non-direct subclasses of bridged classes not calling the original constructor (#2546)
+- Regexp.escape: Cast to String or drop exception (#2552)
+- Propagate removal of method from included/prepended modules (#2553)
+- Restore `nodejs/yaml` functionality (#2551)
+- Fix sine `Range#size` edge cases (#2541)
+
+### Added
+
+- SourceMap support for `Kernel#eval` (#2534)
+- Add `CGI::Util#escapeURIComponent` and `CGI::Util#unescapeURIComponent` (#2566)
+
+### Changed
+
+- Change compilation of Regexp nodes that may contain advanced features, so if invalid that they would raise at runtime, not parse-time (#2548)
+- `Hash` is now bridged to JavaScript `Map` and support for non-symbol keys in keyword arguments (#2568)
+
+### Documentation
+
+- Bridging documentation (#2541)
+
+### Performance
+
+- Improve performance of `Array#intersect?` and `#intersection` (#2533)
+- `Proc#call`: Refactor for performance (#2541)
+- Opal.stub_for: optimize (#2541)
+- Hash: Optimize `#to_a` (#2541)
+- Array: Optimize `#collect`/`#map` (#2541)
+- Optimize argument slicing in runtime for performance (#2555)
+- Closure: Generate a JavaScript object, not an Error, gain up to 15% on Asciidoctor (#2556)
+- Optimize `String#split` and `String#start_with` (#2560)
+
+### Internal
+
+- Update rubocop (#2535)
+- Match3Node Cleanup (#2541)
+- IFlipFlop/EFlipFlop: Refactor for readability (#2541)
+- ForRewriter: Refactor for readability (#2541)

data/benchmark-ips/bm_block_vs_yield.rb

@@ -9,6 +9,9 @@ module BmBlockVsYield
 end
 
 Benchmark.ips do |x|
+  x.warmup = 10
+  x.time = 60
+
   x.report('block') do
     BmBlockVsYield._block { 1+1 }
   end

data/benchmark-ips/bm_slice_or_not.rb

@@ -0,0 +1,53 @@
+%x{
+  // Minify common function calls
+  var $call      = Function.prototype.call;
+  var $bind      = Function.prototype.bind;
+  var $has_own   = Object.hasOwn || $call.bind(Object.prototype.hasOwnProperty);
+  var $set_proto = Object.setPrototypeOf;
+  var $slice     = $call.bind(Array.prototype.slice);
+  var $splice    = $call.bind(Array.prototype.splice);
+
+  var cnt = 0;
+  var fun = function(a,b,c) {
+    cnt += a + b + c;
+  }
+}
+
+Benchmark.ips do |x|
+  ary = [1,2,3]
+  obj = `{0: 1, 1: 2, 2: 3, length: 3}`
+
+  x.report('Array.from(array)') do
+    `fun.apply(null, Array.from(ary))`
+  end
+
+  x.report('Array.from(obj)') do
+    `fun.apply(null, Array.from(obj))`
+  end
+
+  x.report('$slice(array)') do
+    `fun.apply(null, $slice(ary))`
+  end
+
+  x.report('$slice(obj)') do
+    `fun.apply(null, $slice(obj))`
+  end
+
+  x.report('array') do
+    `fun.apply(null, ary)`
+  end
+
+  x.report('obj') do
+    `fun.apply(null, obj)`
+  end
+
+  x.report('$slice?(array)') do
+    `fun.apply(null, ary.$$is_array ? ary : $slice(ary))`
+  end
+
+  x.report('$slice?(obj)') do
+    `fun.apply(null, obj.$$is_array ? obj : $slice(obj))`
+  end
+
+  x.compare!
+end