RubyGems - opal - Versions diffs - 1.7.0 → 1.7.1 - Mend

opal 1.7.0 → 1.7.1

Files changed (45) hide show

checksums.yaml +4 -4
data/.github/workflows/build.yml +12 -4
data/CHANGELOG.md +29 -1
data/exe/opal +5 -7
data/lib/opal/builder.rb +13 -13
data/lib/opal/builder_processors.rb +8 -2
data/lib/opal/builder_scheduler/prefork.rb +60 -6
data/lib/opal/cli.rb +59 -43
data/lib/opal/cli_runners/compiler.rb +7 -6
data/lib/opal/cli_runners/safari.rb +208 -0
data/lib/opal/cli_runners.rb +1 -0
data/lib/opal/nodes/literal.rb +16 -0
data/lib/opal/version.rb +1 -1
data/opal/corelib/constants.rb +2 -2
data/spec/filters/platform/.keep +0 -0
data/spec/filters/platform/firefox/exception.rb +8 -0
data/spec/filters/platform/firefox/kernel.rb +3 -0
data/spec/filters/platform/safari/exception.rb +8 -0
data/spec/filters/platform/safari/float.rb +4 -0
data/spec/filters/platform/safari/kernel.rb +3 -0
data/spec/filters/platform/safari/literal_regexp.rb +6 -0
data/spec/lib/builder_spec.rb +32 -0
data/spec/lib/cli_spec.rb +18 -6
data/spec/lib/fixtures/build_order/file1.js +1 -0
data/spec/lib/fixtures/build_order/file2.js +1 -0
data/spec/lib/fixtures/build_order/file3.js +1 -0
data/spec/lib/fixtures/build_order/file4.js +1 -0
data/spec/lib/fixtures/build_order/file5.rb.erb +4 -0
data/spec/lib/fixtures/build_order/file51.js +1 -0
data/spec/lib/fixtures/build_order/file6.rb +10 -0
data/spec/lib/fixtures/build_order/file61.rb +1 -0
data/spec/lib/fixtures/build_order/file62.rb +4 -0
data/spec/lib/fixtures/build_order/file63.rb +4 -0
data/spec/lib/fixtures/build_order/file64.rb +1 -0
data/spec/lib/fixtures/build_order/file7.rb +1 -0
data/spec/lib/fixtures/build_order.rb +9 -0
data/spec/lib/rake_dist_spec.rb +69 -0
data/spec/mspec-opal/runner.rb +1 -0
data/spec/opal/core/io/read_spec.rb +12 -3
data/stdlib/opal/platform.rb +1 -0
data/stdlib/opal-platform.rb +3 -0
data/stdlib/time.rb +21 -1
data/tasks/building.rake +1 -1
data/tasks/testing.rake +3 -4
metadata +29 -6

data/lib/opal/cli_runners/safari.rb ADDED Viewed

@@ -0,0 +1,208 @@
+# frozen_string_literal: true
+require 'shellwords'
+require 'socket'
+require 'timeout'
+require 'tmpdir'
+require 'rbconfig'
+require 'opal/os'
+require 'net/http'
+require 'webrick'
+module Opal
+  module CliRunners
+    class Safari
+      EXECUTION_TIMEOUT = 600 # seconds
+      DEFAULT_SAFARI_DRIVER_HOST = 'localhost'
+      DEFAULT_SAFARI_DRIVER_PORT = 9444 # in addition safari_driver_port + 1 is used for the http server
+      def self.call(data)
+        runner = new(data)
+        runner.run
+      end
+      def initialize(data)
+        argv = data[:argv]
+        if argv && argv.any?
+          warn "warning: ARGV is not supported by the Safari runner #{argv.inspect}"
+        end
+        options  = data[:options]
+        @output  = options.fetch(:output, $stdout)
+        @builder = data[:builder].call
+      end
+      attr_reader :output, :exit_status, :builder
+      def run
+        mktmpdir do |dir|
+          with_http_server(dir) do |http_port, server_thread|
+            with_safari_driver do
+              prepare_files_in(dir)
+              # Safaridriver commands are very limitied, for supported commands see:
+              # https://developer.apple.com/documentation/webkit/macos_webdriver_commands_for_safari_12_and_later
+              Net::HTTP.start(safari_driver_host, safari_driver_port) do |con|
+                con.read_timeout = EXECUTION_TIMEOUT
+                res = con.post('/session', { capabilities: { browserName: 'Safari' } }.to_json, 'Content-Type' => 'application/json')
+                session_id = JSON.parse(res.body).dig('value', 'sessionId')
+                if session_id
+                  session_path = "/session/#{session_id}"
+                  con.post("#{session_path}/url", { url: "http://#{safari_driver_host}:#{http_port}/index.html" }.to_json, 'Content-Type' => 'application/json')
+                  server_thread.join(EXECUTION_TIMEOUT)
+                else
+                  STDERR.puts "Could not create session: #{res.body}"
+                end
+              end
+              0
+            end
+          end
+        end
+      end
+      private
+      def prepare_files_in(dir)
+        # The safaridriver is very limited in capabilities, basically it can trigger visiting sites
+        # and interact a bit with the page. So this runner starts its own server, overwrites the
+        # console log, warn, error functions of the browser and triggers a request after execution
+        # to exit. Certain exceptions cannot be caught that way and everything may fail in between,
+        # thats why execution is timed out after EXECUTION_TIMEOUT (10 minutes).
+        # As a side effect, console messages may arrive out of order and timing anything may be inaccurate.
+        builder.build_str <<~RUBY, '(exit)', no_export: true
+        %x{
+          var req = new XMLHttpRequest();
+          req.open("GET", '/exit');
+          req.send();
+        }
+        RUBY
+        js = builder.to_s
+        map = builder.source_map.to_json
+        ext = builder.output_extension
+        module_type = ' type="module"' if builder.esm?
+        File.binwrite("#{dir}/index.#{ext}", js)
+        File.binwrite("#{dir}/index.map", map)
+        File.binwrite("#{dir}/index.html", <<~HTML)
+          <html><head>
+            <meta charset='utf-8'>
+            <link rel="icon" href="data:;base64,=">
+          </head><body>
+            <script>
+              var orig_log = console.log;
+              var orig_err = console.error;
+              var orig_warn = console.warn;
+              function send_log_request(args) {
+                var req = new XMLHttpRequest();
+                req.open("POST", '/log');
+                req.setRequestHeader("Content-Type", "application/json");
+                req.send(JSON.stringify(args));
+              }
+              console.log = function() {
+                orig_log.apply(null, arguments);
+                send_log_request(arguments);
+              }
+              console.error = function() {
+                orig_err.apply(null, arguments);
+                send_log_request(arguments);
+              }
+              console.warn = function() {
+                orig_warn.apply(null, arguments);
+                send_log_request(arguments);
+              }
+            </script>
+            <script src='./index.#{ext}'#{module_type}></script>
+          </body></html>
+        HTML
+        # <script src='./index.#{ext}'#{module_type}></script>
+      end
+      def safari_driver_host
+        ENV['SAFARI_DRIVER_HOST'] || DEFAULT_SAFARI_DRIVER_HOST
+      end
+      def safari_driver_port
+        ENV['SAFARI_DRIVER_PORT'] || DEFAULT_SAFARI_DRIVER_PORT
+      end
+      def with_http_server(dir)
+        port = safari_driver_port.to_i + 1
+        server_thread = Thread.new do
+          server = WEBrick::HTTPServer.new(Port: port, DocumentRoot: dir, Logger: WEBrick::Log.new('/dev/null'), AccessLog: [])
+          server.mount_proc('/log') do |req, res|
+            if req.body
+              par = JSON.parse(req.body)
+              par.each_value do |value|
+                print value.to_s
+              end
+            end
+            res.header['Content-Type'] = 'text/plain'
+            res.body = ''
+          end
+          server.mount_proc('/exit') do
+            server_thread.kill
+          end
+          server.start
+        end
+        yield port, server_thread
+      rescue
+        exit(1)
+      ensure
+        server_thread.kill if server_thread
+      end
+      def with_safari_driver
+        if safari_driver_running?
+          yield
+        else
+          run_safari_driver { yield }
+        end
+      end
+      def run_safari_driver
+        raise 'Safari driver can be started only on localhost' if safari_driver_host != DEFAULT_SAFARI_DRIVER_HOST
+        started = false
+        safari_driver_cmd = %{/usr/bin/safaridriver \
+          -p #{safari_driver_port} \
+          #{ENV['SAFARI_DRIVER_OPTS']}}
+        safari_driver_pid = Process.spawn(safari_driver_cmd, in: OS.dev_null, out: OS.dev_null, err: OS.dev_null)
+        Timeout.timeout(30) do
+          loop do
+            break if safari_driver_running?
+            sleep 0.5
+          end
+        end
+        started = true
+        yield
+      rescue Timeout::Error => e
+        puts started ? 'Execution timed out' : 'Failed to start Safari driver'
+        raise e
+      ensure
+        Process.kill('HUP', safari_driver_pid) if safari_driver_pid
+      end
+      def safari_driver_running?
+        puts "Connecting to #{safari_driver_host}:#{safari_driver_port}..."
+        TCPSocket.new(safari_driver_host, safari_driver_port).close
+        true
+      rescue Errno::ECONNREFUSED, Errno::EADDRNOTAVAIL
+        false
+      end
+      def mktmpdir(&block)
+        Dir.mktmpdir('safari-opal-', &block)
+      end
+    end
+  end
+end

data/lib/opal/cli_runners.rb CHANGED Viewed

@@ -93,6 +93,7 @@ module Opal
     if OS.macos?
       register_runner :applescript, :Applescript, 'opal/cli_runners/applescript'
+      register_runner :safari,      :Safari,      'opal/cli_runners/safari'
       alias_runner :osascript, :applescript
     end
   end

data/lib/opal/nodes/literal.rb CHANGED Viewed

@@ -158,11 +158,27 @@ module Opal
         case value
         when ''
           push('/(?:)/')
+        when /\(\?<=|\(\?<!/
+          # Safari/WebKit will not execute javascript code if it contains a lookbehind literal RegExp
+          # and they fail with "Syntax Error". This tricks their parser by disguising the literal RegExp
+          # as string for the dynamic $regexp helper. Safari/Webkit will still fail to execute the RegExp,
+          # but at least they will parse and run everything else.
+          static_as_dynamic(value)
         else
           push "#{Regexp.new(value).inspect}#{flags.join}"
         end
       end
+      def static_as_dynamic(value)
+        helper :regexp
+        push '$regexp(["'
+        push value.gsub('\\', '\\\\\\\\')
+        push '"]'
+        push ", '#{flags.join}'" if flags.any?
+        push ")"
+      end
       def extract_flags_and_value
         *values, flags_sexp = *children
         self.flags = flags_sexp.children.map(&:to_s)

data/lib/opal/version.rb CHANGED Viewed

@@ -3,5 +3,5 @@
 module Opal
   # WHEN RELEASING:
   # Remember to update RUBY_ENGINE_VERSION in opal/corelib/constants.rb too!
-  VERSION = '1.7.0'
+  VERSION = '1.7.1'
 end

data/opal/corelib/constants.rb CHANGED Viewed

@@ -1,8 +1,8 @@
 ::RUBY_PLATFORM       = 'opal'
 ::RUBY_ENGINE         = 'opal'
 ::RUBY_VERSION        = '3.2.0'
-::RUBY_ENGINE_VERSION = '1.7.0'
-::RUBY_RELEASE_DATE   = '2022-12-26'
+::RUBY_ENGINE_VERSION = '1.7.1'
+::RUBY_RELEASE_DATE   = '2023-01-06'
 ::RUBY_PATCHLEVEL     = 0
 ::RUBY_REVISION       = '0'
 ::RUBY_COPYRIGHT      = 'opal - Copyright (C) 2013-2022 Adam Beynon and the Opal contributors'

data/spec/filters/platform/.keep ADDED Viewed

File without changes

data/spec/filters/platform/firefox/exception.rb ADDED Viewed

@@ -0,0 +1,8 @@
+# Source map support currently is only available for Chrome and Nodejs
+opal_unsupported_filter "Exception" do
+  fails "Exception#backtrace_locations sets each element to a Thread::Backtrace::Location"
+  fails "Exception#backtrace contains lines of the same format for each prior position in the stack"
+  fails "Exception#backtrace sets each element to a String"
+  fails "Invoking a method when the method is not available should omit the method_missing call from the backtrace for NoMethodError"
+  fails "Invoking a method when the method is not available should omit the method_missing call from the backtrace for NameError"
+end

data/spec/filters/platform/firefox/kernel.rb ADDED Viewed

@@ -0,0 +1,3 @@
+opal_unsupported_filter "Kernel" do
+  fails "Kernel#caller includes core library methods defined in Ruby"
+end

data/spec/filters/platform/safari/exception.rb ADDED Viewed

@@ -0,0 +1,8 @@
+# Source map support currently is only available for Chrome and Nodejs
+opal_unsupported_filter "Exception" do
+  fails "Exception#backtrace contains lines of the same format for each prior position in the stack"
+  fails "Exception#backtrace_locations sets each element to a Thread::Backtrace::Location"
+  fails "Exception#backtrace returns an Array that can be updated"
+  fails "Exception#backtrace returns the same array after duping"
+  fails "Exception#backtrace sets each element to a String"
+end

data/spec/filters/platform/safari/float.rb ADDED Viewed

@@ -0,0 +1,4 @@
+opal_filter "Float" do
+  fails "Float#fdiv performs floating-point division between self and an Integer" # Expected 8.900000000008007e-117 == 8.900000000008011e-117 to be truthy but was false
+  fails "Float#quo performs floating-point division between self and an Integer" # Expected 8.900000000008007e-117 == 8.900000000008011e-117 to be truthy but was false
+end

data/spec/filters/platform/safari/kernel.rb ADDED Viewed

@@ -0,0 +1,3 @@
+opal_unsupported_filter "Kernel" do
+  fails "Kernel#caller includes core library methods defined in Ruby"
+end

data/spec/filters/platform/safari/literal_regexp.rb ADDED Viewed

@@ -0,0 +1,6 @@
+opal_unsupported_filter "Literal Regexp" do
+  # Safari and WebKit do not support lookbehind, but may in the future see https://github.com/WebKit/WebKit/pull/7109
+  fails "Literal Regexps handles a lookbehind with ss characters"
+  fails "Literal Regexps supports (?<= ) (positive lookbehind)"
+  fails "Literal Regexps supports (?<! ) (negative lookbehind)"
+end

data/spec/lib/builder_spec.rb CHANGED Viewed

@@ -154,4 +154,36 @@ RSpec.describe Opal::Builder do
       expect(builder.build('opal/platform', requirable: true).to_s).to include(%{Opal.modules["opal/platform"]})
     end
   end
+  describe 'output order' do
+    it 'is preserved with a prefork scheduler' do
+      my_builder = builder.dup
+      my_builder.append_paths(File.expand_path('..', __FILE__))
+      my_builder.cache = Opal::Cache::NullCache.new
+      10.times do |i| # Increase entropy
+        expect(
+          my_builder.dup.build('fixtures/build_order').to_s.scan(/(FILE_[0-9]+)/).map(&:first)
+        ).to eq(%w[
+          FILE_1 FILE_2 FILE_3 FILE_4
+          FILE_51 FILE_5
+          FILE_61 FILE_62 FILE_63 FILE_64 FILE_6
+          FILE_7
+        ])
+      end
+    end
+    it 'is preserved with a sequential scheduler' do
+      temporarily_with_sequential_scheduler do
+        builder.append_paths(File.expand_path('..', __FILE__))
+        expect(
+          builder.build('fixtures/build_order').to_s.scan(/(FILE_[0-9]+)/).map(&:first)
+        ).to eq(%w[
+          FILE_1 FILE_2 FILE_3 FILE_4
+          FILE_51 FILE_5
+          FILE_61 FILE_62 FILE_63 FILE_64 FILE_6
+          FILE_7
+        ])
+      end
+    end
+  end
 end

data/spec/lib/cli_spec.rb CHANGED Viewed

@@ -9,7 +9,7 @@ RSpec.describe Opal::CLI do
   subject(:cli) { described_class.new(options) }
   context 'with a file' do
-    let(:options) { {:file => File.open(file)} }
+    let(:options) { {argv: [file]} }
     it 'runs the file' do
       expect_output_of{ subject.run }.to eq("hi from opal!\n")
@@ -26,8 +26,10 @@ RSpec.describe Opal::CLI do
   describe ':evals option' do
     context 'without evals and paths' do
-      it 'raises ArgumentError' do
-        expect { subject.run }.to raise_error(ArgumentError)
+      it 'uses stdin' do
+        expect(cli.file).to eq($stdin)
+        expect(cli.filename).to eq('-')
+        expect(cli.argv).to eq([])
       end
       context 'with lib_only: true and opal require' do
@@ -40,7 +42,7 @@ RSpec.describe Opal::CLI do
     end
     context 'with one eval' do
-      let(:options) { {:evals => ['puts "hello"']} }
+      let(:options) { {evals: ['puts "hello"']} }
       it 'executes the code' do
         expect_output_of{ subject.run }.to eq("hello\n")
@@ -56,12 +58,22 @@ RSpec.describe Opal::CLI do
     end
     context 'with many evals' do
-      let(:options) { {:evals => ['puts "hello"', 'puts "ciao"']} }
+      let(:options) { {evals: ['puts "hello"', 'puts "ciao"']} }
       it 'executes the code' do
         expect_output_of{ subject.run }.to eq("hello\nciao\n")
       end
     end
+    context 'with a file path arg' do
+      let(:options) { {:evals => ['puts "hello"'], argv: [file]} }
+      it 'considers it as part of ARGV' do
+        expect(cli.argv).to eq([file])
+        expect(cli.file.tap(&:rewind).read).to eq('puts "hello"')
+        expect(cli.filename).to eq('-e')
+      end
+    end
   end
   describe ':no_exit option' do
@@ -229,7 +241,7 @@ RSpec.describe Opal::CLI do
   describe ':enable_source_location' do
     let(:file) { File.expand_path('../fixtures/source_location_test.rb', __FILE__) }
-    let(:options) { { enable_source_location: true, runner: :compiler, file: File.open(file) } }
+    let(:options) { { enable_source_location: true, runner: :compiler, argv: [file] } }
     it 'sets $$source_location prop for compiled methods' do
       expect_output_of { subject.run }.to include("source_location_test.rb', 6]")

data/spec/lib/fixtures/build_order/file1.js ADDED Viewed

	@@ -0,0 +1 @@
1	+ var FILE_1;

data/spec/lib/fixtures/build_order/file2.js ADDED Viewed

	@@ -0,0 +1 @@
1	+ var FILE_2;

data/spec/lib/fixtures/build_order/file3.js ADDED Viewed

	@@ -0,0 +1 @@
1	+ var FILE_3;

data/spec/lib/fixtures/build_order/file4.js ADDED Viewed

	@@ -0,0 +1 @@
1	+ var FILE_4;

data/spec/lib/fixtures/build_order/file5.rb.erb ADDED Viewed

@@ -0,0 +1,4 @@
+# Try loading a file with an absolute path.
+require "<%= p __dir__.inspect[1..-2] %>/file51.js"
+FILE_5 = true

data/spec/lib/fixtures/build_order/file51.js ADDED Viewed

	@@ -0,0 +1 @@
1	+ var FILE_51;

data/spec/lib/fixtures/build_order/file6.rb ADDED Viewed

@@ -0,0 +1,10 @@
+require_relative 'file61'
+# There's a circular require between file63 and 62
+# file62 should be in output file before 63
+require 'fixtures/build_order/file63'
+require_relative './file62'
+require 'fixtures/build_order/file64.rb'
+FILE_6 = true

data/spec/lib/fixtures/build_order/file61.rb ADDED Viewed

	@@ -0,0 +1 @@
1	+ FILE_61 = true

data/spec/lib/fixtures/build_order/file62.rb ADDED Viewed

@@ -0,0 +1,4 @@
+# A circular require
+require_relative 'file63'
+FILE_62 = true

data/spec/lib/fixtures/build_order/file63.rb ADDED Viewed

@@ -0,0 +1,4 @@
+# A circular require
+require_relative 'file62'
+FILE_63 = true

data/spec/lib/fixtures/build_order/file64.rb ADDED Viewed

	@@ -0,0 +1 @@
1	+ FILE_64 = true

data/spec/lib/fixtures/build_order/file7.rb ADDED Viewed

	@@ -0,0 +1 @@
1	+ FILE_7 = true

data/spec/lib/fixtures/build_order.rb ADDED Viewed

@@ -0,0 +1,9 @@
+# This fixture tests build order of required JS files
+require 'fixtures/build_order/file1'
+require 'fixtures/build_order/file2'
+require 'fixtures/build_order/file3'
+require 'fixtures/build_order/file4'
+require 'fixtures/build_order/file5'
+require 'fixtures/build_order/file6'
+require 'fixtures/build_order/file7'

data/spec/lib/rake_dist_spec.rb ADDED Viewed

@@ -0,0 +1,69 @@
+require 'lib/spec_helper'
+require 'open3'
+require 'opal/os'
+RSpec.describe "rake dist" do
+  before :all do
+    system "rake dist >#{Opal::OS.dev_null}"
+  end
+  def run_with_node(code, precode:, requires:)
+    requires = requires.map do |i|
+      "require('./build/#{i}');"
+    end.join
+    code = "#{requires};#{precode};console.log(#{code});"
+    stdout, _, status = Open3.capture3('node', '-e', code)
+    expect(status).to eq(0)
+    stdout.chomp
+  end
+  let(:output) { run_with_node(code, precode: precode, requires: requires) }
+  let(:requires) { ['opal'] }
+  let(:precode) { '' }
+  let(:code) { 'typeof Opal' }
+  it 'should provide a working Opal environment' do
+    expect(output).to eq('object')
+  end
+  context do
+    let(:requires) { ['opal/mini'] }
+    it 'should provide a working Opal mini environment' do
+      expect(output).to eq('object')
+    end
+  end
+  context do
+    let(:requires) { ['opal', 'opal/full'] }
+    let(:precode) { 'Opal.require("corelib/pattern_matching")' }
+    let(:code) { 'typeof Opal.PatternMatching' }
+    it 'should provide a working Opal full environment' do
+      expect(output).to eq('function')
+    end
+  end
+  context do
+    let(:requires) { %w[opal opal-replutils] }
+    let(:code) { 'typeof Opal.REPLUtils' }
+    it 'should not require requirable files by default' do
+      expect(output).to eq('undefined')
+    end
+  end
+  context do
+    let(:requires) { %w[opal opal-replutils] }
+    let(:precode) { 'Opal.require("opal-replutils")' }
+    let(:code) { 'typeof Opal.REPLUtils' }
+    it 'should allow user to require requirable files to provide missing functionality' do
+      expect(output).to eq('function')
+    end
+  end
+end

data/spec/mspec-opal/runner.rb CHANGED Viewed

@@ -80,6 +80,7 @@ class OSpecFormatter
       'server'       => BrowserFormatter,
       'chrome'       => DottedFormatter,
       'firefox'      => DottedFormatter,
+      'safari'       => DottedFormatter,
       'deno'         => NodeJSFormatter,
       'node'         => NodeJSFormatter,
       'nodejs'       => NodeJSFormatter,

data/spec/opal/core/io/read_spec.rb CHANGED Viewed

@@ -32,7 +32,10 @@ describe "IO reading methods" do
     examples.each do |example|
       it "correctly splits messages for input #{example.inspect}" do
         io = prepare_io_for.(example)
-        expected_output = example.gsub("|", "").split(/(?<=\n)/)
+        expected_output = example.gsub("|", "").split(/\n/).map { |e| e + "\n" }
+        len = expected_output.length
+        last = expected_output.last
+        expected_output[len-1] = last.chop if !example.end_with?("\n") && last
         io.readlines.should == expected_output
       end
     end
@@ -42,7 +45,10 @@ describe "IO reading methods" do
     examples.each do |example|
       it "correctly splits messages for input #{example.inspect}" do
         io = prepare_io_for.(example)
-        expected_output = example.gsub("|", "").split(/(?<=\n)/)
+        expected_output = example.gsub("|", "").split(/\n/).map { |e| e + "\n" }
+        len = expected_output.length
+        last = expected_output.last
+        expected_output[len-1] = last.chop if !example.end_with?("\n") && last
         loop do
           expected_output.shift.should == io.readline
         rescue EOFError
@@ -57,7 +63,10 @@ describe "IO reading methods" do
     examples.each do |example|
       it "correctly splits messages for input #{example.inspect}" do
         io = prepare_io_for.(example)
-        expected_output = example.gsub("|", "").split(/(?<=\n)/)
+        expected_output = example.gsub("|", "").split(/\n/).map { |e| e + "\n" }
+        len = expected_output.length
+        last = expected_output.last
+        expected_output[len-1] = last.chop if !example.end_with?("\n") && last
         loop do
           line = io.gets
           expected_output.shift.should == line

data/stdlib/opal/platform.rb CHANGED Viewed

@@ -8,5 +8,6 @@ when 'deno'             then require 'deno/base'
 when 'nodejs'           then require 'nodejs/base'
 when 'headless-chrome'  then require 'headless_browser/base'
 when 'headless-firefox' then require 'headless_browser/base'
+when 'safari'           then require 'headless_browser/base'
 when 'opal-miniracer'   then require 'opal/miniracer'
 end

data/stdlib/opal-platform.rb CHANGED Viewed

@@ -6,6 +6,7 @@ node             = `typeof(process) !== "undefined" && process.versions && proce
 nashorn          = `typeof(Java) !== "undefined" && Java.type`
 headless_chrome  = `typeof(opalheadlesschrome) !== "undefined"`
 headless_firefox = `typeof(opalheadlessfirefox) !== "undefined"`
+safari           = `typeof(opalsafari) !== "undefined"`
 gjs              = `typeof(window) !== "undefined" && typeof(GjsFileImporter) !== "undefined"`
 quickjs          = `typeof(window) === "undefined" && typeof(__loadScript) !== "undefined"`
 opal_miniracer   = `typeof(opalminiracer) !== "undefined"`
@@ -20,6 +21,8 @@ OPAL_PLATFORM = if nashorn
                   'headless-chrome'
                 elsif headless_firefox
                   'headless-firefox'
+                elsif safari
+                  'safari'
                 elsif gjs
                   'gjs'
                 elsif quickjs

data/stdlib/time.rb CHANGED Viewed

@@ -1,6 +1,26 @@
 class Time
   def self.parse(str)
-    `new Date(Date.parse(str))`
+    %x{
+      var d = Date.parse(str);
+      if (d !== d) {
+        // parsing failed, d is a NaN
+        // probably str is not in ISO 8601 format, which is the only format, required to be supported by Javascript
+        // try to make the format more like ISO or more like Chrome and parse again
+        str = str.replace(/^(\d+)([\./])(\d+)([\./])?(\d+)?/, function(matched_sub, c1, c2, c3, c4, c5, offset, orig_string) {
+          if ((c2 === c4) && c5) {
+            // 2007.10.1 or 2007/10/1 are ok, but 2007/10.1 is not, convert to 2007-10-1
+            return c1 + '-' + c3 + '-' + c5;
+          } else if (c3 && !c4) {
+            // 2007.10 or 2007/10
+            // Chrome and Ruby can parse "2007/10", assuming its "2007-10-01", do the same
+            return c1 + '-' + c3 + '-01';
+          };
+          return matched_sub;
+        });
+        d = Date.parse(str);
+      }
+      return new Date(d);
+    }
   end
   def self.def_formatter(name, format, on_utc: false, utc_tz: nil, tz_format: nil, fractions: false, on: self)

data/tasks/building.rake CHANGED Viewed

@@ -38,7 +38,7 @@ task :dist do
       $stdout.flush
       # Set requirable to true, unless building opal. This allows opal to be auto-loaded.
-      requirable = (%w[opal opal/mini opal/base].include? lib)
+      requirable = !(%w[opal opal/mini opal/base].include? lib)
       builder = Opal::Builder.build(lib, requirable: requirable)
       src = builder.to_s if (formats & %w[js min gz]).any?