opal 1.6.0.alpha1 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 799fb70bbdbc0be33af9c9757287797702fd8752f29e3beb4b3515f3dc0e7a66
-  data.tar.gz: 757ec0cb6cc3a5bb24e7a6e6e2aec81fa70d5f05f98025ee00528d00b0779d48
+  metadata.gz: 849fd3ee9a34f471ea70ff0069aedfc41b66471e846b81c59e6fd17370e881a6
+  data.tar.gz: 71220b09662aef06681fadb4e0841eb110afa4a3e15b14e77de9a6e0666f0564
 SHA512:
-  metadata.gz: f3024674d274a45c92bbb5094416074ef754802a78c0484a71d68a7b03815867a8ac42f8499e23a9f2d05587212afeafb752c0894cfabc4a6ace63faf0da4098
-  data.tar.gz: f1d8ec6f6ac95d89233d4af4a26ab4eaed8d275edd86b154dd06d6fea5477c9aa869dc644f571a2c95737bf674703f03db9b8bed7b43a8af322d5dad6e3a0516
+  metadata.gz: 62c5c2f184630d3fc92ec3792e5022434668d33023b89c36a49e128991a7aeea26d61f7ed7559e57e9def93577a94d784f6308c65a78c3ac83726d50942e3435
+  data.tar.gz: b7ede6f69220d31c0b8dc0f8350b3699c428d50471ef8d9df47a1a6c9b197116994d1b682681ee37a83b2a0c8547b93e059295c555074a093403ebe9d6ccf84a

data/.gitattributes

@@ -1 +1,5 @@
 UNRELEASED.md merge=union
+spec/opal/core/language/DATA/characters_support_crlf_spec.rb text eol=crlf
+spec/opal/core/language/DATA/characters_support_spec.rb text eol=lf
+spec/opal/core/language/DATA/multiple___END___crlf_spec.rb text eol=crlf
+spec/opal/core/language/DATA/multiple___END___spec.rb text eol=lf

data/.github/workflows/build.yml

@@ -45,9 +45,20 @@ jobs:
           - name: smoke-test
             ruby: '3.0'
             command: bin/rake smoke_test
+          - name: windows-mspec-nodejs
+            command: bundle exec rake mspec_nodejs
+            ruby: '3.0'
+            os: windows-latest
+          - name: windows-mspec-chrome
+            command: bundle exec rake mspec_chrome
+            ruby: '3.0'
+            os: windows-latest
+          - name: windows-minitest
+            command: bundle exec rake minitest
+            ruby: '3.0'
+            os: windows-latest
           - name: windows
-            # These two fail because of broken stacktraces on windows: minitest_node_nodejs mspec_nodejs
-            command: bundle exec rake rspec minitest_nodejs
+            command: bundle exec rake rspec
             ruby: '3.0'
             os: windows-latest
           - name: lint

data/CHANGELOG.md

@@ -10,11 +10,76 @@ Changes are grouped as follows:
 - **Removed** for deprecated features removed in this release.
 - **Fixed** for any bug fixes.
 - **Security** to invite users to upgrade in case of vulnerabilities.
+- **Performance** changes related to speed and efficiency.
 
 
 
 
 
+## [1.6.0](https://github.com/opal/opal/compare/v1.5.1...v1.6.0) - 2022-11-24
+
+
+<!--
+### Internal
+### Changed
+### Added
+### Removed
+### Deprecated
+### Performance
+### Fixed
+-->
+
+### Changed
+
+- No longer truncate stacktraces to 15 lines ([#2440](https://github.com/opal/opal/pull/2440))
+- Mark async/await as non-experimental ([#2477](https://github.com/opal/opal/pull/2477))
+
+### Performance
+
+- Improve method block performance for runtime ([#2449](https://github.com/opal/opal/pull/2449))
+- Uninline non-typical argument handling ([#2419](https://github.com/opal/opal/pull/2419))
+- Logic optimization of runtime.js ([#2415](https://github.com/opal/opal/pull/2415))
+- Windows support for `performance:compare` CI check ([#2450](https://github.com/opal/opal/pull/2450))
+- Improve block performance for even more cases ([#2465](https://github.com/opal/opal/pull/2465))
+
+### Added
+
+- Added support for `#freeze` and `#frozen?` (#2444, #2468)
+- Add CLI support for ESM, at least for Chrome, NodeJS, QuickJS and GJS ([#2435](https://github.com/opal/opal/pull/2435))
+- Support exit in Chrome CLI Runner, both sync and async ([#2439](https://github.com/opal/opal/pull/2439))
+- Make sure the Server CLI Runner can pick up changes in sources ([#2436](https://github.com/opal/opal/pull/2436))
+- Delegate and ruby2_keywords ([#2446](https://github.com/opal/opal/pull/2446))
+- Source code can now be embedded in the compiled file to improve development/debugging, e.g. RSpec reports, `Proc#source_location` ([#2440](https://github.com/opal/opal/pull/2440))
+- Added `Kernel#caller_locations` ([#2440](https://github.com/opal/opal/pull/2440))
+- `Opal::Builder::Prefork` for blazingly fast multicore compilation times (#2263, #2462, #2454, #2469, #2475)
+- Add `Opal::BuilderProcessors::RubyERBProcessor` ([#2470](https://github.com/opal/opal/pull/2470))
+
+### Fixed
+
+- Closure tracking support fixes a whole array of bugs handling `break` / `next` / `retry` / … ([#2357](https://github.com/opal/opal/pull/2357))
+- Fix an edge case of if in the most complex form not returning ([#2433](https://github.com/opal/opal/pull/2433))
+- `String#length` is now available when using `opal/mini` ([#2438](https://github.com/opal/opal/pull/2438))
+- Auto-await produced invalid code ([#2440](https://github.com/opal/opal/pull/2440))
+- Fix `Enumerable#collect_concat` and `#flat_map` implementation ([#2440](https://github.com/opal/opal/pull/2440))
+- Improved await support for PromiseV1 ([#2440](https://github.com/opal/opal/pull/2440))
+- Compilation error occurs while compiling `being/end` returning a `case/when` ([#2459](https://github.com/opal/opal/pull/2459))
+- Ensure UTF-8 encoding of `.sourcesContent` of source maps ([#2451](https://github.com/opal/opal/pull/2451))
+- Benchmarks require string/unpack ([#2453](https://github.com/opal/opal/pull/2453))
+- Fix compilation of a call: `gets&.chomp` ([#2473](https://github.com/opal/opal/pull/2473))
+- Fix specs on Windows ([#2460](https://github.com/opal/opal/pull/2460))
+- Make opal CLI tool work again with pipes ([#2474](https://github.com/opal/opal/pull/2474))
+
+### Internal
+
+- GitHub Workflows security hardening ([#2432](https://github.com/opal/opal/pull/2432))
+- Retry if file cache write operation exits with Zlib::BufError ([#2463](https://github.com/opal/opal/pull/2463))
+- Eliminate redundant `var constructor` in `allocate_class` ([#2452](https://github.com/opal/opal/pull/2452))
+- Fix `performance:compare` asset size calculation ([#2457](https://github.com/opal/opal/pull/2457))
+- Fix a few specs after the Opal RSpec 1.0 (alpha) release (#2471, #2472)
+
+
+
+
 ## [1.5.1](https://github.com/opal/opal/compare/v1.5.0...v1.5.1) - 2022-07-20
 
 
@@ -24,6 +89,11 @@ Changes are grouped as follows:
 - Fix exception during `Hash#each_value` if keys get deleted during loop ([#2427](https://github.com/opal/opal/pull/2427))
 - Fix scan_until and check_until implementation of StringScanner ([#2420](https://github.com/opal/opal/pull/2420))
 
+## New Contributors
+* @Leon0402 made their first contribution in https://github.com/opal/opal/pull/2420
+
+**Full Changelog**: https://github.com/opal/opal/compare/v1.5.0...v1.5.1
+
 
 
 

data/README.md

@@ -18,14 +18,14 @@
   <a href="#sponsors"><img src="https://opencollective.com/opal/sponsors/badge.svg" alt="Sponsors on Open Collective" title="" /></a>
   <a href="https://slack.opalrb.com/"><img src="https://img.shields.io/badge/slack-join%20chat-46BC99?logo=slack&style=flat" alt="Slack" title="Join Chat" /></a>
   <a href="https://opalrb.com/docs"><img src="https://img.shields.io/badge/docs-updated-blue.svg" alt="Documentation" title="" /></a>
-  
+
   <br>
   <strong>Code:</strong><br>
   <a href="https://badge.fury.io/rb/opal"><img src="https://img.shields.io/gem/v/opal.svg?style=flat" alt="Gem Version" title="" /></a>
   <a href="https://github.com/opal/opal/actions?query=workflow%3Abuild"><img src="https://github.com/opal/opal/workflows/build/badge.svg" alt="Build Status" /></a>
   <a href="https://codeclimate.com/github/opal/opal"><img src="https://img.shields.io/codeclimate/maintainability-percentage/opal/opal.svg" alt="Code Climate" title="" /></a>
   <a href="https://coveralls.io/github/opal/opal?branch=master"><img src="https://coveralls.io/repos/opal/opal/badge.svg?branch=master&amp;service=github" alt="Coverage Status" title="" /></a>
-  
+
   <br>
   <strong>Sponsors:</strong>
   <br/><a href="https://nebulab.it?utm_source=github&utm_medium=badge"><img src="https://img.shields.io/static/v1?label=Nebulab&message=Open+Source+Fridays&color=%235dbefd&logo=data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABwAAAAcCAYAAAByDd+UAAAACXBIWXMAABYlAAAWJQFJUiTwAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAMQSURBVHgBrZZNTxNRFIbfczsgIMQiLBCRFDaGhUr9A9iiIa5EEneIwE/AlRsNv8KlIKwFl35RTUBX8rFBdiVKAgqmXSCY0M71nJl+zJTOdKh9k6Yzc8/cZ86555x7CQE0mji5hSyGlQoNaOgIPwrnhtIArWszu4EQFudjdR8rzUV+gw8/ZMZB9IwvIwimJJGafhmjWZwFOJ7QkYzWCwTdj+qUDJGKz8Rou3RAlT4YS+hHWW2u/QdM1MNzrI6+zwyXDrg8FANStIDaSXOIJ5whLgAljOIZiglRK6U4vDfz4S2ElGGJWsEaQkCTUbhtNbV+lb+xgFY2Bs9ET0h/GzBxlfAkqnCUKY5xKfVLbsi1/R126lcF6WgCYp2ES42EBp6tvQFY+alLTUlrUxizJEVNWiVwBkVagGg7oe+CDclLYOfrgMdfTBz8PfWa1lkzbsDEsH/5FyF9YUK0zQ1xwpoZtsm9pwxMRLyA9wyi0A2Jcjl1NNqeeEFEimxYPkmWd014ikIDnDTeBb53DOweaRxnvWGyhnmYfPZWGt487sNi6lsK67/lZ1oZGOtUaD3nhtU7etXXfe0VzrzCBgLKCR68rNDX6oaJlvd0xXnklbSfgSTL/QghXF8EP980cVKyVL/Ys9UDVFJa8Tdt+1lYmcmJM3Vd4UEvWeslRf32h9ubrVRl77gBrCto85OfUU+LXTMGx+JuN2Hoin3/Zkfjj6ObBAknV+KG4jpc9BqXMEpiCMz6Z9ZQ12kvJZxb6co4Zr1W83esY8F2OYsIe+eEyfTiVXczCl7uM2wliHfMEJaRc3Wa++mLUotrF4EW7h6f94Dvh6aVFM60Fy8Xkya+BfBOjh5yUWhqY0vmKi9q1GnVxZ7sHKIWSs7FQ71yUagkRTTCfymnVY1gsgHHC5z8hbUjaz0Fr8ZanXhX0pPOw5SrV8wNGjNscMrTKpXKaj05f9twVYHnMZGPHEuwTwEBNi+3NGiNt6GRcsfEIAfhp2cAV3cQLtXoOz7q8+ZJRLx3kmxn4dy7aas1SrfiBpKraV/9A+PSJLDAXLUvAAAAAElFTkSuQmCC" alt="Nebulab: Open Source Fridays" /></a>
@@ -99,7 +99,7 @@ or to build an entire app including dependencies declared with `require`:
 ```ruby
 builder = Opal::Builder.new
 builder.build_str('require "opal"; puts "wow"', '(inline)')
-File.write 'app.js', builder.to_s
+File.binwrite 'app.js', builder.to_s # must use binary mode for writing
 ```
 
 

data/UNRELEASED.md

@@ -8,44 +8,3 @@
 ### Fixed
 -->
 
-### Changed
-
-- No longer truncate stacktraces to 15 lines (#2440)
-
-### Performance
-
-- Improve method block performance for runtime (#2449)
-- Uninline non-typical argument handling (#2419)
-- Logic optimization of runtime.js (#2415)
-- Windows support for `performance:compare` CI check (#2450)
-- Improve block performance for even more cases (#2465)
-
-### Added
-
-- Added support for `#freeze` and `#frozen?` (#2444, #2468)
-- Add CLI support for ESM, at least for Chrome, NodeJS, QuickJS and GJS (#2435)
-- Support exit in Chrome CLI Runner, both sync and async (#2439)
-- Make sure the Server CLI Runner can pick up changes in sources (#2436)
-- Delegate and ruby2_keywords (#2446)
-- Source code can now be embedded in the compiled file to improve development/debugging, e.g. RSpec reports, `Proc#source_location` (#2440)
-- Added `Kernel#caller_locations` (#2440)
-- `Opal::Builder::Prefork` for blazingly fast multicore compilation times (#2263, #2462, #2454)
-
-### Fixed
-
-- Closure tracking support fixes a whole array of bugs handling `break` / `next` / `retry` / … (#2357)
-- Fix an edge case of if in the most complex form not returning (#2433)
-- `String#length` is now available when using `opal/mini` (#2438)
-- Auto-await produced invalid code (#2440)
-- Fix `Enumerable#collect_concat` and `#flat_map` implementation (#2440)
-- Improved await support for PromiseV1 (#2440)
-- Compilation error occurs while compiling `being/end` returning a `case/when` (#2459)
-- Ensure UTF-8 encoding of `.sourcesContent` of source maps (#2451)
-- Benchmarks require string/unpack (#2453)
-
-### Internal
-
-- GitHub Workflows security hardening (#2432)
-- Retry if file cache write operation exits with Zlib::BufError (#2463)
-- Eliminate redundant `var constructor` in `allocate_class` (#2452)
-- Fix `performance:compare` asset size calculation (#2457)

data/docs/async.md

@@ -1,16 +1,5 @@
 # Asynchronous code (PromiseV2 / async / await)
 
-Please be aware that this functionality is marked as experimental and may change
-in the future.
-
-In order to disable the warnings that will be shown if you use those experimental
-features, add the following line before requiring `promise/v2` or `await` and after
-requiring `opal`.
-
-```ruby
-`Opal.config.experimental_features_severity = 'ignore'`
-```
-
 ## PromiseV2
 
 In Opal 1.2 we introduced PromiseV2 which is to replace the default Promise in Opal 2.0
@@ -52,7 +41,7 @@ require "await"
 
 def wait_5_seconds
   puts "Let's wait 5 seconds..."
-  sleep(5).await
+  sleep(5).__await__
   puts "Done!"
 end
 
@@ -60,14 +49,11 @@ wait_5_seconds.__await__
 ```
 
 It's important to understand what happens under the hood: every scope in which `#__await__` is
-encountered will become async, which means that it will return a Promise that will resolve
+encountered will become async, which means that it will return a PromiseV2 that will resolve
 to a value. This includes methods, blocks and the top scope. This means, that `#__await__` is
 infectious and you need to remember to `#__await__` everything along the way, otherwise
 a program will finish too early and the values may be incorrect.
 
-[You can take a look at how we ported Minitest to support asynchronous tests.](https://github.com/opal/opal/pull/2221/commits/8383c7b45a94fe4628778f429508b9c08c8948b0) Take note, that
-it was ported to use `#await` while the finally accepted version uses `#__await__`.
-
 It is certainly correct to `#__await__` any value, including non-Promises, for instance
 `5.__await__` will correctly resolve to `5` (except that it will make the scope an async
 function, with all the limitations described above).
@@ -76,6 +62,8 @@ The `await` stdlib module includes a few useful functions, like async-aware `eac
 function and `sleep` that doesn't block the thread. It also includes a method `#await`
 which is an alias of `#itself` - it makes sense to auto-await that method.
 
+[You can take a look at how we ported Minitest to support asynchronous tests.](https://github.com/opal/opal/pull/2221/files#diff-bdc8868ad4476bff7b25475f1b19059ac684d64c6531a645b3ba0aef0c466d0f).
+
 This approach is certainly incompatible with what Ruby does, but due to a dynamic nature
 of Ruby and a different model of JavaScript this was the least invasive way to catch up
 with the latest JavaScript trends and support `Promise` heavy APIs and asynchronous code.
@@ -106,4 +94,4 @@ require "await"
   p i
   sleep i
 end
-```
+```

data/docs/jquery.md

@@ -58,7 +58,7 @@ builder.build('opal')
 builder.build('opal-jquery')
 builder.build('./app/application.rb')
 
-File.write('application.js', builder.to_s)
+File.binwrite('application.js', builder.to_s) # must use binary mode for writing
 ```
 
 then simply load the compiled file in your html:
@@ -67,7 +67,7 @@ then simply load the compiled file in your html:
 <!DOCTYPE html>
 <html>
   <head>
-    <script src='https://code.jquery.com/jquery-3.3.1.min.js' integrity='sha256-FgpCb/KJQlLNfOu91ta32o/NMZxltwRo8QtmkMRdAu8=' crossorigin='anonymous'></script> 
+    <script src='https://code.jquery.com/jquery-3.3.1.min.js' integrity='sha256-FgpCb/KJQlLNfOu91ta32o/NMZxltwRo8QtmkMRdAu8=' crossorigin='anonymous'></script>
     <script type='text/javascript' src='./application.js'></script>
   </head>
   <body></body>
@@ -75,11 +75,11 @@ then simply load the compiled file in your html:
 ```
 
 NOTE: opal-jquery expects a jquery library to be loaded. This example loads it
-remotely from jquery.com, but a locally downloaded copy works just as well, or- 
+remotely from jquery.com, but a locally downloaded copy works just as well, or-
 if you're using rails- jquery may be included automatically.
 
-This example builds opal, opal-jquery and the application into a single `.js` file, 
-but you may build them separately, if you so choose. Just remember to include 
+This example builds opal, opal-jquery and the application into a single `.js` file,
+but you may build them separately, if you so choose. Just remember to include
 each respective script in your html!
 
 ### How does opal-jquery work

data/docs/releasing.md

@@ -18,14 +18,14 @@ _This guide is a work-in-progress._
 - Commit the updated changelog along with the version bump using this commit message:
   "Release v1.2.3"
 - Push the commit and run `bin/rake release` to release the new version to Rubygems
-- Go to GitHub releases and create a new release from the latest tag pasting the contents from CHANGELOG.md
+- Go to GitHub releases and create a new release from the latest tag pasting the contents from CHANGELOG.md (or UNRELEASED.md for pre-releases)
 
 ## Opal docs
 
 - Open `opal-docs` and run `bin/build v1.2.3`
 - Then run `bin/deploy`
 
-## Opal site
+## [skip for pre-releases] Opal site
 
 - Open `opal.github.io` and update the opal version in the `Gemfile`
 - run `bin/build`
@@ -35,9 +35,8 @@ _This guide is a work-in-progress._
 
 - Run `bin/release v1.2.3`
 
-## Prepare for the next release
+## [skip for minor-releases] Prepare for the next release
 
-- Skip this step if releasing a stable release
 - Create a new pull request that:
   - Updates a version to `v1.x.0.dev` in both `lib/opal/version.rb` and `opal/corelib/constants.rb`
 - Remember to merge that PR before merging anything else next once we decide to not release any more point releases from `master`.

data/lib/opal/builder_processors.rb

@@ -114,6 +114,12 @@ module Opal
       end
     end
 
+    # This handler is for files named ".opalerb", which ought to
+    # first get compiled to Ruby code using ERB, then with Opal.
+    # Unlike below processors, OpalERBProcessor can be used to
+    # compile templates, which will in turn output HTML. Take
+    # a look at docs/templates.md to understand this subsystem
+    # better.
     class OpalERBProcessor < RubyProcessor
       handles :opalerb
 
@@ -133,6 +139,24 @@ module Opal
       end
     end
 
+    # This handler is for files named ".rb.erb", which ought to
+    # first get preprocessed via ERB, then via Opal.
+    class RubyERBProcessor < RubyProcessor
+      handles :"rb.erb"
+
+      def compiled
+        @compiled ||= begin
+          @source = ::ERB.new(@source.to_s).result
+
+          compiler = compiler_for(@source, file: @filename)
+          compiler.compile
+          compiler
+        end
+      end
+    end
+
+    # This handler is for files named ".js.erb", which ought to
+    # first get preprocessed via ERB, then served verbatim as JS.
     class ERBProcessor < Processor
       handles :erb
 

data/lib/opal/builder_scheduler/prefork.rb

@@ -161,6 +161,9 @@ module Opal
       end
 
       def fork_entrypoint(io)
+        # Ensure we can work with our forks async...
+        Fiber.set_scheduler(nil) if Fiber.respond_to? :set_scheduler
+
         @in_fork = io
 
         until io.eof?

data/lib/opal/cache/file_cache.rb

@@ -19,15 +19,21 @@ module Opal
 
       def set(key, data)
         file = cache_filename_for(key)
-
         out = Marshal.dump(data)
-        out = Zlib.gzip(out, level: 9)
+
+        # Sometimes `Zlib::BufError` gets raised, unsure why, makes no sense, possibly
+        # some race condition (see https://github.com/ruby/zlib/issues/49).
+        # Limit the number of retries to avoid infinite loops.
+        retries = 5
+        begin
+          out = Zlib.gzip(out, level: 9)
+        rescue Zlib::BufError
+          warn "\n[Opal]: Zlib::BufError; retrying (#{retries} retries left)"
+          retries -= 1
+          retry if retries > 0
+        end
+
         File.binwrite(file, out)
-      rescue Zlib::BufError
-        # This sometimes happens, unsure why, makes no sense, possibly
-        # some race condition
-        warn '[Opal]: Zlib::BufError; retrying'
-        retry
       end
 
       def get(key)

data/lib/opal/cli.rb

@@ -184,8 +184,21 @@ module Opal
       if evals.any?
         yield evals.join("\n"), '-e'
       elsif file && (filename != '-' || evals.empty?)
-        file.rewind
-        yield file.read, filename
+        return @content if @content
+
+        if file.tty?
+          save = true
+        else
+          begin
+            file.rewind
+          rescue Errno::ESPIPE
+            save = true
+          end
+        end
+
+        content = yield(file.read, filename)
+        @content = content if save
+        content
       end
     end
   end

data/lib/opal/cli_runners/chrome.rb

@@ -66,7 +66,7 @@ module Opal
       def prepare_files_in(dir)
         js = builder.to_s
         map = builder.source_map.to_json
-        stack = File.read("#{__dir__}/source-map-support-browser.js")
+        stack = File.binread("#{__dir__}/source-map-support-browser.js")
 
         ext = builder.output_extension
         module_type = ' type="module"' if builder.esm?
@@ -74,9 +74,9 @@ module Opal
         # Chrome can't handle huge data passed to `addScriptToEvaluateOnLoad`
         # https://groups.google.com/a/chromium.org/forum/#!topic/chromium-discuss/U5qyeX_ydBo
         # The only way is to create temporary files and pass them to chrome.
-        File.write("#{dir}/index.#{ext}", js)
-        File.write("#{dir}/source-map-support.js", stack)
-        File.write("#{dir}/index.html", <<~HTML)
+        File.binwrite("#{dir}/index.#{ext}", js)
+        File.binwrite("#{dir}/source-map-support.js", stack)
+        File.binwrite("#{dir}/index.html", <<~HTML)
           <html><head>
             <meta charset='utf-8'>
             <script src='./source-map-support.js'></script>
@@ -124,7 +124,7 @@ module Opal
 
         chrome_pid = Process.spawn(chrome_server_cmd)
 
-        Timeout.timeout(10) do
+        Timeout.timeout(30) do
           loop do
             break if chrome_server_running?
             sleep 0.5
@@ -137,7 +137,7 @@ module Opal
         puts 'Make sure that you have it installed and that its version is > 59'
         exit(1)
       ensure
-        if windows? && chrome_pid
+        if OS.windows? && chrome_pid
           Process.kill('KILL', chrome_pid) unless system("taskkill /f /t /pid #{chrome_pid} >NUL 2>NUL")
         elsif chrome_pid
           Process.kill('HUP', chrome_pid)

data/lib/opal/cli_runners/system_runner.rb

@@ -27,9 +27,9 @@ SystemRunner = ->(data, &block) {
 
   tempfile =
     if debug
-      File.new("opal-nodejs-runner.#{ext}", 'w')
+      File.new("opal-nodejs-runner.#{ext}", 'wb')
     else
-      Tempfile.new(['opal-system-runner', ".#{ext}"])
+      Tempfile.new(['opal-system-runner', ".#{ext}"], mode: File::BINARY)
     end
 
   tempfile.write code

data/lib/opal/eof_content.rb

@@ -15,9 +15,12 @@ module Opal
       eof_content = @source[last_token_position..-1]
       return nil unless eof_content
 
-      eof_content = eof_content.lines.drop_while { |line| line == "\n" }
+      # On Windows token position is off a bit, because Parser does not seem to compensate for \r\n
+      # The first eof_content line on Windows may be for example "end\r\n"
+      # Must match for it and \r\n and \n
+      eof_content = eof_content.lines.drop_while { |line| /\A.*\r?\n?\z/.match?(line) && !line.start_with?('__END__') }
 
-      if eof_content[0] == "__END__\n"
+      if /\A__END__\r?\n?\z/.match?(eof_content[0])
         eof_content = eof_content[1..-1] || []
         eof_content.join
       elsif eof_content == ['__END__']

data/lib/opal/nodes/call.rb

@@ -186,7 +186,8 @@ module Opal
       end
 
       def compile_simple_call_chain
-        push recv(receiver_sexp), method_jsid, '(', expr(arglist), ')'
+        compile_receiver
+        push method_jsid, '(', expr(arglist), ')'
       end
 
       def splat?
@@ -469,7 +470,7 @@ module Opal
       def handle_conditional_send
         # temporary variable that stores method receiver
         receiver_temp = scope.new_temp
-        push "#{receiver_temp} = ", expr(recvr)
+        push "#{receiver_temp} = ", expr(receiver_sexp)
 
         # execute the sexp only if the receiver isn't nil
         push ", (#{receiver_temp} === nil || #{receiver_temp} == null) ? nil : "

data/lib/opal/source_map/file.rb

@@ -182,8 +182,9 @@ class Opal::SourceMap::File
   def fragments_by_line
     raw_mappings = [[]]
     fragments.flat_map do |fragment|
-      fragment_code  = fragment.code
-      fragment_lines = fragment_code.split("\n", -1) # a negative limit won't suppress trailing null values
+      fragment_code = fragment.code
+      splitter = /\r/.match?(fragment_code) ? /\r?\n/ : "\n"
+      fragment_lines = fragment_code.split(splitter, -1) # a negative limit won't suppress trailing null values
       fragment_lines.each.with_index do |fragment_line, index|
         raw_segment = [fragment_line, fragment]
         if index.zero? && !fragment_line.size.zero?

data/lib/opal/version.rb

@@ -3,5 +3,5 @@
 module Opal
   # WHEN RELEASING:
   # Remember to update RUBY_ENGINE_VERSION in opal/corelib/constants.rb too!
-  VERSION = '1.6.0.alpha1'
+  VERSION = '1.6.0'
 end

data/opal/corelib/constants.rb

@@ -1,8 +1,8 @@
 ::RUBY_PLATFORM       = 'opal'
 ::RUBY_ENGINE         = 'opal'
 ::RUBY_VERSION        = '3.1.0'
-::RUBY_ENGINE_VERSION = '1.6.0.alpha1'
-::RUBY_RELEASE_DATE   = '2022-11-11'
+::RUBY_ENGINE_VERSION = '1.6.0'
+::RUBY_RELEASE_DATE   = '2022-11-24'
 ::RUBY_PATCHLEVEL     = 0
 ::RUBY_REVISION       = '0'
 ::RUBY_COPYRIGHT      = 'opal - Copyright (C) 2013-2022 Adam Beynon and the Opal contributors'

data/opal/corelib/error/errno.rb

@@ -4,6 +4,7 @@ module ::Errno
     [:EEXIST, 'File exists', 17],
     [:EISDIR, 'Is a directory', 21],
     [:EMFILE, 'Too many open files', 24],
+    [:ESPIPE, 'Illegal seek', 29],
     [:EACCES, 'Permission denied', 13],
     [:EPERM, 'Operation not permitted', 1],
     [:ENOENT, 'No such file or directory', 2],

data/opal/corelib/io.rb

@@ -89,7 +89,7 @@ class ::IO
     parts = ''
 
     # Will execure at most twice - one time reading from a buffer
-    # second time
+    # second time executing read proc
     begin
       @read_buffer += parts
       if @read_buffer != ''

data/opal.gemspec

@@ -44,9 +44,9 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rack-test'
   spec.add_development_dependency 'selenium-webdriver'
   spec.add_development_dependency 'benchmark-ips', '< 2.8'
-  spec.add_development_dependency 'sinatra'
+  spec.add_development_dependency 'sinatra', '~> 3.0'
   spec.add_development_dependency 'rubocop', '~> 0.67.0'
   spec.add_development_dependency 'rubocop-performance', '~> 1.1.0'
-  spec.add_development_dependency 'rack'
+  spec.add_development_dependency 'rack', '~> 2.2'
   spec.add_development_dependency 'webrick'
 end

data/spec/lib/cli_spec.rb

@@ -236,6 +236,20 @@ RSpec.describe Opal::CLI do
     end
   end
 
+  context 'using pipes' do
+    it 'runs the provided source' do
+      # `echo` on windows will output double-quotes along with the contents, that's why we print with ruby
+      expect(`ruby -e"puts 'foo'" | ruby bin/opal -ropal/platform -e "puts gets.reverse"`.strip).to eq("oof")
+    end
+
+    it 'compiles the provided source' do
+      # `echo` on windows will output double-quotes along with the contents, that's why we print with ruby
+      expect(`ruby -e"puts 'puts 123'" | ruby bin/opal -cEO`.strip).to include("self.$puts(123)")
+    end
+
+    # TODO: test refreshes with the server runner (only way to ensure we correctly rewind or cache the eval contents)
+  end
+
   private
 
   def expect_output_of

data/spec/opal/core/language/DATA/characters_support_crlf_spec.rb

@@ -0,0 +1,9 @@
+describe "characters support of the DATA contstant" do
+  it "supports all characters" do
+    DATA.read.should == "azAZ09`~!@#$%^&*(\r\n)_+{}\\|;:'\",<.>/?\r\n"
+  end
+end
+
+__END__
+azAZ09`~!@#$%^&*(
+)_+{}\|;:'",<.>/?

data/spec/opal/core/language/DATA/multiple___END___crlf_spec.rb

@@ -0,0 +1,10 @@
+describe "DATA constant with multiple __END__ sections" do
+  it "returns everything after first __END__" do
+    DATA.read.should == "1\r\n__END__\r\n2\r\n"
+  end
+end
+
+__END__
+1
+__END__
+2

data/spec/opal/core/language/safe_navigator_spec.rb

@@ -4,4 +4,14 @@ describe 'Safe navigator' do
       value&.unknown.should == nil
     end
   end
+
+  it "calls a receiver exactly once" do
+    def receiver
+      @calls += 1
+    end
+    @calls = 0
+    receiver&.itself.should == 1
+    @calls = 0
+    receiver&.itself{}.should == 1
+  end
 end

data/stdlib/await.rb

@@ -1,13 +1,6 @@
 # helpers: coerce_to
 # await: await
 
-if `Opal.config.experimental_features_severity == 'warning'`
-  warn 'Await functionality is a technology preview, which means it may change its behavior ' \
-      'in the future unless this warning is removed. If you are interested in this part, ' \
-      'please make sure you track the async/await/promises tag on Opal issues: ' \
-      'https://github.com/opal/opal/issues?q=label%3Aasync%2Fawait%2Fpromises'
-end
-
 %x{
   var AsyncFunction = Object.getPrototypeOf(async function() {}).constructor;
 }

data/tasks/testing.rake

@@ -427,14 +427,15 @@ task :smoke_test do
         extend RSpec::Matchers
         expect(actual_output.lines[0]).to    eq("..\n")
         expect(actual_output.lines[1]).to    eq("\n")
-        expect(actual_output.lines[2]).to match(%r{^Finished in \d+\.\d+ seconds \(files took \d+\.\d+ seconds to load\)\n$})
-        expect(actual_output.lines[3]).to    eq("2 examples, 0 failures\n")
-        expect(actual_output.lines[4]).to    eq("\n")
-        expect(actual_output.lines[5]).to match(%r{Top 2 slowest examples \(\d+\.\d+ seconds, \d+\.\d+% of total time\):\n})
-        expect(actual_output.lines[7]).to match(%r{    \[1m\d+\.\d+\[0m \[1mseconds\[0m \n})
+        expect(actual_output.lines[2]).to match(%r{Top 2 slowest examples \(\d+\.\d+ seconds, \d+\.\d+% of total time\):\n})
+        expect(actual_output.lines[4]).to match(%r{    \[1m\d+\.\d+\[0m \[1mseconds\[0m .*deprecations_spec\.rb:7\n})
+        expect(actual_output.lines[6]).to match(%r{    \[1m\d+\.\d+\[0m \[1mseconds\[0m .*deprecations_spec\.rb:12\n})
+        expect(actual_output.lines[7]).to    eq("\n")
+        expect(actual_output.lines[8]).to match(%r{^Finished in \d+\.\d+ seconds \(files took \d+\.\d+ seconds to load\)\n$})
+        expect(actual_output.lines[9]).to    eq("2 examples, 0 failures\n")
         expect([
-          actual_output.lines[6],
-          actual_output.lines[8],
+          actual_output.lines[3],
+          actual_output.lines[5],
         ]).to contain_exactly(
           "  Opal::Deprecations defaults to warn\n",
           "  Opal::Deprecations can be set to raise\n",

data/test/nodejs/test_file.rb

@@ -175,6 +175,7 @@ class TestNodejsFile < Test::Unit::TestCase
   end if windows_platform?
 
   def test_windows_file_expand_path
+    # do not use d: because its a symlink in github actions fs, leading to unexpected results
     drive_letter = Dir.pwd.slice(0, 2)
     assert_equal(Dir.pwd + '/foo/bar.js', File.expand_path('./foo/bar.js'))
     assert_equal(drive_letter + '/foo/bar.js', File.expand_path('/foo/bar.js'))
@@ -186,8 +187,8 @@ class TestNodejsFile < Test::Unit::TestCase
     assert_equal('c:/bar.js', File.expand_path('\\..\\bar.js', 'c:\\foo\\baz\\'))
     assert_equal('c:/foo/baz/bar.js', File.expand_path('baz\\bar.js', 'c:\\foo'))
     assert_equal('c:/baz/bar.js', File.expand_path('baz\\bar.js', 'c:\\foo\\..'))
-    assert_equal('d:/', File.expand_path('d:'), 'should add a trailing slash when the path is d:')
-    assert_equal('d:/', File.expand_path('d:/'), 'should preserve the trailing slash when the path d:/')
+    assert_equal('f:/', File.expand_path('f:'), 'should add a trailing slash when the path is d:')
+    assert_equal('g:/', File.expand_path('g:/'), 'should preserve the trailing slash when the path d:/')
     assert_equal(Dir.pwd, File.expand_path(drive_letter), 'should expand to the current directory when the path is c: (and the current directory is located in the c drive)')
     assert_equal(drive_letter + '/', drive_letter + '/', 'should return c:/ when the path is c:/ because the path is absolute')
   end if windows_platform?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: opal
 version: !ruby/object:Gem::Version
-  version: 1.6.0.alpha1
+  version: 1.6.0
 platform: ruby
 authors:
 - Elia Schito
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-11-11 00:00:00.000000000 Z
+date: 2022-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast
@@ -162,16 +162,16 @@ dependencies:
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -204,16 +204,16 @@ dependencies:
   name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: webrick
   requirement: !ruby/object:Gem::Requirement
@@ -856,8 +856,10 @@ files:
 - spec/opal/core/kernel/puts_spec.rb
 - spec/opal/core/kernel/require_tree_spec.rb
 - spec/opal/core/kernel/respond_to_spec.rb
+- spec/opal/core/language/DATA/characters_support_crlf_spec.rb
 - spec/opal/core/language/DATA/characters_support_spec.rb
 - spec/opal/core/language/DATA/empty___END___spec.rb
+- spec/opal/core/language/DATA/multiple___END___crlf_spec.rb
 - spec/opal/core/language/DATA/multiple___END___spec.rb
 - spec/opal/core/language/arguments/mlhs_arg_spec.rb
 - spec/opal/core/language/forward_args_spec.rb
@@ -1167,10 +1169,10 @@ licenses:
 metadata:
   homepage_uri: https://opalrb.com/
   bug_tracker_uri: https://github.com/opal/opal/issues
-  changelog_uri: https://github.com/opal/opal/blob/v1.6.0.alpha1/CHANGELOG.md
-  readme_uri: https://github.com/opal/opal/blob/v1.6.0.alpha1/README.md
-  api_documentation_uri: http://opalrb.com/docs/api/v1.6.0.alpha1/index.html
-  guides_uri: http://opalrb.com/docs/guides/v1.6.0.alpha1/index.html
+  changelog_uri: https://github.com/opal/opal/blob/v1.6.0/CHANGELOG.md
+  readme_uri: https://github.com/opal/opal/blob/v1.6.0/README.md
+  api_documentation_uri: http://opalrb.com/docs/api/v1.6.0/index.html
+  guides_uri: http://opalrb.com/docs/guides/v1.6.0/index.html
   chat_uri: https://gitter.im/opal/opal
   source_code_uri: https://github.com/opal/opal
 post_install_message:
@@ -1184,9 +1186,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.3.22
 signing_key: