opal 1.4.0.alpha1 → 1.5.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a891400c1e60680daab2289df6be2148d87aaf7e007210797a963c68af671e82
-  data.tar.gz: 4315f9771bd13282d378ae1ec2b564864945cf94e780c17288d53af8f38dfc91
+  metadata.gz: 6ac3c5ae91f1f31b94c292f0aed320bdba76511abd34bb6dc45294c11958e802
+  data.tar.gz: 473ca0893f427b05c88c64805dc0f64668816b263b136863b903f5262aba7aef
 SHA512:
-  metadata.gz: 3342a7d52885c1cab9b7371d72a758ce0e13aa97bae741ce549111245422366d5965b36d3eeda91b56b8d0ac733e2a3492c7d6c80190b27a9528aa77f12bfc84
-  data.tar.gz: 1f71da4662d1218e4561154cc042ac2e643f097b119b048f35fc0f6d7c566b3b9321a3d4eb0a7020c83b197a32818379a7e7662aa82684a51c4b33e870be2a9a
+  metadata.gz: 5ba1e5223c56695db351ede10b36872590b29701f4576c9a1962502686434548d855d71fdd147e5b34492bb70964db72bed3229cc552dfa139a2db747dd4caa1
+  data.tar.gz: 30e97d6c8293b918084145f15cd9f42d6495989405d97ebbccc414440c281a8297405f651560e8a65ea21dda191631d9bd20fda058d5693af1c25b8b61cc1e40

data/.eslintrc.js

@@ -24,12 +24,14 @@ module.exports = {
     "no-control-regex": "off",
   },
   "globals": {
-    "Opal": "readonly",
-    "DataView": "readonly",
     "ArrayBuffer": "readonly",
+    "DataView": "readonly",
     "globalThis": "readonly",
-    "Uint8Array": "readonly",
+    "Opal": "readonly",
     "Promise": "readonly",
+    "Proxy": "readonly",
+    "Reflect": "readonly",
+    "Uint8Array": "readonly",
     "WeakRef": "readonly",
   }
 };

data/.github/workflows/build.yml

@@ -16,41 +16,44 @@ jobs:
       matrix:
         combo:
           - name: mspec-nodejs
-            ruby: 3.0
+            ruby: '3.0'
             command: bin/rake mspec_nodejs
           - name: mspec-chrome
-            ruby: 3.0
+            ruby: '3.0'
             command: bin/rake mspec_chrome
           - name: minitest
-            ruby: 3.0
+            ruby: '3.0'
             command: bin/rake minitest
           - name: minitest-strict-mode
-            ruby: 3.0
+            ruby: '3.0'
             command: bin/rake minitest
             strict: 'true'
+          - name: head-ruby
+            ruby: head
+            permissive: true
           - name: current-ruby
-            ruby: 3.0
+            ruby: 3.1
           - name: previous-ruby
-            ruby: 2.7
+            ruby: '3.0'
           - name: older-ruby
+            ruby: 2.7
+          - name: near-eol-ruby
             ruby: 2.6
-          # - name: near-eol-ruby
-          #   ruby: 2.6
           - name: smoke-test
-            ruby: 3.0
+            ruby: '3.0'
             command: bin/rake smoke_test
           - name: windows
             # These two fail because of broken stacktraces on windows: minitest_node_nodejs mspec_nodejs
             command: bundle exec rake rspec minitest_nodejs
-            ruby: 3.0
+            ruby: '3.0'
             os: windows-latest
           - name: lint
             command: bin/rake lint
-            ruby: 3.0
+            ruby: '3.0'
           - name: timezone
-            ruby: 3.0
+            ruby: '3.0'
           - name: performance
-            ruby: 3.0
+            ruby: '3.0'
             permissive: true
             fetchdepth: '0'
             command: bin/rake performance:compare
@@ -59,7 +62,6 @@ jobs:
           # Currently failing:
           # - ruby: truffleruby
           # - ruby: jruby
-          # - ruby: ruby-head
 
     runs-on: ${{ matrix.combo.os || 'ubuntu-latest' }}
     continue-on-error: ${{ matrix.combo.permissive || false }}
@@ -77,11 +79,11 @@ jobs:
       - uses: actions/cache@v2
         with:
           path: ./vendor/bundle
-          key: ${{ runner.os }}-${{ matrix.combo.ruby }}-gems-${{ github.ref }}-${{ hashFiles('**/Gemfile.lock') }}
+          key: ${{ runner.os }}-${{ matrix.combo.ruby }}-gem-${{ github.ref }}-${{ hashFiles('**/Gemfile.lock') }}
           restore-keys: |
-            ${{ runner.os }}-${{ matrix.combo.ruby }}-gems-${{ github.ref }}
-            ${{ runner.os }}-${{ matrix.combo.ruby }}-gems-master
-            ${{ runner.os }}-${{ matrix.combo.ruby }}-gems-
+            ${{ runner.os }}-${{ matrix.combo.ruby }}-gem-${{ github.ref }}
+            ${{ runner.os }}-${{ matrix.combo.ruby }}-gem-master
+            ${{ runner.os }}-${{ matrix.combo.ruby }}-gem-
       - uses: actions/cache@v2
         with:
           path: ./node_modules

data/.rubocop.yml

@@ -365,6 +365,7 @@ Naming/FileName:
     - 'stdlib/opal-parser.rb'
     - 'stdlib/opal-platform.rb'
     - 'stdlib/opal-source-maps.rb'
+    - 'stdlib/opal-replutils.rb'
 
 Naming/ConstantName:
   Exclude:

data/CHANGELOG.md

@@ -15,27 +15,118 @@ Changes are grouped as follows:
 
 
 
-## [1.3.2](https://github.com/opal/opal/compare/v1.3.1...v1.3.2) - 2021-11-10
+## [1.4.1](https://github.com/opal/opal/compare/v1.4.0...v1.4.1) - 2022-01-12
+
+
+### Changed
 
+- PromiseV2 is now declared a stable interface!
 
 ### Fixed
 
-- Update documentation ([#2350](https://github.com/opal/opal/pull/2350))
-- Fix `IO#gets` getting an extra char under some circumstances ([#2349](https://github.com/opal/opal/pull/2349))
-- Raise a `TypeError` instead of `UndefinedMethod` if not a string is passed to `__send__` ([#2346](https://github.com/opal/opal/pull/2346))
-- Do not modify `$~` when calling `String#scan` from internal methods ([#2353](https://github.com/opal/opal/pull/2353))
-- Stop interpreting falsey values as a missing constant in `Module#const_get` ([#2354](https://github.com/opal/opal/pull/2354))
+- Args named with JS reserved words weren't always renamed when _zsuper_ was involved ([#2385](https://github.com/opal/opal/pull/2385))
 
 <!--
-### Changed
+### Added
+### Removed
 ### Deprecated
+### Internal
+-->
+
+
+
+
+## [1.4.0](https://github.com/opal/opal/compare/v1.3.2...v1.4.0) - 2021-12-24
+
+
+### Added
+
+- Implement `chomp:` option for `String#each_line` and `#lines` ([#2355](https://github.com/opal/opal/pull/2355))
+- Ruby 3.1 support and some older Ruby features we missed ([#2347](https://github.com/opal/opal/pull/2347))
+  - Use parser in 3.1 mode to support new language-level features like hashes/kwargs value omission, the pin operator for pattern matching
+  - `Array#intersect?`
+  - `String#strip` and `String#lstrip` to also remove NUL bytes
+  - `Integer.try_convert`
+  - `public`, `private`, `protected`, `module_function` now return their arguments
+  - `Class#descendants`, `Class#subclasses`
+  - (<=1.8) `Kernel#local_variables`
+  - (<=2.3) Set local variables for regexp named captures (`/(?<b>a)/ =~ 'a'` => `b = 'a'`)
+  - Remove deprecated `NIL`, `TRUE`, `FALSE` constants
+  - `String#unpack` and `String#unpack1` to support an `offset:` kwarg
+  - `MatchData#match`, `MatchData#match_length`
+  - Enumerable modernization
+    - `Enumerable#tally` to support an optional hash accumulator
+    - `Enumerable#each_{cons,slice}` to return self
+    - `Enumerable#compact`
+  - `Refinement` becomes its own class now
+  - `Struct#keyword_init?`
+  - (pre-3.1) Large Enumerator rework
+    - Introduce `Enumerator::ArithmeticSequence`
+    - Introduce `Enumerator::Chain`
+    - Introduce `Enumerator#+` to create `Enumerator::Chain`s
+    - `Enumerator#{rewind,peek,peek_values,next,next_values}`
+    - Improve corelib support for beginless/endless ranges and `ArithmeticSequences`
+      - `String#[]`, `Array#[]`, `Array#[]=`, `Array#fill`, `Array#values_at`
+    - `Range#step` and `Numeric#step` return an `ArithmeticSequence` when `Numeric` values are in play
+    - Introduce `Range#%`
+    - `Enumerator::Yielder#to_proc`
+    - Fix #2367
+  - (2.7) `UnboundMethod#bind_call`
+  - (Opal) `{Kernel,BasicObject}#{inspect,p,pp,method_missing}` may work with JS native values now, also they now correctly report cycles
+  - `Enumerable#sum` uses Kahan's summation algorithm to reduce error with floating point values
+  - `File.dirname` supports a new `level` argument
+- Vendor in `optparse` and `shellwords` ([#2326](https://github.com/opal/opal/pull/2326))
+- Preliminary support for compiling the whole `bin/opal` with Opal ([#2326](https://github.com/opal/opal/pull/2326))
+
+### Fixed
+
+- Fix coertion for `Array#drop` ([#2371](https://github.com/opal/opal/pull/2371))
+- Fix coertion for `File.absolute_path` ([#2372](https://github.com/opal/opal/pull/2372))
+- Fix some `IO#puts` edge cases (no args, empty array, nested array, …) ([#2372](https://github.com/opal/opal/pull/2372))
+- Preserve UNC path prefix on File.join ([#2366](https://github.com/opal/opal/pull/2366))
+- Methods on `Kernel`, `BasicObject`, `Boolean` will never return boxed values anymore ([#2293](https://github.com/opal/opal/pull/2293))
+  - `false.tap{}` will now correctly return a JS value of `false`, not `Object(false)`
+- opal-parser doesn't break on `<<~END` strings anymore ([#2364](https://github.com/opal/opal/pull/2364))
+- Fix error reporting at the early stage of loading ([#2326](https://github.com/opal/opal/pull/2326))
+
+### Changed
+
+- Various outputted code size optimizations - 19% improvement for minified unmangled AsciiDoctor bundle - see: https://opalrb.com/blog/2021/11/24/optimizing-opal-output-for-size/ ([#2356](https://github.com/opal/opal/pull/2356))
+- Second round of code size optimizations - 3% improvement for AsciiDoctor bundle on top of the first round - 23% total - see: https://github.com/opal/opal/pull/2365/commits ([#2365](https://github.com/opal/opal/pull/2365))
+  - The calls to `==`, `!=` and `===` changed their semantics slightly: it's impossible to monkey patch those calls for `String` and `Number`, but on other classes they can now return `nil` and it will be handled correctly
+  - The calls to `!` changed their semantics slightly: it's impossible to monkey patch this call for `Boolean` or `NilClass`.
+- Refactored the structure of the internal `stdlib/nodejs` folder ([#2374](https://github.com/opal/opal/pull/2374))
+  - Added `nodejs/base` with just I/O, exit, and ARGV management
+  - Moved `Process::Status` to corelib
+  - Fixed requires to be more robust
+
 ### Removed
+
+- Removed `nodejs/irb` from stdlib as it's been broken for some time ([#2374](https://github.com/opal/opal/pull/2374))
+- Removed `Kernel#node_require` from `nodejs/kernel` as it's been deprecated for a long time ([#2374](https://github.com/opal/opal/pull/2374))
+
+<!--
+### Deprecated
 ### Internal
 -->
 
 
 
 
+## [1.3.2](https://github.com/opal/opal/compare/v1.3.1...v1.3.2) - 2021-11-10
+
+
+### Fixed
+
+- Update documentation ([#2350](https://github.com/opal/opal/pull/2350))
+- Fix `IO#gets` getting an extra char under some circumstances ([#2349](https://github.com/opal/opal/pull/2349))
+- Raise a `TypeError` instead of `UndefinedMethod` if not a string is passed to `__send__` ([#2346](https://github.com/opal/opal/pull/2346))
+- Do not modify `$~` when calling `String#scan` from internal methods ([#2353](https://github.com/opal/opal/pull/2353))
+- Stop interpreting falsey values as a missing constant in `Module#const_get` ([#2354](https://github.com/opal/opal/pull/2354))
+
+
+
+
 ## [1.3.1](https://github.com/opal/opal/compare/v1.3.0...v1.3.1) - 2021-11-03
 
 

data/UNRELEASED.md

@@ -1,71 +1,43 @@
 ### Added
 
-- Implement `chomp:` option for `String#each_line` and `#lines` (#2355)
-- Ruby 3.1 support and some older Ruby features we missed (#2347)
-  - Use parser in 3.1 mode to support new language-level features like hashes/kwargs value omission, the pin operator for pattern matching
-  - `Array#intersect?`
-  - `String#strip` and `String#lstrip` to also remove NUL bytes
-  - `Integer.try_convert`
-  - `public`, `private`, `protected`, `module_function` now return their arguments
-  - `Class#descendants`, `Class#subclasses`
-  - (<=1.8) `Kernel#local_variables`
-  - (<=2.3) Set local variables for regexp named captures (`/(?<b>a)/ =~ 'a'` => `b = 'a'`)
-  - Remove deprecated `NIL`, `TRUE`, `FALSE` constants
-  - `String#unpack` and `String#unpack1` to support an `offset:` kwarg
-  - `MatchData#match`, `MatchData#match_length`
-  - Enumerable modernization
-    - `Enumerable#tally` to support an optional hash accumulator
-    - `Enumerable#each_{cons,slice}` to return self
-    - `Enumerable#compact`
-  - `Refinement` becomes its own class now
-  - `Struct#keyword_init?`
-  - (pre-3.1) Large Enumerator rework
-    - Introduce `Enumerator::ArithmeticSequence`
-    - Introduce `Enumerator::Chain`
-    - Introduce `Enumerator#+` to create `Enumerator::Chain`s
-    - `Enumerator#{rewind,peek,peek_values,next,next_values}`
-    - Improve corelib support for beginless/endless ranges and `ArithmeticSequences`
-      - `String#[]`, `Array#[]`, `Array#[]=`, `Array#fill`, `Array#values_at`
-    - `Range#step` and `Numeric#step` return an `ArithmeticSequence` when `Numeric` values are in play
-    - Introduce `Range#%`
-    - `Enumerator::Yielder#to_proc`
-    - Fix #2367
-  - (2.7) `UnboundMethod#bind_call`
-  - (Opal) `{Kernel,BasicObject}#{inspect,p,pp,method_missing}` may work with JS native values now, also they now correctly report cycles
-  - `Enumerable#sum` uses Kahan's summation algorithm to reduce error with floating point values
-  - `File.dirname` supports a new `level` argument
-- Vendor in `optparse` and `shellwords` (#2326)
-- Preliminary support for compiling the whole `bin/opal` with Opal (#2326)
+- Introduce timezone support for Time (#2394)
+- DateTime and Date refactor (#2398)
+- Implement `Number#prev_float`/`#next_float` (#2404)
+- Support `binding.irb` anywhere in the code, for both browsers and node (#2392)
+- Added `URI.decode_www_form` (#2387)
 
-### Fixed
+### Changed
 
-- Fix defining multiple methods with the same block (#2345)
-- Fix coertion for `Array#drop` (#2371)
-- Fix coertion for `File.absolute_path` (#2372)
-- Fix some `IO#puts` edge cases (no args, empty array, nested array, …) (#2372)
-- Preserve UNC path prefix on File.join (#2366)
-- Methods on `Kernel`, `BasicObject`, `Boolean` will never return boxed values anymore (#2293)
-  - `false.tap{}` will now correctly return a JS value of `false`, not `Object(false)`
-- opal-parser doesn't break on `<<~END` strings anymore (#2364)
-- Fix error reporting at the early stage of loading (#2326)
+- Move Math IE11-supporting polyfills to a separate file (#2395)
+- String methods always return Strings even when overloaded (#2413)
+- `alias` calls will not add the "old name" method to the list of stubs for method missing (#2414)
+- Optimize writer/setter methods, up to 4% performance gain (#2402)
 
-### Changed
+### Performance
 
-- Various outputted code size optimizations - 19% improvement for minified unmangled AsciiDoctor bundle - see: https://opalrb.com/blog/2021/11/24/optimizing-opal-output-for-size/ (#2356)
-- Second round of code size optimizations - 3% improvement for AsciiDoctor bundle on top of the first round - 23% total - see: https://github.com/opal/opal/pull/2365/commits (#2365)
-  - The calls to `==`, `!=` and `===` changed their semantics slightly: it's impossible to monkey patch those calls for `String` and `Number`, but on other classes they can now return `nil` and it will be handled correctly
-  - The calls to `!` changed their semantics slightly: it's impossible to monkey patch this call for `Boolean` or `NilClass`.
-- Refactored the structure of the internal `stdlib/nodejs` folder (#2374)
-  - Added `nodejs/base` with just I/O, exit, and ARGV management
-  - Moved `Process::Status` to corelib
-  - Fixed requires to be more robust
+- Improve performance of argument coertion, fast-track `Integer`, `String`, and calling the designed coertion method (#2383)
+- Optimize `Array#[]=` by moving the implementation to JavaScript and inlining type checks (#2383)
+- Optimize internal runtime passing of block-options (#2383)
+- Compile `case` statements as `switch` whenever possible (#2411)
+- Improve performance with optimized common method/iter implementation shortcuts (#2401)
 
-### Removed
+### Fixed
+
+- Fix `Regexp.new`, previously `\A` and `\z` didn't match beginning and end of input (#2079)
+- Fix exception during `Hash#each` and `Hash#each_key` if keys get deleted during the loop (#2403)
+- Fix defining multiple methods with the same block (#2397)
+- A few edge cases of conditional calls combined with setters, e.g. `foo&.bar = 123` (#2402)
+- Correct String#to_proc and method_missing compatibility (#2418)
+- Exit REPL respecting the exit status number (#2396)
 
-- Removed `nodejs/irb` from stdlib as it's been broken for some time (#2374)
-- Removed `Kernel#node_require` from `nodejs/kernel` as it's been deprecated for a long time (#2374)
+### Internal
+
+- Rewriters refactor, fix interaction between cache and inverted runner (#2400)
 
 <!--
-### Deprecated
 ### Internal
+### Changed
+### Added
+### Removed
+### Deprecated
 -->

data/benchmark-ips/bm_js_symbols_vs_strings.rb

@@ -1,33 +1,58 @@
 Benchmark.ips do |x|
   %x{
+    const c_foo = 'foo'
+    const v_foo = 'foo'
+    const cfoo = Symbol('foo')
+    var vfoo = Symbol('foo')
+    const cgfoo = Symbol.for('foo')
+    var vgfoo = Symbol.for('foo')
+
     var o = {}
-    o[Symbol.for('foo')] = 123
-    o.foo = 123
-    var foo = Symbol('foo')
-    var gfoo = Symbol.for('foo')
-    o[foo] = 123
-    var a = 0, b = 0, c = 0
+    o[cfoo] = 1
+    o[cgfoo] = 1
+    o[c_foo] = 1
+    o[vfoo] = 1
+
+    let a1 = 0, a2 = 0, a3 = 0, a4 = 0, a5 = 0, a6 = 0, a7 = 0, a8 = 0
   }
 
+  x.report('const string ref') do
+    `a1 += o[c_foo]`
+  end
+
+  x.report('var string ref') do
+    `a2 += o[v_foo]`
+  end
+
   x.report('live global symbol') do
-    `a += o[Symbol.for('foo')]`
+    `a3 += o[Symbol.for('foo')]`
   end
 
-  x.report('stored global symbol') do
-    `a += o[gfoo]`
+  x.report('const global symbol') do
+    `a4 += o[cgfoo]`
   end
 
-  x.report('stored symbol') do
-    `a += o[foo]`
+  x.report('var global symbol') do
+    `a5 += o[vgfoo]`
+  end
+
+  x.report('const symbol') do
+    `a6 += o[cfoo]`
+  end
+
+  x.report('var symbol') do
+    `a6 += o[vfoo]`
   end
 
   x.report('ident') do
-    `b += o.foo`
+    `a7 += o.foo`
   end
 
-  x.report('string') do
-    `c += o['foo']`
+  x.report('live string') do
+    `a8 += o['foo']`
   end
 
+  x.time = 10
+
   x.compare!
 end

data/docs/releasing.md

@@ -10,16 +10,15 @@ _This guide is a work-in-progress._
 ## Updating the changelog
 
 - Ensure all the unreleased changes are documented in UNRELEASED.md
-- Run `bin/rake changelog VERSION=v1.2.3` specifying the version number you're about to release
+- [skip for pre-releases] Run `bin/rake changelog VERSION=v1.2.3` specifying the version number you're about to release
+- [skip for pre-releases] Empty UNRELEASED.md
 
 ## The commit
 
 - Commit the updated changelog along with the version bump using this commit message:
   "Release v1.2.3"
 - Push the commit and run `bin/rake release` to release the new version to Rubygems
-- Go to GitHub releases and create a new release from the latest tag pasting the contents of UNRELEASED.md
-- Empty UNRELEASED.md and run `bin/rake changelog`
-- Push the updated changelog
+- Go to GitHub releases and create a new release from the latest tag pasting the contents from CHANGELOG.md
 
 ## Opal docs
 
@@ -35,3 +34,11 @@ _This guide is a work-in-progress._
 ## Opal CDN
 
 - Run `bin/release v1.2.3`
+
+## Prepare for the next release
+
+- Skip this step if releasing a stable release
+- Create a new pull request that:
+  - Updates a version to `v1.x.0.dev` in both `lib/opal/version.rb` and `opal/corelib/constants.rb`
+- Remember to merge that PR before merging anything else next once we decide to not release any more point releases from `master`.
+

data/lib/opal/ast/matcher.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+require 'ast'
+require 'parser/ast/node'
+
+module Opal
+  module AST
+    class Matcher
+      def initialize(&block)
+        @root = instance_exec(&block)
+      end
+
+      def s(type, *children)
+        Node.new(type, children)
+      end
+
+      def cap(capture)
+        Node.new(:capture, [capture])
+      end
+
+      def match(ast)
+        @captures = []
+        @root.match(ast, self) || (return false)
+        @captures
+      end
+
+      def inspect
+        "#<Opal::AST::Matcher: #{@root.inspect}>"
+      end
+
+      attr_accessor :captures
+
+      Node = Struct.new(:type, :children) do
+        def match(ast, matcher)
+          return false if ast.nil?
+
+          ast_parts = [ast.type] + ast.children
+          self_parts = [type] + children
+
+          return false if ast_parts.length != self_parts.length
+
+          ast_parts.length.times.all? do |i|
+            ast_elem = ast_parts[i]
+            self_elem = self_parts[i]
+
+            if self_elem.is_a?(Node) && self_elem.type == :capture
+              capture = true
+              self_elem = self_elem.children.first
+            end
+
+            res = case self_elem
+                  when Node
+                    self_elem.match(ast_elem, matcher)
+                  when Array
+                    self_elem.include?(ast_elem)
+                  when :*
+                    true
+                  else
+                    self_elem == ast_elem
+                  end
+
+            matcher.captures << ast_elem if capture
+            res
+          end
+        end
+
+        def inspect
+          if type == :capture
+            "{#{children.first.inspect}}"
+          else
+            "s(#{type.inspect}, #{children.inspect[1..-2]})"
+          end
+        end
+      end
+    end
+  end
+end

data/lib/opal/cache.rb

@@ -41,7 +41,7 @@ module Opal
 
       data || begin
                 compiler = yield
-                cache.set(key, compiler)
+                cache.set(key, compiler) unless compiler.dynamic_cache_result
                 compiler
               end
     end

data/lib/opal/cli_runners/applescript.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'opal/cli_runners/system_runner'
+
 module Opal
   module CliRunners
     class Applescript

data/lib/opal/compiler.rb

@@ -217,9 +217,16 @@ module Opal
     # Comments from the source code
     attr_reader :comments
 
+    # Method calls made in this file
+    attr_reader :method_calls
+
     # Magic comment flags extracted from the leading comments
     attr_reader :magic_comments
 
+    # Set if some rewritter caused a dynamic cache result, meaning it's not
+    # fit to be cached
+    attr_accessor :dynamic_cache_result
+
     def initialize(source, options = {})
       @source = source
       @indent = ''
@@ -227,8 +234,10 @@ module Opal
       @options = options
       @comments = Hash.new([])
       @case_stmt = nil
+      @method_calls = Set.new
       @option_values = {}
       @magic_comments = {}
+      @dynamic_cache_result = false
     end
 
     # Compile some ruby code to a string.
@@ -260,9 +269,12 @@ module Opal
                :main
              end
 
-      @sexp = s(:top, sexp || s(:nil)).tap { |i| i.meta[:kind] = kind }
-      @comments = ::Parser::Source::Comment.associate_locations(sexp, comments)
-      @magic_comments = MagicComments.parse(sexp, comments)
+      @sexp = sexp.tap { |i| i.meta[:kind] = kind }
+
+      first_node = sexp.children.first if sexp.children.first.location
+
+      @comments = ::Parser::Source::Comment.associate_locations(first_node, comments)
+      @magic_comments = MagicComments.parse(first_node, comments)
       @eof_content = EofContent.new(tokens, @source).eof
     end
 
@@ -287,9 +299,8 @@ module Opal
       )
     end
 
-    # Method calls made in this file
-    def method_calls
-      @method_calls ||= Set.new
+    def record_method_call(mid)
+      @method_calls << mid
     end
 
     alias async_await_before_typecasting async_await
@@ -353,9 +364,7 @@ module Opal
       @indent
     end
 
-    # Create a new sexp using the given parts. Even though this just
-    # returns an array, it must be used incase the internal structure
-    # of sexps does change.
+    # Create a new sexp using the given parts.
     def s(type, *children)
       ::Opal::AST::Node.new(type, children)
     end