opal 0.7.2 → 0.8.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4256a7bf8ec93bf946b468fcb3bbc9898f9943a0
-  data.tar.gz: 61d122b4e553f31f2e1aab7f9075f45285dfcbdf
+  metadata.gz: 4a0a405fd05a0fa6b1f6efac707d0317c6d0ca57
+  data.tar.gz: c57f69d7c54f38d210cc3bfb139c98af5385505b
 SHA512:
-  metadata.gz: b9060be07267f2b36a2c44a4cf3d006d4e53c1f3ff2df782375a7276a164536c273ada8906e462c22721f843a961b79efdfa6571ad1fc88713ceb2c5e5a55750
-  data.tar.gz: 3fe8c046309b9cb7b19ee41ba0cb87e3d04e05c873fd9801528252aaf7b9afea9d85b72e1a528c394b026905e5635e769a68dadfd515c11970d3c9935c867952
+  metadata.gz: a2e4b8e88e96a05e3f5a284624571b6e8232594782cc72189ed48835d30ab3cd32ca0ab9d40e3cc93e2978fd1a1c0c4750408f8a57bf55a8aba07eee80278d50
+  data.tar.gz: 902b292438b1fe4893f45a52c3dc31429aa9eebefda5914cd18705c863d6e308ab36ea1323320ba2b9374f6360037a5a55dd9425488b7155b5aab97517a59324

data/.travis.yml

@@ -12,6 +12,9 @@ matrix:
     - rvm: 2.2
       env: RUN=default TZ="/usr/share/zoneinfo/Pacific/Fiji"
 
+    - rvm: 2.2
+      env: RUN=default SPROCKETS_VERSION="~> 2.12.3"
+
     - rvm: 2.1
       env: RUN=rspec
 
@@ -33,13 +36,15 @@ matrix:
   allow_failures:
     - rvm: 1.8.7
     - rvm: 1.9.3
-    - rvm: 2.0.0
     - rvm: rbx
     - rvm: jruby
     - rvm: jruby-head
 
 
 before_install:
+  # Keep track of which version of node and phantomjs we're running the specs against
+  - node -v
+  - phantomjs -v
   - git submodule update --init
 
 script:

data/CHANGELOG.md

@@ -1,3 +1,32 @@
+## edge (upcoming 0.8.0)
+
+*   Parser: Allow trailing comma in paren arglists, after normal args as
+    well as assoc args.
+
+*   Parser: Fix parsing of parens following divide operator without a
+    space.
+
+*   Parser: Fix bug where keyword arguments could not be parsed if
+    method definition did not have parens around arguments.
+
+*   Support calling `String#[]` and `String#slice` with a regexp argument
+
+*   `String#[]` and `String#slice` implementation fully compliant with rubyspec
+
+*   `Array#product` implementation fully compliant with rubyspec
+
+*   `Module#const_get` accepts a scoped constant name
+
+*   `String#succ` and `String#next` implementation fully compliant with rubyspec
+
+*   `String#===`, `String#==`, and `String#eql?` implementation fully compliant with rubyspec
+
+*   Add support for sprockets 3.0 while keeping compatibility with the 2.0 series
+
+*   Delegate dependency management directly to Sprockets (when used) making sourcemaps swift again.
+    This means code generated by sprockets will always need to be bootstrapped via `Opal.load` or `Opal.require`.
+    Luckily `Opal::Processor.load_asset_code(sprockets, name)` does just that in the right way.
+
 ## 0.7.2 2015-04-23
 
 *   Remove Sprockets 3.0 support (focus moved to upcoming 0.8)

data/CONTRIBUTING.md

@@ -20,16 +20,22 @@ and javascript code we use 2 spaces (no tabs).
 
 ## Quick Start
 
-Clone repo:
+Fork https://github.com/opal/opal, then clone the fork to your machine:
 
 ```
-$ git clone git://github.com/opal/opal.git
+$ git clone git://github.com/<Your GitHub Username>/opal.git
 ```
 
 Get dependencies:
 
 ```
-$ bundle
+$ bundle install
+```
+
+RubySpec related repos must be cloned as a git submodules:
+
+```
+$ git submodule update --init
 ```
 
 Run the test suite:
@@ -38,4 +44,45 @@ Run the test suite:
 $ bundle exec rake
 ```
 
-See the [README](https://github.com/opal/opal/blob/master/README.md#running-tests) for further details.
+You are now ready to make your first contribution to Opal! At a high level, your workflow will be to:
+
+1. Make changes to Opal source code
+2. Run the test suite to make sure it still passes
+3. Submit a pull request
+
+## Down The Rabbit Hole
+
+Before making changes to Opal source, you need to understand a little about how the test suite works. Every spec that Opal test suite executes is listed in `spec/rubyspecs` file. Each line in that file is a path to either a spec file or a directory full of spec files. If it's a path to a directory, all spec files in that directory will be executed when you run the test suite. All paths are relative to the top-level `specs` directory. Let's follow one of these paths - `corelib/core/string/sub_spec` - and see where it goes.
+
+Navigating to `spec/corelib/core` directory, you see that it contains multiple sub-directories, usually named after the Ruby class or module. Drilling further down into `spec/corelib/core/string` you see all the spec files for the various `String` behaviors under test, usually named by a method name followed by `_spec.rb`. Opening `spec/corelib/core/string/sub_spec.rb` you finally see the code that checks the correctness of Opal's implementation of `String#sub` method's behavior.
+
+When you execute `$ bundle exec rake`, the code in this file is executed, along with all the other specs in the entire test suite. It's a good idea to run the entire test suite when you feel you reached a certain milestone in the course of making your changes (exactly what that means is up to you), and definitely do `$ bundle exec rake` before commiting your changes to make sure they have not introduced regressions or other unintended side effects.
+
+But you will want to run tests as often as possible, after every small change, and running the entire test suite will slow you down. You need to be able to execute a single spec that is concerned with the feature you are currently working on. To accomplish this, just add `PATTERN` to your spec invocation command, like this:
+```
+$ bundle exec rake mspec_node PATTERN=spec/corelib/core/string/sub_spec.rb
+```
+This will make sure that only `spec/corelib/core/string/sub_spec.rb` is run, and no other specs are executed.
+
+Another way to quickly validate ideas and play with your changes is to use `opal-repl`, a tool similar to `irb`. Running `opal-repl` drops you into an interactive environment with your current version of Opal loaded, including any changes you have made.
+```
+$ bundle exec opal-repl
+>> 2 + 2
+=> 4
+>> 
+```
+
+When quickly iterating on an idea, even `opal-repl` may feel a bit too heavy, because after making a change in Opal, you must `exit` from `opal-repl` and do `$ bundle exec opal-repl` again to load Opal with your latest changes. In this case, you can run `opal` with the `-e` option, which executes a piece of code you pass to it once, then returns to the shell. This means that in order to run it again after making another adjustment to Opal, all you have to do is hit the up arrow key on your keyboard and press the enter key. This is the fastest way to go from making a change in Opal to seeing its effect.
+```
+$ bundle exec opal -e "3.times {puts 'hello'}"
+hello
+hello
+hello
+$
+```
+
+Let's recap what we covered so far. `spec/rubyspecs` is the "master list" of all the specs that get executed when you do `$ bundle exec rake`. You know where to find individual specs, inspect them, and execute them selectively or in bulk. But how do you know which specs to work on? You may be tempted to compare the contents of one of the directories in `spec/corelib/core` with the list of paths in `spec/rubyspecs`, add the missing paths to the "master list", run `$ bundle exec rake`, and start fixing the failures by implementing the missing features. However, chances are that as you are reading this, there are plenty of failing tests in the specs that are already listed in `spec/rubyspecs`. How can that be if `$ bundle exec rake` runs green? To understand this, you need to get acquainted with the concept of spec filters.
+
+There are two types of spec filters in the Opal project: `spec/filters/bugs` and `spec/filters/unsupported`. Both filters have the same effect: any spec failures that are noted inside any of the files inside of these directories are ignored when running the spec suite, i.e. they are not reported as failures. Even though their effect is the same, the purpose of `bugs` and `unsupported` filters is different. As the name suggests, `unsupported` filters list _permanent_ failures, things that other Ruby implementations can do that Opal cannot and will never be able to do (by design and by virtue of being implemented on top of JavaScript running in the browser environment). `bugs` filters, on the other hand, are _temporary_ failures, problems that need to be worked on. Problems that Opal needs your help with. Think of the `bugs` directory and the files contained within it as your "TO DO" list for contributing to Opal.
+
+Comment out any of the `fail` lines in any of the files in the `spec/filters/bugs` directory, run `$bundle exec rake`, and watch it fail. Make it pass and submit a pull request - that's all there is to it :) Happy hacking!

data/Gemfile

@@ -25,3 +25,6 @@ unless ENV['CI']
 end
 
 gem 'mspec', github: 'rubyspec/mspec'
+
+sprockets_version = ENV['SPROCKETS_VERSION']
+gem 'sprockets', sprockets_version if sprockets_version

data/README.md

@@ -84,7 +84,7 @@ Run `bundle exec guard -i` to have it started.
 
     $ rake mspec
 
-Alternatively, you can just load up a rack instance using `rackup spec/config.ru`, and
+Alternatively, you can just load up a rack instance using `rackup`, and
 visit `http://localhost:9292/` in any web browser.
 
 
@@ -127,17 +127,17 @@ Holds the stdlib that opal currently supports. This includes `Observable`,
 * Safari 5.1+
 * Opera 12.1x or (Current - 1) or Current
 
-Any problem above browsers should be considered and reported as a bug.
+Any problems encountered using the browsers listed above should be reported as a bug.
 
 (Current - 1) or Current denotes that we support the current stable version of
 the browser and the version that preceded it. For example, if the current
 version of a browser is 24.x, we support the 24.x and 23.x versions.
 
 12.1x or (Current - 1) or Current denotes that we support Opera 12.1x as well
-as last 2 versions of Opera. For example, if the current Opera version is 20.x,
-we support Opera 12.1x, 19.x and 20.x but not Opera 15.x through 18.x.
+as the last 2 versions of Opera. For example, if the current Opera version is 20.x,
+then we support Opera 12.1x, 19.x and 20.x but not Opera 15.x through 18.x.
 
-Cross-browser testing sponsored by [BrowserStack](http://browserstack.com).
+Cross-browser testing is sponsored by [BrowserStack](http://browserstack.com).
 
 ## License
 

data/config.ru

@@ -4,7 +4,7 @@ Bundler.require
 require 'mspec/opal/rake_task'
 
 ::Opal::Processor.arity_check_enabled = true
-::Opal::Processor.dynamic_require_severity = :raise
+::Opal::Processor.dynamic_require_severity = :error
 
 use Rack::ShowExceptions
 use Rack::ShowStatus

data/examples/sinatra/Gemfile

@@ -1,4 +1,5 @@
 source 'https://rubygems.org'
 
 gem 'opal', :path => '../..'
+gem 'thin' # webrick has a bug with safari
 gem 'sinatra'

data/examples/sinatra/config.ru

@@ -6,20 +6,30 @@ opal = Opal::Server.new {|s|
   s.main = 'application'
 }
 
-map opal.source_maps.prefix do
-  run opal.source_maps
+sprockets   = opal.sprockets
+maps_prefix = '/__OPAL_SOURCE_MAPS__'
+maps_app    = Opal::SourceMapServer.new(sprockets, maps_prefix)
+
+# Monkeypatch sourcemap header support into sprockets
+::Opal::Sprockets::SourceMapHeaderPatch.inject!(maps_prefix)
+
+map maps_prefix do
+  run maps_app
 end
 
 map '/assets' do
-  run opal.sprockets
+  run sprockets
 end
 
 get '/' do
+  opal_boot_code = Opal::Processor.load_asset_code(sprockets, 'application')
+
   <<-HTML
     <!doctype html>
     <html>
       <head>
         <script src="/assets/application.js"></script>
+        <script>#{opal_boot_code}</script>
       </head>
     </html>
   HTML

data/lib/mspec/opal/rake_task.rb

@@ -1,3 +1,4 @@
+require 'opal'
 require 'rack'
 require 'webrick'
 require 'mspec/opal/special_calls'
@@ -37,7 +38,16 @@ module MSpec
 
     class Runner
       def initialize &block
-        @app = RackApp.new(&block).to_app
+        @app = Rack::Builder.new do
+          ::Opal::Processor.arity_check_enabled = true
+          ::Opal::Processor.dynamic_require_severity = :error
+
+          use Rack::ShowExceptions
+          use Rack::ShowStatus
+          use MSpec::Opal::Index
+          run MSpec::Opal::Environment.new
+        end
+
         @port = 9999
       end
 
@@ -86,10 +96,7 @@ module MSpec
       end
 
       def start_server
-        @server = Thread.new do
-          Rack::Server.start(:app => app, :Port => port, :AccessLog => [],
-            :Logger => WEBrick::Log.new("/dev/null"))
-        end
+        @server = Thread.new { Rack::Server.start(:app => app, :Port => port) }
       end
     end
 
@@ -97,9 +104,6 @@ module MSpec
       attr_reader :basedir, :pattern
 
       def initialize(basedir = nil, pattern = nil)
-        ::Opal::Processor.arity_check_enabled = true
-        ::Opal::Processor.dynamic_require_severity = :error
-
         @pattern = pattern
         @basedir = basedir = File.expand_path(basedir || DEFAULT_BASEDIR)
 
@@ -173,10 +177,15 @@ module MSpec
 
       def rubyspec_white_list
         File.read("#{basedir}/rubyspecs").split("\n").reject do |line|
-          line.sub(/#.*/, '').strip.empty?
+          line.sub(/#.*/, '').strip.empty? ||
+            (line.start_with?('!') && rubyspec_black_list.push(line.sub('!', '') + '.rb'))
         end
       end
 
+      def rubyspec_black_list
+        @rubyspec_black_list ||= []
+      end
+
       def files_to_run(pattern=nil)
         # add any filters in spec/filters of specs we dont want to run
         add_files paths_from_glob("#{basedir}/filters/**/*.rb"), :filters
@@ -195,6 +204,8 @@ module MSpec
           # add any rubyspecs we want to run (defined in spec/rubyspecs)
           add_files rubyspec_white_list, :rubyspecs
         end
+
+        files - rubyspec_black_list
       end
 
       def build_specs file = "#{basedir}/build/specs.js"
@@ -205,27 +216,6 @@ module MSpec
       end
     end
 
-    class RackApp < Rack::Builder
-      attr_accessor :pattern, :basedir
-
-      def initialize
-        self.pattern = nil
-        self.basedir = DEFAULT_BASEDIR
-
-        yield(self) if block_given?
-        super()
-
-        use Rack::ShowExceptions
-        use Rack::ShowStatus
-        use Index
-        run environment
-      end
-
-      def environment
-        @environment ||= Environment.new(basedir, pattern)
-      end
-    end
-
     class Index
       HTML = <<-HTML
       <!DOCTYPE html>
@@ -236,6 +226,7 @@ module MSpec
         </head>
         <body>
           <script src="/mspec/opal/main.js"></script>
+          <script>Opal.load('mspec/opal/main');</script>
         </body>
       </html>
       HTML

data/lib/mspec/opal/runner.rb

@@ -227,7 +227,44 @@ class OSpecRunner
     MSpec.actions :start
   end
 
+  def bm!(repeat)
+    `self.bm = {}`
+    MSpec.repeat = repeat;
+    MSpec.register :before, self
+    MSpec.register :after,  self
+  end
+
+  def before(state = nil)
+    %x{
+      if (self.bm && !self.bm.hasOwnProperty(state.description)) {
+        self.bm[state.description] = {started: Date.now()};
+      }
+    }
+  end
+
+  def after(state = nil)
+    %x{
+      if (self.bm) {
+        self.bm[state.description].stopped = Date.now();
+      }
+    }
+  end
+
   def did_finish
+    %x{
+      var obj = self.bm, key, val, json, file;
+      if (obj) {
+        for (key in obj) {
+          if (obj.hasOwnProperty(key)) {
+            val = obj[key];
+            obj[key] = val.stopped - val.started;
+          }
+        }
+        json = JSON.stringify(obj, null, '  ');
+        file = #{Time.now.strftime('tmp/bm_%Y-%m-%d_%H-%M-%S-%L.json')};
+        #{File.open(`file`, 'w') {|f| f.write(`json`)}}
+      }
+    }
     MSpec.actions :finish
   end
 end

data/lib/mspec/opal/special_calls.rb

@@ -22,6 +22,12 @@ class Opal::Nodes::CallNode
     end
   end
 
+  add_special :not_compliant_on do
+    unless arglist.flatten.include? :opal
+      compile_default!
+    end
+  end
+
   add_special :platform_is_not do
     unless arglist.flatten.include? :opal
       compile_default!

data/lib/opal/builder.rb

@@ -101,6 +101,7 @@ module Opal
     end
 
     def process_require(filename, options)
+      filename.gsub!(/\.(rb|js|opal)$/, '')
       return if prerequired.include?(filename)
       return if already_processed.include?(filename)
       already_processed << filename

data/lib/opal/builder_processors.rb

@@ -87,7 +87,7 @@ module Opal
 
       def compiled
         @compiled ||= begin
-          compiler = compiler_for(@source, file: @filename)
+          compiler = compiler_for(@source, file: @filename.gsub(/\.(rb|js|opal)$/, ''))
           compiler.compile
           compiler
         end
@@ -102,7 +102,10 @@ module Opal
       end
 
       def required_trees
-        compiled.required_trees
+        compiled.required_trees.map do |tree|
+          # Remove any leading ./ after joining to dirname
+          File.join(File.dirname(@filename), tree).sub(%r{^(\./)*}, '')
+        end
       end
 
       def compiler_class

data/lib/opal/cli_runners/phantom.js

@@ -8,11 +8,20 @@ page.onConsoleMessage = function(msg) {
 
 var opal_code = fs.read('/dev/stdin');
 
+/*
+ * Exit phantom instance "safely" see - https://github.com/ariya/phantomjs/issues/12697
+ * https://github.com/nobuoka/gulp-qunit/commit/d242aff9b79de7543d956e294b2ee36eda4bac6c
+ */
+function phantom_exit(code) {
+  page.close();
+  setTimeout(function () { phantom.exit(code); }, 0);
+}
+
 page.onCallback = function(data) {
   switch (data[0]) {
   case 'exit':
     var status = data[1] || 0;
-    phantom.exit(status);
+    phantom_exit(status);
   case 'stdout':
     system.stdout.write(data[1] || '');
     break;