opal 0.6.3 → 0.7.0.beta1

data/opal/corelib/variables.rb

@@ -1,9 +1,9 @@
 # regexp matches
 $& = $~ = $` = $' = nil
 
-# stub library path
-$: = []
-$" = []
+# requires
+$LOADED_FEATURES = $" = `Opal.loaded_features`
+$LOAD_PATH       = $: = []
 
 # split lines
 $/ = "\n"

data/opal/opal.rb

@@ -28,3 +28,5 @@ require 'corelib/struct'
 require 'corelib/io'
 require 'corelib/main'
 require 'corelib/variables'
+require 'corelib/dir'
+require 'corelib/file'

data/package.json

@@ -0,0 +1,9 @@
+{
+  "dependencies": {
+    "glob": "latest",
+    "js-yaml": "latest"
+  },
+  "devDependencies": {
+    "doxx": "latest"
+  }
+}

data/spec/filters/bugs/array.rb

@@ -213,13 +213,7 @@ opal_filter "Array" do
   fails "Array#partition returns two arrays"
   fails "Array#partition does not return subclass instances on Array subclasses"
 
-  fails "Array#| does not call to_ary on array subclasses"
-  fails "Array#| does not return subclass instances for Array subclasses"
   fails "Array#| acts as if using an intermediate hash to collect values"
-  fails "Array#| tries to convert the passed argument to an Array using #to_ary"
-  fails "Array#| creates an array with elements in order they are first encountered"
-  fails "Array#| creates an array with no duplicates"
-  fails "Array#| returns an array of elements that appear in either array (union)"
 
   # recursive arrays
   fails "Array#join raises an ArgumentError when the Array is recursive"

data/spec/filters/bugs/language.rb

@@ -320,6 +320,7 @@ opal_filter "language" do
   fails "The super keyword raises an error error when super method does not exist"
   fails "The super keyword calls the correct method when the superclass argument list is different from the subclass"
   fails "The super keyword respects the original module a method is aliased from"
+  fails "The super keyword raises a RuntimeError when called with implicit arguments from a method defined with define_method"
 
   fails "The until modifier with begin .. end block restart the current iteration without reevaluting condition with redo"
   fails "The until modifier with begin .. end block skips to end of body with next"
@@ -408,4 +409,7 @@ opal_filter "language" do
   fails "The defined? keyword for super for a method taking no arguments returns nil from a block in a #define_method when no superclass method exists"
   fails "The defined? keyword for super for a method taking arguments returns nil from a #define_method when no superclass method exists"
   fails "The defined? keyword for super for a method taking arguments returns nil from a block in a #define_method when no superclass method exists"
+
+  fails "The __FILE__ pseudo-variable equals the absolute path of a file loaded by an absolute path" # we can't clear $LOADED_FEATURES, should be treated as readonly
+  fails "The __FILE__ pseudo-variable equals the absolute path of a file loaded by a relative path" # we can't clear $LOADED_FEATURES, should be treated as readonly
 end

data/spec/filters/bugs/numeric.rb

@@ -6,14 +6,15 @@ opal_filter "Fixnum bugs" do
   fails "Fixnum#zero? returns true if self is 0"
 end
 
-opal_filter "Fixnum#<< doesn't handle non-integers" do
-  fails "Fixnum#<< with n << m raises a TypeError when passed a String"
-  fails "Fixnum#<< with n << m raises a TypeError when passed nil"
-  fails "Fixnum#<< with n << m raises a TypeError when #to_int does not return an Integer"
+opal_filter "Fixnum#<< doesn't handle Bignum and large number checks" do
   fails "Fixnum#<< with n << m returns a Bignum == fixnum_min() * 2 when fixnum_min() << 1 and n < 0"
   fails "Fixnum#<< with n << m returns a Bignum == fixnum_max() * 2 when fixnum_max() << 1 and n > 0"
   fails "Fixnum#<< with n << m returns 0 when m < 0 and m is a Bignum"
   fails "Fixnum#<< with n << m returns 0 when m < 0 and m == p where 2**p > n >= 2**(p-1)"
-  fails "Fixnum#<< with n << m returns n shifted right m bits when n < 0, m < 0"
-  fails "Fixnum#<< with n << m returns n shifted right m bits when n > 0, m < 0"
+end
+
+opal_filter "Fixnum#>> doesn't handle Bignum" do
+  fails "Fixnum#>> with n >> m returns a Bignum == fixnum_max() * 2 when fixnum_max() >> -1 and n > 0"
+  fails "Fixnum#>> with n >> m returns a Bignum == fixnum_min() * 2 when fixnum_min() >> -1 and n < 0"
+  fails "Fixnum#>> with n >> m returns 0 when m is a Bignum"
 end

data/spec/filters/bugs/opal.rb

@@ -9,4 +9,6 @@ opal_filter "Opal bugs" do
   fails "String#index with Regexp supports \\G which matches at the given start offset"
   fails "String#index with Regexp starts the search at the given offset"
   fails "String#index with Regexp returns the index of the first match of regexp"
+
+  fails "Kernel#warn requires multiple arguments"
 end

data/spec/filters/bugs/regexp.rb

@@ -1,7 +1,11 @@
 opal_filter "RegExp" do
+  fails "Regexp#eql? is true if self and other have the same character set code"
+  fails "Regexp#== is true if self and other have the same character set code"
   fails "Regexp#~ matches against the contents of $_"
   fails "Regexp#match uses the start as a character offset"
   fails "Regexp#match matches the input at a given position"
   fails "Regexp#match with [string, position] when given a positive position matches the input at a given position"
   fails "Regexp#match with [string, position] when given a negative position matches the input at a given position"
+  fails "MatchData#regexp returns the pattern used in the match"
+  fails "MatchData#values_at when passed a Range returns an array of the matching value"
 end

data/spec/filters/bugs/string.rb

@@ -192,14 +192,7 @@ opal_filter "String" do
   fails "String#sub with pattern, replacement replaces \\' with everything after the current match"
   fails "String#sub with pattern, replacement replaces \\+ with the last paren that actually matched"
   fails "String#sub with pattern, replacement treats \\+ as an empty string if there was no captures"
-  fails "String#sub with pattern, replacement maps \\\\ in replacement to \\"
-  fails "String#sub with pattern, replacement tries to convert pattern to a string using to_str"
-  fails "String#sub with pattern, replacement tries to convert pattern to a string using to_str"
-  fails "String#sub with pattern, replacement raises a TypeError when pattern can't be converted to a string"
-  fails "String#sub with pattern, replacement raises a TypeError when replacement can't be converted to a string"
   fails "String#sub with pattern, replacement sets $~ to MatchData of match and nil when there's none"
-  fails "String#sub with pattern, replacement replaces \\1 with 1"
-  fails "String#sub with pattern, replacement replaces \\\\1 with \\1"
   fails "String#sub with pattern and block sets $~ for access from the block"
   fails "String#sub with pattern and block sets $~ to MatchData of last match and nil when there's none for access from outside"
   fails "String#sub with pattern and block doesn't raise a RuntimeError if the string is modified while substituting"

data/spec/filters/bugs/stringscanner.rb

@@ -2,7 +2,7 @@ opal_filter "StringScanner" do
   fails "StringScanner#[] calls to_int on the given index"
   fails "StringScanner#[] raises a TypeError if the given index is nil"
   fails "StringScanner#[] raises a TypeError when a Range is as argument"
-  fails "StringScanner#[] raises a TypeError when a String is as argument"  
+  fails "StringScanner#[] raises a TypeError when a String is as argument"
 
   fails "StringScanner#get_byte is not multi-byte character sensitive"
 
@@ -16,4 +16,7 @@ opal_filter "StringScanner" do
 
   fails "StringScanner#scan returns the matched string for a multi byte string"
   fails "StringScanner#scan raises a TypeError if pattern isn't a Regexp"
+
+  fails "StringScanner#pos= can poin position that greater than string length for multibyte string"
+  fails "StringScanner#pos= positions from the end if the argument is negative for multibyte string"
 end

data/spec/filters/unsupported/private_methods.rb

@@ -39,4 +39,6 @@ opal_filter "Private methods" do
   fails "Class#initialize is private"
 
   fails "Math#atanh is a private instance method"
+
+  fails "Kernel#warn is a private method"
 end

data/spec/lib/builder_processors_spec.rb

@@ -0,0 +1,27 @@
+require 'lib/spec_helper'
+require 'opal/builder_processors'
+
+describe Opal::Builder::RubyProcessor do
+  it 'compiles ruby to js' do
+    processor = described_class.new('puts 5', '-e')
+    expect(processor.to_s).to include('$puts(5)')
+  end
+
+  describe ':requirable option' do
+    it 'is respected' do
+      processor = described_class.new('puts 5', '-e', requirable: true)
+      expect(processor.to_s).to include('Opal.modules[')
+    end
+
+    it 'defaults to "false"' do
+      processor = described_class.new('puts 5', '-e')
+      expect(processor.to_s).not_to include('Opal.modules[')
+    end
+  end
+
+  it 'fills required_trees' do
+    processor = described_class.new('require_tree "./pippo"', '-e')
+    expect(processor.required_trees).to eq(['pippo'])
+  end
+end
+

data/spec/lib/builder_spec.rb

@@ -0,0 +1,66 @@
+require 'lib/spec_helper'
+require 'opal/builder'
+require 'lib/shared/path_reader_shared'
+
+describe Opal::Builder do
+  subject(:builder) { described_class.new(options) }
+  let(:options) { {} }
+
+  it 'compiles opal' do
+    expect(builder.build('opal').to_s).to match('(Opal);')
+  end
+
+  it 'respect #require_tree calls' do
+    begin
+      Opal.append_path(File.expand_path('..', __FILE__))
+      expect(builder.build('fixtures/require_tree_test').to_s).to include('Opal.modules["fixtures/required_tree_test/required_file1"]')
+    ensure
+      Opal.instance_variable_set('@paths', nil)
+    end
+  end
+
+  describe ':stubs' do
+    let(:options) { {stubs: ['foo']} }
+
+    it 'compiles them as empty files' do
+      source = 'require "foo"'
+      expect(builder.default_processor).to receive('new').with(source, anything, anything).once.and_call_original
+      expect(builder.default_processor).to receive('new').with('',     anything, anything).once.and_call_original
+
+      builder.build_str(source, 'bar.rb')
+    end
+  end
+
+  describe ':prerequired' do
+    let(:options) { {prerequired: ['foo']} }
+
+    it 'compiles them as empty files' do
+      source = 'require "foo"'
+      builder.build_str(source, 'bar.rb')
+    end
+  end
+
+  describe ':preload' do
+    let(:options) { {preload: ['base64']} }
+
+    it 'compiles them as empty files' do
+      source = 'puts 5'
+      expect(builder.default_processor).to receive('new').with(anything, 'base64', anything).once.and_call_original
+      expect(builder.default_processor).to receive('new').with(source, anything, anything).once.and_call_original
+
+      builder.build_str(source, 'bar.rb')
+    end
+  end
+
+  describe 'requiring a native .js file' do
+    it 'can be required without specifying extension' do
+      builder.build_str('require "corelib/runtime"', 'foo')
+      expect(builder.to_s).to start_with('(function(undefined)')
+    end
+
+    it 'can be required specifying extension' do
+      builder.build_str('require "corelib/runtime.js"', 'foo')
+      expect(builder.to_s).to start_with('(function(undefined)')
+    end
+  end
+end

data/spec/{cli → lib}/cli_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../spec_helper', __FILE__)
+require 'lib/spec_helper'
 require 'opal/cli'
 require 'stringio'
 
@@ -9,7 +9,7 @@ describe Opal::CLI do
   subject(:cli) { described_class.new(options) }
 
   context 'with a file' do
-    let(:options) { {:filename => file} }
+    let(:options) { {:file => File.open(file)} }
 
     it 'runs the file' do
       expect_output_of{ subject.run }.to eq("hi from opal!\n")
@@ -58,6 +58,56 @@ describe Opal::CLI do
     end
   end
 
+  describe ':gems options' do
+    context 'with a Gem name' do
+      let(:dir)      { File.dirname(file) }
+      let(:filename) { File.basename(file) }
+      let(:gem_name) { 'mspec' }
+      let(:options)  { {:gems => [gem_name], :evals => ['']} }
+
+      it "adds the gem's lib paths to Opal.path" do
+        cli.run
+
+        spec = Gem::Specification.find_by_name(gem_name)
+        spec.require_paths.each do |require_path|
+          require_path = File.join(spec.gem_dir, require_path)
+          expect(Opal.paths).to include(require_path)
+        end
+      end
+    end
+  end
+
+  describe ':stubs options' do
+    context 'with a stubbed file' do
+      let(:dir)      { File.dirname(file) }
+      let(:filename) { File.basename(file) }
+      let(:stub_name) { 'an_unparsable_lib' }
+      let(:options)  { {:stubs => [stub_name], :evals => ["require #{stub_name.inspect}"]} }
+
+      it "adds the gem's lib paths to Opal.path" do
+        expect_output_of{ subject.run }.to eq('')
+      end
+    end
+  end
+
+  describe ':verbose option' do
+    let(:options)  { {:verbose => true, :evals => ['']} }
+
+    it 'sets the verbose flag (currently unused)' do
+      expect(cli.verbose).to eq(true)
+    end
+  end
+
+  describe ':compile option' do
+    let(:options)  { {:compile => true, :evals => ['puts 5']} }
+
+    it 'outputs the compiled javascript' do
+      expect_output_of{ subject.run }.to include(".$puts(5)")
+      expect_output_of{ subject.run }.not_to include("5\n")
+    end
+  end
+
+
   describe ':load_paths options' do
     let(:dir)      { File.dirname(file) }
     let(:filename) { File.basename(file) }
@@ -68,11 +118,16 @@ describe Opal::CLI do
   end
 
   def expect_output_of
+    @output, _result = output_and_result_of { yield }
+    expect(@output)
+  end
+
+  def output_and_result_of
     stdout = described_class.stdout
     described_class.stdout = fake_stdout
-    yield
-    @output = fake_stdout.tap(&:rewind).read
-    expect(@output)
+    result = yield
+    output = fake_stdout.tap(&:rewind).read
+    return output, result
   ensure
     described_class.stdout = stdout
   end

data/spec/{cli → lib}/compiler_spec.rb

@@ -1,6 +1,25 @@
-require File.expand_path('../spec_helper', __FILE__)
+require 'lib/spec_helper'
 
 describe Opal::Compiler do
+  describe 'requiring' do
+    it 'calls #require' do
+      expect_compiled("require 'pippo'").to include('self.$require("pippo")')
+    end
+  end
+
+  describe 'requirable' do
+    it 'executes the file' do
+      expect_compiled("").to include('(function($opal) {')
+      expect_compiled("").to end_with("})(Opal);\n")
+    end
+
+    it 'puts the compiled into "Opal.modules"' do
+      options = { :requirable => true, :file => "pippo" }
+      expect_compiled("", options).to include('Opal.modules["pippo"] = function($opal) {')
+      expect_compiled("", options).to end_with("};\n")
+    end
+  end
+
   it "should compile simple ruby values" do
     expect_compiled("3.142").to include("return 3.142")
     expect_compiled("123e1").to include("return 1230")
@@ -21,8 +40,8 @@ describe Opal::Compiler do
   end
 
   it "should compile constant lookups" do
-    expect_compiled("Object").to include("scope.Object")
-    expect_compiled("Array").to include("scope.Array")
+    expect_compiled("Object").to include("Object")
+    expect_compiled("Array").to include("Array")
   end
 
   describe "class names" do
@@ -130,7 +149,49 @@ describe Opal::Compiler do
     end
   end
 
-  def expect_compiled(source)
-    expect(Opal::Compiler.new.compile source)
+  describe 'pre-processing require-ish methods' do
+    describe '#require' do
+      it 'parses and resolve #require argument' do
+        compiler = compiler_for(%Q{require "#{__FILE__}"})
+        expect(compiler.requires).to eq([__FILE__])
+      end
+    end
+
+    describe '#autoload' do
+      it 'ignores autoload outside of context class' do
+        compiler = compiler_for(%Q{autoload Whatever, "#{__FILE__}"})
+        expect(compiler.requires).to eq([])
+      end
+
+      it 'parses and resolve second #autoload arguments' do
+        compiler = compiler_for(%Q{class Foo; autoload Whatever, "#{__FILE__}"; end})
+        expect(compiler.requires).to eq([__FILE__])
+      end
+    end
+
+    describe '#require_relative' do
+      it 'parses and resolve #require_relative argument' do
+        compiler = compiler_for(%Q{require_relative "./#{File.basename(__FILE__)}"}, file: __FILE__)
+        expect(compiler.requires).to eq([__FILE__])
+      end
+    end
+
+    describe '#require_tree' do
+      require 'pathname'
+      let(:file) { Pathname(__FILE__).join('../fixtures/require_tree_test.rb') }
+
+      it 'parses and resolve #require argument' do
+        compiler = compiler_for(file.read)
+        expect(compiler.required_trees).to eq(['../fixtures/required_tree_test'])
+      end
+    end
+  end
+
+  def expect_compiled(*args)
+    expect(Opal::Compiler.new(*args).compile)
+  end
+
+  def compiler_for(*args)
+    Opal::Compiler.new(*args).tap(&:compile)
   end
 end

data/spec/{cli → lib}/dependency_resolver_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../spec_helper.rb', __FILE__)
+require 'lib/spec_helper'
 
 describe Opal::Nodes::CallNode::DependencyResolver do
   let(:compiler) { double(:compiler, :dynamic_require_severity => :none) }

data/spec/lib/fixtures/no_requires.rb

@@ -0,0 +1 @@
+puts 'hi there'

data/spec/lib/fixtures/require_tree_test.rb

@@ -0,0 +1,3 @@
+require_tree '../fixtures/required_tree_test'
+
+puts 5

data/spec/lib/fixtures/required_tree_test/required_file1.rb

@@ -0,0 +1 @@
+p 1