opal 0.10.6 → 0.11.0.rc1

data/spec/opal/core/date_spec.rb

@@ -8,6 +8,11 @@ describe Date do
       Date.parse('2013-10-4').should == Date.new(2013, 10, 4)
       Date.parse('2013-06-02').should == Date.new(2013, 6, 2)
     end
+
+    it "parses date string with month name into a Date instance" do
+      Date.parse("2013 Jun 02").should == Date.new(2013, 6, 2)
+      Date.parse("2013 jun 02").should == Date.new(2013, 6, 2)
+    end
   end
 
   describe "#<" do
@@ -46,6 +51,10 @@ describe Date do
     it 'returns 1 when self is greater than other' do
       (Date.new(2015, 1, 2) <=> Date.new(2015, 1, 1)).should == 1
     end
+
+    it 'returns nil when compared to non-Date objects' do
+      (Date.new <=> nil).should == nil
+    end
   end
 
   describe "#==" do
@@ -56,6 +65,11 @@ describe Date do
     it "returns false if self is not equal to other date" do
       (Date.new(2013, 10, 2) == Date.new(2013, 10, 11)).should == false
     end
+
+    it 'returns false when compared to non-Date objects' do
+      (Date.new == nil).should == false
+      (Date.new == Object.new).should == false
+    end
   end
 
   describe "#clone" do

data/spec/opal/core/exception_spec.rb

@@ -18,3 +18,13 @@ describe "Native exception" do
     exception.message.should == "native message"
   end
 end
+
+# TODO: Delete when this code is added to the ruby spec
+describe "Exception#to_s" do
+  it "calls #to_s on the message" do
+    message = mock("message")
+    message.should_receive(:to_s).and_return("message").any_number_of_times
+    ExceptionSpecs::Exceptional.new(message).to_s.should == "message"
+  end
+end
+

data/spec/opal/core/hash/internals_spec.rb

@@ -188,11 +188,11 @@ describe 'Hash' do
         @obj1  => 'xyz'
       }
 
-      `#@hash.$$map.hasOwnProperty('hhh')`.should == true
-      `#@hash.$$map.hasOwnProperty(#{@obj1.hash})`.should == true
-      `#@hash.$$smap.hasOwnProperty('a')`.should == true
-      `#@hash.$$smap.hasOwnProperty('b')`.should == true
-      `#@hash.$$smap.hasOwnProperty('c')`.should == true
+      `Opal.hasOwnProperty.call(#@hash.$$map, 'hhh')`.should == true
+      `Opal.hasOwnProperty.call(#@hash.$$map, #{@obj1.hash})`.should == true
+      `Opal.hasOwnProperty.call(#@hash.$$smap, 'a')`.should == true
+      `Opal.hasOwnProperty.call(#@hash.$$smap, 'b')`.should == true
+      `Opal.hasOwnProperty.call(#@hash.$$smap, 'c')`.should == true
 
       `#@hash.$$keys.length`.should == 8
       `Object.keys(#@hash.$$map).length`.should == 2
@@ -322,11 +322,11 @@ describe 'Hash' do
       `#@hash.$$smap['b'] === undefined`.should == true
       `#@hash.$$smap['c'] === undefined`.should == true
 
-      `#@hash.$$map.hasOwnProperty('hhh')`.should == false
-      `#@hash.$$map.hasOwnProperty(#{@obj1.hash})`.should == false
-      `#@hash.$$smap.hasOwnProperty('a')`.should == false
-      `#@hash.$$smap.hasOwnProperty('b')`.should == false
-      `#@hash.$$smap.hasOwnProperty('c')`.should == false
+      `Opal.hasOwnProperty.call(#@hash.$$map, 'hhh')`.should == false
+      `Opal.hasOwnProperty.call(#@hash.$$map, #{@obj1.hash})`.should == false
+      `Opal.hasOwnProperty.call(#@hash.$$smap, 'a')`.should == false
+      `Opal.hasOwnProperty.call(#@hash.$$smap, 'b')`.should == false
+      `Opal.hasOwnProperty.call(#@hash.$$smap, 'c')`.should == false
     end
   end
 end

data/spec/opal/core/kernel/rand_spec.rb

@@ -12,10 +12,6 @@ describe "Kernel.rand" do
     r.to_a.include?(rand(r)).should == true
   end
 
-  it "should convert negative number and convert to integer" do
-    rand(-0.1).should == 0
-  end
-
   it "returns a numeric in opal" do
     rand.should be_kind_of(Numeric)
     rand(77).should be_kind_of(Numeric)

data/spec/opal/core/kernel/respond_to_spec.rb

@@ -12,6 +12,9 @@ class RespondToSpecs
   def some_method
     :foo
   end
+
+  def foo
+  end
 end
 
 describe "Kernel.respond_to?" do
@@ -35,7 +38,7 @@ describe "Kernel#respond_to?" do
   end
 
   it "returns false if a method exists, but is marked with a '$$stub' property" do
-    `#{@a}.$some_method.$$stub = true`
-    @a.respond_to?(:some_method).should be_false
+    `#{@a}.$foo.$$stub = true`
+    @a.respond_to?(:foo).should be_false
   end
 end

data/spec/opal/core/language/constant_lookup_spec.rb

@@ -0,0 +1,38 @@
+ConstantLookupSpec_TopDef = 123
+def self._ConstantLookupSpec_TopDef
+  ConstantLookupSpec_TopDef
+end
+ConstantLookupSpec_TopDefValue = _ConstantLookupSpec_TopDef
+
+module ConstantLookupSpec_Module
+end
+class ConstantLookupSpec_Class
+end
+
+module ConstantLookupSpec_Namespace
+  class NamespacedClass
+    def self.foo
+      ConstantLookupSpec_TopDef
+    end
+  end
+end
+
+
+describe 'constant lookup' do
+  it 'can reach constants from methods defined at top level' do
+    ::ConstantLookupSpec_TopDefValue.should == 123
+    ::ConstantLookupSpec_TopDefValue.should == ::ConstantLookupSpec_TopDef
+    ::ConstantLookupSpec_TopDefValue.should == ConstantLookupSpec_TopDef
+  end
+
+  it 'cannot reach a toplevel constant from a qualified lookup on another toplevel constant' do
+    ->{ConstantLookupSpec_Module::ConstantLookupSpec_Class}.should raise_error(NameError)
+
+    # When the cref is a module then ::Object is added to the search
+    ->{ConstantLookupSpec_Class::ConstantLookupSpec_Module}.should_not raise_error
+  end
+
+  it 'can reach a constant from inside a namespaced class' do
+    ConstantLookupSpec_Namespace::NamespacedClass.foo.should == 123
+  end
+end

data/spec/opal/core/language/predefined_spec.rb

@@ -114,7 +114,7 @@ describe "The predefined global constants" do
 
   it "includes RUBY_VERSION" do
     Object.const_defined?(:RUBY_VERSION).should == true
-    RUBY_VERSION.should =~ /^\d+\.\d+\.\d+$/
+    RUBY_VERSION.should =~ /^\d\.\d\.\d$/
   end
 
   it "includes RUBY_RELEASE_DATE" do

data/spec/opal/core/language/safe_navigator_spec.rb

@@ -0,0 +1,7 @@
+describe 'Safe navigator' do
+  it "handles also null and undefined" do
+    [`null`, `undefined`].each do |value|
+      value&.unknown.should == nil
+    end
+  end
+end

data/spec/opal/core/language/send_spec.rb

@@ -73,7 +73,7 @@ describe "Invoking a method" do
         specs.fooM1O1(1,2,3)
       }.should raise_error(ArgumentError)
     end
-    
+
     it "keeps the block if supplied" do
       block = lambda {}
       specs.fooM1O2(1, foo: :bar, &block).should == [1, {foo: :bar}, block]
@@ -102,14 +102,6 @@ describe "Invoking a method" do
     prc.call.should == "hello"
   end
 
-  it "with an object as a block uses 'to_proc' for coercion" do
-    o = LangSendSpecs::ToProc.new(:from_to_proc)
-
-    specs.makeproc(&o).call.should == :from_to_proc
-
-    specs.yield_now(&o).should == :from_to_proc
-  end
-
   it "raises a SyntaxError with both a literal block and an object as block" do
     lambda {
       eval "specs.oneb(10, &l){ 42 }"

data/spec/opal/core/language/string_spec.rb

@@ -16,29 +16,29 @@ describe "Ruby character strings" do
 
   it "should not process escape characters in single-quoted heredocs" do
     s = <<'EOD'
-      hey\now\brown\cow
-    EOD
+  hey\now\brown\cow
+EOD
     s.strip.should == 'hey\now\brown\cow'
   end
 
   it "should ignore single-quote escapes in single-quoted heredocs" do
     s = <<'EOD'
-      they\'re greeeeaaat!
-    EOD
+  they\'re greeeeaaat!
+EOD
     s.strip.should == 'they\\\'re greeeeaaat!'
   end
 
   it "should process escape characters in double quoted heredocs" do
     s = <<"EOD"
-      hey\now\brown\cow
-    EOD
+  hey\now\brown\cow
+EOD
     s.strip.should == "hey\now\brown\cow"
   end
 
   it "should treat bare-word heredoc identifiers as double-quoted" do
     s = <<EOD
-      hey\now\brown\cow
-    EOD
+  hey\now\brown\cow
+EOD
     s.strip.should == "hey\now\brown\cow"
   end
 end

data/spec/opal/core/language/versions/def_2_0_spec.rb

@@ -17,10 +17,6 @@ describe "An instance method with keyword arguments" do
       foo(a: nil).should be_nil
     end
 
-    it "raises an argument error when an unknown keyword argument is provided" do
-      lambda { foo(b: 20) }.should raise_error(ArgumentError)
-    end
-
     it "raises an argument error when a non-keyword argument is provided" do
       lambda { foo(1) }.should raise_error(ArgumentError)
     end

data/spec/opal/core/language_spec.rb

@@ -43,3 +43,35 @@ describe "generated method names" do
     }
   end
 end
+
+describe 'undef with dynamic symbol (regression for https://github.com/opal/opal/pull/1128)' do
+  class UndefWithDynamicSymbol
+    def foo_bar
+    end
+  end
+
+  class UndefWithDynamicSymbol
+    bar = "bar"
+    undef :"foo_#{bar}"
+  end
+
+  it 'should work' do
+    lambda { UndefWithDynamicSymbol.new.foo_bar }.should raise_error(NoMethodError)
+  end
+end
+
+describe 'alias with dynamic symbol (regression for https://github.com/opal/opal/pull/1128)' do
+  class AliasWithDynamicSymbol
+    def method1
+    end
+  end
+
+  class AliasWithDynamicSymbol
+    alias :"method#{2}" :"method#{1}"
+  end
+
+  it 'should work' do
+    AliasWithDynamicSymbol.new.should respond_to(:method1)
+    AliasWithDynamicSymbol.new.should respond_to(:method2)
+  end
+end

data/spec/opal/core/module/const_get_spec.rb

@@ -4,7 +4,7 @@ CS_CONST1 = :const1
 
 module ConstGetSpecs
   FOO = 100
-  
+
   module Bar
     BAR = 200
 

data/spec/opal/core/runtime/is_a_spec.rb

@@ -0,0 +1,36 @@
+describe 'Opal.is_a' do
+  describe 'Numeric/Number special cases' do
+    [
+      [1, Numeric, true],
+      [1, Number, true],
+      [1, Fixnum, true],
+      [1, Integer, true],
+      [1, Float, true],
+
+      [1.2, Numeric, true],
+      [1.2, Number, true],
+      [1.2, Fixnum, true],
+      [1.2, Integer, true],
+      [1.2, Float, true],
+
+      [Numeric.new, Numeric, true],
+      [Numeric.new, Number, false],
+      [Numeric.new, Fixnum, false],
+      [Numeric.new, Integer, false],
+      [Numeric.new, Float, false],
+    ].each do |(value, klass, result)|
+      it "returns #{result} for Opal.is_a(#{value}, #{klass})" do
+        # p klass => `[!!klass.$$is_number_class, !!klass.$$proto.$$is_number]`
+        `Opal.is_a(#{value}, #{klass})`.should == result
+      end
+    end
+
+    it 'can rely on Number subclasses having $$is_number_class on their prototype' do
+      `!!#{Numeric}.$$is_number_class`.should == false
+      `!!#{Number}.$$is_number_class`.should == true
+      `!!#{Fixnum}.$$is_number_class`.should == true
+      `!!#{Integer}.$$is_number_class`.should == true
+      `!!#{Float}.$$is_number_class`.should == true
+    end
+  end
+end

data/spec/opal/core/runtime/rescue_spec.rb

@@ -68,4 +68,39 @@ describe "The rescue keyword" do
     a.should == "I got foo"
   end
 
+  context 'JS::Error' do
+    it 'handles raw js throws' do
+      begin
+        `throw { message: 'foo' }`
+        nil
+      rescue JS::Error => e
+        e.JS[:message]
+      end.should == 'foo'
+    end
+
+    it 'handles other Opal error' do
+      begin
+        raise 'bar'
+      rescue JS::Error => e
+        e.message
+      end.should == 'bar'
+    end
+
+    it 'can be combined with other classes to catch js errors' do
+      begin
+        `throw { message: 'baz' }`
+        nil
+      rescue JS::Error, RuntimeError => e
+        e.JS[:message]
+      end.should == 'baz'
+    end
+
+    it 'can be combined with other classes to catch Opal errors' do
+      begin
+        raise 'quux'
+      rescue JS::Error, RuntimeError => e
+        e.message
+      end.should == 'quux'
+    end
+  end
 end

data/spec/opal/core/runtime_spec.rb

@@ -9,12 +9,12 @@ end
 describe 'javascript access using .JS' do
   it 'should call javascript methods via .JS.method()' do
     "a1234b5678c".JS.indexOf('c').should == 10
-    "a1234b5678c".JS.replace(/[0-9]/g, '').should == 'abc'
+    "a1234b5678c".JS.replace(`/[0-9]/g`, '').should == 'abc'
   end
 
   it 'should call javascript methods via .JS.method arg' do
     ("a1234b5678c".JS.indexOf 'c').should == 10
-    ("a1234b5678c".JS.replace /[0-9]/g, '').should == 'abc'
+    ("a1234b5678c".JS.replace `/[0-9]/g`, '').should == 'abc'
   end
 
   it 'should call javascript methods with blocks via .JS.method' do
@@ -41,8 +41,8 @@ describe 'javascript access using .JS' do
   end
 
   it 'should be chainable' do
-    "a1234b5678c".JS.replace(/[0-9]/g, '').JS.toUpperCase.should == 'ABC'
-    "a1234b5678c".JS.replace(/[0-9]/g, '').JS[:length].should == 3
+    "a1234b5678c".JS.replace(`/[0-9]/g`, '').JS.toUpperCase.should == 'ABC'
+    "a1234b5678c".JS.replace(`/[0-9]/g`, '').JS[:length].should == 3
     "a1234b5678c".JS[:length].JS.toString.should == "11"
     `{a:{b:1}}`.JS[:a].JS[:b].JS.toString.should == '1'
     f = `{a:function(f){return {b: function(f2){return f(f2(1)) + f(f2(2))}}}}`

data/spec/opal/core/string_spec.rb

@@ -12,16 +12,16 @@ describe "String" do
   it 'parses complex heredoc (pr #1363)' do
     str = <<'...end ruby23.y/module_eval...'
 
-      def version
-        23
-      end
+  def version
+    23
+  end
 
-      def default_encoding
-        Encoding::UTF_8
-      end
-    ...end ruby23.y/module_eval...
+  def default_encoding
+    Encoding::UTF_8
+  end
+...end ruby23.y/module_eval...
 
-    str.should == "\n      def version\n        23\n      end\n\n      def default_encoding\n        Encoding::UTF_8\n      end\n"
+    str.should == "\n  def version\n    23\n  end\n\n  def default_encoding\n    Encoding::UTF_8\n  end\n"
   end
 end
 

data/spec/opal/core/time_spec.rb

@@ -3,27 +3,36 @@ require 'time'
 
 # rubyspec does not have specs for these listed methods
 describe Time do
-  describe '#zone' do
-    context 'with different TZs on Tue Jun 20 20:50:08 UTC 2017' do
-      it 'zone is +12' do
-        time = Time.now
+  describe '<=>' do
+    it 'returns -1 when self is less than other' do
+      (Time.new(2015, 1, 1) <=> Time.new(2015, 1, 2)).should == -1
+    end
 
-        # export TZ="/usr/share/zoneinfo/Pacific/Fiji"; node -e 'console.log(new Date().toString())'
-        time.JS[:toString] = -> { 'Wed Jun 21 2017 08:42:01 GMT+1200 (+12)' }
-        time.zone.should == '+12'
+    it 'returns 0 when self is equal to other' do
+      (Time.new(2015, 1, 1) <=> Time.new(2015, 1, 1)).should == 0
+    end
 
-        # export TZ="/usr/share/zoneinfo/Europe/Rome"; node -e 'console.log(new Date().toString())'
-        time.JS[:toString] = -> { 'Tue Jun 20 2017 22:52:57 GMT+0200 (CEST)' }
-        time.zone.should == 'CEST'
+    it 'returns 1 when self is greater than other' do
+      (Time.new(2015, 1, 2) <=> Time.new(2015, 1, 1)).should == 1
+    end
 
-        # export TZ="/usr/share/zoneinfo/Europe/Rome"; node -e 'console.log(new Date().toString())'
-        time.JS[:toString] = -> { 'Tue Jun 20 2017 23:56:54 GMT+0300 (MSK)' }
-        time.zone.should == 'MSK'
+    it 'returns nil when compared to non-Time objects' do
+      (Time.new <=> nil).should == nil
+    end
+  end
+
+  describe "#==" do
+    it "returns true if self is equal to other date" do
+      (Time.new(2013, 9, 13) == Time.new(2013, 9, 13)).should == true
+    end
+
+    it "returns false if self is not equal to other date" do
+      (Time.new(2013, 10, 2) == Time.new(2013, 10, 11)).should == false
+    end
 
-        # https://github.com/opal/opal/issues/403
-        time.JS[:toString] = -> { 'Wed May 07 2014 11:59:05 GMT+0300 (Финляндия (лето))' }
-        time.zone.should == 'Финляндия (лето)'
-      end
+    it 'returns false when compared to non-Time objects' do
+      (Time.new == nil).should == false
+      (Time.new == Object.new).should == false
     end
   end
 end