opal-webpack-loader 0.7.3 → 0.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9389946c873c4ef255f3381e4f11602470ee782d2976c7875abb3b995ed5ef93
-  data.tar.gz: a2b84759d7a7622afd10d24c104229f8313e5d44212f4bef22d01a85c5a61ca9
+  metadata.gz: 6db01d779ed0f9e15291c68cf42b154f104467af55d65441fd1ff36423c28e2d
+  data.tar.gz: b6acd6bff5f734bb69992e6d63d8fc702d8bce65cf67032eb3678ee92a00cfc5
 SHA512:
-  metadata.gz: 2f447ff0b696fd4fb2e497492f0ffcce69ac8b7d9531bf887505bd66294f5b9cc344658fe78c71cc55f9e1101eb7bf6dd2a9d97e88a6f377517562f39470a539
-  data.tar.gz: d8f2e96492d4410b7f27d271c5e70dabcfef47ce927894d003fde47ab04953ec9164ef285482b0c48a484d897bb0fde9fb1d4aa7e993a1d7eef950cfdf90d2ae
+  metadata.gz: 62c15a3c9d2f6b829b6337e3291c854ddd659fb54ae1f90fa4300be3ef16fccb477fcb3c3e02431f16d2288d006b323717a340e7627f5e5e3fe728bb66627c6c
+  data.tar.gz: 0fdd85e7a30c38b28b192d748861271b2989ec98279165018ed7b7b85f12531caa00b9a7ba80d877704e503b384b8a9c7b6d407c80465709d0939d101fba7919

data/lib/opal-webpack-loader/compile_server.rb

@@ -1,11 +1,12 @@
 require 'socket'
+require 'tempfile'
 
 module OpalWebpackLoader
   class CompileServer
     OWL_CACHE_DIR = File.join('.','.owl_cache/')
     OWL_LP_CACHE = File.join(OWL_CACHE_DIR, 'load_paths.json')
     OWCS_SOCKET_PATH = File.join(OWL_CACHE_DIR, 'owcs_socket')
-    SIGNALS = %w[QUIT INT TERM TTIN TTOU]
+    SIGNALS = %w[QUIT INT TERM]
     TIMEOUT = 15
 
     def self.unlink_socket?
@@ -53,7 +54,8 @@ module OpalWebpackLoader
 
       loop do
         reap_workers
-        case (mode = @signal_queue.shift)
+        mode = @signal_queue.shift
+        case mode
         when nil
           kill_runaway_workers
           spawn_workers
@@ -62,13 +64,6 @@ module OpalWebpackLoader
             Process.kill('TERM', pid)
           end
           break
-        when 'TTIN'
-          @number_of_workers += 1
-        when 'TTOU'
-          unless @number_of_workers <= 0
-            Config.workers -= 1
-            kill_worker('QUIT', @workers.keys.max)
-          end
         end
         reap_workers
         ready = IO.select([@read_pipe], nil, nil, 1) || next

data/lib/opal-webpack-loader/compile_worker.rb

@@ -2,7 +2,7 @@ require 'socket'
 
 module OpalWebpackLoader
   class CompileWorker
-    SIGNALS = %w[QUIT TTIN TTOU]
+    SIGNALS = %w[QUIT]
 
     attr_reader :number, :tempfile
 

data/lib/opal-webpack-loader/installer_cli.rb

@@ -41,13 +41,11 @@ module OpalWebpackLoader
         @opal_directory = 'isomorfeus'
         @styles_directory = File.join(@opal_directory, 'styles')
         @webpack_config_directory = 'webpack'
-        create_common_directories
-        create_isomorfeus_directories
+        create_directory(@webpack_config_directory)
+        create_directory(@asset_output_directory)
         install_webpack_config
-        create_file_from_template('application.css.erb', File.join('isomorfeus', 'styles', 'application.css'), {})
-        create_file_from_template('initializer.rb.erb', File.join('config', 'owl_init.rb'), {})
+        create_file_from_template('initializer.rb.erb', File.join('owl_init.rb'), { opal_directory: @opal_directory })
         add_gem
-        print_message
       end
 
       desc "flat", "Install owl configuration into a existing project with a flat structure, execute from the projects root directory."
@@ -80,7 +78,6 @@ module OpalWebpackLoader
         @opal_directory = options[:opal_name]
         @styles_directory = 'styles'
         @webpack_config_directory = 'webpack'
-        create_directory(@styles_directory)
         create_common_directories
         install_common_things
         create_file_from_template('application.css.erb', File.join('styles', 'application.css'), {})
@@ -125,7 +122,6 @@ module OpalWebpackLoader
         @styles_directory = File.join('app', 'assets', 'stylesheets')
         @webpack_config_directory = File.join('config', 'webpack')
         create_directory('app')
-        create_directory(@styles_directory)
         create_common_directories
         install_common_things
         create_file_from_template('initializer.rb.erb', File.join('config', 'initializers', 'opal_webpack_loader.rb'),
@@ -148,14 +144,7 @@ module OpalWebpackLoader
         create_directory(@js_entrypoints_directory)
         create_directory(@opal_directory)
         create_directory(@asset_output_directory)
-      end
-
-      def create_isomorfeus_directories
-        create_directory(File.join('isomorfeus', 'components'))
-        create_directory(File.join('isomorfeus', 'models'))
-        create_directory(File.join('isomorfeus', 'operations'))
-        create_directory(File.join('isomorfeus', 'policies'))
-        create_directory(File.join('isomorfeus', 'styles'))
+        create_directory(@styles_directory)
       end
 
       def install_common_things
@@ -296,11 +285,8 @@ module OpalWebpackLoader
       end
 
       def add_gem
-        # TODO
-        # STDERR.puts File.read('Gemfile')
-        # STDERR.puts OpalWebpackLoader::VERSION
-        # `bundle add opal-webpack-loader -v "#{OpalWebpackLoader::VERSION}" --skip-install`
-        # specifying a version results in a bundler printing a error and not adding the gem
+        # TODO specifying a version results in bundler printing a error and not adding the gem
+        # `bundle add opal-webpack-loader -v "#{OpalWebpackLoader::VERSION}" --skip-install`ß´
       end
 
       def print_message
@@ -308,7 +294,7 @@ module OpalWebpackLoader
         
           Add the following lines to your Gemfile:
 
-            gem 'opal', github: 'janbiedermann/opal', branch: 'es6_import_export'
+            gem 'opal', github: 'janbiedermann/opal', branch: 'es6_modules'
             gem 'opal-webpack-loader', '~> #{OpalWebpackLoader::VERSION}'
 
           owl currently works only with above opal branch. If you have a existing "gem 'opal'", please replace it with above line.

data/lib/opal-webpack-loader/templates/initializer.rb.erb

@@ -1,7 +1,7 @@
 Opal.append_path(File.realdirpath('<%= opal_directory %>'))
 
-env = defined?(Rails) ? Rails.env : 'development'
-
+env = defined?(Rails) ? Rails.env : ENV['OWL_ENV']
+env = 'development' unless env
 if env != 'development'
   OpalWebpackLoader.client_asset_path = '' # the full path is in the manifest already, like: /assets/application-97fd9c2b7e7bdb112fc1.js
   OpalWebpackLoader.manifest_path = 'public/assets/manifest.json'

data/lib/opal-webpack-loader/version.rb

@@ -1,3 +1,3 @@
 module OpalWebpackLoader
-  VERSION="0.7.3"
+  VERSION="0.7.4"
 end

data/readme.md

@@ -23,10 +23,25 @@ Intel® Core™ i7-7700HQ CPU @ 2.80GHz × 8, with 8 workers in around 1850ms
   - everything else webpack can do, like loading stylesheets, etc.
 
 ### Requirements
+- opal-webpack-loader consists of 2 parts, the npm package and the gem, both are required
 - webpack 4.30
 - webpack-dev-server 3.3.0
-- es6_import_export branch of opal, [PR#1832](https://github.com/opal/opal/pull/1832)
-- if you have webpacker gem installed somewhere, it should be a version supporting webpack 4
+- one of the ES6 modules branches of opal
+  - [PR#1832](https://github.com/opal/opal/pull/1832), implementing ES6 modules, based on Opal 0.11.1.dev
+    
+    `gem 'opal', github: 'janbiedermann/opal', branch: 'es6_import_export', ref: 'e3fdf16e8a657f7d9f9507207848a34953dced8d'`
+      
+  - [PR#1970](https://github.com/opal/opal/pull/1969), implementing ES6 modules and changes for 'strict' mode,
+    based on Opal master 1.0.beta using javascript string primitives
+    
+    `gem 'opal', github: 'janbiedermann/opal', branch: 'es6_modules'`
+    
+  - [PR#1973](https://github.com/opal/opal/pull/1973), implementing ES6 modules and changes for 'strict' mode,
+    based on Opal master 1.0.beta using javascript string objects by default for all strings
+    
+    `gem 'opal', github: 'janbiedermann/opal', branch: 'es6_modules_string'`
+    
+- if you have the webpacker gem installed somewhere, it should be a version supporting webpack 4
 - ruby, version 2.5 or higher recommended
 - bundler, latest version recommended
 
@@ -37,112 +52,14 @@ First install the gem:
 ```
 gem install 'opal-webpack-loader'
 ```
-##### Install for Rails like projects
-If you start a new rails project, the following options are recommended for `rails new`: `--skip-sprockets --skip-javascript`
 
-Then within the projects root directory execute:
-```bash
-owl-install rails
-```
-If you have the webpacker gem installed, you need to merge the configuration in the config/webpacker directory.
-A example for config/webpack/development.js is in the
-[templates](https://github.com/isomorfeus/opal-webpack-loader/blob/master/lib/opal-webpack-loader/templates/webpacker_development.js_example).
-
-Please see the messages of owl-install. You may need to manually add the following gems to the projects Gemfile:
-```ruby
-gem 'opal', github: 'janbiedermann/opal', branch: 'es6_import_export'
-gem 'opal-webpack-loader', '~> 0.6.2' # use the most recent released version here
-```
-
-Then:
-```bash
-yarn install
-bundle install
-```
-Opal ruby files should then go in the newly created `app/opal` directory. With the option -o the directory can be named differently, for example:
-```bash
-owl-install rails -o hyperhyper
-```
-A directory `app/hyperhyper` will be created, opal files should then go there and will be properly resolved by webpack.
-
-Complete set of directories and files created by the installer for projects with a rails like structure:
-```
-project_root
-    +- app
-        +- assets
-            +- javascripts  # javascript entries directory
-            +- styles       # directory for stylesheets
-        +- opal             # directory for opal application files, can be changed with -o
-    +- config
-        +- webpack          # directory for webpack configuration files
-        +- initializers
-            +- opal_webpack_loader.rb  # initializer for owl
-    +- package.json         # package config for npm/yarn and their scripts
-    +- public
-        +- assets           # directory for compiled output files
-    +- Procfile             # config file for foreman
-```
-              
-##### Install for Cuba, Roda, Sinatra and others with a flat structure
-```bash
-owl-install flat
-```
+Continue here:
+- [Install for Rails like projects](https://github.com/isomorfeus/opal-webpack-loader/blob/master/docs/installation_rails.md)
+- [Install for Cuba, Roda, Sinatra and others with a flat structure](https://github.com/isomorfeus/opal-webpack-loader/blob/master/docs/installation_flat.md)           
+- [Manual Installation](https://github.com/isomorfeus/opal-webpack-loader/blob/master/docs/installation_manual.md)
 
-Please see the message of owl-install. You may need to manually add the following gems to the projects Gemfile:
-```ruby
-gem 'opal', github: 'janbiedermann/opal', branch: 'es6_import_export'
-gem 'opal-webpack-loader', '~> 0.5.1'
-```
-
-Then:
-```bash
-yarn install
-bundle install
-```
-The installer produces a `app_loader.rb` which `require './owl_init'`. `app_loader.rb` is used by the compile server to correctly determine opal load
-paths. It should be required by `config.ru`.
-Opal ruby files should then go in the newly created `opal` directory. With the option -o the directory can be named differently, for example:
-```bash
-owl-install rails -o supersuper
-```
-A directory `supersuper` will be created, opal files should then go there and will be properly resolved by webpack.
-
-Complete set of directories and files created by the installer for projects with a flat structure:
-```
-project_root
-    +- owl_init.rb      # initializer for owl
-    +- javascripts      # javascript entries directory
-    +- opal             # directory for opal application files, can be changed with -o
-    +- package.json     # package config for npm/yarn and their scripts
-    +- public
-        +- assets       # directory for compiled output files
-    +- styles           # directory for stylesheets
-    +- webpack          # directory for webpack configuration files
-    +- Procfile         # config file for foreman
-```
-
-#### Manual Installation
-##### Install the accompanying NPM package:
-one of:
-```bash
-npm i opal-webpack-loader
-yarn add opal-webpack-loader
-```
-##### Install the gems
-```bash
-gem install opal-webpack-loader
-```
-or add it to the Gemfile as below and `bundle install`
-```ruby
-source 'https://rubygems.org'
-
-gem 'opal', github: 'janbiedermann/opal', branch: 'es6_import_export' # requires this branch
-gem 'opal-autoloader' # recommended
-gem 'opal-webpack-loader'
-```
-##### Install the configuration
-See the [configuration templates](https://github.com/isomorfeus/opal-webpack-loader/tree/master/lib/opal-webpack-loader/templates)
-and adjust to your preference.
+### Example applications
+[are here](https://github.com/isomorfeus/opal-webpack-loader/tree/master/example_apps/)
 
 ### General Usage
 
@@ -205,64 +122,13 @@ The compile server will start 4 workers for compiling opal files. The recommende
 or equal to the number of cores, for machines with up to 12 cores. More than 12 can't be kept busy by webpack it seems, ymmv.
 Example for 8 cores:
 `"production_build": "bundle exec opal-webpack-compile-server start 8 webpack --config=config/webpack/production.js"`
-### Source Maps
-
-#### Source Map Demo
-[![SourceMap Demo](https://img.youtube.com/vi/SCmDYu_MLQU/0.jpg)](https://www.youtube.com/watch?v=SCmDYu_MLQU)
-
-It shows a exception during a page load. In the console tab of the browsers developer tools, the error message is then expanded and just by clicking
-on the shown file:line_numer link, the browser shows the ruby source code, where the exception occured.
-
-#### Source Map Configuration
 
-The opal-webpack-loader for webpack supports the following options to enable HMR:
-(These are options for the webpack config, not to be confused with the owl ruby project options further down below)
-```javascript
-    loader: 'opal-webpack-loader',
-    options: {
-        sourceMap: true
-    }
-```
+### Source Maps
 
-- `sourceMap` : enable (`true`) or disable (`false`) source maps. Optional, default: `false`
+[Source Maps](https://github.com/isomorfeus/opal-webpack-loader/blob/master/docs/source_maps.md)
 
-Also source maps must be enabled in webpack. See [webpack devtool configuration](https://webpack.js.org/configuration/devtool).
 ### Hot Module Reloading
-
-#### HMR Demo
-
-[![HMR Demo](https://img.youtube.com/vi/igF3cUsZrAQ/0.jpg)](https://www.youtube.com/watch?v=igF3cUsZrAQ)
-
-(Recommended to watch in FullHD)
-
-#### HMR and Ruby
-
-When a module uses method aliasing and is reloaded, the aliases are applied again, which may lead to a endless recursion of method calls of
-the aliased method once called after hot reloading.
-To prevent that, the alias should be conditional, only be applied if the alias has not been applied before. Or alternatively the original
-method must be restored before aliasing it again.
-Because gems are not hot reloaded, this is not a issue for imported gems, but must be taken care of within the projects code.
-
-Also it must be considered, that other code, which without hot reloading would only execute once during the programs life cycle, possibly will
-execute many times when hot reloaded. "initialization code" should be guarded to prevent it from executing many times.
-
-#### HMR Configuration
-
-The opal-webpack-loader for webpack supports the following options to enable HMR:
-(These are options for the webpack config, not to be confused with the owl ruby project options further down below)
-```javascript
-    loader: 'opal-webpack-loader',
-    options: {
-        hmr: true,
-        hmrHook: 'global.Opal.ViewJS["$force_update!"]();'
-    }
-```
-
-- `hmr` : enable (`true`) or disable (`false`) hot module reloading. Optional, default: `false`
-- `hmrHook` : A javascript expression as string which will be executed after the new code has been loaded.
-Useful to trigger a render or update for React or ViewJS projects.
-
-Note: HMR works only for files within the project tree. Files outside the project tree are not hot reloaded.
+[Hot Module Reloading](https://github.com/isomorfeus/opal-webpack-loader/blob/master/docs/hot_module_reloading.md)
 
 ### Opal Load Path
 The projects directory for opal ruby files must be in the opal load path. This is done in the initializer for rails apps in
@@ -336,5 +202,8 @@ OpalWebpackLoader.use_manifest = false
 OpalWebpackLoader.manifest_path = File.join(Dir.getwd, 'public', 'assets', 'manifest.json') # doesn't matter, not used
 OpalWebpackLoader.client_asset_path = 'http://localhost:3035/assets/'
 ```
-### Example webpack configuration
-See the [configuration templates](https://github.com/isomorfeus/opal-webpack-loader/tree/master/lib/opal-webpack-loader/templates).
+
+### Tests
+- clone the repo
+- `bundle install`
+- `bundle exec rspec`

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: opal-webpack-loader
 version: !ruby/object:Gem::Version
-  version: 0.7.3
+  version: 0.7.4
 platform: ruby
 authors:
 - Jan Biedermann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-03 00:00:00.000000000 Z
+date: 2019-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opal
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.6.0
+        version: 3.7.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.6.0
+        version: 3.7.0
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.2.0
+        version: 5.2.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.2.0
+        version: 5.2.3
 - !ruby/object:Gem::Dependency
   name: roda
   requirement: !ruby/object:Gem::Requirement