opal-rspec 0.5.0 → 0.6.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1da9042a8eae6f23afb1f989cd88ac73bb16bf2b
-  data.tar.gz: 199ade21ce80c64e09f5123ecadd37d156c7cde9
+  metadata.gz: 882a14ef615ce8c04e42e0251c20689eab6d0cb9
+  data.tar.gz: 7ace5634304dc7cd953aa5de1af4ad1c31140586
 SHA512:
-  metadata.gz: 07fd2261509f2ac82c45866d6acbce58db865a75e08fb04ae48ab8047589781b70b940f1f00b419b07ae35118a692ddb0af27e3ea9a5089a01cb06dc514359a9
-  data.tar.gz: fa16038e70c8daa6cd27ac081a295fdba6c9bb3f96e353e72446173cce572eca39945d3a0782cd23c04f852807fd2b435f8f6d33b09fdf3ba9334308b03d0283
+  metadata.gz: c18a02f4f4fd2221c5a1baf9976a7ce0298c3511694cf41c622ba07d19ffb3f02c80f596ad1fef813588422454e0b3ae35623d3a3daf81d796c249e4b74cccd5
+  data.tar.gz: c49795363ee60fd59e6308767e5c97605a697e6ad9d1adcf0a82ae6492363db2e7f28ac4a795dc8674baeb9a70e63498be3713cf0d8773722922323a78a8d975

data/.codeclimate.yml

@@ -0,0 +1,6 @@
+exclude_paths:
+- rspec/**/*
+- rspec-core/**/*
+- rspec-expectations/**/*
+- rspec-mocks/**/*
+- rspec-support/**/*

data/.gitignore

@@ -3,3 +3,4 @@ Gemfile.lock
 *.gem
 Gemfile.lock
 gemfiles/*.lock
+/tmp

data/.rspec

@@ -0,0 +1,2 @@
+-c
+-f d

data/.travis.yml

@@ -3,42 +3,52 @@ sudo: false
 
 cache:
   bundler: true
+  directories:
+  - node_modules
+  - phantom20
 
 matrix:
   fast_finish: true
 
   include:
-    # - rvm: 1.9.3
-    #   env: RUN=default
-    - rvm: 2.0.0
-      env: RUN=default
-    - rvm: 2.1.0
-      env: RUN=default
-    - rvm: 2.2.3
-      env: RUN=default
-    - rvm: 2.2.3
+    - rvm: 2.2.4
+      env: RUN=mri_sanity_check
+    - rvm: 2.3.0
+      env: RUN=mri_sanity_check
+    - rvm: 2.3.0
+      env: RUN=rake_only
+    - rvm: 2.3.0
       # PHANTOMJS env variable is not used but it makes it easier to differentiate this build in Travis
-      # https://github.com/travis-ci/travis-ci/issues/3225 - Easiest way to use 2.0 on Travis
-      env: RUN=default PHANTOMJS=2.0
-      before_script:
-        - "mkdir phantom20"
-        - "export PATH=`pwd`/phantom20:$PATH"
+      env: PHANTOMJS=2.1 RUN=rake_only
+      before_install:
+        # Attempt to work around Travis issues and Ruby 2.3 - https://github.com/vcr/vcr/issues/582
+        - gem update --system
+        - "export PATH=`pwd`/node_modules/phantomjs-prebuilt/bin:$PATH"
         - "echo $PATH"
-        - "pushd ."
-        - "cd phantom20"
-        - "curl -L -O https://s3.amazonaws.com/travis-phantomjs/phantomjs-2.0.0-ubuntu-12.04.tar.bz2"
-        - "tar xjvf phantomjs-2.0.0-ubuntu-12.04.tar.bz2"
-        - "popd"
-        - "export DISPLAY=:99.0"
-        - "sh -e /etc/init.d/xvfb start"
-    - rvm: 2.2.3
-      env: RUN=default RUNNER=node
-    - rvm: 2.2.3
-      env: RUN=default
+        - phantomjs -v | grep 2.1 || npm install phantomjs-prebuilt # get rate limits from bitbucket download source, so get from NPM if we don't have it already
+    - rvm: 2.3.0
+      env: RUNNER=node RUN=rake_only
+    - rvm: 2.3.0
+      env: RUN=rake_only
       gemfile: gemfiles/opal_master.gemfile
+    - rvm: 2.3.0
+      env: RUN=rake_only
+      gemfile: gemfiles/opal_0.10_stable.gemfile
+
+  allow_failures:
+    - gemfile: gemfiles/opal_master.gemfile
 
 before_install:
-  - git submodule update --init
+  # Attempt to work around Travis issues and Ruby 2.3 - https://github.com/vcr/vcr/issues/582
+  - gem update --system
+  - "mkdir -p phantom20"
+  - "export PATH=`pwd`/phantom20:$PATH"
+  - "echo $PATH"
+  - "pushd phantom20"
+  - "ls phantomjs || curl -L -O https://s3.amazonaws.com/travis-phantomjs/phantomjs-2.0.0-ubuntu-12.04.tar.bz2"
+  - "ls phantomjs || tar xjvf phantomjs-2.0.0-ubuntu-12.04.tar.bz2"
+  - "rm -rf phantomjs-2.0.0-ubuntu-12.04.tar.bz2"
+  - "popd"
 
 before_script:
   - "export DISPLAY=:99.0"

data/Appraisals

@@ -0,0 +1,7 @@
+appraise 'opal-0.10-stable' do
+  gem 'opal', git: 'https://github.com/opal/opal.git', branch: '0-10-stable'
+end
+
+appraise 'opal-master' do
+  gem 'opal', git: 'https://github.com/opal/opal.git'
+end

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 0.6.0 - Under development
+
+*   Support for Opal 0.8/0.9 removed
+*   Opal 0.10 support
+*   Arity checking enabled by default
+*   Dropped support for PhantomJS < 2.0
+*   Removed `Kernel#caller` monkey patch so test file/line metadata is only available if supplied via test metadata or for failures. Should improve performance since an exception isn't thrown for every test to gather the data
+
 ## 0.5.0 (2015-12-08)
 
 *   By default, any subject, it example block, before(:each), after(:each), and around that returns a promise will be executed asynchronously. Async is NOT yet supported for context level hooks. Async approach from < 0.4.3 will still work.

data/Gemfile

@@ -5,9 +5,7 @@ unless Dir['rspec{,-{core,expectations,mocks,support}}'].any?
   warn 'Run: "git submodule update --init" to get RSpec sources'
 end
 
-# Opal 0.9 still in development
-# gem 'opal', git: 'https://github.com/opal/opal.git'
-gem 'capybara-webkit', require: false
+gem 'capybara'
 gem 'selenium-webdriver', require: false
 
 # These need to come from our local path in order for create_requires.rb to work properly
@@ -16,4 +14,4 @@ gem 'rspec-support',      path: 'rspec-support'
 gem 'rspec-core',         path: 'rspec-core'
 gem 'rspec-mocks',        path: 'rspec-mocks'
 gem 'rspec-expectations', path: 'rspec-expectations'
-
+gem 'appraisal'

data/README.md

@@ -1,10 +1,12 @@
 # opal-rspec
 
 [![Build Status](http://img.shields.io/travis/opal/opal-rspec/master.svg?style=flat)](http://travis-ci.org/opal/opal-rspec)
+[![Quality](http://img.shields.io/codeclimate/github/opal/opal-rspec.svg?style=flat-square)](https://codeclimate.com/github/opal/opal-rspec)
+[![Version](http://img.shields.io/gem/v/opal-rspec.svg?style=flat-square)](https://rubygems.org/gems/opal-rspec)
 
-An attempt at a compatibility layer of rspec for opal.
+An attempt at a compatibility layer of RSpec for Opal.
 
-[See the website for documentation](http://opalrb.org/docs/rspec/).
+#### For the README for the latest release, click [here](https://github.com/opal/opal-rspec/blob/releases/0-5-stable/README.md).
 
 ## Usage
 
@@ -17,7 +19,7 @@ gem 'opal-rspec'
 ## Requirements
 
 Besides what's already reflected in the GEM dependencies:
-* PhantomJS 1.9.8 or 2.0 for Rake task testing
+* PhantomJS 2.0 or 2.1 for Rake task testing
 * Browser if you want to run and debug tests that way
 
 ### Run specs in phantomjs
@@ -95,6 +97,14 @@ Opal::RSpec::RakeTask.new(:default) do |server, task|
 end
 ```
 
+Arity checking is enabled by default. Opal allows you to disable arity checking (faster in production this way) but for unit testing, you probably want information on arity mismatch. If you wish to disable it, configure your Rake task like this:
+
+```ruby
+Opal::RSpec::RakeTask.new(:default) do |server, task|
+  task.arity_checking = :disabled
+end
+```
+
 ### Run specs in nodejs
 
 Same options as above, you can use the `RUNNER=node` environment variable or use the Rake task like so:
@@ -126,7 +136,7 @@ run Opal::Server.new(sprockets: sprockets_env) { |s|
 Then run the rack server `bundle exec rackup` and visit `http://localhost:9292`
 in any web browser.
 
-A new feature of opal-rspec 0.5 allows you to click a 'Console' button in the browser's test results and get a 
+A new feature as of opal-rspec 0.5 allows you to click a 'Console' button in the browser's test results and get a 
 clickable stack trace in the browser console. This should ease debugging with long, concatenated script files and trying
 to navigate to where an exception occurred.
 
@@ -233,10 +243,26 @@ Disadvantages:
 
 ## Opal load path
 
-NOTE: Only the 'spec' directory will be added to the Opal load path by default. Use the Rake task's 'default_path' setting to change that
+NOTE: Only the 'spec' directory will be added to the Opal load path by default. Use the Rake task's `default_path` setting to change that. Here's an example of that.
+
+```ruby
+Opal::RSpec::RakeTask.new do |server, task|
+  task.default_path = 'spec/javascripts'
+end
+```
+
+If you need to add additional load paths to run your specs, then use the `append_path` method like this:
+
+```ruby
+Opal::RSpec::RakeTask.new do |server, task|
+  server.append_path 'some_path'
+end
+```
 
 ## Other Limitations/Known Issues
 
+80%+ of the RSpec test suites pass so most items work but there are a few things that do not yet work.
+
 * Core Examples
   * Example groups included like this are currently not working:
 ```ruby
@@ -254,37 +280,33 @@ RSpec.configure do |c|
   c.include TestMod
 end
 ```
-* Formatting
-  * Backtrace info on specs is buggy ([no Kernel::caller method in Opal](https://github.com/opal/opal/issues/894)), in Firefox w/ the browser runner, no backtraces show up with failed specs
+* Formatting/Reporting
+  * Specs will not have file path/line number information on them unless they are supplied from user metadata or they fail, see [this issue](https://github.com/opal/opal-rspec/issues/36)
+  * In Firefox w/ the browser runner, no backtraces show up with failed specs
   * Diffs are not yet available when objects do not meet expectations (diff-lcs gem dependency has not been dealt with yet in Opal)
 * Configuration
   * Not all RSpec runner options are supported yet
   * At some point, using node + Phantom's ability to read environment variables could be combined with a opal friendly optparse implementation to allow full options to be supplied/parsed
-  * Expect and should syntax are both enabled. They cannot be disabled due to bugs with the `undef` keyword in Opal 0.8. Status of changing this via config has not been tested in Opal 0.9.
+  * Expect and should syntax are both enabled. They cannot be disabled due to past bugs with the `undef` keyword in Opal. Status of changing this via config has not been retested.
   * Random order does not work yet due to lack of [srand/Random support](https://github.com/opal/opal/issues/639) and RSpec's bundled Random implementation, `RSpec::Core::Backports::Random`, locks the browser/Phantom. If you specify random order, it will be ignored.
-* With Opal < 0.9, you can't access the example from named subject blocks (e.g. ```subject {|e| puts "example is #{e}" }```)
 * Nodejs runner
   * debug mode + source map support not there yet (see source map support - https://github.com/evanw/node-source-map-support)
   * currently running a lot slower than phantomjs, might need optimization
 * Matchers
   * predicate matchers (be_some_method_on_your_subject) do not currently work with delegate objects (Opal `DelegateClass` is incomplete)
-  * operator based comparison, except for `==`, won't work on Opal 0.8 due to lack of method_missing support for operators. This works correctly in Opal 0.9.
-  * descriptions on aliased/negated matchers won't be like normal RSpec due to several bugs: method owner not being correct (not fixed yet), blocks passed after arguments and hash (fixed in Opal 0.9)
   * equal and eq matchers function largely the same right now since `==` and `equal?` in Opal are largely the same
   * time based matching is not yet tested
-  * arity checking is not enabled by default in Opal but it can be. It's not currently enabled because it broke a lot of Opal specs. As a result, any matcher use (particularly respond_to) that depends on arity checking will not work
-  * splat methods and expect(...).to respond_to will be inconsistent in Opal 0.8 since several splat bugs were fixed with Opal 0.9
+  * Due to some issues with splats and arity in Opal, respond_to matchers may not work properly on methods with splats
 * Mocks
   * `allow_any_instance/any_instance_of/any_instance` are unstable and may cause runner to crash due to issues with redefining the `===` operator, which breaks a case statement inside `Hooks#find_hook`
   * using expect/allow on `String`, `Number`, or any immutable bridged/native class, does not work since rspec-mocks uses singleton classes and those cannot be defined on immutable objects
   * mocking class methods (including `::new`) is currently broken
   * `class_double/class_spy` are not supported (it depends on `ClassVerifyingDouble` inheriting from `Module` to support transferring nested constants, but that doesn't work on Opal)
   * `object_spy` is not supported (depends on proper initializer behavior in `ObjectVerifyingDoubleMethods`)
-  * verifying partial doubles do not fully work yet
+  * verifying partial doubles do not fully work yet (arity issues with Opal)
   * chaining and_return after do...end does not work
   * duck_type argument matching is still buggy
-  * `and_throw` does not work on Opal 0.8 since throw/catch was not implemented until Opal 0.9
-* A lot of backports/monkey patches to Opal classes/methods are done to make this work on Opal 0.8. That means some things might work in your tests that do not work without opal-rspec. You can explore the opal/opal/rspec/fixes/opal directory to see what is being changed. All of the monkey patches check to see if the feature is "broken" before they apply themselves.
+  * RSpec's marshal support does not yet work with Opal's marshaller (so patch_marshal_to_support_partial_doubles config setting is not supported)
 
 ## Contributing
 

data/Rakefile

@@ -9,12 +9,23 @@ require_relative 'spec/rspec/expectations/expectation_spec_loader'
 require_relative 'spec/rspec/support/support_spec_loader'
 require_relative 'spec/rspec/mocks/mocks_spec_loader'
 
+desc 'Run the full suite, this can time out on Travis'
 task :default => [:phantom_node_ver,
                   :unit_specs,
                   :verify_opal_specs,
                   :integration_specs,
                   :verify_rspec_specs]
 
+desc 'Run only tests that use the opal-rspec Rake task'
+task :rake_only => [:phantom_node_ver,
+                    :verify_opal_specs,
+                    :verify_rspec_specs]
+
+desc 'Sanity checks a given version of MRI and run a basic check'
+task :mri_sanity_check => [:phantom_node_ver,
+                           :unit_specs,
+                           :integration_specs]
+
 task :phantom_node_ver do
   sh 'phantomjs -v'
   sh 'node -v'
@@ -63,11 +74,11 @@ Opal::RSpec::MocksSpecLoader.rake_tasks_for(:rspec_mocks_specs)
 # These are done
 desc 'Verifies all RSpec specs'
 task :verify_rspec_specs => [
-         :verify_rspec_support_specs,
-         :verify_rspec_core_specs,
-         :verify_rspec_expectation_specs,
-         :verify_rspec_mocks_specs
-     ]
+  :verify_rspec_support_specs,
+  :verify_rspec_core_specs,
+  :verify_rspec_expectation_specs,
+  :verify_rspec_mocks_specs
+]
 
 desc 'Verifies other_spec_dir task ran correctly'
 task :verify_other_specs do
@@ -81,6 +92,7 @@ end
 desc 'Will run a spec suite (rake opal_specs) and check for expected combination of failures and successes'
 task :verify_opal_specs do
   test_output = `rake opal_specs`
+  test_output.force_encoding 'UTF-8'
   raise "Expected test runner to fail due to failed tests, but got return code of #{$?.exitstatus}" if $?.success?
   count_match = /(\d+) examples, (\d+) failures, (\d+) pending/.match(test_output)
   raise 'Expected a finished count of test failures/success/etc. but did not see it' unless count_match
@@ -130,8 +142,8 @@ task :dist do
   require 'fileutils'
   FileUtils.mkdir_p 'build'
 
-  builder = Opal::Builder.new(stubs: Opal::Processor.stubbed_files, # stubs already specified in lib/opal/rspec.rb
-                              compiler_options: {dynamic_require_severity: :ignore}) # RSpec is full of dynamic requires
+  builder = Opal::Builder.new(stubs: Opal::Config.stubbed_files, # stubs already specified in lib/opal/rspec.rb
+                              compiler_options: { dynamic_require_severity: :ignore }) # RSpec is full of dynamic requires
   src = builder.build('opal-rspec')
 
   min = uglify src

data/config.ru

@@ -1,11 +1,13 @@
 require 'opal/rspec'
 
-Opal::Processor.source_map_enabled = false
+Opal::Config.source_map_enabled = false
+Opal::Config.arity_check_enabled = true
 
 sprockets_env = Opal::RSpec::SprocketsEnvironment.new(spec_pattern='spec/opal/**/*_spec.{rb,opal}',
                                                       spec_exclude_pattern=nil,
                                                       spec_files=nil,
                                                       default_path='spec/opal')
+sprockets_env.cache = ::Sprockets::Cache::FileStore.new(File.join('tmp', 'cache', 'opal_specs'))
 run Opal::Server.new(sprockets: sprockets_env) { |s|
       s.main = 'sprockets_runner_js_errors'
       # sprockets_runner_js_errors will not be in the opal load path by default

data/gemfiles/opal_0.10_stable.gemfile

@@ -0,0 +1,15 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "capybara"
+gem "selenium-webdriver", :require => false
+gem "rspec", :path => "../rspec"
+gem "rspec-support", :path => "../rspec-support"
+gem "rspec-core", :path => "../rspec-core"
+gem "rspec-mocks", :path => "../rspec-mocks"
+gem "rspec-expectations", :path => "../rspec-expectations"
+gem "appraisal"
+gem "opal", :git => "https://github.com/opal/opal.git", :branch => "0-10-stable"
+
+gemspec :path => "../"

data/gemfiles/opal_master.gemfile

@@ -1,18 +1,15 @@
-source 'https://rubygems.org'
-gemspec path: '../'
+# This file was generated by Appraisal
 
-unless Dir['rspec{,-{core,expectations,mocks,support}}'].any?
-  warn 'Run: "git submodule update --init" to get RSpec sources'
-end
+source "https://rubygems.org"
 
-gem 'opal', git: 'https://github.com/opal/opal.git'
-gem 'capybara-webkit', require: false
-gem 'selenium-webdriver', require: false
-
-# These need to come from our local path in order for create_requires.rb to work properly
-gem 'rspec',              path: '../rspec'
-gem 'rspec-support',      path: '../rspec-support'
-gem 'rspec-core',         path: '../rspec-core'
-gem 'rspec-mocks',        path: '../rspec-mocks'
-gem 'rspec-expectations', path: '../rspec-expectations'
+gem "capybara"
+gem "selenium-webdriver", :require => false
+gem "rspec", :path => "../rspec"
+gem "rspec-support", :path => "../rspec-support"
+gem "rspec-core", :path => "../rspec-core"
+gem "rspec-mocks", :path => "../rspec-mocks"
+gem "rspec-expectations", :path => "../rspec-expectations"
+gem "appraisal"
+gem "opal", :git => "https://github.com/opal/opal.git"
 
+gemspec :path => "../"

data/lib/opal/rspec/rake_task.rb

@@ -11,7 +11,12 @@ module Opal
       PORT = 9999
       URL = "http://localhost:#{PORT}/"
 
-      attr_accessor :pattern, :exclude_pattern, :files, :default_path, :runner, :timeout
+      attr_accessor :pattern, :exclude_pattern, :files, :default_path, :runner, :timeout, :arity_checking
+
+      def arity_checking?
+        setting = @arity_checking || :enabled
+        setting == :enabled
+      end
 
       def launch_phantom(timeout_value)
         command_line = %Q{phantomjs #{RUNNER} "#{URL}"#{timeout_value ? " #{timeout_value}" : ''}}
@@ -31,7 +36,7 @@ module Opal
         name = server.main
         asset = sprockets[name]
         raise "Cannot find asset: #{name}" if asset.nil?
-        Opal::Processor.load_asset_code(sprockets, name)
+        Opal::Sprockets.load_asset name, sprockets
       end
 
       # TODO: Avoid the Rack server and compile directly
@@ -98,23 +103,31 @@ module Opal
             sprockets_env.add_spec_paths_to_sprockets
           }
 
+          Opal::Config.arity_check_enabled = arity_checking?
+
           # TODO: Once Opal 0.9 compatibility is established, if we're running node, add in the node stdlib requires in so RSpec can use them, also add NODE_PATH to the runner command above
 
           server = Thread.new do
             Thread.current.abort_on_exception = true
             Rack::Server.start(
-                :app => app,
-                :Port => PORT,
-                :AccessLog => [],
-                :Logger => WEBrick::Log.new("/dev/null"),
+              :app => app,
+              :Port => PORT,
+              :AccessLog => [],
+              :Logger => WEBrick::Log.new("/dev/null"),
             )
           end
 
           wait_for_server
           is_phantom = runner == :phantom
           if is_phantom
-            if `phantomjs -v`.nil?
-              warn "Could not find phantomjs command"
+            version_output = begin
+              `phantomjs -v`.strip
+            rescue
+              warn 'Could not find phantomjs command on path!'
+              exit 1
+            end
+            if version_output.to_f < 2
+              warn "PhantomJS >= 2.0 is required but version #{version_output} is installed!"
               exit 1
             end
           end

data/lib/opal/rspec/version.rb

@@ -1,5 +1,5 @@
 module Opal
   module RSpec
-    VERSION = '0.5.0'
+    VERSION = '0.6.0.beta1'
   end
 end

data/lib/opal/rspec.rb

@@ -11,7 +11,7 @@ Opal.append_path File.expand_path('../../../opal', __FILE__)
 end
 
 # Since we have better specs than before (and a script to deal with this), ignoring
-Opal::Processor.dynamic_require_severity = :ignore
+Opal::Config.dynamic_require_severity = :ignore
 
 stubs = [
   'mutex_m', # Used with some threading operations but seems to run OK without this
@@ -36,4 +36,4 @@ stubs = [
   'minitest/assertions'
 ]
 
-stubs.each {|mod| Opal::Processor.stub_file mod }
+::Opal::Config.stubbed_files.merge(stubs)

data/opal/opal/rspec/async/async_example.rb

@@ -21,11 +21,11 @@ class ::RSpec::Core::Example
           example_group_instance.__memoized[:subject] = resolved_subject
         end
       end
-    rescue
+    rescue Exception => _ # Can't use empty rescue in Opal 0.10 because it won't catch native JS exceptions (which aren't StandardError instances)
       # Exception occurred while checking the subject, might be that the example group had a described class, was not intending on using it as the subject,
       # and the initializer for that described class failed
     end
-    Promise.value
+    Promise.value(true)
   end
 
   def run_after_example
@@ -46,13 +46,13 @@ class ::RSpec::Core::Example
     start(reporter)
     Pending.mark_pending!(self, pending) if pending?
 
-    Promise.value.then do
-      Promise.value.then do
+    Promise.value(true).then do
+      Promise.value(true).then do
         if skipped?
           Pending.mark_pending! self, skip
         elsif !RSpec.configuration.dry_run?
           with_around_example_hooks do
-            Promise.value.then do
+            Promise.value(true).then do
               run_before_example.then do
                 resolve_subject
               end.then do

data/opal/opal/rspec/async/example_group.rb

@@ -15,7 +15,7 @@ class ::RSpec::Core::ExampleGroup
 
   def self.process_descendants(our_examples_result, reporter)
     descendants = ordering_strategy.order(children)
-    return Promise.value our_examples_result if descendants.empty?
+    return Promise.value(our_examples_result) if descendants.empty?
 
     results_for_descendants = []
     # Can use true for this because we're AND'ing everything anyways
@@ -40,7 +40,7 @@ class ::RSpec::Core::ExampleGroup
     end
 
     reporter.example_group_started(self)
-    Promise.value.then do
+    Promise.value(true).then do
       run_before_context_hooks(new)
     end.then do
       run_examples(reporter)
@@ -66,7 +66,7 @@ class ::RSpec::Core::ExampleGroup
   # Promise oriented version
   def self.run_examples(reporter)
     examples = ordering_strategy.order(filtered_examples)
-    return Promise.value true if examples.empty?
+    return Promise.value(true) if examples.empty?
 
     example_promise = lambda do |example|
       next Promise.value(nil) if RSpec.world.wants_to_quit
@@ -78,7 +78,7 @@ class ::RSpec::Core::ExampleGroup
 
     results = []
     # Can use true for this because we're AND'ing everything anyways
-    seed = Promise.value true
+    seed = Promise.value(true)
     latest_promise = examples.inject(seed) do |previous_promise, next_example|
       previous_promise.then do |succeeded|
         RSpec.world.wants_to_quit = true if fail_fast? && !succeeded

data/opal/opal/rspec/async/hooks.rb

@@ -1,9 +1,9 @@
 class RSpec::Core::Hooks::HookCollection
   def run
-    hooks.inject(Promise.value) do |previous_hook_promise, next_hook|
+    hooks.inject(Promise.value(true)) do |previous_hook_promise, next_hook|
       previous_hook_promise.then do
         result = next_hook.run @example
-        Promise.value result
+        Promise.value(result)
       end
     end
   end

data/opal/opal/rspec/async/legacy.rb

@@ -1,29 +1,29 @@
 module Opal
   module RSpec
     module AsyncHelpers
-      module ClassMethods        
+      module ClassMethods
         def async(desc, *args, &block)
           options = ::RSpec::Core::Metadata.build_hash_from(args)
           options.update(:skip => ::RSpec::Core::Pending::NOT_YET_IMPLEMENTED) unless block
 
           examples << Opal::RSpec::LegacyAsyncExample.new(self, desc, options, block)
-          examples.last          
+          examples.last
         end
       end
-      
+
       attr_accessor :legacy_promise
-      
+
       def self.included(base)
         base.extend ClassMethods
       end
-      
+
       # Use {#async} instead.
       #
       # @deprecated
       def run_async(&block)
         async(&block)
       end
-  
+
       def async(&block)
         begin
           instance_eval &block
@@ -38,13 +38,12 @@ end
 
 class Opal::RSpec::LegacyAsyncExample < ::RSpec::Core::Example
   def initialize(example_group_class, description, user_metadata, example_block=nil)
-    example = self
-    legacy_promise_ex_block = lambda do
+    legacy_promise_ex_block = lambda do |example|
       self.legacy_promise = Promise.new
       instance_exec(example, &example_block)
       self.legacy_promise
     end
-    
+
     super example_group_class, description, user_metadata, legacy_promise_ex_block
   end
 end