opal-rspec 0.5.0 → 0.6.0.beta1

data/spec/opal/after_hooks_spec.rb

@@ -1,20 +1,22 @@
+require 'spec_helper'
+
 describe 'hooks' do
   describe 'after' do
     before :all do
       @@total = 0
       @@example_still_in_progress = nil
     end
-    
+
     after :all do
       expected = 13
       unless @@total == expected
-        msg = "Expected #{expected} after hits but got #{@@total}"        
+        msg = "Expected #{expected} after hits but got #{@@total}"
         `console.error(#{msg})`
-      end       
+      end
     end
-    
+
     let(:raise_before_error) { false }
-    
+
     before do |example|
       if raise_before_error
         @@example_still_in_progress = nil
@@ -26,71 +28,71 @@ describe 'hooks' do
       end
       @@example_still_in_progress = example.description
     end
-    
-    let(:raise_after_error) { false }    
-    
+
+    let(:raise_after_error) { false }
+
     context 'sync' do
       after do
         @@total += 1
-        @@example_still_in_progress = nil        
+        @@example_still_in_progress = nil
         raise 'expected after problem' if raise_after_error
       end
-      
-      subject { 42 }            
-      
+
+      subject { 42 }
+
       context 'before fails' do
         let(:raise_before_error) { true }
-        
+
         it 'should not reach the example' do
           fail 'we reached the example and we should not have!'
         end
       end
-      
+
       context 'match succeeds' do
         context 'sync match' do
           it { is_expected.to eq 42 }
         end
-        
+
         it 'async match' do
           delay_with_promise 0 do
             expect(subject).to eq 42
           end
         end
       end
-      
+
       context 'match fails' do
         context 'sync match' do
           it { is_expected.to eq 43 }
         end
-        
+
         it 'async match' do
           delay_with_promise 0 do
             expect(subject).to eq 43
           end
         end
-      end     
-      
+      end
+
       context 'after fails' do
         let(:raise_after_error) { true }
-        
+
         it { is_expected.to eq 42 }
       end
-      
+
       context 'context' do
         after :context do
           raise 'it failed in the after context!'
         end
-            
+
         it { is_expected.to eq 42 }
       end
     end
-    
+
     context 'async' do
       after do
         delay_with_promise 0 do
           @@total += 1
           @@example_still_in_progress = nil
-          raise 'after problem' if raise_after_error          
+          raise 'after problem' if raise_after_error
         end
       end
 

data/spec/opal/around_hooks_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe 'hooks' do
   describe 'around' do
     RSpec.shared_context :around_count do

data/spec/opal/async_spec.rb

@@ -1,10 +1,12 @@
+require 'spec_helper'
+
 describe 'legacy async' do
   let(:foo) { 100 }
 
   before do
     @model = Object.new
   end
-  
+
   async "fails properly after a long delay" do
     obj = [2, 2, 3, 4]
 
@@ -12,7 +14,7 @@ describe 'legacy async' do
       async { obj.should == [1, 2, 3, 4] }
     end
   end
-  
+
   async 'allows overriding the timeout', timeout: 15 do
     delay(11) do
       async { expect(42).to eq(42) }
@@ -52,18 +54,18 @@ describe 'legacy async' do
 end
 
 describe 'promise' do
-  let(:foo) { 100 }    
-  
+  let(:foo) { 100 }
+
   it 'matcher fails properly' do
     delay_with_promise 0 do
       1.should == 2
-    end      
+    end
   end
 
   it 'matcher succeeds' do
     delay_with_promise 0 do
       1.should == 1
-    end      
+    end
   end
 
   context 'non-assertion failure in promise' do
@@ -89,7 +91,7 @@ describe 'promise' do
       end
     end
   end
-  
+
   context 'skipped' do
     it 'via variable', skip: true do
       obj = [1, 2, 3, 4]
@@ -105,30 +107,30 @@ describe 'promise' do
       delay_with_promise 0 do
         obj.should == [2, 2, 3, 4]
       end
-    end    
-  
+    end
+
     it 'in example, inside promise' do
       delay_with_promise 0 do
         skip 'want to skip within'
       end
     end
-  
+
     it 'in example, outside promise' do
       skip 'want to skip within'
       delay_with_promise 0 do
         1.should == 1
-      end      
-    end    
+      end
+    end
   end
-  
+
   context 'pending' do
     it 'in example' do
       obj = [1, 2, 3, 4]
 
       delay_with_promise 0 do
         pending 'want to pend within'
-        obj.should == [2, 2, 3, 4]        
-      end      
+        obj.should == [2, 2, 3, 4]
+      end
     end
 
     it 'via variable', pending: 'the reason' do
@@ -137,8 +139,8 @@ describe 'promise' do
       delay_with_promise 0 do
         obj.should == [2, 2, 3, 4]
       end
-    end    
-  end  
+    end
+  end
 
   it "should make example fail properly before async block reached" do
     expect(:foo).to eq(:baz)
@@ -146,18 +148,18 @@ describe 'promise' do
     delay_with_promise(0) do
       expect(nil).to eq 'we reached this assertion and we should not have'
     end
-  end  
+  end
 end
 
 describe 'async/sync mix' do
   it 'fails properly if a sync test is among async tests' do
     1.should == 2
   end
-  
+
   it 'is an async test between 2 sync tests' do
     delay_with_promise 0 do
       1.should == 1
-    end    
+    end
   end
 
   it 'passes correctly if a sync test is among async tests' do

data/spec/opal/before_hooks_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe 'hooks' do
   describe 'before' do
     context 'async' do
@@ -101,83 +103,83 @@ describe 'hooks' do
         end
       end
     end
-  
+
     context 'sync' do
       context 'with sync subject' do
         subject { 42 }
-      
+
         context 'context' do
           context 'success' do
             before :context do
               @@before_context_both_sync = 22
             end
-        
+
             before do
               raise "@@before_context_both_sync should already be 22!" unless @@before_context_both_sync == 22
               @test_value = 42
             end
-        
-            it { is_expected.to eq @test_value }          
+
+            it { is_expected.to eq @test_value }
           end
-        
+
           context 'fails properly' do
             before :context do
               raise 'it failed in the before context!'
               @@before_context_both_sync = 55
             end
-        
+
             before do
               raise "we reached before:each and we should not have!" if @@before_context_both_sync == 55
             end
-        
+
             it 'should not reach the example' do
               fail 'we reached the example and we should not have!'
             end
           end
         end
-  
+
         context 'succeeds' do
           before do
             @test_value = 42
           end
-    
+
           it { is_expected.to eq @test_value }
         end
-  
+
         context 'before :each fails properly' do
           before do
             raise 'before :each failed properly'
           end
-    
+
           it 'should not reach the example' do
             fail 'we reached the example and we should not have!'
           end
         end
-      
+
         context 'first before :each in chain triggers failure' do
           before do
             raise 'first before :each fails, this is correct'
           end
-        
+
           context 'inner context' do
             before do
               raise 'we reached the inner before :each and we should not have'
             end
-          
+
             it 'should not reach the example' do
               fail 'we reached the example and we should not have!'
             end
           end
         end
-  
+
         context 'match fails properly' do
           before do
             @test_value = 42
           end
-    
+
           it { is_expected.to_not eq @test_value }
         end
       end
-    end  
+    end
   end
 end

data/spec/opal/example_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 module SomeHelpers
   def opal_rspec_helper
     let(:defined_opal_helper) { :it_works }
@@ -166,9 +168,9 @@ describe 'exception handling' do
   it "should fail properly if an exception is raised" do
     raise 'problem'
   end
-  
+
   it "should ignore an exception after a failed assertion" do
     expect(42).to eq(43)
     raise 'problem'
-  end  
+  end
 end

data/spec/opal/matchers_spec.rb

@@ -1,10 +1,12 @@
+require 'spec_helper'
+
 describe "be_truthy" do
   it "passes with truthy values" do
     expect(true).to be_truthy
     expect(1.0).to be_truthy
     expect([]).to be_truthy
   end
-  
+
   it 'fails properly with truthy values' do
     expect(false).to be_truthy
   end

data/spec/opal/mock_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe "RSpec mocks" do
   describe "stubs" do
     it "can stub basic methods" do

data/spec/opal/should_syntax_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe "One-liner should syntax" do
   subject { 42 }
 

data/spec/opal/skip_pending_spec.rb

@@ -1,8 +1,10 @@
+require 'spec_helper'
+
 describe 'skip' do
   it 'in example, no promise' do
     skip 'want to skip within'
   end
-  
+
   it 'no implementation provided'
 
   skip 'entire group' do
@@ -30,14 +32,14 @@ describe 'pending' do
       it 'would fail otherwise' do
         pending 'want to pend within example'
         obj = [1, 2, 3, 4]
-        obj.should == [2, 2, 3, 4]    
+        obj.should == [2, 2, 3, 4]
       end
-  
+
       it 'would not fail otherwise, thus fails properly' do
         pending 'want to pend within example'
         obj = [1, 2, 3, 4]
-        obj.should == [1, 2, 3, 4]    
+        obj.should == [1, 2, 3, 4]
       end
     end
-  end  
+  end
 end

data/spec/opal/spec_helper.rb

@@ -0,0 +1,4 @@
+RSpec::configure do |config|
+  config.filter_run_including focus: true
+  config.run_all_when_everything_filtered = true
+end

data/spec/opal/subject_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe 'subject' do
   context 'sync' do
     context 'named' do

data/spec/rspec/core/filter/core/async/hooks.rb

@@ -1,7 +1,6 @@
 rspec_filter 'hooks' do
   # promise, see opal alternates
   filter /RSpec::Core::Hooks when an error happens in.* allows the error to propagate to the user/
-  filter('RSpec::Core::Hooks#around considers the hook to have run when passed as a block to a method that yields').unless { at_least_opal_0_9? }
 
   # promise, for some reason succeeds on Opal 0.8, see opal alternates
   filter('RSpec::Core::Hooks#around does not consider the hook to have run when passed as a block to a method that does not yield').if { at_least_opal_0_9? }

data/spec/rspec/core/filter/core/async/metadata.rb

@@ -0,0 +1,4 @@
+rspec_filter 'metadata' do
+  # Promise on the run, see opal alternates
+  filter('RSpec::Core::Metadata backwards compatibility :example_group allows integration libraries like VCR to infer a fixture name from the example description by walking up nesting structure').unless { at_least_opal_0_11? }
+end

data/spec/rspec/core/filter/core/bugs/memoized_helpers.rb

@@ -2,10 +2,4 @@ rspec_filter 'memoized_helpers' do
   # These depend on https://github.com/opal/opal/issues/1124, but you can only reproduce that with Opal 0.9
   filter 'RSpec::Core::MemoizedHelpers explicit subject with a name when `super` is used raises a "not supported" error'
   filter 'RSpec::Core::MemoizedHelpers explicit subject with a name when `super` is used with a `let` definition before the named subject raises a "not supported" error'
-
-  # This works right in Opal 0.9 (see sandbox/subject_issue_test), might be something with the class scoping PR (https://github.com/opal/opal/pull/1114) that requires compiler changes to fix
-  filter("RSpec::Core::MemoizedHelpers explicit subject with a name yields the example in which it is eval'd").unless { at_least_opal_0_9? }
-
-  # This works right in Opal 0.9 (Class === Enumerable), might be https://github.com/opal/opal/commit/304ab9c464754ca54ab03f1f31d5c137ae8e995d but not sure
-  filter('RSpec::Core::MemoizedHelpers implicit subject with a Module returns the Module').unless { at_least_opal_0_9? }
 end

data/spec/rspec/core/require_specs.rb

@@ -22,4 +22,3 @@ require 'rspec/support/spec'
 require_relative 'config'
 require 'opal/fixes/deprecation_helpers'
 require 'opal/fixes/rspec_helpers'
-require_relative 'fixes/opal_itself'

data/spec/rspec/expectations/config.rb

@@ -1,5 +1,10 @@
 require 'opal/progress_json_formatter' # verify case uses this
 
+# Only doing this because this spec causes the runner itself to break
+CAUSES_SPECS_TO_CRASH = [
+    'RSpec::Expectations::Configuration#backtrace_formatter defaults to a null formatter when rspec-core is not loaded'
+]
+
 RSpec::configure do |config|
   config.color = true
 
@@ -11,6 +16,6 @@ RSpec::configure do |config|
     expectations.syntax = :expect
     expectations.include_chain_clauses_in_custom_matcher_descriptions = true
   end
-
+  config.filter_run_excluding full_description: Regexp.union(CAUSES_SPECS_TO_CRASH)
   #config.full_description = 'RSpec::Matchers once required includes itself in Minitest::Test'
 end

data/spec/rspec/expectations/filter/bugs/configuration.txt

@@ -3,6 +3,3 @@ RSpec::Expectations::Configuration configuring rspec-expectations directly behav
 RSpec::Expectations::Configuration configuring rspec-expectations directly behaves like configuring the expectation syntax can limit the syntax to :expect
 RSpec::Expectations::Configuration configuring using the rspec-core config API behaves like configuring the expectation syntax can limit the syntax to :should
 RSpec::Expectations::Configuration configuring using the rspec-core config API behaves like configuring the expectation syntax can limit the syntax to :expect
-
-# global config problem
-RSpec::Expectations::Configuration#backtrace_formatter defaults to a null formatter when rspec-core is not loaded

data/spec/rspec/expectations/filter/bugs/contain_exactly.rb

@@ -1,11 +1,6 @@
 rspec_filter 'contain_exactly' do
   # https://github.com/opal/opal/pull/1136 - operators and method missing issues with a_value > < etc
   filter /should_not =~ \[:with, :multiple, :args\] fails when the arrays match.*/
-  unless at_least_opal_0_9?
-    filter('should =~ array when the array undefines `=~` still works')
-    filter('using contain_exactly with expect passes for an out of order valid positive expectation with hashes')
-    filter('using contain_exactly with expect passes for an in order valid positive expectation with hashes')
-  end
   filter('should =~ array when the array defines a `send` method still works')
   filter('should =~ array when the array defines a `=~` method delegates to that method rather than using the contain_exactly matcher')
   filter('should =~ array fails an invalid positive expectation')

data/spec/rspec/expectations/filter/bugs/define_negated_matcher.rb

@@ -1,7 +1,6 @@
 rspec_filter 'define_negated_matcher' do
   # method owner (no issue/PR) and block (https://github.com/opal/opal/pull/1132)
   filter('RSpec::Matchers.define_negated_matcher when the negated description is overriden overrides the failure message with the provided block')
-  filter('RSpec::Matchers.define_negated_matcher when the negated description is overriden overrides the description with the provided block').unless { at_least_opal_0_9? }
   filter('RSpec::Matchers.define_negated_matcher when no block is passed when matched negatively fails matches against values that pass the original matcher')
   filter('RSpec::Matchers.define_negated_matcher when no block is passed when matched positively fails matches against values that pass the original matcher')
   filter('RSpec::Matchers.define_negated_matcher the failure message for a matcher with default failure messages when failing negatively uses the phrasing from the provided defined matcher alias')

data/spec/rspec/expectations/filter/bugs/dsl.rb

@@ -0,0 +1,15 @@
+rspec_filter 'dsl' do
+  filter('RSpec::Matchers::DSL::Matcher allows chainable methods to accept blocks').unless { at_least_opal_0_10? }
+
+  # something w/ inheritance is wrong here
+  filter 'RSpec::Matchers::DSL::Matcher defined using the dsl can get a method object for methods in the running example'
+
+  # probably class scoping issue since new_matcher creates a new DSL matcher class, probably https://github.com/opal/opal/issues/1110 related
+  filter('RSpec::Matchers::DSL::Matcher#match_unless_raises without a specified error class passes if no error is raised').unless { at_least_opal_0_10? }
+
+  # not sure, class scoping issue? (see above)
+  filter('RSpec::Matchers::DSL::Matcher#match_unless_raises with an unexpected error raises the error').unless { at_least_opal_0_10? }
+  filter('RSpec::Matchers::DSL::Matcher#match_unless_raises with an assertion with passing assertion passes').unless { at_least_opal_0_10? }
+  filter('RSpec::Matchers::DSL::Matcher with an included module allows multiple modules to be included at once').unless { at_least_opal_0_10? }
+  filter('RSpec::Matchers::DSL::Matcher allows an early `return` to be used from a `match_unless_raises` block').unless { at_least_opal_0_10? }
+end

data/spec/rspec/expectations/filter/bugs/expectation_target.rb

@@ -0,0 +1,4 @@
+rspec_filter 'expectation_target' do
+  # Arity
+  filter('RSpec::Expectations::ExpectationTarget when constructed via #expect raises a wrong number of args ArgumentError when given two args').unless { at_least_opal_0_10? }
+end

data/spec/rspec/expectations/filter/bugs/expectations.rb

@@ -0,0 +1,4 @@
+rspec_filter 'expectations' do
+  # Probably more related to nesting lambdas in the test than with using raise_error - https://github.com/opal/opal/pull/1117
+  filter('RSpec::Expectations does not allow expectation failures to be caught by a bare rescue').unless { at_least_opal_0_10? }
+end

data/spec/rspec/expectations/filter/bugs/respond_to.rb

@@ -1,13 +1,7 @@
 rspec_filter 'respond_to' do
-  # Also arity related, but looks like opal is returning the optional arg splat as arity
-  filter('expect(...).not_to respond_to(:sym).with(1).argument fails if target responds to :sym with one or more args').unless { at_least_opal_0_9? }
-  filter('expect(...).to respond_to(:sym).with(2).arguments passes if target responds to two or more arguments').unless { at_least_opal_0_9? }
-  filter 'expect(...).to respond_to(:sym).with(2).arguments passes if target responds to any number of arguments'
-  filter('expect(...).to respond_to(:sym).with(1).argument passes if target responds to one or more arguments').unless { at_least_opal_0_9? }
-
-  # arity related
-  filter('expect(...).to respond_to(:sym).with(1).argument passes if target responds to any number of arguments').if { at_least_opal_0_9? }
-  filter('expect(...).to respond_to(:sym).with(2).arguments passes if target responds to one or more arguments').if { at_least_opal_0_9? }
-  filter('expect(...).not_to respond_to(:sym).with(1).argument fails if target responds to :sym with any number of args').if { at_least_opal_0_9? }
-  filter('expect(...).not_to respond_to(:sym).with(2).arguments fails if target responds to :sym with one or more args').if { at_least_opal_0_9? }
+  # arity + splat related in opal (more related to Method#arity than arity checking)
+  filter('expect(...).to respond_to(:sym).with(1).argument passes if target responds to any number of arguments').unless { at_least_opal_0_10? }
+  filter('expect(...).to respond_to(:sym).with(2).arguments passes if target responds to one or more arguments').unless { at_least_opal_0_10? }
+  filter('expect(...).not_to respond_to(:sym).with(1).argument fails if target responds to :sym with any number of args').unless { at_least_opal_0_10? }
+  filter('expect(...).not_to respond_to(:sym).with(2).arguments fails if target responds to :sym with one or more args').unless { at_least_opal_0_10? }
 end

data/spec/rspec/expectations/filter/unsupported/dsl.rb

@@ -0,0 +1,10 @@
+rspec_filter 'dsl' do
+  # mutable strings, see opal alternates
+  filter 'RSpec::Matchers::DSL::Matcher defined using the dsl raises NoMethodError for methods not in the running_example'
+
+  # Fixnum = Numeric on Opal, see opal alternates
+  filter 'RSpec::Matchers::DSL::Matcher wrapping another expectation (expect(...).to eq ...) can use the `include` matcher from a `match` block'
+
+  # regex compatibility, see opal alternates
+  filter('RSpec::Matchers::DSL::Matcher wrapping another expectation (expect(...).to eq ...) can use the `match` matcher from a `match` block').unless { at_least_opal_0_11? }
+end

data/spec/rspec/expectations/fixes/example_patches.rb

@@ -13,20 +13,3 @@ module Opal
     end
   end
 end
-
-unless Opal::RSpec::Compatibility.constant_resolution_works_right?
-  groups_are_in = RSpec::ExampleGroups
-  built_in_spec = :BuiltInMatchers
-  # in case we aren't running all of the examples
-  if groups_are_in.const_defined? built_in_spec
-    example_group = groups_are_in.const_get built_in_spec
-    example_group.let(:matchers) do
-      # .constants is broken in Opal, this is a hack
-      constants = Opal::RSpec.get_constants_for(RSpec::Matchers::BuiltIn) - [:NullCapture, :CaptureStdOut, :CaptureStdErr]
-      constants.map { |n| RSpec::Matchers::BuiltIn.const_get(n) }.select do |m|
-        #BuiltIn.constants.map { |n| BuiltIn.const_get(n) }.select do |m|
-        m.method_defined?(:matches?) && m.method_defined?(:failure_message)
-      end
-    end
-  end
-end

data/spec/rspec/expectations/opal_alternates/dsl_spec.rb

@@ -31,14 +31,14 @@ describe 'Opal RSpec::Matchers::DSL::Matcher' do
 
       expect {
         expect(Fixnum).to descend_from(Array)
-      }.to fail_with(/expected Numeric to descend from Array/)
+      }.to fail_with(/expected Number to descend from Array/)
       # Fixnum = Numeric on Opal
       #}.to fail_with(/expected Fixnum to descend from Array/)
 
       expect {
         expect(Fixnum).not_to descend_from(Object)
         # Fixnum = Numeric on Opal
-      }.to fail_with(/expected Numeric not to descend from Object/)
+      }.to fail_with(/expected Number not to descend from Object/)
       #}.to fail_with(/expected Fixnum not to descend from Object/)
     end
 

data/spec/rspec/expectations/require_specs.rb

@@ -5,7 +5,6 @@ end
 
 require_relative 'fixes/missing_constants'
 require_relative 'fixes/not_compatible'
-require_relative 'fixes/opal_itself'
 require_relative 'spec_helper_opal'
 require 'support/matchers'
 require 'rspec/support/spec/deprecation_helpers'