opal-rspec 0.8.0.alpha3 → 1.0.0.alpha1

data/rspec-core/upstream/benchmarks/singleton_example_groups/helper.rb

@@ -0,0 +1,122 @@
+require_relative "../../bundle/bundler/setup" # configures load paths
+require 'rspec/core'
+require 'stackprof'
+
+class << RSpec
+  attr_writer :world
+end
+
+RSpec::Core::Example.class_eval do
+  alias_method :new_with_around_and_singleton_context_hooks, :with_around_and_singleton_context_hooks
+  alias_method :old_with_around_and_singleton_context_hooks, :with_around_example_hooks
+end
+
+RSpec::Core::Hooks::HookCollections.class_eval do
+  def old_register_global_singleton_context_hooks(*)
+    # no-op: this method didn't exist before
+  end
+  alias_method :new_register_global_singleton_context_hooks, :register_global_singleton_context_hooks
+end
+
+RSpec::Core::Configuration.class_eval do
+  def old_configure_example(*)
+    # no-op: this method didn't exist before
+  end
+  alias_method :new_configure_example, :configure_example
+end
+
+RSpec.configure do |c|
+  c.output_stream = StringIO.new
+end
+
+require 'benchmark/ips'
+
+class BenchmarkHelpers
+  def self.prepare_implementation(prefix)
+    RSpec.world = RSpec::Core::World.new # clear our state
+    RSpec::Core::Example.__send__ :alias_method, :with_around_and_singleton_context_hooks,
+                                  :"#{prefix}_with_around_and_singleton_context_hooks"
+    RSpec::Core::Hooks::HookCollections.__send__ :alias_method, :register_global_singleton_context_hooks,
+                                                 :"#{prefix}_register_global_singleton_context_hooks"
+    RSpec::Core::Configuration.__send__ :alias_method, :configure_example, :"#{prefix}_configure_example"
+  end
+
+  @@runner = RSpec::Core::Runner.new(RSpec::Core::ConfigurationOptions.new([]))
+  def self.define_and_run_examples(desc, count, group_meta: {}, example_meta: {})
+    groups = count.times.map do |i|
+      RSpec.describe "Group #{desc} #{i}", group_meta do
+        10.times { |j| example("ex #{j}", example_meta) { } }
+      end
+    end
+
+    @@runner.run_specs(groups)
+  end
+
+  def self.profile(count, meta = { example_meta: { apply_it: true } })
+    [:new, :old].map do |prefix|
+      prepare_implementation(prefix)
+
+      results = StackProf.run(mode: :cpu) do
+        define_and_run_examples("No match/#{prefix}", count, meta)
+      end
+
+      format_profile_results(results, prefix)
+    end
+  end
+
+  def self.format_profile_results(results, prefix)
+    File.open("tmp/#{prefix}_stack_prof_results.txt", "w") do |f|
+      StackProf::Report.new(results).print_text(false, nil, f)
+    end
+    system "open tmp/#{prefix}_stack_prof_results.txt"
+
+    File.open("tmp/#{prefix}_stack_prof_results.graphviz", "w") do |f|
+      StackProf::Report.new(results).print_graphviz(nil, f)
+    end
+
+    system "dot tmp/#{prefix}_stack_prof_results.graphviz -Tpdf > tmp/#{prefix}_stack_prof_results.pdf"
+    system "open tmp/#{prefix}_stack_prof_results.pdf"
+  end
+
+  def self.run_benchmarks
+    Benchmark.ips do |x|
+      implementations = { :old => "without", :new => "with" }
+      # Historically, many of our benchmarks have initially been order-sensitive,
+      # where whichever implementation went first got favored because defining
+      # more groups (or whatever) would cause things to slow down. To easily
+      # check if we're having those problems, you can pass REVERSE=1 to try
+      # it out in the opposite order.
+      implementations = implementations.to_a.reverse.to_h if ENV['REVERSE']
+
+      implementations.each do |prefix, description|
+        x.report("No match -- #{description} singleton group support") do |times|
+          prepare_implementation(prefix)
+          define_and_run_examples("No match/#{description}", times)
+        end
+      end
+
+      implementations.each do |prefix, description|
+        x.report("Example match -- #{description} singleton group support") do |times|
+          prepare_implementation(prefix)
+          define_and_run_examples("Example match/#{description}", times, example_meta: { apply_it: true })
+        end
+      end
+
+      implementations.each do |prefix, description|
+        x.report("Group match -- #{description} singleton group support") do |times|
+          prepare_implementation(prefix)
+          define_and_run_examples("Group match/#{description}", times, group_meta: { apply_it: true })
+        end
+      end
+
+      implementations.each do |prefix, description|
+        x.report("Both match -- #{description} singleton group support") do |times|
+          prepare_implementation(prefix)
+          define_and_run_examples("Both match/#{description}", times,
+                                  example_meta: { apply_it: true },
+                                  group_meta: { apply_it: true })
+        end
+      end
+    end
+  end
+end

data/rspec-core/upstream/benchmarks/singleton_example_groups/with_config_hooks.rb

@@ -0,0 +1,28 @@
+require_relative "helper"
+
+RSpec.configure do |c|
+  10.times do
+    c.before(:context, :apply_it) { }
+    c.after(:context,  :apply_it) { }
+  end
+end
+
+BenchmarkHelpers.run_benchmarks
+
+__END__
+No match -- without singleton group support
+                        575.250  (±29.0%) i/s -      2.484k
+No match -- with singleton group support
+                        503.671  (±21.8%) i/s -      2.250k
+Example match -- without singleton group support
+                        544.191  (±25.7%) i/s -      2.160k
+Example match -- with singleton group support
+                        413.538  (±22.2%) i/s -      1.715k
+Group match -- without singleton group support
+                        517.998  (±28.2%) i/s -      2.058k
+Group match -- with singleton group support
+                        431.554  (±15.3%) i/s -      1.960k
+Both match -- without singleton group support
+                        525.306  (±25.1%) i/s -      2.107k in   5.556760s
+Both match -- with singleton group support
+                        440.288  (±16.6%) i/s -      1.848k

data/rspec-core/upstream/benchmarks/singleton_example_groups/with_config_hooks_module_inclusions_and_shared_context_inclusions.rb

@@ -0,0 +1,35 @@
+require_relative "helper"
+
+RSpec.configure do |c|
+  10.times do
+    c.before(:context, :apply_it) { }
+    c.after(:context,  :apply_it) { }
+    c.include Module.new, :apply_it
+  end
+end
+
+1.upto(10) do |i|
+  RSpec.shared_context "context #{i}", :apply_it do
+  end
+end
+
+BenchmarkHelpers.run_benchmarks
+
+__END__
+
+No match -- without singleton group support
+                        544.396  (±34.0%) i/s -      2.340k
+No match -- with singleton group support
+                        451.635  (±31.0%) i/s -      1.935k
+Example match -- without singleton group support
+                        538.788  (±23.8%) i/s -      2.450k
+Example match -- with singleton group support
+                        342.990  (±22.4%) i/s -      1.440k
+Group match -- without singleton group support
+                        509.969  (±26.7%) i/s -      2.070k
+Group match -- with singleton group support
+                        405.284  (±20.5%) i/s -      1.518k
+Both match -- without singleton group support
+                        513.344  (±24.0%) i/s -      1.927k
+Both match -- with singleton group support
+                        406.111  (±18.5%) i/s -      1.760k

data/rspec-core/upstream/benchmarks/singleton_example_groups/with_module_inclusions.rb

@@ -0,0 +1,28 @@
+require_relative "helper"
+
+RSpec.configure do |c|
+  1.upto(10) do
+    c.include Module.new, :apply_it
+  end
+end
+
+BenchmarkHelpers.run_benchmarks
+
+__END__
+
+No match -- without singleton group support
+                        555.498  (±27.0%) i/s -      2.496k
+No match -- with singleton group support
+                        529.826  (±23.0%) i/s -      2.397k in   5.402305s
+Example match -- without singleton group support
+                        541.845  (±29.0%) i/s -      2.208k
+Example match -- with singleton group support
+                        465.440  (±20.4%) i/s -      2.091k
+Group match -- without singleton group support
+                        530.976  (±24.1%) i/s -      2.303k
+Group match -- with singleton group support
+                        505.291  (±18.8%) i/s -      2.226k
+Both match -- without singleton group support
+                        542.168  (±28.4%) i/s -      2.067k in   5.414905s
+Both match -- with singleton group support
+                        503.226  (±27.2%) i/s -      1.880k in   5.621210s

data/rspec-core/upstream/benchmarks/singleton_example_groups/with_no_config_hooks_or_inclusions.rb

@@ -0,0 +1,22 @@
+require_relative "helper"
+
+BenchmarkHelpers.run_benchmarks
+
+__END__
+
+No match -- without singleton group support
+                        565.198  (±28.8%) i/s -      2.438k
+No match -- with singleton group support
+                        539.781  (±18.9%) i/s -      2.496k
+Example match -- without singleton group support
+                        539.287  (±28.2%) i/s -      2.450k in   5.555471s
+Example match -- with singleton group support
+                        511.576  (±28.1%) i/s -      2.058k
+Group match -- without singleton group support
+                        535.298  (±23.2%) i/s -      2.352k
+Group match -- with singleton group support
+                        539.454  (±19.1%) i/s -      2.350k
+Both match -- without singleton group support
+                        550.932  (±32.1%) i/s -      2.145k in   5.930432s
+Both match -- with singleton group support
+                        540.183  (±19.6%) i/s -      2.300k

data/rspec-core/upstream/benchmarks/singleton_example_groups/with_shared_context_inclusions.rb

@@ -0,0 +1,28 @@
+require_relative "helper"
+
+1.upto(10) do |i|
+  RSpec.shared_context "context #{i}", :apply_it do
+  end
+end
+
+BenchmarkHelpers.run_benchmarks
+# BenchmarkHelpers.profile(1000)
+
+__END__
+
+No match -- without singleton group support
+                        563.304  (±29.6%) i/s -      2.385k
+No match -- with singleton group support
+                        538.738  (±22.3%) i/s -      2.209k
+Example match -- without singleton group support
+                        546.605  (±25.6%) i/s -      2.450k
+Example match -- with singleton group support
+                        421.111  (±23.5%) i/s -      1.845k
+Group match -- without singleton group support
+                        536.267  (±27.4%) i/s -      2.050k
+Group match -- with singleton group support
+                        508.644  (±17.7%) i/s -      2.268k
+Both match -- without singleton group support
+                        538.047  (±27.7%) i/s -      2.067k in   5.431649s
+Both match -- with singleton group support
+                        505.388  (±26.7%) i/s -      1.880k in   5.578614s

data/rspec-core/upstream/benchmarks/threadsafe_let_block.rb

@@ -0,0 +1,312 @@
+require 'rspec/core'
+require 'rspec/expectations'
+
+# switches between these implementations - https://github.com/rspec/rspec-core/pull/1858/files
+# benchmark requested in this PR         - https://github.com/rspec/rspec-core/pull/1858
+#
+# I ran these from lib root by adding "gem 'benchmark-ips'" to ../Gemfile-custom
+# then ran `bundle install --standalone --binstubs bundle/bin`
+# then ran `ruby --disable-gems -I lib -I "$PWD/bundle" -r bundler/setup -S benchmarks/threadsafe_let_block.rb`
+
+# The old, non-thread safe implementation, imported from the `main` branch and pared down.
+module OriginalNonThreadSafeMemoizedHelpers
+  def __memoized
+    @__memoized ||= {}
+  end
+
+  module ClassMethods
+    def let(name, &block)
+      # We have to pass the block directly to `define_method` to
+      # allow it to use method constructs like `super` and `return`.
+      raise "#let or #subject called without a block" if block.nil?
+      OriginalNonThreadSafeMemoizedHelpers.module_for(self).__send__(:define_method, name, &block)
+
+      # Apply the memoization. The method has been defined in an ancestor
+      # module so we can use `super` here to get the value.
+      if block.arity == 1
+        define_method(name) { __memoized.fetch(name) { |k| __memoized[k] = super(RSpec.current_example, &nil) } }
+      else
+        define_method(name) { __memoized.fetch(name) { |k| __memoized[k] = super(&nil) } }
+      end
+    end
+  end
+
+  def self.module_for(example_group)
+    get_constant_or_yield(example_group, :LetDefinitions) do
+      mod = Module.new do
+        include Module.new {
+          example_group.const_set(:NamedSubjectPreventSuper, self)
+        }
+      end
+
+      example_group.const_set(:LetDefinitions, mod)
+      mod
+    end
+  end
+
+  # @private
+  def self.define_helpers_on(example_group)
+    example_group.__send__(:include, module_for(example_group))
+  end
+
+  def self.get_constant_or_yield(example_group, name)
+    if example_group.const_defined?(name, (check_ancestors = false))
+      example_group.const_get(name, check_ancestors)
+    else
+      yield
+    end
+  end
+end
+
+class HostBase
+  # wires the implementation
+  # adds `let(:name) { nil }`
+  # returns `Class.new(self) { let(:name) { super() } }`
+  def self.prepare_using(memoized_helpers, options={})
+    include memoized_helpers
+    extend memoized_helpers::ClassMethods
+    memoized_helpers.define_helpers_on(self)
+
+    define_method(:initialize, &options[:initialize]) if options[:initialize]
+    let(:name) { nil }
+
+    verify_memoizes memoized_helpers, options[:verify]
+
+    Class.new(self) do
+      memoized_helpers.define_helpers_on(self)
+      let(:name) { super() }
+    end
+  end
+
+  def self.verify_memoizes(memoized_helpers, additional_verification)
+    # Since we're using custom code, ensure it actually memoizes as we expect...
+    counter_class = Class.new(self) do
+      include RSpec::Matchers
+      memoized_helpers.define_helpers_on(self)
+      counter = 0
+      let(:count) { counter += 1 }
+    end
+    extend RSpec::Matchers
+
+    instance_1 = counter_class.new
+    expect(instance_1.count).to eq(1)
+    expect(instance_1.count).to eq(1)
+
+    instance_2 = counter_class.new
+    expect(instance_2.count).to eq(2)
+    expect(instance_2.count).to eq(2)
+
+    instance_3 = counter_class.new
+    instance_3.instance_eval &additional_verification if additional_verification
+  end
+end
+
+class OriginalNonThreadSafeHost < HostBase
+  Subclass = prepare_using OriginalNonThreadSafeMemoizedHelpers
+end
+
+class ThreadSafeHost < HostBase
+  Subclass = prepare_using RSpec::Core::MemoizedHelpers,
+    :initialize => lambda { |*| @__memoized = ThreadsafeMemoized.new },
+    :verify     => lambda { |*| expect(__memoized).to be_a_kind_of RSpec::Core::MemoizedHelpers::ThreadsafeMemoized }
+end
+
+class ConfigNonThreadSafeHost < HostBase
+  Subclass = prepare_using RSpec::Core::MemoizedHelpers,
+    :initialize => lambda { |*| @__memoized = NonThreadSafeMemoized.new },
+    :verify     => lambda { |*| expect(__memoized).to be_a_kind_of RSpec::Core::MemoizedHelpers::NonThreadSafeMemoized }
+end
+
+def title(title)
+  hr    = "#" * (title.length + 6)
+  blank = "#  #{' ' * title.length}  #"
+  [hr, blank, "#  #{title}  #", blank, hr]
+end
+
+require 'benchmark/ips'
+
+puts title "versions"
+puts "RUBY_VERSION             #{RUBY_VERSION}"
+puts "RUBY_PLATFORM            #{RUBY_PLATFORM}"
+puts "RUBY_ENGINE              #{RUBY_ENGINE}"
+puts "ruby -v                  #{`ruby -v`}"
+puts "Benchmark::IPS::VERSION  #{Benchmark::IPS::VERSION}"
+puts "rspec-core SHA           #{`git log --pretty=format:%H -1`}"
+puts
+
+puts title "1 call to let -- each sets the value"
+Benchmark.ips do |x|
+  x.report("non-threadsafe (original)") { OriginalNonThreadSafeHost.new.name }
+  x.report("non-threadsafe (config)  ") { ConfigNonThreadSafeHost.new.name }
+  x.report("threadsafe               ") { ThreadSafeHost.new.name }
+  x.compare!
+end
+
+puts title "10 calls to let -- 9 will find memoized value"
+Benchmark.ips do |x|
+  x.report("non-threadsafe (original)") do
+    i = OriginalNonThreadSafeHost.new
+    i.name; i.name; i.name; i.name; i.name
+    i.name; i.name; i.name; i.name; i.name
+  end
+
+  x.report("non-threadsafe (config)  ") do
+    i = ConfigNonThreadSafeHost.new
+    i.name; i.name; i.name; i.name; i.name
+    i.name; i.name; i.name; i.name; i.name
+  end
+
+  x.report("threadsafe               ") do
+    i = ThreadSafeHost.new
+    i.name; i.name; i.name; i.name; i.name
+    i.name; i.name; i.name; i.name; i.name
+  end
+
+  x.compare!
+end
+
+puts title "1 call to let which invokes super"
+
+Benchmark.ips do |x|
+  x.report("non-threadsafe (original)") { OriginalNonThreadSafeHost::Subclass.new.name }
+  x.report("non-threadsafe (config)  ") { ConfigNonThreadSafeHost::Subclass.new.name }
+  x.report("threadsafe               ") { ThreadSafeHost::Subclass.new.name }
+  x.compare!
+end
+
+puts title "10 calls to let which invokes super"
+Benchmark.ips do |x|
+  x.report("non-threadsafe (original)") do
+    i = OriginalNonThreadSafeHost::Subclass.new
+    i.name; i.name; i.name; i.name; i.name
+    i.name; i.name; i.name; i.name; i.name
+  end
+
+  x.report("non-threadsafe (config)  ") do
+    i = ConfigNonThreadSafeHost::Subclass.new
+    i.name; i.name; i.name; i.name; i.name
+    i.name; i.name; i.name; i.name; i.name
+  end
+
+  x.report("threadsafe               ") do
+    i = ThreadSafeHost::Subclass.new
+    i.name; i.name; i.name; i.name; i.name
+    i.name; i.name; i.name; i.name; i.name
+  end
+
+  x.compare!
+end
+
+__END__
+
+##############
+#            #
+#  versions  #
+#            #
+##############
+RUBY_VERSION             2.2.0
+RUBY_PLATFORM            x86_64-darwin13
+RUBY_ENGINE              ruby
+ruby -v                  ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-darwin13]
+Benchmark::IPS::VERSION  2.1.1
+rspec-core SHA           1ee7a8d8cde6ba2dd13d35e90e824e8e5ba7db76
+
+##########################################
+#                                        #
+#  1 call to let -- each sets the value  #
+#                                        #
+##########################################
+Calculating -------------------------------------
+non-threadsafe (original)
+                        53.722k i/100ms
+non-threadsafe (config)
+                        44.998k i/100ms
+threadsafe
+                        26.123k i/100ms
+-------------------------------------------------
+non-threadsafe (original)
+                        830.988k (± 6.3%) i/s -      4.190M
+non-threadsafe (config)
+                        665.662k (± 6.7%) i/s -      3.330M
+threadsafe
+                        323.575k (± 5.6%) i/s -      1.620M
+
+Comparison:
+non-threadsafe (original):   830988.5 i/s
+non-threadsafe (config)  :   665661.9 i/s - 1.25x slower
+threadsafe               :   323574.9 i/s - 2.57x slower
+
+###################################################
+#                                                 #
+#  10 calls to let -- 9 will find memoized value  #
+#                                                 #
+###################################################
+Calculating -------------------------------------
+non-threadsafe (original)
+                        28.724k i/100ms
+non-threadsafe (config)
+                        25.357k i/100ms
+threadsafe
+                        18.349k i/100ms
+-------------------------------------------------
+non-threadsafe (original)
+                        346.302k (± 6.1%) i/s -      1.752M
+non-threadsafe (config)
+                        309.970k (± 5.4%) i/s -      1.547M
+threadsafe
+                        208.946k (± 5.2%) i/s -      1.046M
+
+Comparison:
+non-threadsafe (original):   346302.0 i/s
+non-threadsafe (config)  :   309970.2 i/s - 1.12x slower
+threadsafe               :   208946.3 i/s - 1.66x slower
+
+#######################################
+#                                     #
+#  1 call to let which invokes super  #
+#                                     #
+#######################################
+Calculating -------------------------------------
+non-threadsafe (original)
+                        42.458k i/100ms
+non-threadsafe (config)
+                        37.367k i/100ms
+threadsafe
+                        21.088k i/100ms
+-------------------------------------------------
+non-threadsafe (original)
+                        591.906k (± 6.3%) i/s -      2.972M
+non-threadsafe (config)
+                        511.295k (± 4.7%) i/s -      2.578M
+threadsafe
+                        246.080k (± 5.8%) i/s -      1.244M
+
+Comparison:
+non-threadsafe (original):   591906.3 i/s
+non-threadsafe (config)  :   511295.0 i/s - 1.16x slower
+threadsafe               :   246079.6 i/s - 2.41x slower
+
+#########################################
+#                                       #
+#  10 calls to let which invokes super  #
+#                                       #
+#########################################
+Calculating -------------------------------------
+non-threadsafe (original)
+                        24.282k i/100ms
+non-threadsafe (config)
+                        22.762k i/100ms
+threadsafe
+                        14.685k i/100ms
+-------------------------------------------------
+non-threadsafe (original)
+                        297.423k (± 5.0%) i/s -      1.505M
+non-threadsafe (config)
+                        264.046k (± 5.6%) i/s -      1.320M
+threadsafe
+                        170.853k (± 4.7%) i/s -    866.415k
+
+Comparison:
+non-threadsafe (original):   297422.6 i/s
+non-threadsafe (config)  :   264045.8 i/s - 1.13x slower
+threadsafe               :   170853.1 i/s - 1.74x slower

data/rspec-core/upstream/cucumber.yml

@@ -1,6 +1,11 @@
 <%
+
+USE_TILDE_TAGS = !defined?(::RUBY_ENGINE_VERSION) || (::RUBY_ENGINE_VERSION < '2.0.0')
+NOT_WIP_TAG = USE_TILDE_TAGS ? '~@wip' : '"not @wip"'
+NOT_JRUBY_TAG = USE_TILDE_TAGS ? '~@no-jruby' : '"not @no-jruby"'
+
 exclusions = []
-exclusions << ' --tags ~@no-jruby' if RUBY_PLATFORM == 'java'
+exclusions << " --tags #{NOT_JRUBY_TAG}" if RUBY_PLATFORM == 'java'
 %>
-default: --require features --strict --format progress --tags ~@wip<%= exclusions.join %> features
+default: --require features --strict --format progress --tags <%= NOT_WIP_TAG %><%= exclusions.join %> features
 wip:     --require features --tags @wip:30 --wip features

data/rspec-core/upstream/features/.nav

@@ -1,4 +1,3 @@
-- Upgrade.md
 - Changelog.md
 - Autotest.md
 - example_groups:
@@ -20,6 +19,7 @@
   - before_and_after_hooks.feature
   - around_hooks.feature
   - filtering.feature
+  - when_first_matching_example_defined.feature
 - subject:
   - implicit_subject.feature
   - explicit_subject.feature
@@ -37,15 +37,19 @@
   - inclusion_filters.feature
   - exclusion_filters.feature
   - if_and_unless.feature
+  - filter_run_when_matching.feature
   - run_all_when_everything_filtered.feature
 - configuration:
   - read_options_from_file.feature
+  - color.feature
   - fail_fast.feature
+  - fail_if_no_examples.feature
   - custom_settings.feature
   - alias_example_to.feature
   - default_path.feature
 - expectation_framework_integration:
   - configure_expectation_framework.feature
+  - failure_aggregation.feature
 - mock_framework_integration:
   - use_rspec.feature
   - use_flexmock.feature

data/rspec-core/upstream/features/README.md

@@ -1,6 +1,6 @@
 rspec-core provides the structure for RSpec code examples:
 
-    describe Account do
+    RSpec.describe Account do
       it "has a balance of zero when first opened" do
         # example code goes here - for more on the
         # code inside the examples, see rspec-expectations
@@ -10,4 +10,4 @@ rspec-core provides the structure for RSpec code examples:
 
 ## Issues
 
-This documentation is [open source](https://github.com/rspec/rspec-core/tree/master/features), and a work in progress.  If you find it incomplete or confusing, please [submit an issue](http://github.com/rspec/rspec-core/issues), or, better yet, [a pull request](http://github.com/rspec/rspec-core).
+This documentation is [open source](https://github.com/rspec/rspec-core/tree/main/features), and a work in progress.  If you find it incomplete or confusing, please [submit an issue](http://github.com/rspec/rspec-core/issues), or, better yet, [a pull request](http://github.com/rspec/rspec-core).