opal-jquery 0.4.1 → 0.4.5

data/lib/opal/jquery/http.rb

@@ -165,7 +165,7 @@ class HTTP
 
     %x{
       if (typeof(#{payload}) === 'string') {
-        #{settings}.data = payload;
+        settings.data = payload;
       }
       else if (payload != nil) {
         settings.data = payload.$to_json();
@@ -223,8 +223,16 @@ class HTTP
   #
   # @param key [String] name of the header to get
   # @return [String] value of the header
+  # @return [nil] if the header +key+ was not in the response
   def get_header(key)
-    `#@xhr.getResponseHeader(#{key});`
+    %x{
+      var value = #@xhr.getResponseHeader(#{key});
+      return (value === null) ? nil : value;
+    }
+  end
+
+  def inspect
+    "#<HTTP @url=#{@url} @method=#{@method}>"
   end
 
   private

data/lib/opal/jquery/version.rb

@@ -1,5 +1,5 @@
 module Opal
   module JQuery
-    VERSION = '0.4.1'
+    VERSION = '0.4.5'
   end
 end

data/lib/opal/jquery/window.rb

@@ -6,7 +6,8 @@ module Browser
   # Generally, you will want to use the top level {::Window} instance, which
   # wraps `window` from the main page.
   class Window
-    include Native
+    # In more recent Opal versions Native::Wrapper should be used
+    include defined?(Native::Wrapper) ? Native::Wrapper : Native
 
     # Returns this {Window} instance wrapped as an {Element}. Useful for
     # delegating jQuery events, which allows the use of `window` as target.

data/opal-jquery.gemspec

@@ -4,19 +4,20 @@ require File.expand_path('../lib/opal/jquery/version', __FILE__)
 Gem::Specification.new do |s|
   s.name         = 'opal-jquery'
   s.version      = Opal::JQuery::VERSION
-  s.author       = 'Adam Beynon'
-  s.email        = 'adam.beynon@gmail.com'
-  s.homepage     = 'http://opalrb.org'
-  s.summary      = 'Opal access to jquery'
-  s.description  = 'Opal DOM library for jquery'
+  s.authors      = ['Adam Beynon', 'Elia Schito']
+  s.email        = 'elia@schito.me'
+  s.homepage     = 'https://github.com/opal/opal-jquery#readme'
+  s.summary      = 'Opal access to jQuery'
+  s.description  = 'Opal DOM library for jQuery'
 
   s.files          = `git ls-files`.split("\n")
   s.executables    = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   s.test_files     = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.require_paths  = ['lib']
 
-  s.add_runtime_dependency 'opal', '>= 0.7.0', '< 0.10.0'
-  s.add_development_dependency 'opal-rspec', '~> 0.4.0'
+  s.add_runtime_dependency 'opal', ['>= 0.10.0', '< 2.0']
+  s.add_development_dependency 'opal-rspec', ['>= 0.7', '< 2.0']
+  s.add_development_dependency 'opal-sprockets', ['>= 0.4.1', '< 2.0']
   s.add_development_dependency 'yard'
   s.add_development_dependency 'rake'
 end

data/{spec → spec-opal}/document_spec.rb

@@ -1,22 +1,29 @@
 require 'spec_helper'
 
-describe Document do
+RSpec.describe 'Document' do
   subject { Document }
 
   describe "ready?" do
+    it "accepts a block" do
+      Document.ready? {
+        puts `$.fn.jquery`
+      }
+    end
+
     it "accepts a block" do
       Document.ready? { }
     end
   end
-  
+
   describe "ready" do
+    p self.ancestors
     async "resolves when document is ready" do
-      Document.ready.then do 
+      Document.ready.then do
         async { Document.ready.resolved?.should be_truthy }
       end
     end
   end
-  
+
   describe "title" do
     it "gets the document title" do
       Document.title.should be_kind_of(String)

data/{spec → spec-opal}/element/after_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe 'Element#after' do
+RSpec.describe 'Element#after' do
   html <<-HTML
     <div id="some-header" class="kapow"></div>
     <div id="foo" class="after-spec-first"></div>

data/{spec → spec-opal}/element/animations_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe "Element animation methods" do
+RSpec.describe "Element animation methods" do
   html <<-HTML
     <div id="animate-foo"></div>
   HTML
@@ -41,16 +41,16 @@ describe "Element animation methods" do
   end
 end
 
-describe "Element effects methods" do
+RSpec.describe "Element effects methods" do
   html <<-HTML
     <div id="effects-foo"></div>
   HTML
-  
+
   describe "#fadeout / #fadein" do
     async "should fade the element out first" do
       foo = Element.find "#effects-foo"
       foo.effect(:fade_out)
-      
+
       delay 1 do
         async {
           foo.css("display").should eq("none")
@@ -64,4 +64,4 @@ describe "Element effects methods" do
       end
     end
   end
-end
+end

data/{spec → spec-opal}/element/append_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe "Element#append" do
+RSpec.describe "Element#append" do
   html <<-HTML
     <div id="foo" class="first-append"></div>
     <div id="bar" class="first-append"></div>

data/{spec → spec-opal}/element/append_to_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe "Element#append_to" do
+RSpec.describe "Element#append_to" do
   html <<-HTML
     <div id="foo"></div>
     <div id="bar"></div>

data/{spec → spec-opal}/element/at_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe "Element#at" do
+RSpec.describe "Element#at" do
   html <<-HTML
     <div class="foo" id="blah"></div>
     <div class="foo" id="bleh"></div>

data/{spec → spec-opal}/element/attributes_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Element do
+RSpec.describe Element do
   html <<-HTML
     <div id="foo"></div>
     <div id="bar" class="apples"></div>

data/{spec → spec-opal}/element/before_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe "Element#before" do
+RSpec.describe "Element#before" do
   html <<-HTML
     <div id="some-header" class="kapow"></div>
     <div id="foo" class="before-spec-first"></div>

data/{spec → spec-opal}/element/class_name_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe "Element#class_name" do
+RSpec.describe "Element#class_name" do
   html <<-HTML
     <div id="foo" class="whiskey"></div>
     <div id="bar" class="scotch brandy"></div>
@@ -30,7 +30,7 @@ describe "Element#class_name" do
   end
 end
 
-describe "Element#class_name=" do
+RSpec.describe "Element#class_name=" do
   before do
     @div = Element.parse <<-HTML
       <div id="class-name-set-spec">

data/{spec → spec-opal}/element/css_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe "Element#css" do
+RSpec.describe "Element#css" do
   html <<-HTML
     <div id="foo" style="background-color:rgb(15,99,30); color:;"></div>
     <div id="bar"></div>
@@ -32,8 +32,8 @@ describe "Element#css" do
     it "should set the properties" do
       hash = Element.find("#hash")
       hash.css(:width => "100px", :height => "200px")
-      hash.css("width").should be_kind_of(String) 
-      hash.css("height").should be_kind_of(String) 
+      hash.css("width").should be_kind_of(String)
+      hash.css("height").should be_kind_of(String)
     end
 
     it "should return self" do

data/{spec → spec-opal}/element/display_spec.rb

@@ -1,34 +1,34 @@
 require "spec_helper"
 
-describe "Element display methods" do
+RSpec.describe "Element display methods" do
   html <<-HTML
     <div id="shown"></div>
     <div id="hidden" style="display: none"></div>
   HTML
 
   it "hides an element" do
-    element = Element.find('#shown') 
+    element = Element.find('#shown')
     element.css('display').should == 'block'
     element.hide
     element.css('display').should == 'none'
   end
 
-  it "shows an element" do 
-    element = Element.find('#hidden') 
+  it "shows an element" do
+    element = Element.find('#hidden')
     element.css('display').should == 'none'
     element.show
     element.css('display').should == 'block'
   end
 
   it "toggles on a hidden element" do
-    element = Element.find('#hidden') 
+    element = Element.find('#hidden')
     element.css('display').should == 'none'
     element.toggle
     element.css('display').should == 'block'
   end
 
   it "toggles off a displayed element" do
-    element = Element.find('#shown') 
+    element = Element.find('#shown')
     element.css('display').should == 'block'
     element.toggle
     element.css('display').should == 'none'

data/spec-opal/element/expose_spec.rb

@@ -0,0 +1,73 @@
+require "spec_helper"
+
+RSpec.describe "Element#expose" do
+  subject(:element) { Element.new }
+  before do
+    `$.fn.exposableMethod = function() {return 123}`
+    `$.fn.exposableMethod2 = function() {return 12}`
+    `$.fn.opal_specs_extension = function() {return "foo_bar_baz";};`
+    `$.fn.opal_specs_args = function() {return Array.prototype.slice.call(arguments);};`
+    Element.expose :opal_specs_extension, :opal_specs_args
+  end
+
+  after do
+    `delete $.fn.exposableMethod; delete $.fn.$exposableMethod;`
+    `delete $.fn.exposableMethod2; delete $.fn.$exposableMethod2;`
+    `delete $.fn.opal_specs_extension; delete $.fn.$opal_specs_extension;`
+    `delete $.fn.opal_specs_args; delete $.fn.$opal_specs_args;`
+  end
+
+  it "exposes jquery plugins by given name" do
+    Element.new.opal_specs_extension.should eq("foo_bar_baz")
+  end
+
+  it "forwards any args onto native function" do
+    Element.new.opal_specs_args(:foo, 42, false).should eq([:foo, 42, false])
+  end
+
+  it "only forwards calls when a native method exists" do
+    expect {
+      Element.new.some_unknown_plugin
+    }.to raise_error(Exception)
+  end
+
+  it 'exposes methods defined on $.fn' do
+    expect(element).to respond_to(:exposableMethod) # via #respond_to_missing?
+    expect(element.methods).not_to include(:exposableMethod)
+    Element.expose :exposableMethod
+    expect(element.methods).to include(:exposableMethod)
+    expect(element).to respond_to(:exposableMethod) # via method missing
+    expect(element.exposableMethod).to eq(123)
+  end
+
+  it 'work if exposing the same method multiple times' do
+    Element.expose :exposableMethod
+    Element.expose :exposableMethod
+    expect(element.exposableMethod).to eq(123)
+
+    Element.expose :exposableMethod, :exposableMethod
+    expect(element.exposableMethod).to eq(123)
+  end
+
+  it 'work if exposing multiple methods' do
+    Element.expose :exposableMethod, :exposableMethod2
+    expect(element.exposableMethod).to eq(123)
+    expect(element.exposableMethod2).to eq(12)
+  end
+
+  it 'does not call method_missing after the method is exposed' do
+    pending "broken on opal < 0.11" if RUBY_ENGINE_VERSION.to_f < 0.11
+
+    expect(element).to receive(:method_missing).once.with(:exposableMethod)
+    def element.method_missing(name)
+      "#{name} (via method_missing)"
+    end
+
+    expect(element.exposableMethod).to eq("exposableMethod (via method_missing)")
+    Element.expose :exposableMethod
+
+    expect(element).not_to receive(:method_missing).once
+    element.exposableMethod
+  end
+
+end

data/{spec → spec-opal}/element/height_width_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe "Element height and width" do
+RSpec.describe "Element height and width" do
   html <<-HTML
     <div id="dimensions" style='width: 100px; height: 200px'></div>
   HTML

data/{spec → spec-opal}/element/inspect_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe "Element#inspect" do
+RSpec.describe "Element#inspect" do
   html <<-HTML
     <div id="foo"></div>
     <div class="bar"></div>

data/{spec → spec-opal}/element/iterable_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Element do
+RSpec.describe Element do
   html <<-HTML
     <table class="players">
     <tr class="player">

data/{spec → spec-opal}/element/length_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe "Element#length" do
+RSpec.describe "Element#length" do
   it "should report the number of elements in the instance" do
     Element.new.length.should == 1
   end

data/spec-opal/element/method_missing_spec.rb

@@ -0,0 +1,34 @@
+require "spec_helper"
+
+RSpec.describe "Element#method_missing" do
+  context 'with missing property' do
+    html %{<div id="foo" class="bar"></div>}
+
+    it 'fallsback on method_missing when a method is unknown' do
+      expect(Element['#foo']).to respond_to(:offsetParent)
+      expect(Element['#foo'].offsetParent).to eq(Element['body'])
+    end
+  end
+
+  context 'jQuery plugin methods' do
+    subject(:element) { Element.new }
+
+    before do
+      `$.fn.pluginMethod = function() {return 123}`
+    end
+
+    after do
+      `delete $.fn.pluginMethod; delete $.fn.$pluginMethod;`
+    end
+
+    it 'calls method_missing' do
+      expect(element).to receive(:method_missing).once.with(:pluginMethod)
+      element.pluginMethod
+    end
+
+    it 'calls forwards to the plugin', :focus do
+      pending "broken on opal < 0.11" if RUBY_ENGINE_VERSION.to_f < 0.11
+      expect(element.pluginMethod).to eq(123)
+    end
+  end
+end

data/{spec → spec-opal}/element/prepend_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe 'Element#prepend' do
+RSpec.describe 'Element#prepend' do
   html <<-HTML
     <div id="foo"></div>
     <div id="bar">

data/{spec → spec-opal}/element/to_s_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe "Element#to_s" do
+RSpec.describe "Element#to_s" do
   html <<-HTML
     <div id="foo">hi</div>
     <div class="bar"></div>

data/{spec → spec-opal}/element/traversing_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Element do
+RSpec.describe Element do
   before do
     @div = Element.parse <<-HTML
       <div id="traversing-spec">
@@ -76,7 +76,7 @@ describe Element do
   end
 end
 
-describe "Element#next" do
+RSpec.describe "Element#next" do
   before do
     @div = Element.parse <<-HTML
       <div id="next-spec">
@@ -101,7 +101,7 @@ describe "Element#next" do
   end
 end
 
-describe "Element#parent" do
+RSpec.describe "Element#parent" do
   before do
     @div = Element.parse <<-HTML
       <div id="foo">
@@ -126,7 +126,7 @@ describe "Element#parent" do
   end
 end
 
-describe "Element#succ" do
+RSpec.describe "Element#succ" do
   before do
     @div = Element.parse <<-HTML
       <div id="succ-spec">
@@ -151,7 +151,7 @@ describe "Element#succ" do
   end
 end
 
-describe "Element#siblings" do
+RSpec.describe "Element#siblings" do
   before do
     @div = Element.parse <<-HTML
       <div id="siblings-spec">