ood_packaging 0.0.1.rc.7 → 0.0.3.r2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8d06c4909a16375f19e2ea2f04296382904f1605aced7628b24a32724cfdc47d
-  data.tar.gz: 3d079d84b97722071acc1960a108bd16429b841b044e4952dd4ab42b6e2ec23a
+  metadata.gz: 7fcaaed05fcdf85f942480ee3c0c983dcb636e68c033ad2e613bbda346893109
+  data.tar.gz: 96a5eea4c809d8d076374dc0d2855e5b390cb5f42410edb8e60fee23349b534f
 SHA512:
-  metadata.gz: 022faaca41616c5ae4cc2e8fe1c7c3bb2e9159bfca06ddc472ff4b311ce1af9f9d03557710648bd0d800d1af66b90bc713621908d8366068bee0c37303b2cfaf
-  data.tar.gz: 5d4df0f7b85f405ee49e637185f1fad4b25738dec1f8b5fd5d4c2fd7d670b8f2b08336428709dcb62608d796939d91908386e4e1e5db0cc235b54bcbcff9d5e8
+  metadata.gz: 506cc31f4d30572a1d8c1e38e338d3133bca116a1543d861ba9c8b3ea489f4924c19428d3f9d8aa7aaf0ff332f9b8e5345a224fdd88bbbc587c4b6fef00e2200
+  data.tar.gz: df75dfdf6f84cf24bd1b3a6f2b3572106e417fbe0af705f390ac74fd74b0273833229347fc26ce6fb4f20145e6f3263cadfc1dd1294fe7138263c2270e965787

data/bin/ood_packaging

@@ -2,13 +2,9 @@
 # frozen_string_literal: true
 
 require 'optparse'
-begin
-  require 'ood_packaging'
-# If gem is not installed, load from location in git repo
-rescue LoadError
-  $LOAD_PATH.unshift(File.expand_path(File.join(__dir__, '../lib')))
-  require 'ood_packaging'
-end
+libdir = File.expand_path(File.join(__dir__, '../lib'))
+$LOAD_PATH.unshift(libdir) if Dir.exist?(libdir)
+require 'ood_packaging'
 
 options = {}
 OptionParser.new do |opts|

data/lib/ood_packaging/build.rb

@@ -76,6 +76,8 @@ class OodPackaging::Build
                     '/package/rpm'
                   elsif Dir.exist?('/package/packaging/rpm')
                     '/package/packaging/rpm'
+                  elsif Dir.exist?('/package/packaging')
+                    '/package/packaging'
                   else
                     '/package'
                   end
@@ -92,6 +94,8 @@ class OodPackaging::Build
   def debian_dir
     @debian_dir ||= if Dir.exist?('/package/deb/debian')
                       '/package/deb/debian'
+                    elsif Dir.exist?('/package/packaging/deb')
+                      '/package/packaging/deb'
                     else
                       '/package/debian'
                     end
@@ -142,6 +146,7 @@ class OodPackaging::Build
     rpmbuild! if build_box.rpm?
     debuild! if build_box.deb?
     copy_output!
+    show_output!
     gpg_sign! if build_box.rpm? && gpg_sign?
     sanity!
   end
@@ -190,10 +195,17 @@ class OodPackaging::Build
   def bootstrap_get_source!
     if ENV['SKIP_DOWNLOAD'] == 'true'
       puts "\tSKIP_DOWNLOAD detected, skipping download sources".blue
-    else
-      puts "\tDownloading sources defined in #{spec_file}".blue
-      sh "spectool #{rpm_defines.join(' ')} -g -R -S #{spec_file}#{cmd_suffix}"
+      return
     end
+    output = `spectool #{rpm_defines.join(' ')} -l -R -S #{spec_file} 2>&1 | grep 'Source0:'`.strip
+    exit_code = $CHILD_STATUS.exitstatus
+    if exit_code.zero?
+      source = File.join(work_dir, 'SOURCES', File.basename(output))
+      tar = File.join(work_dir, 'SOURCES', ENV['TAR_NAME'])
+      sh "mv #{tar} #{source}" if !File.exist?(source) && File.exist?(tar)
+    end
+    puts "\tDownloading sources defined in #{spec_file}".blue
+    sh "spectool #{rpm_defines.join(' ')} -g -R -S #{spec_file}#{cmd_suffix}"
   end
 
   def bootstrap_deb!
@@ -210,7 +222,7 @@ class OodPackaging::Build
     puts "\tBootstrap debian build files".blue
     Dir.chdir(deb_work_dir) do
       sh "dh_make -s -y --createorig -f ../#{deb_name}.tar.gz#{cmd_suffix} || true"
-      sh "dch -b -v #{deb_version} 'Release #{deb_version}'#{cmd_suffix}"
+      sh "dch -b -v #{deb_version} --controlmaint 'Release #{deb_version}'#{cmd_suffix}"
     end
   end
 
@@ -236,9 +248,14 @@ class OodPackaging::Build
 
   def install_deb_dependencies!
     sh "sudo apt update -y#{cmd_suffix}"
+    tool = [
+      'DEBIAN_FRONTEND=noninteractive apt-cudf-get --solver aspcud',
+      '-o APT::Get::Assume-Yes=1 -o APT::Get::Allow-Downgrades=1',
+      '-o Debug::pkgProblemResolver=0 -o APT::Install-Recommends=0'
+    ]
     cmd = [
       'mk-build-deps --install --remove --root-cmd sudo',
-      "--tool='apt-get -o Debug::pkgProblemResolver=yes --no-install-recommends --yes'"
+      "--tool='#{tool.join(' ')}'"
     ]
     Dir.chdir(deb_work_dir) do
       sh "#{cmd.join(' ')}#{cmd_suffix}"
@@ -277,6 +294,13 @@ class OodPackaging::Build
     end
   end
 
+  def show_output!
+    puts '== Copied output =='.blue
+    Dir["#{output_dir}/*"].each do |f|
+      puts "\tSaved output #{f}".blue
+    end
+  end
+
   def gpg_sign!
     puts '== GPG sign RPMs =='.blue
     rpms.each do |rpm|

data/lib/ood_packaging/build_box/docker-image/Dockerfile.erb

@@ -2,32 +2,35 @@ FROM <%= base_image %>
 MAINTAINER Trey Dockendorf <tdockendorf@osc.edu>
 ENV LANG=en_US.UTF-8
 ENV LC_CTYPE=en_US.UTF-8
+ENV USER=<%= ctr_user %>
 ENV GEM_PATH=<%= ctr_gems_dir %>:
-<% if dist == 'el7' -%>
+<% if scl? -%>
 RUN yum update -y && yum clean all && rm -rf /var/cache/yum/*
 RUN yum install -y yum-utils epel-release centos-release-scl && yum clean all && rm -rf /var/cache/yum/*
 RUN yum install -y <%= scl_ruby %>-ruby sudo which wget @buildsys-build \
     rpm-build rpmdevtools rpm-sign scl-utils-build && \
     yum clean all && rm -rf /var/cache/yum/*
-<% elsif dist =~ /^el/ -%>
+RUN rm -f /etc/yum.repos.d/CentOS-Vault.repo /etc/yum.repos.d/CentOS-Sources.repo
+RUN head -n 13 /etc/yum.repos.d/CentOS-SCLo-scl.repo > /etc/yum.repos.d/CentOS-SCLo.repo
+RUN head -n 13 /etc/yum.repos.d/CentOS-SCLo-scl-rh.repo >> /etc/yum.repos.d/CentOS-SCLo.repo
+RUN rm -f /etc/yum.repos.d/CentOS-SCLo-scl-rh.repo /etc/yum.repos.d/CentOS-SCLo-scl.repo
+<% elsif dnf? -%>
 RUN dnf update -y && dnf clean all && rm -rf /var/cache/dnf/*
 RUN dnf install -y dnf-utils epel-release langpacks-en glibc-all-langpacks && dnf clean all && rm -rf /var/cache/dnf/*
 RUN dnf config-manager --set-enabled powertools && dnf clean all && rm -rf /var/cache/dnf/*
-RUN dnf module enable -y ruby:<%= ruby_version %> && dnf clean all && rm -rf /var/cache/dnf/*
-RUN dnf module enable -y nodejs:<%= nodejs_version %> && dnf clean all && rm -rf /var/cache/dnf/*
-RUN dnf install -y ruby sudo which wget \
+RUN dnf module enable -y ruby:<%= ruby_version %> nodejs:<%= nodejs_version %> && dnf clean all && rm -rf /var/cache/dnf/*
+RUN dnf install -y systemd ruby nodejs sudo which wget \
     gcc-c++ gcc make patch \
     rpm-build rpmdevtools rpm-sign scl-utils-build && \
     dnf clean all && rm -rf /var/cache/dnf/*
-<% elsif dist =~ /^ubuntu|debian/ -%>
+<% elsif deb? -%>
 ENV DEBIAN_FRONTEND=noninteractive
 RUN apt update -y && apt upgrade -y && apt clean all -y
 RUN apt update -y && apt install -y locales && locale-gen $LANG && \
     apt clean all -y
 RUN apt update -y && apt install -y apt-transport-https ca-certificates \
-    init debhelper devscripts dh-make build-essential lintian equivs \
-    sudo rake wget curl ruby && \
-    ln -snf /bin/bundle2.7 /bin/bundle && \
+    init debhelper devscripts dh-make build-essential apt-cudf lintian equivs \
+    sudo rake wget curl ruby bundler && \
     apt clean all -y
 RUN echo "deb https://deb.nodesource.com/node_<%= nodejs_version %>.x <%= codename %> main" > /etc/apt/sources.list.d/nodesource.list
 RUN curl -s https://deb.nodesource.com/gpgkey/nodesource.gpg.key | gpg --dearmor > /etc/apt/trusted.gpg.d/nodesource.gpg

data/lib/ood_packaging/build_box/docker-image/install.sh.erb

@@ -72,7 +72,7 @@ echo "allow-loopback-pinentry" >> <%= ctr_gpg_dir %>/gpg-agent.conf
 <%- end -%>
 
 header "Install ood_packaging gem"
-<%- if rpm? && !dnf? -%>
+<%- if scl? -%>
 run scl enable <%= scl_ruby %> -- gem install --no-doc --bindir <%= ctr_scripts_dir %> --install-dir <%= ctr_gems_dir %> /build/*.gem
 <%- else -%>
 run gem install --no-doc --bindir <%= ctr_scripts_dir %> --install-dir <%= ctr_gems_dir %> /build/*.gem

data/lib/ood_packaging/build_box.rb

@@ -12,10 +12,12 @@ class OodPackaging::BuildBox
   BASE_IMAGES = {
     'el7'          => 'centos:7',
     'el8'          => 'rockylinux/rockylinux:8',
+    'ubuntu-18.04' => 'ubuntu:18.04',
     'ubuntu-20.04' => 'ubuntu:20.04'
   }.freeze
 
   CODENAMES = {
+    'ubuntu-18.04' => 'bionic',
     'ubuntu-20.04' => 'focal'
   }.freeze
 
@@ -133,6 +135,10 @@ class OodPackaging::BuildBox
     sh [container_runtime, 'push', image_tag].join(' ')
   end
 
+  def pull!
+    sh [container_runtime, 'pull', image_tag].join(' ')
+  end
+
   def save!(path)
     sh [container_runtime, 'save', image_tag, '| gzip >', path].join(' ')
   end

data/lib/ood_packaging/package.rb

@@ -21,8 +21,6 @@ class OodPackaging::Package
     @config = config
     @config[:dist] = 'el8' if tar_only?
     @build_box = OodPackaging::BuildBox.new(config)
-    @clean_work_dir = config[:clean_work_dir].nil? ? true : config[:clean_work_dir]
-    @clean_output_dir = config[:clean_output_dir].nil? ? true : config[:clean_output_dir]
     raise ArgumentError, 'Package is required' if package.nil?
     raise ArgumentError, 'Version is required' if version.nil?
     raise ArgumentError, "Package #{package} is not a directory" unless Dir.exist?(package)
@@ -33,12 +31,18 @@ class OodPackaging::Package
     @container_name ||= SecureRandom.uuid
   end
 
-  def debug
+  def debug?
     return true if ENV['OOD_PACKAGING_DEBUG'] == 'true'
 
     @config[:debug].nil? ? false : @config[:debug]
   end
 
+  def cmd_suffix
+    return '' if debug?
+
+    ' 2>/dev/null 1>/dev/null'
+  end
+
   def attach?
     return true if ENV['OOD_PACKAGING_ATTACH'] == 'true'
 
@@ -49,10 +53,22 @@ class OodPackaging::Package
     @work_dir ||= File.expand_path(@config[:work_dir])
   end
 
+  def clean_work_dir
+    return false if ENV['OOD_PACKAGING_CLEAN_WORK_DIR'] == 'false'
+
+    @config[:clean_work_dir].nil? ? true : @config[:clean_work_dir]
+  end
+
   def output_dir
     @output_dir ||= File.expand_path(@config[:output_dir])
   end
 
+  def clean_output_dir
+    return false if ENV['OOD_PACKAGING_CLEAN_OUTPUT_DIR'] == 'false'
+
+    @config[:clean_output_dir].nil? ? true : @config[:clean_output_dir]
+  end
+
   def package
     @config[:package]
   end
@@ -90,8 +106,6 @@ class OodPackaging::Package
 
   def gpg_files
     [
-      OpenStruct.new(private_key: File.join(proj_root, 'ondemand.sec'), passphrase: File.join(proj_root, '.gpgpass')),
-      OpenStruct.new(private_key: File.join(package, 'ondemand.sec'), passphrase: File.join(package, '.gpgpass')),
       OpenStruct.new(private_key: @config[:gpg_private_key], passphrase: @config[:gpg_passphrase]),
       OpenStruct.new(private_key: ENV['OOD_PACKAGING_GPG_PRIVATE_KEY'],
                      passphrase:  ENV['OOD_PACKAGING_GPG_PASSPHRASE'])
@@ -109,8 +123,12 @@ class OodPackaging::Package
     !gpg_files.nil?
   end
 
+  def default_gpg_name
+    'OnDemand Release Signing Key'
+  end
+
   def gpg_name
-    @config[:gpg_name].nil? ? 'OnDemand Release Signing Key' : @config[:gpg_name]
+    @config[:gpg_name].nil? ? default_gpg_name : @config[:gpg_name]
   end
 
   def container_init
@@ -126,10 +144,23 @@ class OodPackaging::Package
     package
   end
 
-  def rpm_tar_dest_dir
-    dir = File.join(package, 'rpm')
-    return dir if Dir.exist?(dir)
+  def tar_name
+    version = if build_box.rpm?
+                rpm_version
+              else
+                deb_version
+              end
+    "#{package_name}-#{version}"
+  end
 
+  def rpm_tar_dest_dir
+    [
+      File.join(package, 'rpm'),
+      File.join(package, 'packaging/rpm'),
+      File.join(package, 'packaging')
+    ].each do |dir|
+      return dir if Dir.exist?(dir)
+    end
     File.join(package, 'packaging/rpm')
   end
 
@@ -161,7 +192,7 @@ class OodPackaging::Package
     cmd.concat exec_launchers if docker_runtime?
     cmd.concat ['scl', 'enable', scl_ruby, '--'] if podman_runtime? && build_box.scl?
     cmd.concat [File.join(ctr_scripts_dir, 'rake')]
-    cmd.concat ['-q'] unless debug
+    cmd.concat ['-q'] unless debug?
     cmd.concat ['-f', File.join(ctr_scripts_dir, 'Rakefile'), 'ood_packaging:package:build']
     cmd
   end
@@ -187,33 +218,31 @@ class OodPackaging::Package
   end
 
   def clean!
-    sh "rm -rf #{work_dir}", verbose: debug if @clean_work_dir
-    sh "rm -rf #{output_dir}", verbose: debug if @clean_output_dir
+    sh "rm -rf #{work_dir}", verbose: debug? if clean_work_dir
+    sh "rm -rf #{output_dir}", verbose: debug? if clean_output_dir
   end
 
   def bootstrap!
-    sh "mkdir -p #{work_dir}", verbose: debug
-    sh "mkdir -p #{output_dir}", verbose: debug
+    sh "mkdir -p #{work_dir}", verbose: debug?
+    sh "mkdir -p #{output_dir}", verbose: debug?
   end
 
   def tar!
     cmd = ['git', 'ls-files', '.', '|', tar, '-c']
     if build_box.rpm?
       dir = rpm_tar_dest_dir
-      version = rpm_version
     else
       dir = deb_tar_dest_dir.tap { |p| sh "mkdir -p #{p}" }
-      version = deb_version
       cmd.concat ["--transform 'flags=r;s,packaging/deb,debian,'"]
     end
-    tar_file = "#{dir}/#{package_name}-#{version}.tar.gz"
-    cmd.concat ["--transform 's,^,#{package_name}-#{version}/,'"]
+    tar_file = "#{dir}/#{tar_name}.tar.gz"
+    cmd.concat ["--transform 's,^,#{tar_name}/,'"]
     cmd.concat ['-T', '-', '|', "gzip > #{tar_file}"]
 
     sh "rm #{tar_file}" if File.exist?(tar_file)
     puts "Create tar archive #{tar_file}".blue
     Dir.chdir(tar_path) do
-      sh cmd.join(' '), verbose: debug
+      sh cmd.join(' '), verbose: debug?
     end
   end
 
@@ -227,19 +256,19 @@ class OodPackaging::Package
     tar! if tar?
     container_start!
     container_exec!(exec_rake)
+    puts "Build SUCCESS: package=#{package} dist=#{build_box.dist}".green
   rescue RuntimeError
-    # ret = 1
     puts "Build FAILED package=#{package} dist=#{build_box.dist}".red
     raise
-  else
-    puts "Build SUCCESS: package=#{package} dist=#{build_box.dist}".green
   ensure
     container_exec!(exec_attach, ['-i', '-t']) if attach?
-    container_kill! if container_running?
+    container_kill! if container_running? && !attach?
   end
 
   def container_running?
-    `#{container_runtime} inspect #{container_name} 2>/dev/null 1>/dev/null`
+    cmd = "#{container_runtime} inspect #{container_name} 2>/dev/null 1>/dev/null"
+    puts cmd if debug?
+    `#{cmd}`
     $CHILD_STATUS.success?
   end
 
@@ -250,9 +279,9 @@ class OodPackaging::Package
     cmd.concat container_mounts
     cmd.concat [build_box.image_tag]
     cmd.concat [container_init]
-    cmd.concat ['1>/dev/null'] unless debug
+    cmd.concat ['1>/dev/null'] unless debug?
     puts "Starting container #{container_name} using image #{build_box.image_tag}".blue
-    sh cmd.join(' '), verbose: debug
+    sh cmd.join(' '), verbose: debug?
   end
 
   def container_exec!(exec_cmd, extra_args = [])
@@ -264,14 +293,18 @@ class OodPackaging::Package
     cmd.concat [container_name]
     cmd.concat exec_cmd
     puts "Build STARTED: package=#{package} dist=#{build_box.dist} exec=#{exec_cmd[-1]}".blue
-    sh cmd.join(' '), verbose: debug
+    sh cmd.join(' '), verbose: debug?
+    true
+  rescue RuntimeError
+    container_kill! if container_running? && !attach?
+    raise
   end
 
   def container_kill!
     puts "Killing container #{container_name}".blue
     cmd = [container_runtime, 'kill', container_name]
-    cmd.concat ['1>/dev/null', '2>/dev/null'] unless debug
-    sh cmd.join(' '), verbose: debug
+    cmd.concat [cmd_suffix] unless debug?
+    sh cmd.join(' '), verbose: debug?
   end
 
   def container_env
@@ -279,12 +312,13 @@ class OodPackaging::Package
       'DIST'          => build_box.dist,
       'PACKAGE'       => package_name,
       'VERSION'       => version,
+      'TAR_NAME'      => "#{tar_name}.tar.gz",
       'GPG_SIGN'      => gpg_sign,
       'GPG_NAME'      => gpg_name,
       'SKIP_DOWNLOAD' => @config[:skip_download],
       'OOD_UID'       => Process.uid,
       'OOD_GID'       => Process.gid,
-      'DEBUG'         => debug
+      'DEBUG'         => debug?
     }
     env['GPG_PUBKEY'] = '/gpg.pub' if @config[:gpg_pubkey]
     env

data/lib/ood_packaging/tasks.rb

@@ -28,6 +28,12 @@ namespace :ood_packaging do
       @build_box.push!
     end
 
+    desc 'Pull buildbox image'
+    task :pull, [:dist] do |_task, args|
+      @build_box = OodPackaging::BuildBox.new(args)
+      @build_box.pull!
+    end
+
     desc 'Save buildbox image'
     task :save, [:dist, :path] do |_task, args|
       @build_box = OodPackaging::BuildBox.new(args)
@@ -44,8 +50,9 @@ namespace :ood_packaging do
     OodPackaging::RakeTask.new(:internal, [:package, :dist]) do |t, args|
       name = args[:package].split(':').last
       t.package = File.join(proj_root, 'packages', name)
-      t.dist = args[:dist] || ENV['OOD_PACKAGING_DIST']
-      t.version = OodPackaging.package_version(name, args[:dist])
+      dist = args[:dist] || ENV['OOD_PACKAGING_DIST']
+      t.dist = dist
+      t.version = OodPackaging.package_version(name, dist)
       t.work_dir = File.join(proj_root, 'tmp/work')
       t.output_dir = File.join(proj_root, 'tmp/output')
     end

data/lib/ood_packaging/utils.rb

@@ -55,7 +55,7 @@ module OodPackaging::Utils
   end
 
   def ondemand_repo_version
-    '2.1'
+    '2.0'
   end
 
   def ruby_version
@@ -67,7 +67,7 @@ module OodPackaging::Utils
   end
 
   def nodejs_version
-    '14'
+    '12'
   end
 
   def ctr_scripts_dir

data/lib/ood_packaging/version.rb

@@ -2,25 +2,25 @@
 
 # Version code for OodPackaging
 module OodPackaging
-  VERSION = '0.0.1.rc.7'
+  VERSION = '0.0.3.r2.0'
   PACKAGE_VERSION = {
     'ondemand-release'        => {
-      '(ubuntu|debian)' => '2.1.0',
-      'default'         => '2.1'
+      '(ubuntu|debian)' => '2.0.0',
+      'default'         => '2.0'
     },
     'ondemand-release-latest' => {
       '(ubuntu|debian)' => '1',
-      'default'         => '1-6'
+      'default'         => '1-7'
     },
-    'ondemand-runtime'        => '2.1',
-    'passenger'               => '6.0.11',
+    'ondemand-runtime'        => '2.0-2',
+    'passenger'               => '6.0.14',
     'cjose'                   => '0.6.1',
     'mod_auth_openidc'        => '2.4.5',
     'sqlite'                  => '3.26.0-4',
     'ondemand_exporter'       => '0.9.0',
     'ondemand-compute'        => {
-      '(ubuntu|debian)' => '2.1.0',
-      'default'         => '2.1'
+      '(ubuntu|debian)' => '2.0',
+      'default'         => '2.0'
     },
     'python-websockify'       => '0.8.0',
     'turbovnc'                => '2.2.5'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ood_packaging
 version: !ruby/object:Gem::Version
-  version: 0.0.1.rc.7
+  version: 0.0.3.r2.0
 platform: ruby
 authors:
 - Trey Dockendorf
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-12-22 00:00:00.000000000 Z
+date: 2022-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -113,7 +113,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.2.33
 signing_key: 
 specification_version: 4
 summary: Open OnDemand packaging library