ood_core 0.23.0 → 0.23.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 379d230153e94bdbeca027f601afc89a525b328d8e200cc1a6a18754b3370b88
-  data.tar.gz: 5544e85c81b6e955a63144a056eee24d6bd5ec062de4d17a535d9df78eb5a817
+  metadata.gz: bd8cb5dc98cf0b2c2120fdb6234e5482fb40cbec59f6688318e0d33b050d0dc4
+  data.tar.gz: 0fe72b2fe29aa1e4ca2d5e28ca43e8b3f9e0381fe17f4678ea7218a5c062a3e7
 SHA512:
-  metadata.gz: 972cabe2a634f50b730e29d31a54e34c2784ea707fd562b867c8f8731e4d612bd39fd8bcacb84b49585a08131d4f9e3770195f2c1c6036fde52ff4e3d4f7124c
-  data.tar.gz: 4a0997de2400017ad8a921358b76341706cd4e58034c881dd8b9dfe63e9d9b7c559c42ed711a13051cd5168dde6703164714d22ee1e8ae2d7980fa33d2da3e4c
+  metadata.gz: 53bd81e896ae96b55e92732b86d9ca364449f8140bedbaba0b6fc9de73d5ffb06e65ea9ba84cc84e621bbf64af5b30a241a803b7fb4944745ebb50cc2a6ba39f
+  data.tar.gz: 9106dbc505aff7040bedeba9c0531cd539dbcd11e3aac54072e7bc01660f8f07147fb19be325631496215b6c1725bb68ca57968b39e377b0567747ef5569563c

data/CHANGELOG.md

@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [0.23.1] - 02-01-2023
+
+### Fixed
+
+- `QueueInfo` objects also upcase accounts when applicable in [792](https://github.com/OSC/ood_core/pull/792).
+
+### Added
+
+- `queue_name` has the alias `queue` in [790](https://github.com/OSC/ood_core/pull/790).
+
 ## [0.23.0] - 01-17-2023
 
 ### Added
@@ -469,7 +479,8 @@ Functionally the same as [0.17.3] but with some CI updates.
 ### Added
 - Initial release!
 
-[Unreleased]: https://github.com/OSC/ood_core/compare/v0.23.0...HEAD
+[Unreleased]: https://github.com/OSC/ood_core/compare/v0.23.1...HEAD
+[0.23.1]: https://github.com/OSC/ood_core/compare/v0.22.0...v0.23.0
 [0.23.0]: https://github.com/OSC/ood_core/compare/v0.22.0...v0.23.0
 [0.22.0]: https://github.com/OSC/ood_core/compare/v0.21.0...v0.22.0
 [0.21.0]: https://github.com/OSC/ood_core/compare/v0.20.2...v0.21.0

data/lib/ood_core/data_formatter.rb

@@ -0,0 +1,14 @@
+module OodCore
+  module DataFormatter
+    # Determine whether to upcase account strings when returning adapter#accounts
+    def upcase_accounts?
+      env_var = ENV['OOD_UPCASE_ACCOUNTS']
+
+      if env_var.nil? || env_var.to_s.downcase == 'false'
+        false
+      else
+        true
+      end
+    end
+  end
+end

data/lib/ood_core/job/account_info.rb

@@ -3,6 +3,8 @@ module OodCore
 
     class AccountInfo
 
+      include OodCore::DataFormatter
+
       # The name of the account.
       attr_reader :name
       alias to_s name
@@ -19,7 +21,7 @@ module OodCore
 
       def initialize(**opts)
         orig_name = opts.fetch(:name, 'unknown')
-        @name = OodCore::Job::Adapters::Helper.upcase_accounts? ? orig_name.upcase : orig_name
+        @name = upcase_accounts? ? orig_name.upcase : orig_name
         @qos = opts.fetch(:qos, [])
         @cluster = opts.fetch(:cluster, nil)
         @queue = opts.fetch(:queue, nil)

data/lib/ood_core/job/adapters/helper.rb

@@ -31,17 +31,6 @@ module OodCore
 
           return 'ssh', args + [cmd] + cmd_args
         end
-
-        # Determine whether to upcase account strings when returning adapter#accounts
-        def self.upcase_accounts?
-          env_var = ENV['OOD_UPCASE_ACCOUNTS']
-
-          if env_var.nil? || env_var.to_s.downcase == 'false'
-            false
-          else
-            true
-          end
-        end
       end
     end
   end

data/lib/ood_core/job/adapters/slurm.rb

@@ -186,13 +186,13 @@ module OodCore
             [].tap do |accts|
               call('sacctmgr', *args).each_line do |line|
                 acct, cluster, queue, qos = line.split('|')
-                next if acct.nil?
+                next if acct.nil? || acct.chomp.empty?
 
                 args = {
                   name: acct,
                   qos: qos.to_s.chomp.split(','),
                   cluster: cluster,
-                  queue: queue.empty? ? nil : queue
+                  queue: queue.to_s.empty? ? nil : queue
                 }
                 info = OodCore::Job::AccountInfo.new(**args) unless acct.nil?
                 accts << info unless acct.nil?

data/lib/ood_core/job/queue_info.rb

@@ -2,6 +2,9 @@
 
 # QueueInfo is information about a given queue on a scheduler.
 class OodCore::Job::QueueInfo
+
+  include OodCore::DataFormatter
+
   # The name of the queue.
   attr_reader :name
   alias to_s name
@@ -20,8 +23,17 @@ class OodCore::Job::QueueInfo
   def initialize(**opts)
     @name = opts.fetch(:name, 'unknown')
     @qos = opts.fetch(:qos, [])
-    @allow_accounts = opts.fetch(:allow_accounts, nil)
-    @deny_accounts = opts.fetch(:deny_accounts, [])
+
+    allow_accounts = opts.fetch(:allow_accounts, nil)
+    @allow_accounts = if allow_accounts.nil?
+                        nil
+                      else
+                        allow_accounts.compact.map { |acct| upcase_accounts? ? acct.to_s.upcase : acct }
+                      end
+
+    @deny_accounts = opts.fetch(:deny_accounts, []).compact.map do |acct|
+      upcase_accounts? ? acct.to_s.upcase : acct
+    end
   end
 
   def to_h

data/lib/ood_core/job/script.rb

@@ -77,6 +77,7 @@ module OodCore
       # Name of the queue the job should be submitted to
       # @return [String, nil] queue name
       attr_reader :queue_name
+      alias queue queue_name
 
       # The scheduling priority for the job
       # @return [Integer, nil] scheduling priority

data/lib/ood_core/version.rb

@@ -1,4 +1,4 @@
 module OodCore
   # The current version of {OodCore}
-  VERSION = "0.23.0"
+  VERSION = "0.23.1"
 end

data/lib/ood_core.rb

@@ -3,6 +3,7 @@ require "ood_core/errors"
 require "ood_core/cluster"
 require "ood_core/clusters"
 require "ood_core/invalid_cluster"
+require "ood_core/data_formatter"
 
 # The main namespace for ood_core
 module OodCore

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ood_core
 version: !ruby/object:Gem::Version
-  version: 0.23.0
+  version: 0.23.1
 platform: ruby
 authors:
 - Eric Franz
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-01-18 00:00:00.000000000 Z
+date: 2023-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ood_support
@@ -176,6 +176,7 @@ files:
 - lib/ood_core/batch_connect/templates/vnc_container.rb
 - lib/ood_core/cluster.rb
 - lib/ood_core/clusters.rb
+- lib/ood_core/data_formatter.rb
 - lib/ood_core/errors.rb
 - lib/ood_core/invalid_cluster.rb
 - lib/ood_core/job/account_info.rb