onsip 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d5ffa2969c5d39aabe9a642a0c1750e51281b779
-  data.tar.gz: 1e8224eb20ded09405509b34b3cc120a666e792d
+  metadata.gz: 0f35faf9732e0810a53019559d0efdab7f3d1372
+  data.tar.gz: 842964aec5a4bf1302eee9bc83f90bbc2276c8b1
 SHA512:
-  metadata.gz: d2f165754d8602f33a43042c24abfcead864b2c359cf5aa9e5fbbdba0b717ddc99aa26eebbe608dbb3b5c0aa98d48316f24efdaa519184e93e0dfae24493a2c5
-  data.tar.gz: be1ef2e3bc9486836c081695552fc3d086fbd709c587f0a91d45a726e359f006217f70e2d215fcbddde69e64f790196256fe3dc955f0a660b29e58d92b804118
+  metadata.gz: 0999e314646a8791ac4abe056b0862bc9a3ba2a306226f6611124fbf3489c34c8f0891761f69c3af03b09d3d4c3acba1b156c1bd42e5d8e6f0ac6fbb6ab04dd1
+  data.tar.gz: 0467ead20edf69c833371c4555f8a1a35084a2e0ad23712d83c79e5ce28ae6de36a555b5e95d3e045f200f0263805d579d9c7d060f5c8ece3cadbeb1e0fade5f

data/lib/onsip/version.rb

@@ -1,3 +1,3 @@
 module OnSIP
-  VERSION = '0.1.4'
+  VERSION = '0.1.5'
 end

data/spec/lib/onsip/models/user_spec.rb

@@ -19,8 +19,16 @@ describe OnSIP::User do
   end
 
   describe "add" do
+    fail_body = {"Response"=> {"Context"=> {"Action"=>{"IsCompleted"=>"false"}, "Request"=> {"IsValid"=>"false", "DateTime"=>"2015-06-01T18:45:16+00:00", "Duration"=>"38", "Parameters"=> {"Parameter"=> [{"Name"=>"Action", "Value"=>"UserAdd"}, {"Name"=>"AuthUsername", "Value"=>"foobar888_firertc"}, {"Name"=>"Domain", "Value"=>"sip.devel.firertc.com"}, {"Name"=>"Email", "Value"=>"onsip+foobar888@icehook.com"}, {"Name"=>"Name", "Value"=>{}}, {"Name"=>"OrganizationId", "Value"=>"42975"}, {"Name"=>"Output", "Value"=>"json"}, {"Name"=>"Password", "Value"=>"******"}, {"Name"=>"PasswordConfirm", "Value"=>"******"}, {"Name"=>"SessionId", "Value"=>"ak7gllnq56e0soiebn23h9rlu3"}, {"Name"=>"Username", "Value"=>"foobar888"}]}, "Errors"=>{"Error"=>{"Parameter"=>"Username", "Code"=>"Address.Unavailable", "Message"=>"This address is already in use, is reserved, or is otherwise unavailable for use."}}}, "Session"=>{"IsEstablished"=>"true", "SessionId"=>"ak7gllnq56e0soiebn23h9rlu3", "UserId"=>"282881", "Roles"=>{"Role"=>{"Name"=>"Account Admin"}}}}}}.to_json
     add_body = {"Response"=>{"Context"=>{"Action"=>{ "IsCompleted"=>"true" },"Request"=>{"IsValid"=>"true","DateTime"=>"2014-04-21T16:19:55+00:00","Duration"=>"165","Parameters"=>{"Parameter"=>[{"Name"=>"Action","Value"=>"UserAdd"},{"Name"=>"SessionId","Value"=>"thqqva0i6jp3ea1ved17shcdg7"},{"Name"=>"OrganizationId","Value"=>"25018"},{"Name"=>"Username","Value"=>"docs"},{"Name"=>"Domain","Value"=>"example.onsip.com"},{"Name"=>"Name","Value"=>"Docs"},{"Name"=>"Email","Value"=>"docs@example.onsip.com"},{"Name"=>"AuthUsername","Value"=>"example"},{"Name"=>"Password","Value"=>"******"},{"Name"=>"PasswordConfirm","Value"=>"******"},{"Name"=>"Role","Value"=>"User"}]}},"Session"=>{"IsEstablished"=>"true","SessionId"=>"thqqva0i6jp3ea1ved17shcdg7","UserId"=>"152255","Roles"=>{"Role"=>{ "Name"=>"Account Admin" }}}},"Result"=>{"UserAdd"=>{"User"=>{"UserId"=>"218339","OrganizationId"=>"25018","AccountId"=>"22543","Flags"=>"0","Status"=>"enabled","Domain"=>"example.onsip.com","Username"=>"example","Password"=>"QPD2MLQhdaHB2hBW","AuthUsername"=>"example","Modified"=>"2014-04-21T16:19:55+00:00","Created"=>"2014-04-21T16:19:55+00:00","Ack911"=>"1970-01-01T00:00:00+00:00","SurveyCompleted"=>"1970-01-01T00:00:00+00:00","AckTrunkingTerms"=>"1970-01-01T00:00:00+00:00","AckTrunkingE911"=>"1970-01-01T00:00:00+00:00","AckHostedTerms"=>"1970-01-01T00:00:00+00:00","AckHostedE911"=>"1970-01-01T00:00:00+00:00","ExtendedDialing"=>"false","PSTNForwarding"=>"false","E911Provisioning"=>"false","PSTNTrunking"=>"false","FreePSTNTrunking"=>"false","BusyLampField"=>"false","Contact"=>{"Name"=>"Docs","Organization"=>"example","Address"=>"55 broad street","City"=>"Brooklyn","State"=>"NY","Zipcode"=>"11201","Country"=>"United States of America","CountryId"=>"207","Phone"=>"1-555-555-5555","Email"=>"docs@example.onsip.com","Modified"=>"2014-04-21T16:19:55+00:00"},"Roles"=>{"Role"=>{ "Name"=>"User" }}}}}}}.to_json
     before {
+      stub_request(:get, Regexp.new("http://addfail.onsip.com/api?.*UserAdd.*"))
+      .to_return({
+        :body => fail_body,
+        :status => 200,
+        :headers => { 'Content-Type' => 'application/json; charset=utf-8' }
+        })
+
       stub_request(:get, Regexp.new("http://add.onsip.com/api?.*UserAdd.*"))
       .to_return({
         :body => add_body,
@@ -29,8 +37,7 @@ describe OnSIP::User do
         })
     }
 
-
-    it "with valid orgnization and attrs" do
+    it "should add with valid orgnization and attrs" do
       OnSIP.connect('http://add.onsip.com')
       org = OnSIP::Organization.new
       attrs = {
@@ -47,6 +54,24 @@ describe OnSIP::User do
       user = OnSIP::User.add(org, attrs)
       expect(user.class).to eq OnSIP::User
     end
+
+    it "should not add without valid orgnization and attrs" do
+      OnSIP.connect('http://addfail.onsip.com')
+      org = OnSIP::Organization.new
+      attrs = {
+        'SessionId' => 'thqqva0i6jp3ea1ved17shcdg7',
+        'OrganizationId' => '2501',
+        'Username' => 'docs',
+        'Domain' => 'example.onsip.com',
+        'Name' => 'Docs',
+        'Email' => 'docs@example.onsip.com',
+        'AuthUsername' => 'example',
+        'Password' => 'mysuperpassword',
+        'PasswordConfirm' => 'mysuperpassword'
+      }
+      expect { OnSIP::User.add(org, attrs) }.to raise_error(OnSIP::Exceptions::OnSIPRequestError) 
+
+    end
   end
 
 end

data/spec/lib/onsip/session_spec.rb

@@ -3,6 +3,8 @@ require 'spec_helper'
 describe OnSIP::Session do
   before :each do
 
+    # {"Response"=>{"Context"=>{"Action"=>{"IsCompleted"=>"false"}, "Request"=>{"IsValid"=>"true", "DateTime"=>"2014-12-04T20:07:08+00:00", "Duration"=>"8", "Parameters"=>{"Parameter"=>[{"Name"=>"Action", "Value"=>"SessionCreate"}, {"Name"=>"Output", "Value"=>"json"}, {"Name"=>"Password", "Value"=>"7onsip6"}, {"Name"=>"Username", "Value"=>"klarrimore@icehook.com"}]}, "Errors"=>{"Error"=>{"Parameter"=>"Action", "Code"=>"Accessor.LoginLocked", "Message"=>"You have failed to log in too many times. Please wait 10 minutes then try again."}}}, "Session"=>{"IsEstablished"=>"false"}}}}
+    
     body = {"Response"=>{"Context"=>{"Action"=>{"IsCompleted"=>"true"}, "Request"=>{"IsValid"=>"true", "DateTime"=>"2014-12-04T17:39:53+00:00", "Duration"=>"30", "Parameters"=>{"Parameter"=>[{"Name"=>"Action", "Value"=>"SessionCreate"}, {"Name"=>"Output", "Value"=>"json"}, {"Name"=>"Password", "Value"=>"******"}, {"Name"=>"Username", "Value"=>"icehook"}]}}, "Session"=>{"IsEstablished"=>"true", "SessionId"=>"j2vtu1bk7rsdpklofplu07ocq1", "UserId"=>"212762", "Roles"=>{"Role"=>{"Name"=>"Account Admin"}}}}, "Result"=>{"SessionCreate"=>{}}}}.to_json
     stub_request(:get, Regexp.new('http://api.onsip.com/api?.*SessionCreate.*'))
     .to_return({
@@ -27,5 +29,3 @@ describe OnSIP::Session do
   end
 
 end
-
-# {"Response"=>{"Context"=>{"Action"=>{"IsCompleted"=>"false"}, "Request"=>{"IsValid"=>"true", "DateTime"=>"2014-12-04T20:07:08+00:00", "Duration"=>"8", "Parameters"=>{"Parameter"=>[{"Name"=>"Action", "Value"=>"SessionCreate"}, {"Name"=>"Output", "Value"=>"json"}, {"Name"=>"Password", "Value"=>"7onsip6"}, {"Name"=>"Username", "Value"=>"klarrimore@icehook.com"}]}, "Errors"=>{"Error"=>{"Parameter"=>"Action", "Code"=>"Accessor.LoginLocked", "Message"=>"You have failed to log in too many times. Please wait 10 minutes then try again."}}}, "Session"=>{"IsEstablished"=>"false"}}}}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: onsip
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Keith Larrimore
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-02 00:00:00.000000000 Z
+date: 2015-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -336,7 +336,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: OnSIP ruby client.
@@ -352,3 +352,4 @@ test_files:
 - spec/lib/onsip/session_spec.rb
 - spec/spec_helper.rb
 - spec/support/helpers.rb
+has_rdoc: