onlinepayments-sdk-ruby 8.2.0 → 8.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2c1812c5895b2a6d8893f0e57882b6de4106db352bcc4298c0da32da05530b68
-  data.tar.gz: 794085eb6a33b45b3663ee688f0249493107268fd448b42d59a551eaa42e33bb
+  metadata.gz: 378706048437fe7e8f9ea357cd95453cf63057a5552c5353c8df544a36bf9d7f
+  data.tar.gz: 6d7dbeb85ba5f49cdc6810f805dba3963520f7156195355744689ca7434f3f49
 SHA512:
-  metadata.gz: cb7f8523c051ff997ee7fdf1879c34d2bbe8ef81c52e781a840a46cdb34412a2377d0892bafe127739d2c3e47d23250e197637168201c8215dec606aed58e0a6
-  data.tar.gz: 0ef5ea22f7aeddf9cef5e10b51f2ee2dc4d452bd67eb767692b68898bd7f3e8e469509934421ad068c49f87e7822a2ec41a44680a8becb97fc9735394f4b1f45
+  metadata.gz: 8464617165ab9034463822c009b555bc9bcc1fa09dcc67f5c6e9edcff0ea8fd51a1b7380b6ebb0e466b01f503cb8718a7445a15dec4c459322cf1b6ba2fbe1d2
+  data.tar.gz: 30447d3611f81c1ed8dc20e8467761be89d7853cf45878ada4a8c2fb2f102b241bb5a0cb6f58c5d8f431db6134d4d98e7e978e14b7ddc508c861cba0802155bd

data/lib/onlinepayments/sdk/communication/metadata_provider.rb

@@ -13,7 +13,7 @@ module OnlinePayments
       class MetadataProvider
         private
 
-        SDK_VERSION = '8.2.0'.freeze
+        SDK_VERSION = '8.2.1'.freeze
         SERVER_META_INFO_HEADER = 'X-GCS-ServerMetaInfo'.freeze
         PROHIBITED_HEADERS = [SERVER_META_INFO_HEADER, 'X-GCS-Idempotence-Key', 'Date', 'Content-Type', 'Authorization'].sort!.freeze
         CHARSET = 'utf-8'.freeze

data/lib/onlinepayments/sdk/communication/not_found_exception.rb

@@ -8,7 +8,7 @@ module OnlinePayments
       class NotFoundException < RuntimeError
 
         def initialize(cause, message = nil)
-          super(message)
+          super(message.nil? ? cause.to_s : message)
           @cause = cause
         end
 

data/lib/onlinepayments/sdk/communication/response_exception.rb

@@ -14,12 +14,9 @@ module OnlinePayments
           super('the Online Payments platform returned an error response')
           @status_code = status_code
           @headers = if headers.nil? or headers.empty?
-                       {}
+                       []
                      else
-                       headers.inject({}) do |hash, header|
-                         hash[header.name.downcase.to_sym] = header.dup.freeze
-                         hash
-                       end
+                       headers.map { |h| h.dup.freeze }
                      end.freeze
           @body = body
         end

data/lib/onlinepayments/sdk/communication/response_header.rb

@@ -51,8 +51,8 @@ module OnlinePayments
         def self.get_disposition_filename(headers)
           header_value = get_header_value(headers, "Content-Disposition")
           unless header_value.nil?
-            if header_value =~ /(?:^|;)\s*filename\s*=\s*(.*?)\s*(?:;|$)i/
-              return trim_quotes($2)
+            if header_value =~ /(?:^|;)\s*filename\s*=\s*(.*?)\s*(?:;|$)/i
+              return trim_quotes($1)
             end
           end
 
@@ -63,10 +63,10 @@ module OnlinePayments
 
         # Trims the single or double quotes at the beginning and end of parameter _filename_ if they exist
         # If they don't exist, it returns the original _filename_ instead
-        def trim_quotes(filename)
+        def self.trim_quotes(filename)
           unless filename.length < 2
-            if (filename.chars.first == '\'' && filename.chars.last == '\"') ||
-              (filename.chars.first == '"' && filename.chars.last == '"')
+            if (filename.chars.first == '\'' && filename.chars.last == '\'') ||
+               (filename.chars.first == '"' && filename.chars.last == '"')
               return filename[1...-1]
             end
           end

data/lib/onlinepayments/sdk/communicator.rb

@@ -42,12 +42,12 @@ module OnlinePayments
         raise ArgumentError.new('connection is required') unless connection
         raise ArgumentError.new('authenticator is required') unless authenticator
         raise ArgumentError.new('metadata_provider is required') unless metadata_provider
-        raise ArgumentError('marshaller is required') if marshaller.nil?
+        raise ArgumentError.new('marshaller is required') if marshaller.nil?
 
         uri = URI(api_endpoint)
-        raise RuntimeError('api_endpoint should not contain a path') unless uri.path.nil? || uri.path.empty?
+        raise RuntimeError.new('api_endpoint should not contain a path') unless uri.path.nil? || uri.path.empty?
         unless uri.userinfo.nil? && uri.query.nil? && uri.fragment.nil?
-          raise RuntimeError('api_endpoint should not contain user info, query or fragment')
+          raise RuntimeError.new('api_endpoint should not contain user info, query or fragment')
         end
         @api_endpoint = uri
         @connection = connection
@@ -499,7 +499,7 @@ module OnlinePayments
 
       def throw_exception_if_necessary(body, status_code, headers, request_path)
         if status_code < 200 || status_code >= 300
-          if !body.nil? && !is_json(headers)
+          if !body.nil? && !body.empty? && !is_json(headers)
             cause = Communication::ResponseException.new(status_code, headers, body)
             if status_code == 404
               raise Communication::NotFoundException.new(cause, 'The requested resource was not found; invalid path: ' +

data/lib/onlinepayments/sdk/domain/uploadable_file.rb

@@ -13,9 +13,9 @@ module OnlinePayments
       class UploadableFile
 
         def initialize(file_name, content, content_type, content_length = -1)
-          raise ArgumentError.new("file_name is required") if file_name.nil? or !file_name.strip
+          raise ArgumentError.new("file_name is required") if file_name.nil? || file_name.strip.empty?
           raise ArgumentError.new("content is required") if content.nil?
-          raise ArgumentError.new("content_type is required") if content_type.nil? or !content_type.strip
+          raise ArgumentError.new("content_type is required") if content_type.nil? || content_type.strip.empty?
 
           @file_name = file_name
           @content = content

data/lib/onlinepayments/sdk/exception_factory.rb

@@ -36,6 +36,7 @@ module OnlinePayments
       if error_object.is_a?(OnlinePayments::SDK::Domain::ProblemDetailsResponse)
         return ProblemDetailsException.new(status_code, response_body, error_object)
       end
+      return ApiException.new(status_code, response_body, nil, nil) if error_object.nil?
       raise ArgumentError.new("unsupported error object type: " + error_object.class.name) unless error_object.is_a?(OnlinePayments::SDK::Domain::ErrorResponse)
       create_exception_from_response_fields(status_code, response_body, error_object.error_id, error_object.errors, context)
     end

data/lib/onlinepayments/sdk/json/default_marshaller.rb

@@ -12,16 +12,13 @@ module OnlinePayments
 
         # Marshals the _request_object_ to a JSON string using request_object#to_h
         def marshal(request_object)
+          return 'null' if request_object.nil?
           ::JSON.pretty_generate(request_object.to_h)
         end
 
         # Unmarshals a JSON string into an object of type _klass_ using klass.new_from_hash
         def unmarshal(json_string, klass)
-          if json_string.nil?
-            return nil
-          elsif json_string.length == 0
-            return ''
-          end
+          return nil if json_string.nil? || json_string.empty?
           if klass.respond_to?(:new_from_hash)
             klass.new_from_hash(::JSON.load(json_string))
           else

data/lib/onlinepayments/sdk/logging/request_log_message_builder.rb

@@ -36,13 +36,12 @@ module OnlinePayments
         private
 
         def format_uri
-          '' unless @uri && @uri.path
+          return '' unless @uri && @uri.path
           if @uri.query.nil?
             @uri.path
           else
-            "#{@uri.path}?#{@uri.query}" unless @uri.query.nil?
+            "#{@uri.path}?#{@uri.query}"
           end
-          # @uri.path + '?' + empty_if_null(@uri.query)
         end
       end
     end

data/lib/onlinepayments/sdk/webhooks/signature_validation_exception.rb

@@ -10,7 +10,9 @@ module OnlinePayments
         # @option args [String] :message the error message
         # @option args [RuntimeError] :cause an Error object that causes the Exception
         def initialize(args)
-          super(args[:message]) # NOTE: can be nil
+          msg = args[:message]
+          msg = args[:cause].to_s if msg.nil? && !args[:cause].nil?
+          super(msg)
           # store backtrace info if exception given
           set_backtrace(args[:cause].backtrace) unless args[:cause].nil?
         end

data/onlinepayments-sdk-ruby.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name           = 'onlinepayments-sdk-ruby'
-  spec.version        = '8.2.0'
+  spec.version        = '8.2.1'
   spec.authors        = ['Worldline Direct support team']
   spec.email          = ['82139942+worldline-direct-support-team@users.noreply.github.com']
   spec.summary        = %q{SDK to communicate with the Online Payments platform using the Online Payments Server API}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onlinepayments-sdk-ruby
 version: !ruby/object:Gem::Version
-  version: 8.2.0
+  version: 8.2.1
 platform: ruby
 authors:
 - Worldline Direct support team