online_migrations 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46406fc60e15af6b4dfec0d548c6ca04f9dc3572eb544046e45f2dbd58cbf2eb
-  data.tar.gz: f969563b52c1dac70ede26c9a5bd2094295e93d5fc61e85056adec6b3b22fa69
+  metadata.gz: 9bfe87b009fa9199b4deb0a1bf7e63dac043fa8f29c25f4f93c55fd136155f2d
+  data.tar.gz: 0a95c4b4de358769bce7d3855f7df67c08d027279b523d0ea550a383b60cd6a8
 SHA512:
-  metadata.gz: a7e728653580b3a1635b895c4b6efba8425f300a5a239ad8dd0f07cce06503e1f1a994597535c05b4946444c97f6f210c51ece0796799ac7fa8744ff93c1d48c
-  data.tar.gz: 917fc0a780b7bba7050b65c9cdcd1b5544afb87133078cdf833863b892459bc69ae657a365dd72bd5fd856a0a63a3862a4e19e3f9cd282c252a4a60b9415c19b
+  metadata.gz: 95b0d869484b407b295426bf1b836f00ce71c297fc1ef35fe817e449f126ccbc7e7df512efc30c16cda9dfb9755c86e1b409f9787f40708341aba422128b0d60
+  data.tar.gz: 42b829796b7fd0503416460775ac1c7596fce43621667a9144cd06b9000e35f8054398cadbf82f370b3e8ca988bcd7ce53b505982e8e5b3ed7e6991c71f373aa

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## master (unreleased)
 
+## 0.8.1 (2023-08-04)
+
+- Fix `update_columns_in_batches` when multiple columns are passed
+- Fix reverting adding/removing not null and text limit constraints
+
 ## 0.8.0 (2023-07-24)
 
 - Add check for `change_column_default`

data/lib/online_migrations/command_recorder.rb

@@ -47,6 +47,7 @@ module OnlineMigrations
           record(:"#{method}", args, &block)  #   record(:create_table, args, &block)
         end                                   # end
       RUBY
+      ruby2_keywords(method) if respond_to?(:ruby2_keywords, true)
     end
 
     private
@@ -130,28 +131,21 @@ module OnlineMigrations
       end
 
       def invert_add_not_null_constraint(args)
-        options = args.extract_options!
-        table_name, column = args
-        options.delete(:validate)
-        [:remove_not_null_constraint, [table_name, column, **options]]
+        args.last.delete(:validate) if args.last.is_a?(Hash)
+        [:remove_not_null_constraint, args]
       end
 
       def invert_add_text_limit_constraint(args)
-        options = args.extract_options!
-        table_name, column, _limit = args
-        options.delete(:validate)
-        [:remove_text_limit_constraint, [table_name, column, **options]]
+        args.last.delete(:validate) if args.last.is_a?(Hash)
+        [:remove_text_limit_constraint, args]
       end
 
       def invert_remove_text_limit_constraint(args)
-        options = args.extract_options!
-        table_name, column, limit = args
-
-        unless limit
+        unless args[2]
           raise ActiveRecord::IrreversibleMigration, "remove_text_limit_constraint is only reversible if given a limit."
         end
 
-        [:add_text_limit_constraint, [table_name, column, limit, **options]]
+        [:add_text_limit_constraint, args]
       end
   end
 end

data/lib/online_migrations/schema_statements.rb

@@ -89,11 +89,15 @@ module OnlineMigrations
         # Ignore subqueries in conditions
         unless value.is_a?(Arel::Nodes::SqlLiteral) && value.to_s =~ /select\s+/i
           arel_column = model.arel_table[column_name]
-          arel_column.not_eq(value).or(arel_column.eq(nil))
+          if value.nil?
+            arel_column.not_eq(nil)
+          else
+            arel_column.not_eq(value).or(arel_column.eq(nil))
+          end
         end
       end.compact
 
-      batch_relation = model.where(conditions.inject(:and))
+      batch_relation = model.where(conditions.inject(:or))
       batch_relation = yield batch_relation if block_given?
 
       iterator = BatchIterator.new(batch_relation)

data/lib/online_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OnlineMigrations
-  VERSION = "0.8.0"
+  VERSION = "0.8.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: online_migrations
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - fatkodima
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-07-24 00:00:00.000000000 Z
+date: 2023-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord