online_migrations 0.5.2 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5f0ae9026f83b836b520090730426b5cf93fe18e193f21ea28cd11b96ebb78a8
-  data.tar.gz: 939595b3b732d6351fbab4403f0271e47a2c42b770a9732e30cdc0f52479ce7b
+  metadata.gz: 0ac8a2eb2657fcc3536a9b56d16298f90f8e1a5e626ba52a6e9703b5bcaa7df0
+  data.tar.gz: c5357f94854fb43d1b8404ed9dcfafc2178430aeb9c6d69555f50629a94da3bd
 SHA512:
-  metadata.gz: d09f3b4a3592cada77cf27e152669d6c94e5bd15e3c2930aa18c6ca6de6cd3c0e588314e95cd7cb058e43fea22343c8529ed7c2a11ec60d247ce6479bce58374
-  data.tar.gz: 42185f369b8adb87c10c2e0cfb29891784d3b55bd0c41cc3b92804fb0d8f71d9b70f4349b26a5752ff1f6b9d8ebbdbc061667157d6b1023190907104f71e93b1
+  metadata.gz: 4ccbc274c76ab01f8ece559b3fee27c1c5c0c495225b393c3a4afb7941f0b61d3aab9ef2885195be78ed00f29bd5e6b18e3fe0cb044b745cd791aacf34283492
+  data.tar.gz: 04fb250e30e7620ac1bd06fddf24a5fdfe616f285422e47e19423e23be0c8117e57d45e45029a2e1212cc5e6ad9baf3605fac8b038152fdc73b2d9a818ba211c

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 ## master (unreleased)
 
+## 0.5.3 (2022-11-10)
+
+- Fix removing index by name
+- Fix multiple databases support for `start_after` and `target_version` configs
+- Fix error when `Rails` defined without `Rails.env`
+- Improve error message for adding column with a NULL default for PostgreSQL < 11
+
 ## 0.5.2 (2022-10-04)
 
 - Fix sequence resetting in tests that use fixtures

data/lib/online_migrations/command_checker.rb

@@ -177,10 +177,15 @@ module OnlineMigrations
         if !new_or_small_table?(table_name) && options.key?(:default) &&
            (postgresql_version < Gem::Version.new("11") || (!default.nil? && (volatile_default = Utils.volatile_default?(connection, type, default))))
 
-          raise_error :add_column_with_default,
-            code: command_str(:add_column_with_default, table_name, column_name, type, options),
-            not_null: options[:null] == false,
-            volatile_default: volatile_default
+          if default.nil?
+            raise_error :add_column_with_default_null,
+              code: command_str(:add_column, table_name, column_name, type, options.except(:default))
+          else
+            raise_error :add_column_with_default,
+              code: command_str(:add_column_with_default, table_name, column_name, type, options),
+              not_null: options[:null] == false,
+              volatile_default: volatile_default
+          end
         end
 
         if type == :json

data/lib/online_migrations/config.rb

@@ -185,7 +185,7 @@ module OnlineMigrations
       @small_tables = []
       @check_down = false
       @enabled_checks = @error_messages.keys.map { |k| [k, {}] }.to_h
-      @verbose_sql_logs = defined?(Rails) && Rails.env.production?
+      @verbose_sql_logs = defined?(Rails.env) && Rails.env.production?
     end
 
     def lock_retrier=(value)
@@ -262,17 +262,13 @@ module OnlineMigrations
     private
       def ensure_supports_multiple_dbs
         unless Utils.supports_multiple_dbs?
-          raise "Multiple databases are not supported by this ActiveRecord version"
+          raise "OnlineMigrations does not support multiple databases for Active Record < 6.1"
         end
       end
 
       def db_config_name
         connection = OnlineMigrations.current_migration.connection
-        if Utils.ar_version < 6.1
-          connection.pool.spec.name
-        else
-          connection.pool.db_config.name
-        end
+        connection.pool.db_config.name
       end
   end
 end

data/lib/online_migrations/error_messages.rb

@@ -74,6 +74,16 @@ class <%= migration_name %> < <%= migration_parent %>
 end
 <% end %>",
 
+      add_column_with_default_null:
+"Adding a column with a null default blocks reads and writes while the entire table is rewritten.
+Instead, add the column without a default value.
+
+class <%= migration_name %> < <%= migration_parent %>
+  def change
+    <%= code %>
+  end
+end",
+
       add_column_json:
 "There's no equality operator for the json column type, which can cause errors for
 existing SELECT DISTINCT queries in your application. Use jsonb instead.

data/lib/online_migrations/schema_statements.rb

@@ -689,7 +689,18 @@ module OnlineMigrations
       index_name = options[:name]
       index_name ||= index_name(table_name, column_names)
 
-      if index_exists?(table_name, column_names, **options)
+      index_exists =
+        if Utils.ar_version <= 5.0
+          # Older Active Record is unable to handle blank columns correctly in `index_exists?`,
+          # so we need to use `index_name_exists?`.
+          index_name_exists?(table_name, index_name, nil)
+        elsif Utils.ar_version <= 6.0
+          index_name_exists?(table_name, index_name)
+        else
+          index_exists?(table_name, column_names, **options)
+        end
+
+      if index_exists
         disable_statement_timeout do
           # "DROP INDEX CONCURRENTLY" requires a "SHARE UPDATE EXCLUSIVE" lock.
           # It only conflicts with constraint validations, other creating/removing indexes,
@@ -932,7 +943,7 @@ module OnlineMigrations
       def __index_column_names(column_names)
         if column_names.is_a?(String) && /\W/.match(column_names)
           column_names
-        else
+        elsif column_names.present?
           Array(column_names)
         end
       end

data/lib/online_migrations/utils.rb

@@ -9,7 +9,7 @@ module OnlineMigrations
       end
 
       def developer_env?
-        defined?(Rails) && (Rails.env.development? || Rails.env.test?)
+        defined?(Rails.env) && (Rails.env.development? || Rails.env.test?)
       end
 
       def say(message)
@@ -26,7 +26,9 @@ module OnlineMigrations
       end
 
       def supports_multiple_dbs?
-        ar_version >= 6.0
+        # Technically, Active Record 6.0+ supports multiple databases,
+        # but we can not get the database spec name for this version.
+        ar_version >= 6.1
       end
 
       def migration_parent

data/lib/online_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OnlineMigrations
-  VERSION = "0.5.2"
+  VERSION = "0.5.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: online_migrations
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - fatkodima
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-04 00:00:00.000000000 Z
+date: 2022-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -101,7 +101,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Catch unsafe PostgreSQL migrations in development and run them easier in