online_migrations 0.36.0 → 0.36.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6740adaa6d20273e8d148e8e0788a6e27c6c6701187fe60e006ff3ba8e2129d2
-  data.tar.gz: 445a3ef72888dd358cc5d917ca31de7499df3368797c9c73324704e0e2d8307a
+  metadata.gz: c3d28d3f9893b7c26240f94069032fa65ede6b14a1fb79b8c205111b8eedd934
+  data.tar.gz: da807a14d87705650c05bb7d3151129c534a3c50344b60d0e8e865cdecaa04b5
 SHA512:
-  metadata.gz: 338cf3a26b64efb827b5691addc67987048e0522f467d89c5ff4a18494f6b0e3cbeb93513e419a01b04be643d9f7e7a36c1aaf1b0a9d7f5c8158ecff1eb315e7
-  data.tar.gz: 4a6b9282a87124e037b3f101a5856d4a8756e86f9fb5b8bf3a4e42e7e2790e0edbd78b7263b8e9c653bedc25700d8a3fb8ade671e2f99e1e74dbfd49780c20eb
+  metadata.gz: e8101340c889e837247992f15201b6d1065ae9ea00493f245aad1fe092a7dd2def02965882a5cd29acb9af21504959fd8bbfd95c0f48f911af284ae8fa87baee
+  data.tar.gz: 916c40fec0d7bfe7d08d7402e13ad2b56989921074f566474aeef0280579064ea92377a5b621c427b64205ecf098f3868c104be5772e3a5dd76b68a76f1a16e0

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## master (unreleased)
 
+## 0.36.1 (2026-09-23)
+
+- Fix compatibility with future Rails 8.2
+- Fix pausing already paused background data migrations
+
 ## 0.36.0 (2026-07-20)
 
 - Serialize to JSON `cursor` value for background data migrations

data/lib/online_migrations/background_data_migrations/migration.rb

@@ -177,12 +177,12 @@ module OnlineMigrations
         true
       end
 
-      # Pause this data migration. No-op if migration is completed.
+      # Pause this data migration. No-op if migration is completed or already paused.
       #
       # @return [Boolean] whether this data migration was paused.
       #
       def pause
-        return false if completed?
+        return false if paused? || completed?
 
         if pending? || enqueued? || delayed? || stuck? || errored?
           paused!

data/lib/online_migrations/command_recorder.rb

@@ -153,4 +153,157 @@ module OnlineMigrations
         [:add_text_limit_constraint, args]
       end
   end
+
+  # @private
+  # New format was introduced in https://github.com/rails/rails/pull/58239.
+  module CommandRecorder82
+    REVERSIBLE_AND_IRREVERSIBLE_METHODS = [
+      :update_column_in_batches,
+      :initialize_column_rename,
+      :initialize_columns_rename,
+      :revert_initialize_column_rename,
+      :revert_initialize_columns_rename,
+      :finalize_column_rename,
+      :finalize_columns_rename,
+      :revert_finalize_column_rename,
+      :revert_finalize_columns_rename,
+      :initialize_table_rename,
+      :revert_initialize_table_rename,
+      :finalize_table_rename,
+      :revert_finalize_table_rename,
+      :swap_column_names,
+      :add_column_with_default,
+      :add_not_null_constraint,
+      :remove_not_null_constraint,
+      :add_text_limit_constraint,
+      :remove_text_limit_constraint,
+      :add_reference_concurrently,
+      :change_column_type_in_background,
+      :enqueue_background_data_migration,
+      :remove_background_data_migration,
+
+      # column type change helpers
+      :initialize_column_type_change,
+      :initialize_columns_type_change,
+      :revert_initialize_column_type_change,
+      :revert_initialize_columns_type_change,
+      :backfill_column_for_type_change,
+      :backfill_columns_for_type_change,
+      :finalize_column_type_change,
+      :finalize_columns_type_change,
+      :revert_finalize_column_type_change,
+      :cleanup_column_type_change,
+      :cleanup_columns_type_change,
+    ]
+
+    REVERSIBLE_AND_IRREVERSIBLE_METHODS.each do |method|
+      class_eval <<-RUBY, __FILE__, __LINE__ + 1
+        def #{method}(*args, **kwargs, &block)          # def create_table(*args, **kwargs, &block)
+          record(:"#{method}", args, kwargs, &block)    #   record(:create_table, args, kwargs, &block)
+        end                                             # end
+      RUBY
+    end
+
+    private
+      module StraightReversions
+        {
+          initialize_column_rename:           :revert_initialize_column_rename,
+          initialize_columns_rename:          :revert_initialize_columns_rename,
+          finalize_column_rename:             :revert_finalize_column_rename,
+          finalize_columns_rename:            :revert_finalize_columns_rename,
+          initialize_table_rename:            :revert_initialize_table_rename,
+          finalize_table_rename:              :revert_finalize_table_rename,
+          add_not_null_constraint:            :remove_not_null_constraint,
+          initialize_column_type_change:      :revert_initialize_column_type_change,
+          initialize_columns_type_change:     :revert_initialize_columns_type_change,
+          finalize_column_type_change:        :revert_finalize_column_type_change,
+          finalize_columns_type_change:       :revert_finalize_columns_type_change,
+        }.each do |cmd, inv|
+          [[inv, cmd], [cmd, inv]].each do |method, inverse|
+            class_eval <<-RUBY, __FILE__, __LINE__ + 1
+              def invert_#{method}(args, kwargs, &block)    # def invert_create_table(args, kwargs, &block)
+                [:#{inverse}, args, kwargs, block]          #   [:drop_table, args, kwargs, block]
+              end                                           # end
+            RUBY
+          end
+        end
+      end
+
+      include StraightReversions
+
+      def invert_add_reference_concurrently(args, kwargs)
+        [:remove_reference, args, kwargs]
+      end
+
+      def invert_swap_column_names(args, kwargs)
+        table_name, column1, column2 = args
+        [:swap_column_names, [table_name, column2, column1], kwargs]
+      end
+
+      def invert_add_column_with_default(args, kwargs)
+        table_name, column_name, = args
+        [:remove_column, [table_name, column_name], kwargs]
+      end
+
+      def invert_revert_initialize_column_rename(args, kwargs)
+        _table, column, new_column = args
+        if !column || !new_column
+          raise ActiveRecord::IrreversibleMigration,
+            "revert_initialize_column_rename is only reversible if given a column and new_column."
+        end
+        [:initialize_column_rename, args, kwargs]
+      end
+
+      def invert_revert_initialize_columns_rename(args, kwargs)
+        _table, old_new_column_hash = args
+        if !old_new_column_hash
+          raise ActiveRecord::IrreversibleMigration,
+            "revert_initialize_columns_rename is only reversible if given a hash of old and new columns."
+        end
+        [:initialize_columns_rename, args, kwargs]
+      end
+
+      def invert_finalize_table_rename(args, kwargs)
+        _table_name, new_name = args
+        if !new_name
+          raise ActiveRecord::IrreversibleMigration,
+            "finalize_table_rename is only reversible if given a new_name."
+        end
+        [:revert_finalize_table_rename, args, kwargs]
+      end
+
+      def invert_revert_initialize_column_type_change(args, kwargs)
+        if !args[2]
+          raise ActiveRecord::IrreversibleMigration,
+            "revert_initialize_column_type_change is only reversible if given a new_type."
+        end
+        super
+      end
+
+      def invert_revert_initialize_columns_type_change(args, kwargs)
+        if args[1].empty?
+          raise ActiveRecord::IrreversibleMigration,
+            "revert_initialize_columns_type_change is only reversible if given a columns_and_types."
+        end
+        super
+      end
+
+      def invert_add_not_null_constraint(args, kwargs)
+        kwargs.delete(:validate)
+        [:remove_not_null_constraint, args, kwargs]
+      end
+
+      def invert_add_text_limit_constraint(args, kwargs)
+        kwargs.delete(:validate)
+        [:remove_text_limit_constraint, args, kwargs]
+      end
+
+      def invert_remove_text_limit_constraint(args, kwargs)
+        if !args[2]
+          raise ActiveRecord::IrreversibleMigration, "remove_text_limit_constraint is only reversible if given a limit."
+        end
+
+        [:add_text_limit_constraint, args, kwargs]
+      end
+  end
 end

data/lib/online_migrations/schema_dumper.rb

@@ -15,7 +15,13 @@ module OnlineMigrations
 
   class WrappedConnection < SimpleDelegator
     def columns(table_name)
-      super.sort_by(&:name)
+      columns = super
+
+      if Utils.ar_version >= 8.2 && columns.is_a?(Hash)
+        columns.transform_values { |v| v.sort_by(&:name) }
+      else
+        columns.sort_by(&:name)
+      end
     end
   end
 end

data/lib/online_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OnlineMigrations
-  VERSION = "0.36.0"
+  VERSION = "0.36.1"
 end

data/lib/online_migrations.rb

@@ -119,7 +119,12 @@ module OnlineMigrations
       ActiveRecord::ConnectionAdapters::SchemaCache.prepend(OnlineMigrations::SchemaCache)
 
       ActiveRecord::Tasks::DatabaseTasks.singleton_class.prepend(OnlineMigrations::DatabaseTasks)
-      ActiveRecord::Migration::CommandRecorder.include(OnlineMigrations::CommandRecorder)
+
+      if Utils.ar_version >= 8.2
+        ActiveRecord::Migration::CommandRecorder.include(OnlineMigrations::CommandRecorder82)
+      else
+        ActiveRecord::Migration::CommandRecorder.include(OnlineMigrations::CommandRecorder)
+      end
 
       if !ActiveRecord::Batches::BatchEnumerator.method_defined?(:use_ranges)
         ActiveRecord::Batches::BatchEnumerator.include(OnlineMigrations::ActiveRecordBatchEnumerator)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: online_migrations
 version: !ruby/object:Gem::Version
-  version: 0.36.0
+  version: 0.36.1
 platform: ruby
 authors:
 - fatkodima
@@ -116,7 +116,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.14
+rubygems_version: 4.0.16
 specification_version: 4
 summary: Catch unsafe PostgreSQL migrations in development and run them easier in
   production