online_migrations 0.31.0 → 0.31.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0872638ad98f95ef8fa347b719f14d548fec58402dd8fc6a06702c9d884f9346'
-  data.tar.gz: 572c037d2bf35cf048b8e1ee45fb0e464d375a3adec18264ba3e8f78b5cd433b
+  metadata.gz: 4afb5d9ab9916861d263de3c38a2436d2ee131ae9988edf282866145a274356d
+  data.tar.gz: 761d30f417479db296429af0668bf62e47581aa4a73fce1d9ba72bd62c66173f
 SHA512:
-  metadata.gz: 8da4b37bc6b6e88803a478844b32aa6d04d28b95ab6a147caea69a22e1ce512a70e0df9e6196ceb0cbc87a5c1a164f01d927adcb054d36d2aa98e56ecac854c9
-  data.tar.gz: f0a3f79d9ba42b596f27861ed9b046d82fd3805b47d62c7745b4bac7e69033904a6bbd90ea9d137370679e6e4ea8a42672cd31378f28b8a6b5d52141837c4d86
+  metadata.gz: 9e6930e8069732e7988b731d826a9e82b023c8f4bbebd5827a31efa10747ada86af64e7e75553df5a8d2e318688002e9c194cdf07e9124ef4231986197d885e7
+  data.tar.gz: fe46acbfd31436293ead08b37258c877ca4eddf3bb6c41e462a74c89153d4f632e244c2fa5b98b0887fbfe024a3ab8a9ada8ad101fffb9bebfd10dbbd9f5c9bc

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 ## master (unreleased)
 
+## 0.31.2 (2025-11-13)
+
+- Fix running background data migrations inline
+
+## 0.31.1 (2025-11-11)
+
+- Do not attempt running background migrations on database with `database_tasks: false`
+
 ## 0.31.0 (2025-10-22)
 
 - Store backtraces for failed background data migrations jobs

data/lib/online_migrations/background_data_migrations/migration_job.rb

@@ -37,7 +37,16 @@ module OnlineMigrations
           # TODO: use 'cursor' accessor from sidekiq in the future.
           # https://github.com/sidekiq/sidekiq/pull/6606
           @migration.persist_progress(@_cursor, ticks, duration)
-          @migration.reload
+
+          # When using a scheduler, these are running only from a single shard, but when inline -
+          # these are run from each shard (not needed, but simplifies the implementation).
+          #
+          # Do not reload the migration when running inline, because it can be from a different shard
+          # than the "default" shard (which is used to lookup background migrations).
+          if !Utils.run_background_migrations_inline?
+            # Reload to check if the migration's status changed etc.
+            @migration.reload
+          end
         end
 
         @throttle_checked_at = current_time

data/lib/online_migrations/utils.rb

@@ -127,7 +127,14 @@ module OnlineMigrations
           # This is the way that currently is used in ActiveRecord tests themselves.
           pool_manager = ActiveRecord::Base.connection_handler.send(:get_pool_manager, ancestor.name)
 
-          return pool_manager.shard_names if pool_manager
+          if pool_manager
+            shards_with_database_tasks = pool_manager.shard_names.select do |shard_name|
+              pool_config = pool_manager.get_pool_config(:writing, shard_name)
+              pool_config.db_config.database_tasks? if pool_config
+            end
+
+            return shards_with_database_tasks
+          end
         end
       end
 

data/lib/online_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OnlineMigrations
-  VERSION = "0.31.0"
+  VERSION = "0.31.2"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: online_migrations
 version: !ruby/object:Gem::Version
-  version: 0.31.0
+  version: 0.31.2
 platform: ruby
 authors:
 - fatkodima
 bindir: bin
 cert_chain: []
-date: 2025-10-22 00:00:00.000000000 Z
+date: 2025-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord