online_migrations 0.30.0 → 0.31.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 428fd65e363b915608f720370a2cd91ec14749cd17933ec4e26351bb4745084a
-  data.tar.gz: ae292bba4cd1b557694f78240a7da761c8d890aa691cc6b485ddd9f71fd339c5
+  metadata.gz: b5e1f97d972736356a7aa992a5fb39d318ebdd9709952c9015f98d832b5e94c1
+  data.tar.gz: fd4b0fc1ae446665dd22e27519ffa93272def9ea25d107bfed037b754e9f01e0
 SHA512:
-  metadata.gz: 59c0573c24d75488c849fa746d6346c31e439d66032725264ce724e97ab8ffbd16cebb03a57ad75071e2b29bf884be0b47696abdcadc72d974effaafd73fe8b4
-  data.tar.gz: 73de95254d001d4d285a48ad4d3adb60726ab6bf0bb86b085dde8466b6e1e85fbb668738f09121c38718504ad253615afb3da5e24f56bc48bd01ce9d369cdd4c
+  metadata.gz: 170f3d973598ac2bb5b8cdf6acfa28217b58fda566e3482d1ced37f4e55b173cc32f6e1ca676863df9af0624170b520dcf1bbc50a022278c7664da55ebe317d3
+  data.tar.gz: 04f8aaeacea73a571b562752a7f525d607ea9f601e64dd147fb5d3f2bf75653764aa458610876b28609d12d93dd0113d4fcf3069ddbd9fee06159ee01a59cc20

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 ## master (unreleased)
 
+## 0.31.1 (2025-11-11)
+
+- Do not attempt running background migrations on database with `database_tasks: false`
+
+## 0.31.0 (2025-10-22)
+
+- Store backtraces for failed background data migrations jobs
+- Make `add_column` idempotent
+- Fix `NullLockRetrier#with_lock_retries` method signature
+
 ## 0.30.0 (2025-10-17)
 
 - Fix `remove_check_constraint` when using `:if_exists`

data/lib/online_migrations/background_data_migrations/migration_job.rb

@@ -6,6 +6,8 @@ module OnlineMigrations
     class MigrationJob
       include Sidekiq::IterableJob
 
+      sidekiq_options backtrace: true
+
       sidekiq_retry_in do |count, _exception, jobhash|
         migration_id = jobhash["args"].fetch(0)
         migration = Migration.find(migration_id)

data/lib/online_migrations/lock_retrier.rb

@@ -251,7 +251,7 @@ module OnlineMigrations
     def delay(_attempt, _command = nil, _arguments = [])
     end
 
-    def with_lock_retries(_connection)
+    def with_lock_retries(_connection, _command = nil, *_arguments)
       yield
     end
   end

data/lib/online_migrations/schema_statements.rb

@@ -630,6 +630,19 @@ module OnlineMigrations
       remove_check_constraint(table_name, name: name)
     end
 
+    # Extends default method to be idempotent and automatically recreate invalid indexes.
+    #
+    # @see https://api.rubyonrails.org/v8.1/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-add_column
+    #
+    def add_column(table_name, column_name, type, **options)
+      if column_exists?(table_name, column_name, type, **options)
+        Utils.say("Column was not added because it already exists (this may be due to an aborted migration " \
+                  "or similar) table_name: #{table_name}, column_name: #{column_name}")
+      else
+        super
+      end
+    end
+
     # Adds a reference to the table with minimal locking
     #
     # Active Record adds an index non-`CONCURRENTLY` to references by default, which blocks writes.

data/lib/online_migrations/utils.rb

@@ -127,7 +127,14 @@ module OnlineMigrations
           # This is the way that currently is used in ActiveRecord tests themselves.
           pool_manager = ActiveRecord::Base.connection_handler.send(:get_pool_manager, ancestor.name)
 
-          return pool_manager.shard_names if pool_manager
+          if pool_manager
+            shards_with_database_tasks = pool_manager.shard_names.select do |shard_name|
+              pool_config = pool_manager.get_pool_config(:writing, shard_name)
+              pool_config.db_config.database_tasks? if pool_config
+            end
+
+            return shards_with_database_tasks
+          end
         end
       end
 

data/lib/online_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OnlineMigrations
-  VERSION = "0.30.0"
+  VERSION = "0.31.1"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: online_migrations
 version: !ruby/object:Gem::Version
-  version: 0.30.0
+  version: 0.31.1
 platform: ruby
 authors:
 - fatkodima
 bindir: bin
 cert_chain: []
-date: 2025-10-17 00:00:00.000000000 Z
+date: 2025-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord