online_migrations 0.27.0 → 0.27.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7125a034a085c11fff526219d8f2483dfea610b100486766145b7caf85e07700
-  data.tar.gz: 609636661c23e939a1766a14097fca30bc01b21666cfcb5e207bc20dfde4923c
+  metadata.gz: 8a3658cc979ead6b8dea71140f3ba95b0f7a4a4c26a27891f49a5b6925c94e59
+  data.tar.gz: 7d3ab5e09422e28078543ac67fa0ecae1a7afe9d8e29f67e55d6b772fb708e50
 SHA512:
-  metadata.gz: 22866111b2a0ba3392d930c60548234f72c1f9dd27309a5b0c5ebff0b06232e5a59d2a6353db51d4c760abdafd90091a8ddf873808fb6cb53bbb755ebc7daf80
-  data.tar.gz: 16643b7af80d9d20e482a5be141e0ecd4733503ff9a80effcd03516af60270227c1c7d604b4b342c70a553e6fe729b83b9b8eb609f87cf9f5c6bde7e3177eb36
+  metadata.gz: 43ae3f3ebffa5491d4ac9b99b987b048702b9142e9a4ae49182b705b9c81a562acbea6dc1580ef76e49a9124adf2d662723451b6d03003f10f05c1d39ff4a33e
+  data.tar.gz: 5793df9ffd71454f2edb251d079439c5dfb0cfe212a30360654cbb5622c23fcd47a63e2a8cdd6b8d4df2bd7d3b39ec4d29eede4a99519264075e65956bdd1b55

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## master (unreleased)
 
+## 0.27.1 (2025-05-08)
+
+- Fix background data migrations to enumerate using the correct shard
+
 ## 0.27.0 (2025-05-01)
 
 - **WARNING**: This release has breaking changes! See `docs/0.27-upgrade.md` for release notes

data/docs/0.27-upgrade.md

@@ -9,7 +9,7 @@ To upgrade:
 * Upgrade gem to v0.27: `gem 'online_migrations', '~> 0.27.0'`
 * Upgrade the gem's initializer in `config/online_migrations.rb` by referring to the [newest contents](https://github.com/fatkodima/online_migrations/blob/master/lib/generators/online_migrations/templates/initializer.rb.tt)
 
-If you don't use any of the [background data migrations](docs/background_data_migrations.md) or [background schema migrations](docs/background_schema_migrations.md), then this is probably all you need.
+If you don't use any of the [background data migrations](background_data_migrations.md) or [background schema migrations](background_schema_migrations.md), then this is probably all you need.
 
 If you use background data migrations:
 
@@ -21,4 +21,4 @@ If you use background data migrations:
   $ bin/rails db:migrate
   ```
 
-Look at [background data migrations guide](docs/background_data_migrations.md) to find the API changes and new features.
+Look at [background data migrations guide](background_data_migrations.md) to find the API changes and new features.

data/lib/online_migrations/background_data_migrations/migration_job.rb

@@ -45,10 +45,6 @@ module OnlineMigrations
         @migration.start
       end
 
-      def around_iteration(&block)
-        @migration.on_shard_if_present(&block)
-      end
-
       def on_resume
         @data_migration.after_resume
       end
@@ -140,6 +136,12 @@ module OnlineMigrations
       end
 
       private
+        # It would be better for sidekiq to have a callback like `around_perform`,
+        # but currently this is the way to make job iteration shard aware.
+        def iterate_with_enumerator(enumerator, arguments)
+          @migration.on_shard_if_present { super }
+        end
+
         THROTTLE_CHECK_INTERVAL = 5 # seconds
         private_constant :THROTTLE_CHECK_INTERVAL
 

data/lib/online_migrations/change_column_type_helpers.rb

@@ -152,7 +152,11 @@ module OnlineMigrations
     #   revert_initialize_column_type_change(:files, :size)
     #
     def revert_initialize_column_type_change(table_name, column_name, _new_type = nil, **_options)
-      cleanup_column_type_change(table_name, column_name)
+      tmp_column_name = __change_type_column(column_name)
+      transaction do
+        __remove_copy_triggers(table_name, column_name, tmp_column_name)
+        remove_column(table_name, tmp_column_name)
+      end
     end
 
     # Same as `revert_initialize_column_type_change` but for multiple columns.
@@ -160,7 +164,12 @@ module OnlineMigrations
     #
     def revert_initialize_columns_type_change(table_name, columns_and_types, **_options)
       column_names = columns_and_types.map(&:first)
-      cleanup_columns_type_change(table_name, *column_names)
+      tmp_column_names = column_names.map { |column_name| __change_type_column(column_name) }
+
+      transaction do
+        __remove_copy_triggers(table_name, column_names, tmp_column_names)
+        remove_columns(table_name, *tmp_column_names)
+      end
     end
 
     # Backfills data from the old column to the new column.
@@ -347,6 +356,7 @@ module OnlineMigrations
     #   the original column type to be able to revert.
     #
     def cleanup_column_type_change(table_name, column_name)
+      __ensure_not_in_transaction!
       cleanup_columns_type_change(table_name, column_name)
     end
 
@@ -354,6 +364,8 @@ module OnlineMigrations
     # @see #cleanup_column_type_change
     #
     def cleanup_columns_type_change(table_name, *column_names)
+      __ensure_not_in_transaction!
+
       tmp_column_names = column_names.map { |column_name| __change_type_column(column_name) }
 
       # Safely remove existing indexes and foreign keys first, if any.

data/lib/online_migrations/error_messages.rb

@@ -230,6 +230,8 @@ during writes works automatically). For most column type changes, this does not
 7. Finally, if everything works as expected, remove copy trigger and old column:
 
   class Cleanup<%= migration_name %> < <%= migration_parent %>
+    disable_ddl_transaction!
+
     def up
       <%= cleanup_code %>
     end

data/lib/online_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OnlineMigrations
-  VERSION = "0.27.0"
+  VERSION = "0.27.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: online_migrations
 version: !ruby/object:Gem::Version
-  version: 0.27.0
+  version: 0.27.1
 platform: ruby
 authors:
 - fatkodima
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-05-01 00:00:00.000000000 Z
+date: 2025-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord