online_migrations 0.19.4 → 0.19.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6392ff9889da502701252f97a71e4fa8c3b403dc61aa010957a5b79221a9366b
-  data.tar.gz: 1c880f23e20b142c335679701bdac977f089ac5ef076352a438e6dfa469b54cb
+  metadata.gz: cd8711d56259535675633074868019a5c4b3de068bb30d783c9ae16dc906afb1
+  data.tar.gz: 3b417e176d143092d69e4551c1f96a32e1a2acf1d74d268fc33f9b5a598be553
 SHA512:
-  metadata.gz: 30f7c9ed855f97180ba1b4f9c90f717f58ad9198fbd90f1b80b914b35994a2b863499239263878115d220413927ca3f5a05519e917b66335a346607b19a8f2ab
-  data.tar.gz: 271a237cb9df14677ed5c364c6c90657a6726347ae94b6992ad37c468b0bf59a76e51c0a1b79f187264d2369637e6c6de83d454d6f8c1c368648640c5ee23068
+  metadata.gz: ad26fd5662f2636479b697933042b8d7e60b4ee42f136ddeb8cff8256c65a4491b8017d09d2da849faf65cb6f8d4ecc95595816b7669c8364e9f31bbe75232c4
+  data.tar.gz: 21fec027462ff6f96baaf0fc65d186fc68fefbb50fd3de6af8f561aae691e6f9909d70d7053557d39f0a56ea498841816c2853cce0b1acef161411b2d968b196

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 ## master (unreleased)
 
+## 0.19.6 (2024-09-26)
+
+- Fix `add_refernce_concurrently` when adding non polymorphic references
+- Fix progress for background migrations with small number of records
+
+## 0.19.5 (2024-09-20)
+
+- Fix `add_reference_concurrently` when adding polymorphic references
+
 ## 0.19.4 (2024-09-02)
 
 - Fix an edge case for background schema migrations

data/lib/online_migrations/background_migrations/migration.rb

@@ -138,7 +138,7 @@ module OnlineMigrations
             progresses.sum.round(2)
           end
         elsif rows_count
-          if rows_count > 0
+          if rows_count > 0 && rows_count > batch_size
             jobs_rows_count = migration_jobs.succeeded.sum(:batch_size)
             # The last migration job may need to process the amount of rows
             # less than the batch size, so we can get a value > 1.0.
@@ -183,14 +183,14 @@ module OnlineMigrations
       def retry
         if composite? && failed?
           children.failed.each(&:retry)
-          running!
+          enqueued!
           true
         elsif failed?
           iterator = BatchIterator.new(migration_jobs.failed)
           iterator.each_batch(of: 100) do |batch|
             batch.each(&:retry)
           end
-          running!
+          enqueued!
           true
         else
           false

data/lib/online_migrations/background_migrations/migration_job.rb

@@ -81,7 +81,7 @@ module OnlineMigrations
               error_message: nil,
               backtrace: nil
             )
-            migration.running! if migration.failed?
+            migration.enqueued! if migration.failed?
           end
           true
         else

data/lib/online_migrations/schema_statements.rb

@@ -647,21 +647,29 @@ module OnlineMigrations
       __ensure_not_in_transaction!
 
       column_name = "#{ref_name}_id"
+      type_column_name = "#{ref_name}_type"
+
       if !column_exists?(table_name, column_name)
         type = options[:type] || :bigint
         allow_null = options.fetch(:null, true)
         add_column(table_name, column_name, type, null: allow_null)
       end
 
+      if options[:polymorphic] && !column_exists?(table_name, type_column_name)
+        allow_null = options[:polymorphic].is_a?(Hash) ? options[:polymorphic][:null] : true
+        add_column(table_name, type_column_name, :string, null: allow_null)
+      end
+
       # Always added by default in 5.0+
       index = options.fetch(:index, true)
 
       if index
         index = {} if index == true
         index_columns = [column_name]
+
         if options[:polymorphic]
+          index_columns.unshift(type_column_name)
           index[:name] ||= "index_#{table_name}_on_#{ref_name}"
-          index_columns.unshift("#{ref_name}_type")
         end
 
         add_index(table_name, index_columns, **index.merge(algorithm: :concurrently))

data/lib/online_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OnlineMigrations
-  VERSION = "0.19.4"
+  VERSION = "0.19.6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: online_migrations
 version: !ruby/object:Gem::Version
-  version: 0.19.4
+  version: 0.19.6
 platform: ruby
 authors:
 - fatkodima
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-09-02 00:00:00.000000000 Z
+date: 2024-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord