online_migrations 0.19.4 → 0.19.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6392ff9889da502701252f97a71e4fa8c3b403dc61aa010957a5b79221a9366b
-  data.tar.gz: 1c880f23e20b142c335679701bdac977f089ac5ef076352a438e6dfa469b54cb
+  metadata.gz: 9cb60167b94f5ce8556b3f9835949c86f9be4c523eb2c35494de578dea31a2bf
+  data.tar.gz: 20d9d6fcf509bbc25987a2e3bce165c927cacd03502aa908c02aba37dd284774
 SHA512:
-  metadata.gz: 30f7c9ed855f97180ba1b4f9c90f717f58ad9198fbd90f1b80b914b35994a2b863499239263878115d220413927ca3f5a05519e917b66335a346607b19a8f2ab
-  data.tar.gz: 271a237cb9df14677ed5c364c6c90657a6726347ae94b6992ad37c468b0bf59a76e51c0a1b79f187264d2369637e6c6de83d454d6f8c1c368648640c5ee23068
+  metadata.gz: 03f82fe701b6d2145963f1f2220ac9ed127dc826885455134afc3bb547197d21a1c0307156b6d8b5402c0a521332328eebf45d96a3bb2183804055d866cd3af2
+  data.tar.gz: 94f0bfd73299897757a8b836a9cbd995bb9313c971a6e0076079b783955c26da239098b84df391096128fc0e060ba66ca69e61e16a84013c12d613c7fe4064ce

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## master (unreleased)
 
+## 0.19.5 (2024-09-20)
+
+- Fix `add_reference_concurrently` when adding polymorphic references
+
 ## 0.19.4 (2024-09-02)
 
 - Fix an edge case for background schema migrations

data/lib/online_migrations/schema_statements.rb

@@ -647,21 +647,29 @@ module OnlineMigrations
       __ensure_not_in_transaction!
 
       column_name = "#{ref_name}_id"
+      type_column_name = "#{ref_name}_type"
+
       if !column_exists?(table_name, column_name)
         type = options[:type] || :bigint
         allow_null = options.fetch(:null, true)
         add_column(table_name, column_name, type, null: allow_null)
       end
 
+      if !column_exists?(table_name, type_column_name)
+        allow_null = options[:polymorphic].is_a?(Hash) ? options[:polymorphic][:null] : true
+        add_column(table_name, type_column_name, :string, null: allow_null)
+      end
+
       # Always added by default in 5.0+
       index = options.fetch(:index, true)
 
       if index
         index = {} if index == true
         index_columns = [column_name]
+
         if options[:polymorphic]
+          index_columns.unshift(type_column_name)
           index[:name] ||= "index_#{table_name}_on_#{ref_name}"
-          index_columns.unshift("#{ref_name}_type")
         end
 
         add_index(table_name, index_columns, **index.merge(algorithm: :concurrently))

data/lib/online_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OnlineMigrations
-  VERSION = "0.19.4"
+  VERSION = "0.19.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: online_migrations
 version: !ruby/object:Gem::Version
-  version: 0.19.4
+  version: 0.19.5
 platform: ruby
 authors:
 - fatkodima
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-09-02 00:00:00.000000000 Z
+date: 2024-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord