online_manager 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dc1c0b7ad1198c4e4a02cb8b797b647b919571fd
-  data.tar.gz: e1d2a97d952633e0e68023760cd426f6b98c6a3c
+  metadata.gz: 24f8a91946ab2eb1b0585331886f4e70c253e70e
+  data.tar.gz: 793ac0de4e25815d5d2425ed462ea6e1538f480b
 SHA512:
-  metadata.gz: f505a05f4324e4ac45ea09d940ff7e76a4da416e5ebbc91450ecf2e5bb89c53be3145cff0c10078f4c37b1c69bc4dd1791efc54a9b20036b567c0cb233840360
-  data.tar.gz: 278a2c80e9688f6d9df62e263b2a0391f2151ab0eae0f5c94baaa86726e95ca6efa5db1822c8b9268fb68d5a16305c61583f50e83f7f6d688a7be3f112fc38ac
+  metadata.gz: 4da8e86883f70f5170a725e36dea4ae991d8b228bf26c238731f61fd9c0590aab6af8e6070801523dd2e18892e480aa238f5f97d30a8b60943caec7717673282
+  data.tar.gz: 7271777e28da50652f36a64f507ae0fb85f69548c56cadf88799197287457558d90e719c71811743b83ac1e087b98e33cf36b6c2172d3aea10f12c364f5c1ea3

data/.gitignore

@@ -12,3 +12,4 @@
 *.o
 *.a
 mkmf.log
+*.gem

data/README.md

@@ -30,31 +30,35 @@ require 'online_manager'
 # You should set all the users offline when it first runs,
 # since otherwise you'll be left with users marked online from when it last quit.
 
-# This runs an eventmachine reactor, so the call to .run blocks.
-OnlineManager.run do |c|
+class OnlineConfig
 
   # How long since a heartbeat was last received until the user is considered offline? (in seconds)
-  c.timeout 5
+  def timeout
+    5
+  end
 
   # All the blocks below will be called inside an eventmachine reactor.
 
-  c.setup do |seen|
+  def setup
     # Set up any websocket server/connection to pubsub server, etc
     # This must use eventmachine, otherwise it will block the reactor.
-    # Then call seen.call(user_id) whenever you receive a heartbeat from a user.
+    # Then yield(user_id) whenever you receive a heartbeat from a user.
   end
 
-  c.online do |user_id|
+  def online(user_id)
     puts "Booster #{user_id} online"
     # Update the user to online in the database or whatever
     # This must use asynchronous i/o, otherwise it will block the reactor.
   end
 
-  c.offline do |user_id|
+  def offline(user_id)
     puts "Booster #{user_id} offline"
     # Called when a user transitions from online -> offline
   end
 end
+
+# This runs an eventmachine reactor, so the call to .run blocks.
+OnlineManager.run(OnlineConfig.new)
 ```
 
 If you already are in the context of an eventmachine reactor, or you want to run multiple of these in the same thread,
@@ -62,15 +66,13 @@ you can use `.setup`.
 
 ```ruby
 EM.run do
-  OnlineManager.setup do |c|
-    # Configure it
-  end
+  OnlineManager.setup(OnlineConfig.new)
 end
 ```
 
 ## TODO
 
-* Write tests for this. Its pretty simple (~ 50 lines of code excluding the DSL) and I have it running in production, so it should be fine.
+* Write tests for this. Its pretty simple (~ 50 lines of code) and I have it running in production, so it should be fine.
   Check out [this][1] for testing eventmachine.
 * Consider setting remaining users offline in an ensure block, so it always leaves the statuses in a consistent state.
   [Could this replace setting users offline on initialization?][2]

data/lib/online_manager.rb

@@ -1,10 +1,6 @@
 require 'eventmachine'
 
-require 'online_manager/dsl'
-
 class OnlineManager
-  attr_writer :online_callback, :offline_callback, :setup_callback, :timeout
-
   def self.run(*args, &block)
     new(*args, &block).run
   end
@@ -13,16 +9,9 @@ class OnlineManager
     new(*args, &block).setup
   end
 
-  def initialize
-    @timeout = nil
+  def initialize(config)
+    @config = config
     @online_users = {}
-    @online_callback = -> (_) {  }
-    @offline_callback = -> (_) {  }
-    @setup_callback = ->(_) { raise 'You must specify a setup callback' }
-
-    yield DSL.new(self) if block_given?
-
-    raise 'Timeout must be specified' unless @timeout
   end
 
   def run
@@ -30,18 +19,18 @@ class OnlineManager
   end
 
   def setup
-    @setup_callback.call(method(:seen))
+    @config.setup(&method(:seen))
   end
 
 private
 
   def seen(id)
-    @online_callback.call(id) unless online?(id)
+    @config.online(id) unless online?(id)
 
     time = Time.now
     @online_users[id] = time
 
-    EM.add_timer(@timeout) do
+    EM.add_timer(@config.timeout) do
       set_offline(id, time)
     end
   end
@@ -49,7 +38,7 @@ private
   def set_offline(id, time)
     if @online_users[id] == time
       @online_users.delete(id)
-      @offline_callback.call(id)
+      @config.offline(id)
     end
   end
 

data/online_manager.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'online_manager'
-  spec.version       = '0.0.2'
+  spec.version       = '0.0.3'
   spec.authors       = ['Cameron Martin']
   spec.email         = ['cameronmartin123@gmail.com']
   spec.summary       = %q{Manage user's online status.}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: online_manager
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Cameron Martin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-11 00:00:00.000000000 Z
+date: 2014-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,7 +80,6 @@ files:
 - README.md
 - Rakefile
 - lib/online_manager.rb
-- lib/online_manager/dsl.rb
 - online_manager.gemspec
 homepage: https://github.com/cameron-martin/online_manager
 licenses:

data/lib/online_manager/dsl.rb

@@ -1,23 +0,0 @@
-class OnlineManager
-  class DSL
-    def initialize(target)
-      @target = target
-    end
-
-    def timeout(timeout)
-      @target.timeout = timeout
-    end
-
-    def online(&block)
-      @target.online_callback = block
-    end
-
-    def offline(&block)
-      @target.offline_callback = block
-    end
-
-    def setup(&block)
-      @target.setup_callback = block
-    end
-  end
-end