onix 0.8.4 → 0.8.5

data/spec/other_text_spec.rb

@@ -2,7 +2,7 @@
 
 require File.dirname(__FILE__) + '/spec_helper.rb'
 
-context "ONIX::OtherText" do
+describe ONIX::OtherText do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
@@ -11,19 +11,19 @@ context "ONIX::OtherText" do
     @root = @doc.root
   end
 
-  specify "should correctly convert to a string" do
+  it "should correctly convert to a string" do
     ot = ONIX::OtherText.from_xml(@root.to_s)
     ot.to_xml.to_s[0,11].should eql("<OtherText>")
   end
 
-  specify "should provide read access to first level attributes" do
+  it "should provide read access to first level attributes" do
     ot = ONIX::OtherText.from_xml(@root.to_s)
 
     ot.text_type_code.should eql(2)
     ot.text[0,7].should eql("A woman")
   end
 
-  specify "should provide write access to first level attributes" do
+  it "should provide write access to first level attributes" do
     ot = ONIX::OtherText.new
 
     ot.text_type_code = 2

data/spec/price_spec.rb

@@ -2,7 +2,7 @@
 
 require File.dirname(__FILE__) + '/spec_helper.rb'
 
-context "ONIX::Price" do
+describe ONIX::Price do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
@@ -11,19 +11,19 @@ context "ONIX::Price" do
     @root = @doc.root
   end
 
-  specify "should correctly convert to a string" do
+  it "should correctly convert to a string" do
     p = ONIX::Price.from_xml(@root.to_s)
     p.to_xml.to_s[0,7].should eql("<Price>")
   end
 
-  specify "should provide read access to first level attributes" do
+  it "should provide read access to first level attributes" do
     p = ONIX::Price.from_xml(@root.to_s)
 
     p.price_type_code.should eql(2)
     p.price_amount.should eql(BigDecimal.new("7.5"))
   end
 
-  specify "should provide write access to first level attributes" do
+  it "should provide write access to first level attributes" do
     p = ONIX::Price.new
 
     p.price_type_code = 1

data/spec/product_identifier_spec.rb

@@ -2,7 +2,7 @@
 
 require File.dirname(__FILE__) + '/spec_helper.rb'
 
-context "ONIX::ProductIdentifier" do
+describe ONIX::ProductIdentifier do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
@@ -11,19 +11,19 @@ context "ONIX::ProductIdentifier" do
     @root = @doc.root
   end
 
-  specify "should correctly convert to a string" do
+  it "should correctly convert to a string" do
     id = ONIX::ProductIdentifier.from_xml(@root.to_s)
     id.to_xml.to_s[0,19].should eql("<ProductIdentifier>")
   end
 
-  specify "should provide read access to first level attributes" do
+  it "should provide read access to first level attributes" do
     id = ONIX::ProductIdentifier.from_xml(@root.to_s)
 
     id.product_id_type.should eql(2)
     id.id_value.should eql("0858198363")
   end
 
-  specify "should provide write access to first level attributes" do
+  it "should provide write access to first level attributes" do
     id = ONIX::ProductIdentifier.new
 
     id.product_id_type = 2

data/spec/product_spec.rb

@@ -2,7 +2,7 @@
 
 require File.dirname(__FILE__) + '/spec_helper.rb'
 
-context "ONIX::Product" do
+describe ONIX::Product do
 
   before(:each) do
     @data_path = File.join(File.dirname(__FILE__),"..","data")
@@ -11,7 +11,7 @@ context "ONIX::Product" do
     @product_node = @doc.root
   end
 
-  specify "should provide read access to first level attributes" do
+  it "should provide read access to first level attributes" do
     product = ONIX::Product.from_xml(@product_node.to_s)
 
     product.record_reference.should eql("365-9780194351898")
@@ -32,27 +32,27 @@ context "ONIX::Product" do
     product.dimensions.should eql("100x200")
   end
 
-  specify "should provide read access to product IDs" do
+  it "should provide read access to product IDs" do
     product = ONIX::Product.from_xml(@product_node.to_s)
     product.product_identifiers.size.should eql(3)
   end
 
-  specify "should provide read access to titles" do
+  it "should provide read access to titles" do
     product = ONIX::Product.from_xml(@product_node.to_s)
     product.titles.size.should eql(1)
   end
 
-  specify "should provide read access to subjects" do
+  it "should provide read access to subjects" do
     product = ONIX::Product.from_xml(@product_node.to_s)
     product.subjects.size.should eql(1)
   end
 
-  specify "should provide read access to measurements" do
+  it "should provide read access to measurements" do
     product = ONIX::Product.from_xml(@product_node.to_s)
     product.measurements.size.should eql(1)
   end
 
-  specify "should provide write access to first level attributes" do
+  it "should provide write access to first level attributes" do
     product = ONIX::Product.new
 
     product.notification_type = 3
@@ -83,7 +83,7 @@ context "ONIX::Product" do
     product.to_xml.to_s.include?("<YearFirstPublished>1998</YearFirstPublished>").should be_true
   end
 
-  specify "should correctly from_xml files that have an invalid publication date" do
+  it "should correctly from_xml files that have an invalid publication date" do
     file = File.join(@data_path, "product_invalid_pubdate.xml")
     product = ONIX::Product.from_xml(File.read(file))
 

data/spec/publisher_spec.rb

@@ -2,7 +2,7 @@
 
 require File.dirname(__FILE__) + '/spec_helper.rb'
 
-context "ONIX::Publisher" do
+describe ONIX::Publisher do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
@@ -11,18 +11,18 @@ context "ONIX::Publisher" do
     @root = @doc.root
   end
 
-  specify "should correctly convert to a string" do
+  it "should correctly convert to a string" do
     pub = ONIX::Publisher.from_xml(@root.to_s)
     pub.to_xml.to_s[0,11].should eql("<Publisher>")
   end
 
-  specify "should provide read access to first level attributes" do
+  it "should provide read access to first level attributes" do
     pub = ONIX::Publisher.from_xml(@root.to_s)
     pub.publishing_role.should eql(1)
     pub.publisher_name.should eql("Desbooks Publishing")
   end
 
-  specify "should provide write access to first level attributes" do
+  it "should provide write access to first level attributes" do
     pub = ONIX::Publisher.new
 
     pub.publisher_name = "Paulist Press"

data/spec/reader_spec.rb

@@ -2,7 +2,7 @@
 
 require File.dirname(__FILE__) + '/spec_helper.rb'
 
-context "ONIX::Reader" do
+describe ONIX::Reader do
 
   before(:each) do
     @data_path = File.join(File.dirname(__FILE__),"..","data")
@@ -14,30 +14,30 @@ context "ONIX::Reader" do
     @iso_8859_1_file = File.join(@data_path, "iso_8859_1.xml")
   end
 
-  specify "should initialize with a filename" do
+  it "should initialize with a filename" do
     reader = ONIX::Reader.new(@file1)
     reader.instance_variable_get("@reader").should be_a_kind_of(Nokogiri::XML::Reader)
   end
 
-  specify "should initialize with an IO object" do
+  it "should initialize with an IO object" do
     File.open(@file1,"rb") do |f|
       reader = ONIX::Reader.new(f)
       reader.instance_variable_get("@reader").should be_a_kind_of(Nokogiri::XML::Reader)
     end
   end
 
-  specify "should provide access to various XML metadata from file" do
+  it "should provide access to various XML metadata from file" do
     filename = File.join(@data_path, "reference_with_release_attrib.xml")
     reader = ONIX::Reader.new(filename)
     reader.release.should eql(BigDecimal.new("2.1"))
   end
 
-  specify "should provide access to the header in an ONIX file" do
+  it "should provide access to the header in an ONIX file" do
     reader = ONIX::Reader.new(@file1)
     reader.header.should be_a_kind_of(ONIX::Header)
   end
 
-  specify "should iterate over all product records in an ONIX file" do
+  it "should iterate over all product records in an ONIX file" do
     reader = ONIX::Reader.new(@file1)
     counter = 0
     reader.each do |product|
@@ -48,7 +48,7 @@ context "ONIX::Reader" do
     counter.should eql(1)
   end
 
-  specify "should iterate over all product records in an ONIX file" do
+  it "should iterate over all product records in an ONIX file" do
     reader = ONIX::Reader.new(@file2)
     products = []
     reader.each do |product|
@@ -63,7 +63,7 @@ context "ONIX::Reader" do
   # libxml can handle the 3 standard entities fine (& < and ^gt;) but
   # barfs when it encounters others. In theory other entities are defined in the
   # ONIX DTD, but I can't work out how to get libxml to recognise them
-  specify "should correctly parse a file that has an entity in it" do
+  it "should correctly parse a file that has an entity in it" do
     reader = ONIX::Reader.new(@entity_file)
 
     products = []
@@ -78,7 +78,7 @@ context "ONIX::Reader" do
   end
 
   # for some reason I'm getting segfaults when I read a file with more than 7 records
-  specify "should correctly parse a file with more than 7 records in in" do
+  it "should correctly parse a file with more than 7 records in in" do
     reader = ONIX::Reader.new(@long_file)
     counter = 0
     reader.each do |product|
@@ -88,7 +88,7 @@ context "ONIX::Reader" do
     counter.should eql(346)
   end
 
-  specify "should transparently convert a iso-8859-1 file to utf-8" do
+  it "should transparently convert a iso-8859-1 file to utf-8" do
     reader = ONIX::Reader.new(@iso_8859_1_file)
     product = nil
     reader.each do |p|
@@ -105,7 +105,7 @@ context "ONIX::Reader" do
 
   end
 
-  specify "should transparently convert a utf-16 file to utf-8" do
+  it "should transparently convert a utf-16 file to utf-8" do
     reader = ONIX::Reader.new(@utf_16_file)
     product = nil
     reader.each do |p|

data/spec/sales_restriction_spec.rb

@@ -2,7 +2,7 @@
 
 require File.dirname(__FILE__) + '/spec_helper.rb'
 
-context "ONIX::SalesRestriction" do
+describe "ONIX::SalesRestriction" do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
@@ -11,18 +11,18 @@ context "ONIX::SalesRestriction" do
     @root = @doc.root
   end
 
-  specify "should correctly convert to a string" do
+  it "should correctly convert to a string" do
     sr = ONIX::SalesRestriction.from_xml(@root.to_s)
     sr.to_xml.to_s[0,18].should eql("<SalesRestriction>")
   end
 
-  specify "should provide read access to first level attributes" do
+  it "should provide read access to first level attributes" do
     sr = ONIX::SalesRestriction.from_xml(@root.to_s)
 
     sr.sales_restriction_type.should eql(0)
   end
 
-  specify "should provide write access to first level attributes" do
+  it "should provide write access to first level attributes" do
     sr = ONIX::SalesRestriction.new
 
     sr.sales_restriction_type = 1
@@ -30,4 +30,3 @@ context "ONIX::SalesRestriction" do
   end
 
 end
-

data/spec/sender_identifier.rb

@@ -2,7 +2,7 @@
 
 require File.dirname(__FILE__) + '/spec_helper.rb'
 
-context "ONIX::SenderIdentifier" do
+describe ONIX::SenderIdentifier do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
@@ -11,19 +11,19 @@ context "ONIX::SenderIdentifier" do
     @root = @doc.root
   end
 
-  specify "should correctly convert to a string" do
+  it "should correctly convert to a string" do
     id = ONIX::SenderIdentifier.from_xml(@root.to_s)
     id.to_xml.to_s[0,18].should eql("<SenderIdentifier>")
   end
 
-  specify "should provide read access to first level attributes" do
+  it "should provide read access to first level attributes" do
     id = ONIX::SenderIdentifier.from_xml(@root.to_s)
 
     id.sender_id_type.should eql(1)
     id.id_value.should eql("123456")
   end
 
-  specify "should provide write access to first level attributes" do
+  it "should provide write access to first level attributes" do
     id = ONIX::SenderIdentifier.new
 
     id.sender_id_type = 1

data/spec/series_identifier_spec.rb

@@ -2,7 +2,7 @@
 
 require File.dirname(__FILE__) + '/spec_helper.rb'
 
-context "ONIX::SeriesIdentifier" do
+describe ONIX::SeriesIdentifier do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
@@ -11,19 +11,19 @@ context "ONIX::SeriesIdentifier" do
     @root = @doc.root
   end
 
-  specify "should correctly convert to a string" do
+  it "should correctly convert to a string" do
     series = ONIX::SeriesIdentifier.from_xml(@root.to_s)
     series.to_xml.to_s[0,18].should eql("<SeriesIdentifier>")
   end
 
-  specify "should provide read access to first level attributes" do
+  it "should provide read access to first level attributes" do
     series = ONIX::SeriesIdentifier.from_xml(@root.to_s)
 
     series.series_id_type.should eql(1)
     series.id_value.should eql("10001")
   end
 
-  specify "should provide write access to first level attributes" do
+  it "should provide write access to first level attributes" do
     series = ONIX::SeriesIdentifier.new
 
     series.series_id_type = 9

data/spec/series_spec.rb

@@ -2,7 +2,7 @@
 
 require File.dirname(__FILE__) + '/spec_helper.rb'
 
-context "ONIX::Series" do
+describe ONIX::Series do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
@@ -11,18 +11,18 @@ context "ONIX::Series" do
     @root = @doc.root
   end
 
-  specify "should correctly convert to a string" do
+  it "should correctly convert to a string" do
     series = ONIX::Series.from_xml(@root.to_s)
     series.to_xml.to_s[0,8].should eql("<Series>")
   end
 
-  specify "should provide read access to first level attributes" do
+  it "should provide read access to first level attributes" do
     series = ONIX::Series.from_xml(@root.to_s)
 
     series.title_of_series.should eql("Citizens and Their Governments")
   end
 
-  specify "should provide write access to first level attributes" do
+  it "should provide write access to first level attributes" do
     series = ONIX::Series.new
 
     series.title_of_series = "Cool Science Careers"

data/spec/spec_helper.rb

@@ -1,7 +1,10 @@
 # coding: utf-8
 
+require "rubygems"
+require "bundler"
+Bundler.setup
+
 require 'date'
 require 'stringio'
 require 'rubygems'
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
 require 'onix'

data/spec/stock_spec.rb

@@ -2,7 +2,7 @@
 
 require File.dirname(__FILE__) + '/spec_helper.rb'
 
-context "ONIX::Stock" do
+describe ONIX::Stock do
 
   before(:each) do
     data_path = File.join(File.dirname(__FILE__),"..","data")
@@ -11,12 +11,12 @@ context "ONIX::Stock" do
     @root = @doc.root
   end
 
-  specify "should correctly convert to a string" do
+  it "should correctly convert to a string" do
     s = ONIX::Stock.from_xml(@root.to_s)
     s.to_xml.to_s[0,7].should eql("<Stock>")
   end
 
-  specify "should provide read access to first level attributes" do
+  it "should provide read access to first level attributes" do
     s = ONIX::Stock.from_xml(@root.to_s)
 
     # note that these fields *should* be numeric according to the ONIX spec,
@@ -25,7 +25,7 @@ context "ONIX::Stock" do
     s.on_order.should eql("0")
   end
 
-  specify "should provide write access to first level attributes" do
+  it "should provide write access to first level attributes" do
     s = ONIX::Stock.new
 
     s.on_hand = "123"