onix 0.7.5 → 0.7.6

data/CHANGELOG

@@ -1,3 +1,6 @@
+v0.7.6 (21st September 2009)
+- provide access to the PackQuantity element
+
 v0.7.5 (8th September 2009)
 - Don't raise an exception on malformed dates when reading files
 

data/README.markdown

@@ -21,6 +21,7 @@ view the comments to the following classes:
 
 * ONIX::Reader - For reading ONIX files
 * ONIX::Writer - For writing ONIX files
+* ONIX::Normaliser - For normalising ONIX files before reading them. Fixes encoding issues, etc
 
 ## Licensing
 

data/lib/onix.rb

@@ -16,7 +16,7 @@ module ONIX
   module Version #:nodoc:
     Major = 0
     Minor = 7
-    Tiny  = 5
+    Tiny  = 6
 
     String = [Major, Minor, Tiny].join('.')
   end

data/lib/onix/apa_product.rb

@@ -276,7 +276,7 @@ module ONIX
 
     # retrieve the supplier name
     def supplier_name
-      composite = product.supplier_details.first
+      composite = product.supply_details.first
       composite.nil? ? nil : composite.supplier_name
     end
 
@@ -288,7 +288,7 @@ module ONIX
 
     # retrieve the supplier phone number
     def supplier_phone
-      composite = product.supplier_details.first
+      composite = product.supply_details.first
       composite.nil? ? nil : composite.telephone_number
     end
 
@@ -300,7 +300,7 @@ module ONIX
 
     # retrieve the supplier fax number
     def supplier_fax
-      composite = product.supplier_details.first
+      composite = product.supply_details.first
       composite.nil? ? nil : composite.fax_number
     end
 
@@ -312,7 +312,7 @@ module ONIX
 
     # retrieve the supplier email address
     def supplier_email
-      composite = product.supplier_details.first
+      composite = product.supply_details.first
       composite.nil? ? nil : composite.email_address
     end
 
@@ -324,7 +324,7 @@ module ONIX
 
     # retrieve the supply country code
     def supply_country
-      composite = product.supplier_details.first
+      composite = product.supply_details.first
       composite.nil? ? nil : composite.supply_to_country
     end
 
@@ -336,7 +336,7 @@ module ONIX
 
     # retrieve the product availability code
     def product_availability
-      composite = product.supplier_details.first
+      composite = product.supply_details.first
       composite.nil? ? nil : composite.product_availability
     end
 
@@ -390,6 +390,18 @@ module ONIX
       composite.on_order = num
     end
 
+    # retrieve the supplier phone number
+    def pack_quantity
+      composite = product.supply_details.first
+      composite.nil? ? nil : composite.pack_quantity
+    end
+
+    # set a new supplier phone number
+    def pack_quantity=(val)
+      composite = find_or_create_supply_detail
+      composite.pack_quantity = val.to_i
+    end
+
     # retrieve the rrp excluding any sales tax
     def rrp_exc_sales_tax
       price_get(1).andand.price_amount

data/lib/onix/supply_detail.rb

@@ -20,6 +20,7 @@ module ONIX
     xml_accessor :availability_status_code, :from => "AvailabilityStatusCode", :as => Fixnum, :to_xml => ONIX::Formatters.two_digit
     xml_accessor :product_availability, :from => "ProductAvailability", :as => Fixnum, :to_xml => ONIX::Formatters.two_digit
     xml_accessor :stock, :from => "Stock", :as => [ONIX::Stock]
+    xml_accessor :pack_quantity, :from => "PackQuantity", :as => Fixnum
     xml_accessor :prices, :from => "Price", :as => [ONIX::Price]
 
     def initialize

data/spec/apa_product_spec.rb

@@ -0,0 +1,59 @@
+# coding: utf-8
+
+$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
+
+require 'onix'
+require 'date'
+
+context "ONIX::APAProduct" do
+
+  before(:each) do
+    @data_path = File.join(File.dirname(__FILE__),"..","data")
+    file1    = File.join(@data_path, "product.xml")
+    @doc = LibXML::XML::Document.file(file1)
+    @product_node = @doc.root
+  end
+
+  specify "should provide read access to attibutes" do
+    @product = ONIX::Product.from_xml(@product_node.to_s)
+    @apa     = ONIX::APAProduct.new(@product)
+
+    @apa.record_reference.should eql("365-9780194351898")
+    @apa.notification_type.should eql(3)
+    @apa.product_form.should eql("BC")
+    @apa.number_of_pages.should eql(100)
+    @apa.bic_main_subject.should eql("EB")
+    @apa.publishing_status.should eql(4)
+    @apa.publication_date.should eql(Date.civil(1998,9,1))
+    @apa.pack_quantity.should eql(12)
+  end
+
+  specify "should provide write access to attibutes" do
+    apa = ONIX::APAProduct.new
+
+    apa.notification_type = 3
+    apa.to_xml.to_s.include?("<NotificationType>03</NotificationType>").should be_true
+
+    apa.record_reference = "365-9780194351898"
+    apa.to_xml.to_s.include?("<RecordReference>365-9780194351898</RecordReference>").should be_true
+
+    apa.product_form = "BC"
+    apa.to_xml.to_s.include?("<ProductForm>BC</ProductForm>").should be_true
+
+    apa.number_of_pages = 100
+    apa.to_xml.to_s.include?("<NumberOfPages>100</NumberOfPages>").should be_true
+
+    apa.bic_main_subject = "EB"
+    apa.to_xml.to_s.include?("<BICMainSubject>EB</BICMainSubject>").should be_true
+
+    apa.publishing_status = 4
+    apa.to_xml.to_s.include?("<PublishingStatus>04</PublishingStatus>").should be_true
+
+    apa.publication_date = Date.civil(1998,9,1)
+    apa.to_xml.to_s.include?("<PublicationDate>19980901</PublicationDate>").should be_true
+
+    apa.pack_quantity = 12
+    apa.to_xml.to_s.include?("<PackQuantity>12</PackQuantity>").should be_true
+  end
+
+end

data/spec/supply_detail_spec.rb

@@ -25,6 +25,7 @@ context "ONIX::SupplyDetail" do
     sd.product_availability.should eql(21)
     sd.stock.should be_a_kind_of(Array)
     sd.stock.size.should eql(1)
+    sd.pack_quantity.should eql(16)
     sd.prices.should be_a_kind_of(Array)
     sd.prices.size.should eql(1)
   end
@@ -44,6 +45,8 @@ context "ONIX::SupplyDetail" do
     sd.product_availability = 3
     sd.to_xml.to_s.include?("<ProductAvailability>03</ProductAvailability>").should be_true
 
+    sd.pack_quantity = 12
+    sd.to_xml.to_s.include?("<PackQuantity>12</PackQuantity>").should be_true
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: onix
 version: !ruby/object:Gem::Version 
-  version: 0.7.5
+  version: 0.7.6
 platform: ruby
 authors: 
 - James Healy
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-09-08 00:00:00 +10:00
+date: 2009-09-22 00:00:00 +10:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -133,6 +133,7 @@ files:
 - spec/supply_detail_spec.rb
 - spec/title_spec.rb
 - spec/normaliser_spec.rb
+- spec/apa_product_spec.rb
 has_rdoc: true
 homepage: http://github.com/yob/onix/tree/master
 licenses: []
@@ -185,3 +186,4 @@ test_files:
 - spec/supply_detail_spec.rb
 - spec/title_spec.rb
 - spec/normaliser_spec.rb
+- spec/apa_product_spec.rb